- 06 Nov, 2019 40 commits
-
-
Andy Paicu authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: I076e6b428335ad9756dbba32fed98a001d676a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899884Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712938}
-
Rune Lillesveen authored
For FlatTreeStyleRecalc enabled, we did not walk the slot and ancestors clearing child-dirty bits when clearing a style recalc root as part of removing shadow host children. That would leave stray child-dirty bits. Here, we find the child-dirty slot and start clearing child-dirty bits from the slot and up the flat tree ancestor chain. If the slot was removed before the shadow host child, fall back to use the light tree parent of the removed nodes as the new style recalc root instead. Fall back to use the light tree parent for Shadow DOM V0 as trying to find the flat tree parent to start from is too complicated. TEST=shadow-dom/crashes/cyclic-detach-crash2.html Bug: 972752 Change-Id: If503bb3e102208440dae5b42c9231e680dc4d0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899372Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712937}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fed59b5a..ba61465d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a3f9522e7a7f691e19091ed9607c656edb712f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900886Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712936}
-
Martin Robinson authored
This fixes some issues with the interpretation of AtkCoordType in the platform accessibility implementation. Bug: 1020160 Change-Id: If5458444d224502a6355f74e9548175949751b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897831Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#712935}
-
Peter E Conn authored
Bug: 1019244 Change-Id: I9f8dfdf858e57e78c282d88924ff2e8edb24442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892961Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712934}
-
Leon Han authored
BUG=520391 Change-Id: I09a15805e86d2c1a933295587af9a2a99e6de5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900806 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712933}
-
Roberto Carrillo authored
This is a reland of http://crrev.com/c/1894619 The issue was that the signature for _validate_and_convert_profraw did not accept the newly added output list `counter_overflows`. I added a test to validate the behavior of this function. R=sajjadm,liaoyuke,nodir Bug: 1020404 Change-Id: I25ab734e2d4c5b2237b00c9b8e7d103d4f8de122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900427 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712932}
-
Adam Rice authored
Implement the { signal } option for ReadableStream pipeThrough and pipeTo, permitted a pipe to be aborted. Fixed: 902939 Change-Id: I168b3ac2c3f803cdd12611bea05c1ea706824a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899628Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712931}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/215bc7949b35..88264e3e188d git log 215bc7949b35..88264e3e188d --date=short --no-merges --format='%ad %ae %s' 2019-11-06 swiftshader.regress@gmail.com Regres: Update test lists @ 215bc794 Created with: gclient setdep -r src/third_party/swiftshader@88264e3e188d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I95b34f1a912b01a3dd5658861a4ff28400bf398a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712930}
-
Olivier Robin authored
Change-Id: I5a28eb714a70b84c0e7cada755bce8cb64ee3613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897696Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712929}
-
Zhongyi Shi authored
This change also resets socket_ to nullptr when the socket is closed. Bug: 101492 Change-Id: Ic4942fc580815eb0c062a821ac340138ac98a24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900569Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712928}
-
Maksim Sisov authored
We have all the Ozone platforms implementing the PlatformScreen. Now, it's the time to make that method pure virtual. However, there is one point - Ozone/Drm and Cast do not support PlatformScreen, but still implement it and expect that the method is not reached. Bug: 872339 Change-Id: I628878842294a8e99033893a9be42026066c29c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869004Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#712927}
-
Sam Fortiner authored
This change removes position from the GraphicsLayer tree dump format as another step toward the complete removal of position from GraphicsLayer. This is accomplished by intentionally passing through 0, 0 for the offset/position to CCLayerAsJSON which results in no output for position. As a supporting change, this change also renames CCLayerAsJSON's position parameter to be offset_from_transform_node which more accurately reflects what it is intended to be. Finally, removing a dead-code version of GetLayerTreeAsTextForTesting in WebLocalFrameImpl. Bug: 999336 Change-Id: I17f40076ec6bcf6cab9c70034c2466847af3c233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898806Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e127e9f93079..f00524707da7 git log e127e9f93079..f00524707da7 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 67527cb45293..1d09b983031b (5 commits) Created with: gclient setdep -r src/third_party/skia@f00524707da7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: I3e1d775a4122cf0919c45dffcedb68197163452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899839Reviewed-by:
-
Greg Thompson authored
Also move ScopedTempDir so that it's cleaned after BrowserTaskEnvironment. BUG=546640 R=amoylan@chromium.org Change-Id: I21361f3d8c40c58ac51ccd4f14638252cd1078f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899611 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712924}
-
Michael Lippautz authored
Trait::kWeakHandlingFlag can always be retrieved similarly through WTF::IsWeak<T> which is what the GC relies on. The GC supports the existing use cases based on WeakMember<>. If new weakness support is required, then WTF::IsWeak<> needs to be overridden as well as adding new overrides in trace_traits.h. Overriding weakness from user code using custom tracing functions is no longer supported. Why do we not allow overriding from user code? It turned out that it is hard to guarantee well-defined semantics wrt. to ephemerons and heap snapshots if custom weakness and composite types are created from user code. (In theory, all WTF traits, including those used for tracing, can be overridden from outside heap/. This is discouraged though as it requires knowledge of GC internals and will likely require new visitor APIs for new weakness types.) Bug: 1019191 Change-Id: Ie4291fe9e88eda6eb8ebde0fef5e7258a188cbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899874Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712923}
-
Kouhei Ueno authored
The API was previously blocklisted due to: - test failures, which was resolved in [1] - omnibox geolocation icon incompat, which is not available on Android This CL unblocklists geolocation API on Android. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1883428 Bug: 1015377, 989847 Change-Id: I1ee2dd4f9c9496622769431040fd0d99440ad0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886534 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712922}
-
Hiroki Nakagawa authored
The field was non-const because one test lazily initialized it. This CL tweaks the test setup routine and removes the lazy initialization. Bug: n/a Change-Id: Ib12ac76919dda20dfc7d708283e61d6ff1217b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900519Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#712921}
-
Chih-Yu Huang authored
in BUILD.gn, we already restrict all code in media/gpu/chromeos are only compiled when USE_V4L2_CODEC or USE_VAAPI is true. We don't need this buildflag in the source code. Bug: none Test: Run video_decode_accelerator_tests on Kevin and Eve Change-Id: I5449101ca5ae6702d10f4b3bfc233f27d2767aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900786Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712920}
-
Takashi Sakamoto authored
This reverts commit 29d31a12. Reason for revert: suspect causing compile failure on linux-chromeos-rel Sample build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30980 Original change's description: > Add App Service Instance related classes. > > Design doc: > go/app-service-instance-registry-design-doc > go/appservice-for-per-app-time-limit-design-doc > > This CL adds the App Service Instance classes: > Instance > InstanceUpdate > InstanceRegistry > > InstanceRegistry depends on Instance and InstanceUpdate to calculate > the instance updates to notify the client. > > BUG=1011235 > > Change-Id: Ife2a25c1ae24b3a5c8e1ef67540ba49939126174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896484 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712915} TBR=dominickn@chromium.org,nancylingwang@chromium.org Change-Id: Ibd6556f36a71a477b4a3515b9d53a6be1cceb3fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900793Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c761cf33..fed59b5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I634965541d39fa5f7f4d8c1730d10d1ebea489d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899804Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00e405553245..70f80e7066ba Created with: gclient setdep -r src-internal@70f80e7066ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: Id57dc6860421bcb0d2a52e7f99506240d686b281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712917}
-
Curtis McMullan authored
We want to create a prototype of a resizable floating virtual keyboard. This flag will be used to enable / disable the prototype. Bug: 1019990 Change-Id: I6194b024842ee177bca2180c74e69836d26897bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882256Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712916}
-
nancy authored
Design doc: go/app-service-instance-registry-design-doc go/appservice-for-per-app-time-limit-design-doc This CL adds the App Service Instance classes: Instance InstanceUpdate InstanceRegistry InstanceRegistry depends on Instance and InstanceUpdate to calculate the instance updates to notify the client. BUG=1011235 Change-Id: Ife2a25c1ae24b3a5c8e1ef67540ba49939126174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896484Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712915}
-
Hajime Hoshi authored
This CL is a pure refactoring. After this change, BackForwardCacheMetrics can take the full information about storing a document into the cache. Bug: 1004676 Change-Id: Ie56dfde2f2d5e0cb6d8507607dfd38f61837a358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899630 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#712914}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df4f939b5506..f798ed2acd8a git log df4f939b5506..f798ed2acd8a --date=short --no-merges --format='%ad %ae %s' 2019-11-06 lamontjones@chromium.org paygen: more logging when download fails. Created with: gclient setdep -r src/third_party/chromite@f798ed2acd8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I21b4d7ca226a7159a2d16db6d1d88ab517f5d330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899188Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdc0c23f1a2e..e127e9f93079 git log cdc0c23f1a2e..e127e9f93079 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aaa64b76c0b4..215bc7949b35 (2 commits) Created with: gclient setdep -r src/third_party/skia@e127e9f93079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: I0537ddbf590e457227f1d6477ab011ef20b45810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899187Reviewed-by:
-
Mike West authored
Currently, we're sending `Sec-Fetch-Dest: unknown` for PPAPI-driven requests. We ought to be sending `embed` or `object`. This patch adds some tests to ensure that we're setting the context for PPAPI requests to PLUGIN, and changes Blink's behavior to report PLUGIN as `embed`. We ought to be distinguishing between `embed` and `object`, but don't currently have the context when creating the request to make that possible (and "embed" is strictly better than "unknown" :) ). Bug: 1021432 Change-Id: Ie0d2dff1dee85e34c2fab6f7ea2e542fede644e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899446Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712911}
-
Matt Amert authored
The average_lag_tracker assumes that all events have nondecreasing timestamps. However, the assumption breaks when the main thread takes a long time to handle a scroll update and the compositor thread starts a new scroll in the meantime. This CL removes the invalid DCHECK and instead ignores the out-of-order event. Bug: 1015492 Change-Id: I3dcee2be9c0ba9b6e295d391b4c114f7ef05510b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869378Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712910}
-
Yoshifumi Inoue authored
This patch introduces |NGInlineCursor::CurrentBidiLevel()| with helper functions for prepration of utilizing |NGInlineCursor| to |AbstractInlineTextBox|[1]. [1] http://crrev.com/c/1888242 Utilize NGInlineCursor for inline box traversal Bug: 982194 Change-Id: I92f5aa918f27274cfd97dd2726bf95086d0b9ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899240 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712909}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9b94ee446d9c..b54d7ad71425 git log 9b94ee446d9c..b54d7ad71425 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 shwali@microsoft.com Make FPDFAnnot_SetAP() generate PDF standard compliant AP stream Created with: gclient setdep -r src/third_party/pdfium@b54d7ad71425 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I9eb65784a316dd8585d1d77329b73f9a40648153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900334Reviewed-by:
-
Jiewei Qian authored
SystemWebAppManager::NeedsUpdate() will check whether current locale is consistent with the locale that system web apps were installed with. If not (i.e. when user changes it), request to reinstall apps in order to keep their launcher localization (title, icons, etc.) synchronized to current locale. - Add a preference kSystemWebAppLastInstalledLocale to store locale at installation time. - Check install results of apps before storing locale Fixes: 1020442 Change-Id: I16f99a81fb5a06a634078914ff4fd9d745f5f73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898887Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#712907}
-
Mei Liang authored
This CL adds the following: * End to end tests for TabSelectionEditor * Some customized RecyclerViewMatchers * A TabSelectionEditorTestingRobot that allows others to perform and verify action within the TabSelectionEditor. Change-Id: Ic7283772374a0c0ed2a3aca84d4e4d245118fd04 Bug: 983170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894413 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712906}
-
Hajime Hoshi authored
This change is pure refactoring. This is preparation for letting RenderFrameHostImpl::MarkNotRestoredWithReason accept CanStoreDocumentResult. We'd like to pass not only multiple reasons and blocklisted features but also disallowed reasons at MarkNotRestoredWithReason. As CanStoreDocumentResult is an inner class, forward declaration is impossible, then this CL moves the class to an independent file. Bug: 1004676 Change-Id: I80a59f8035bc0093f87840b0b85ef7f6c31441d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877502 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712905}
-
Yoshifumi Inoue authored
Following bot results are included. 186 A large number of new failures are probably due to r712444 crrev.com/c/1869076 . TBR=kojii@chromium.org NOTRY=true Change-Id: I9456d6b4ea4f4e6cfd7ff96d27eaeba1a5bff99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900525Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712904}
-
Sammie Quon authored
Do not repaint to 1.f opacity if the blur is already 0. Also fix a bug with the cross fading animation being darker in the middle than the end. This is caused by the how the layers with different opacities stacked ontop of each other work. With both tweens linear the combined opacity near the gets to like .2. Changed to use tweens where the combined opacity stays close to .9 ish. Bug: 1009971, 1016267 Test: manual Change-Id: I9cb00afa869a8b83369ae871862700a2df864ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898147Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712903}
-
Fergal Daly authored
This reverts commit 29392d00. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add CanCommitOriginAndUrl() exception for 'no access' URLs. > > Temporary fix that creates an exception for 'no access' URLs like > chrome-native://history. These URLs can cause a origin mismatch in the > commit code because of slight differences between how url::Origin and > blink::SecurityOrigin handle 'no access' URLs. This is intended as a > low risk change that can be easily merged to the M79 branch. > > Bug: 1016711 > Change-Id: I20734fe68b6919c06849a1ce1439624d6332898c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896863 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712415} TBR=acolwell@chromium.org,alexmos@chromium.org Change-Id: I6ac033436b2719090e9fd198c90c410f509c845c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016711,1021779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900513Reviewed-by:
-
Chris Lu authored
This change move the 7 second delay dismiss call into presentInfobarBannerAnimated:. This will be helpful now that Translate will be presenting the banner multiple times, allowing the 7 second delay to reset every time the banner is displayed. Bug: 1014959 Change-Id: I0c11f0221bfc08be9e6bb4b119bdad09b67fcfe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900294 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#712901}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edf176c888c1..00e405553245 Created with: gclient setdep -r src-internal@00e405553245 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I957722487090a867510d1859c368744320978c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900590Reviewed-by:
-
Joel Hockey authored
Terminal System app will call chrome.terminalPrivate.getCroshSettings to get the current settings used by crosh in order to migrate any settings. This migration code will be removed after M83. Terminal System app will add some local storage to indicate that migration has been done, so this function should only be called once ever by Terminal System App. This code reads from the crosh extension sync storage where settings are currently stored. It is a close copy of extensions/browser/api/storage/storage_api code. https://cs.chromium.org/chromium/src/extensions/browser/api/storage/storage_api.cc?l=71-83&rcl=115bc01b385b57e8f96c4fa0b117e887a26cd55e TBR=benwells@chromium.org Bug: 1019021 Change-Id: I5287e804ac2c2a8c1eaf2fe7f14c8012f88b1c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899626 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#712899}
-
