GitLab

This patch stops removing trailing collapsible spaces at the
end of inline formatting contexts.

CSS defines to remove trailing collapsible spaces for each line.
Before this patch, CollectInlines() removes them before line
break as an micro-optimization because the end of an inline
formatting context is also the end of lines.

It turned out that this may prevent the re-use of NGInlineItem
(CL:986982) in some common cases, and since the re-use is a
great performance win, this micro-optimization turned out to
harmful.

Note, there are 19 tests that have 1px differences, probably
because we don't reshape when removing trailing spaces. Since
we already do this in HandleTrailingSpaces, rebaseline in this
patch but I'll work in following patches.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iff30d0cb05b4b80950c0d6da10ce8f6eff23a61a
Reviewed-on: https://chromium-review.googlesource.com/1022191
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555320}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I99b9e618704b04e55d15115f40787193411d69cc
Reviewed-on: https://chromium-review.googlesource.com/1038894Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555319}

Add an instance of SoftwareImageDecodeCache for image decoding for
non-accelerated canvas. This can potentially be used for any other
use-case requiring image decoding on the main thread in blink.

R=chrishtr@chromium.org

Bug: 791828
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1df793ea00e8e5df26878d6ca8e0769a9ca0c500
Reviewed-on: https://chromium-review.googlesource.com/858570
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555318}

Bug: 838692
Change-Id: Ie253322a5d3b76ad63e8d5d6819fdd5ef8db887f
Reviewed-on: https://chromium-review.googlesource.com/1038645
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555317}

Old test was loading http://mock/bad and because this URL did not
exist the load was failing because of DNS resolution error.

New test uses EmbeddedTestServer, which closes the socket to simulate
ERR_INTERNET_DISCONNECTED error.

Bug: 694662
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaca523e8153a2c4cca0e1f174652ed48f22cabd3
Reviewed-on: https://chromium-review.googlesource.com/1035610
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555316}

Using wpt-import in Chromium e896f838.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
7dea9b2c "[css-grid] Subtract scrollbar in ComputeReplacedLogicalHeightUsing()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16662

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-ui

TBR=lukebjerring

No-Export: true
Change-Id: I5580c18f03b90fa23d84d3f210b0d62e775e7e17
Reviewed-on: https://chromium-review.googlesource.com/1038909
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555315}

A float always needs to be positioned by its block parent, so passing
them around to children, parents or siblings really shouldn't be
necessary (and it *was* somewhat confusing, since nobody but the direct
float parent is allowed to touch them anyway, apart from placing them
into temporary exclusion spaces). The main reason for passing them
around like that, was for other blocks to determine, based on the list
of floats being empty or not, the need for relayout once the BFC offset
was resolved.

Instead, confine the list of unpositioned floats to the block parent of
those floats, and introduce the concept of adjoining float types (none,
left, right, both). Adjoining floats occur when the BFC offset is
unknown, meaning that their position may be affected by the current
layout algorithm.

Adjoining float types will now be the thing that's both input to and
output from the layout algorithms. Having something other than "none"
means that a block's BFC offset is unknown, but that doesn't
automatically mean that we have to abort and re-layout if the BFC offset
gets resolved. If the "floats BFC offset" is known, for instance, those
adjoining floats may be positioned right away. Still we need to know
about them (positioned or not), to get clearance correct.

We're going to need to treat adjoining floats specially when applying
clearance. Will deal with that in a later CL. For now, we just keep
track of the adjoining float types, so that the clearance machinery can
tell that there are floats there that may not yet be positioned. That
used to be taken care of the list of unpositioned floats, but, as
previously stated, adjoining floats are special, and we need to know
about them, whether they are positioned or not. This is a preparatory CL
for that.

Each time we add an unpositioned float, we need to update the types of
adjoining floats, so that these can be returned from the algorithm if
necessary. Whether they end up being positioned right away or not isn't
relevant. Adjoining is adjoining.

Note that we don't have to #include the header file for unpositioned
floats as much as before now, but I'll clean that up in a follow-up CL,
because it turned out that there were quite a few translation units that
got stuff for free via that header file, instead of explicitly including
what they need.

Had to rewrite how we deal with floats in HandleNewFormattingContext()
and LayoutNewFormattingContext(), since those depended on a list of all
preceding unpositioned floats to place them into a temporary exclusion
space, to figure out whether to let the child's margin be adjoining with
the current margin strut or not. Instead of using a temporary exclusion
space, we now position floats via the regular mechanisms, and initially
assume that the child's margin is going to be adjoining. This means that
we have to abort and roll back if there are preceding unpositioned
floats. This is no different from how we lay out regular blocks, though.
What *is* different is that if it turns out that the child's margin has
to be separated from the strut, we'll have to abort and roll back
once *again* (but only once).

The algorithms now need to keep track of whether they need to abort if
the BFC offset *changes*, rather than if it is *resolved*. We only allow
the offset to resolve and optionally change *once* afterwards, though.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie527d659213049f180ebedc764e1d7f4926a5876
Reviewed-on: https://chromium-review.googlesource.com/1030191
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555314}

Auto formatting and line length limits can produce the unreadable. In a
business where code is read way more than it is writ, making a reader's
eye dance left, right, and back again is tiresome and unnecessary.

Re-write this code for humans: it is both shorter and clearer.

Bug: 833834
Change-Id: I64535fdf6b4cccbc02029d594543d6719fe3c79f
Reviewed-on: https://chromium-review.googlesource.com/1039164Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555313}

InvalidateClipPathCache should be called whenever style.ClipPath()
changes. Previously it missed a branch.

Bug: 835828
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifd178ac2b2b695239a7aa0b69cdbe4f41cad5af2
Reviewed-on: https://chromium-review.googlesource.com/1038425
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555312}

This CL has no behavior changes.

Presubmit scripts have never applied to the script, and it has many
style errors. This CL has NOPRESUBMIT=true to suppress presubmit errors,
and we should fix them later. See crbug.com/838772.

NOPRESUBMIT=true

Change-Id: I724be7f9af79f9e82ff76bb04e713e0ada860a30
Reviewed-on: https://chromium-review.googlesource.com/1039107
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555311}

This CL adds "enable-layered-api" flag to chrome://flags and
a corresponding web runtime feature that will enable Layered API.

Also, this CL enables Layered API when
ExperimentalProductivityFeatures is enabled.

Bug: 829084
Change-Id: I0ed0346aa9bc685b2ba79ce5ba353a6f7f614c40
Reviewed-on: https://chromium-review.googlesource.com/1013319Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555310}

Change-Id: I26bab2e43fa0599b052b0740e8b9949b12022860
Reviewed-on: https://chromium-review.googlesource.com/1036708Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555309}

This marks the SupportLibWebViewContentsClientAdapter as final. This
instance is 1:1 with WebViewContentsClientAdapter and is set during the
constructor, so it can be final.

Test: N/A
Change-Id: I288ea6784e3a6c613825f8256dcecf78a1201f2c
Reviewed-on: https://chromium-review.googlesource.com/1039156Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555308}

This CL switches those interfaces (ServiceWorkerHost,
ServiceWorkerRegistrationObject[Host] etc.) associated with
EmbeddedWorkerInstanceClient interface before to be associated with
ServiceWorkerEventDispatcher interface living on its particular service
worker thread in the renderer process.
This will not only ensure them keeping the FIFO ordering with
ServiceWorkerEventDispatcher, but also make all their Mojo message
dispatches skip the main thread completely to avoid possible congestion.

The idea is to let browser-side pass ServiceWorkerHost endpoint and
ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call
ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service
worker thread, which holds on evaluating its service worker script until
received that call.

BUG=745327,834200,834183
TBR=lazyboy@chromium.org for enabling a test in
chrome/browser/extensions/service_worker_apitest.cc

Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402
Reviewed-on: https://chromium-review.googlesource.com/981898
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#555307}

Previously, ParentLocalSurfaceIdAllocator would default to an invalid
LocalSurfaceId. A new LSI had to be explicitly allocated before the
normal behavior could use it.

With ParentLocalSurfaceIdAllocator now default initializing a valid LSI,
the various call sites no longer need to explicitly check for the
uninitialized state.

viz/service & viz/test contain some of those call sites.

BUG=837030

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Iace37fb0be4c6389fdf2c89dbd4bb77c9696036f
Reviewed-on: https://chromium-review.googlesource.com/1038124
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555306}

Adds a note about properly configuring .gclient

Bug: None
Change-Id: I8ef7f054b283cf4d2c22e89e1436503504701358
Reviewed-on: https://chromium-review.googlesource.com/1039152Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555305}

This CL fixes #includes and/or include guards of the following
generated files:
 - html_element_factory.cc
 - html_element_factory.h
 - html_element_lookup_trie.cc
 - html_element_lookup_trie.h
 - html_element_type_helpers.cc
 - html_element_type_helpers.h
 - svg_element_factory.cc
 - svg_element_factory.h
 - svg_element_type_helpers.cc
 - svg_element_type_helpers.h

Bug: 836071
Change-Id: Ie9cd4e4c937262f32e64c574903be4580281f3b1
Reviewed-on: https://chromium-review.googlesource.com/1038924
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555304}

Use std::unique_ptr instead of deprecated linked_ptr

Bug: 556939
Change-Id: Iefb3dcb3ae891fe4b0fd0dd70be408517bcd9d85
Reviewed-on: https://chromium-review.googlesource.com/1034942Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sungguk Lim <limasdf@gmail.com>
Cr-Commit-Position: refs/heads/master@{#555303}

Previously, we would update all of the composited layers plus reach into the
LayerTreeHost (via some virtuals) to update even more things. All of these
will be updated anyway if the composited layer configurations actually change,
and it's pure overhead here.

PaintLayerCompositor::FrameViewDidScroll does the same thing (and this is
where I cribbed from in my original patch), but it's overkill. I didn't
change that call site, however, since it is non-RLS specific.

Bug:818709

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3643e42bc4b68bafcfd06dfe787a18b09ee2c7da
Reviewed-on: https://chromium-review.googlesource.com/1038439
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555302}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I4d9f55a3463f97aea1a44d4ca32b5531bd99a956
Reviewed-on: https://chromium-review.googlesource.com/1039148
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555301}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4736430a2b1c..dd3fcf9f3eb0

$ git log 4736430a2..dd3fcf9f3 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 rockot Set target_os=['chromeos'] in generated gclient specs

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:838608


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I770cc7362ad14fc63e8173eeed6661d85b8f4bb1
Reviewed-on: https://chromium-review.googlesource.com/1038821Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555300}

Add a test to invoke the refresh-required bubble for click-to-script.

Bug: 834494
Change-Id: Ie58dc3f98699f3a2b54289a25078c5b414f18fb9
Reviewed-on: https://chromium-review.googlesource.com/1038661Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555299}

... in CreatePrimaryProfile(). This is consistent with the logic in
GetStartupProfilePath() in startup_browser_creator.cc file.

Bug: 734095, 833663
Change-Id: Ic74bf5af947d0ef75006169676ed3bfcad7cde91
Reviewed-on: https://chromium-review.googlesource.com/1037930Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555298}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I3dae1a3c23f259efc05a68d0ff2b80d5ea6ab039
Reviewed-on: https://chromium-review.googlesource.com/1038906Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555297}

When a RuntimeModel with multiple execution contexts was removed,
some of the execution contexts could be unintentionally left in the
ConsoleContextSelector.

Change-Id: I8fea191af5a2f02c1de350866d29ddffe24338f6
Reviewed-on: https://chromium-review.googlesource.com/1038794Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555296}

In order to set proper bounds for active tab which is being dragged,
TabStrin::StartedDraggingTabs() should be called after ResetSelection().

Bug: 836004
Change-Id: I7243bf75b1d3243e55892386f2a5debc092bf925
Reviewed-on: https://chromium-review.googlesource.com/1027590
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555295}

The agent is going to be removed soon.

The ExecutionContextWorkerRegistry is made responsible for reporting workers.
Each worker is reported as a trace event when a worker starts.
Also all previously registred workers are reported on trace start.

Change-Id: I3cde31ae74e991ad522c476b606bee3c0a5f8587
Reviewed-on: https://chromium-review.googlesource.com/1038684Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555294}

Using a normal skia Bitmap mojom type means that large frames may be
transmitted as shared memory regions, which in turn means that
animations with more than 64 large frames can cause DecodeAnimation's
reply to exceed Mojo's self-imposed per-message handle limitation.

This is a temporary solution which restores DecodeAnimation to using
inline bitmap data (which it did prior to CL:1004598).

Bug: 838706
Change-Id: I53542a0070b6d554b52c6b0e3576b94af233a9f4
Reviewed-on: https://chromium-review.googlesource.com/1038760Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555293}

Bug: 836071
Change-Id: Icf7069a6c58d395edae8fddcdb84d07854e8d341
Reviewed-on: https://chromium-review.googlesource.com/1039103Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555292}

Load the favicons shown in chrome://discards via cr.icon instead of
doing a direct network request from WebUI.

Remove LifecycleUnit::GetIconURL() which is now unused.

Bug: 837420
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0ce123cdf944ace2e03b2b56feb18402848f875d
Reviewed-on: https://chromium-review.googlesource.com/1031783
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555291}

generate_event_interfaces.py should produce paths relative to the
repository root.

Bug: 836071
Change-Id: Ibcb9fbe2cdb1e6e0e8f46ad1c0caec11c23123f3
Reviewed-on: https://chromium-review.googlesource.com/1038984Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555290}

https://pdfium.googlesource.com/pdfium.git/+log/9294ffdf371f..c9cd2874278e

$ git log 9294ffdf3..c9cd28742 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 hnakashima Transform float out params from reference to pointer in CXFA_Node.
2018-05-01 tsepez Add CPDF_Document::Extension::DeletePage()
2018-05-01 tsepez Avoid perpetual spins for parserless CPDF_Pages
2018-05-01 hnakashima Transform size out param from reference to pointer in CXFA_Node.
2018-05-01 hnakashima Transform rect out param from reference to pointer in XFA code.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia3177603cfe492a853b4aa4903c52473995b84ef
Reviewed-on: https://chromium-review.googlesource.com/1038686Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555289}

Also, fix include guards.
This CL has no behavior changes.

Bug: 836071
Change-Id: I21d78c16c302405e9fb375843388aaaaaf093500
Reviewed-on: https://chromium-review.googlesource.com/1037047Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555288}

WindowActivityWatcher logs the WindowMetrics UKM event for a browser
window, with features like window show state and tab count.

Replace the WindowMetrics struct with a public WindowFeatures struct.
The UKM logging function forwards info from the new struct to the
UKM event.

Later we will use the same CreateWindowFeatures function to calculate
tab scores with an ML model. Encapsulating the logic for these features
in a single function ensures that we use the same logic for logging as
we will for inference, and makes the inferencing CL smaller.

Bug: 791824
Change-Id: I940b7fc3d9b6d71d2c23f3a6b054b4f0eb74894a
Reviewed-on: https://chromium-review.googlesource.com/1028563
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555287}

Currently we send the default CompositorFrameMetadata with the first
VideoFrame. This makes inspecting a remote target in DevTools buggy
when viz is enabled.

Bug: 837362
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie57e4bb290c1fa683839f7e5f09be1d5c2472b3a
Reviewed-on: https://chromium-review.googlesource.com/1035365
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555286}

Introduce GLRenderingVDAClient::Config and pass arguments to
GLRenderingVDAClient's constructor with it.

BUG=chromium:834170
TEST=VDA unittest on eve and kevin
TEST=VDA unittest on non-Chrome OS platforms in CQ.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5db1cbd9140f9a347f45f89b3903b3f1334b36e1
Reviewed-on: https://chromium-review.googlesource.com/1027490
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555285}

Many tear-down can occur if this is not the case: bug references can be
for the curious.

Tbr: slangley, yamaguchi
No-Presubmit: true
Bug: 833834
Change-Id: I5e795f7ef5b5e28af4050c9506640d8f6df8941a
Reviewed-on: https://chromium-review.googlesource.com/1038983Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555284}

State is simplified to {kInactive, kActive} for now but will need more
granularity later on.

Bug: b:78913434
Change-Id: I558c4f2c9b2b266a621a36fc67ecd5af1d28eed6
Reviewed-on: https://chromium-review.googlesource.com/1036729Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#555283}

Shared libraries are now spread over two directories in the SDK,
causing some libraries to be omitted from packages, rendering the
libraries non-executable.

This CL registers $sysroot/dist as a library data dependency.

Bug: 707030
Change-Id: Ie05e1b5dacf8924475576c3c53bf0d8d460db1f3
Reviewed-on: https://chromium-review.googlesource.com/1039026
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555282}

Chrome stores the seed in preferences, but WebView doesn't persist preferences.
WebView must save save seeds separately. Serialize with protos, and add
aw_variations_seed.proto to mirror the fields in VariationsSeedFetcher.SeedInfo.
Since writing might not complete successfully, the file format must make
truncation unambiguous. The proto wire format is such that truncation in the
middle of a field will be detected, but truncation between fields is permitted.
But by requiring in code that all SeedInfo fields are present, any truncated
seed file will fail to load.

BUG=733857

Change-Id: I7f8d787afed83019c2d891aef419cdf7d593b71c
Reviewed-on: https://chromium-review.googlesource.com/1033823
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555281}