- 22 Dec, 2019 7 commits
-
-
Kent Tamura authored
The following operations and functions had issues applying wrong context nodes to non-first arguments. This CL fixes them. - Operators: or and = != < > <= >= + - * div mod - Functions: concat() starts-with() contains() substring-before() substring-after() substring() translate() Bug: 1036075 Change-Id: I87b393557dc55897d01f6ea627ae83a34cf45331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977884Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#727076}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0af8b596129b..07d3bcf1c443 git log 0af8b596129b..07d3bcf1c443 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 gary.sweet@broadcom.com Correct calculation of GL_MAX_VARYING_COMPONENTS Created with: gclient setdep -r src/third_party/angle@07d3bcf1c443 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I3012831da39e76c85123d84a77eb669882878454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727075}
-
Sadrul Habib Chowdhury authored
Add more information for the various stages to help better understand (and reproduce) the DCHECK() hits. BUG=1034103, 1035382 Change-Id: I85c98bc70c1270baa231768f35555a38657e4ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979849 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#727074}
-
Andrew Xu authored
In ShelfView with the Hotseat flag enabled, ShelfView's |last_visible_index_| updates in ScrollableShelfView::ViewHierarchy- Changed which may be triggered when the child view is destructed. However, for the removed child view, it may be destructed at the end of fading out animation that runs in asynchronous way. As a result, the old value of |last_visible_index_| may still be accessed , such as in tests. This CL fixes the issue by updating |last_visible_index_| before starting the fading out animation when hotseat is enabled. Bug: 1032702 Change-Id: I53c890427f23241763fb001b173459bcce230a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576007Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727073}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34b3c0b066e5..cca9e2e29e2a git log 34b3c0b066e5..cca9e2e29e2a --date=short --first-parent --format='%ad %ae %s' 2019-12-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cca9e2e29e2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9259f6aa5784793a39d475a9416c2d01ca84b62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979953Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8dd630b30d06ca7eea351a388f4f58a5abab4d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979061Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727071}
-
Sadrul Chowdhury authored
This reverts commit b21c79dc. Reason for revert: Broke build on chromeos: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/15413 Original change's description: > Roll clang n332890-c2443155-1 : n333938-3a6da112-1. > > Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. > > Bug: 1030664 > Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 > Auto-Submit: Reid Kleckner <rnk@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727069} TBR=thakis@chromium.org,ukai@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: I2736079e5922fb9b182e952d233d5020ec15eef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979042Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#727070}
-
- 21 Dec, 2019 33 commits
-
-
Reid Kleckner authored
Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. Bug: 1030664 Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 Auto-Submit: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727069}
-
Dana Fried authored
In a few caes, fading out a view would not actually cause it to become invisible. These can be listed as: - In some cases, FadeInOutMode::kHide would not hide the view - If the layout were reset during a fade-out of a view hidden by calling SetVisible() or FadeOut() the view might fail to hide This change ensures that a view that is supposed to fade out always does - and adds appropriate unit tests. Change-Id: I9713f9806e0aa13ad8b35982ac47c2112c91d348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979635Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#727068}
-
Etienne Bergeron authored
Follow up this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1976702 R=oysteine@chromium.org CC=vasilii@chromium.org Bug: 1027929 Change-Id: Id88483e68b41604f541d3bdf71e35d8bca381a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978937 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#727067}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/exo/ Fixed: 1007687 Change-Id: I9a4f7be49e8ff96b9a35e796bc64e54caf9b27a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979014 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#727066}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.83-1576492580-benchmark-81.0.4000.0-r1 to 81-3945.83-1576492580-benchmark-81.0.4001.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I53c787c14e02774d11919b40bc6cc4278ad02f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979307Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bcfc4f47594..814d64d058ed Created with: gclient setdep -r src-internal@814d64d058ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I35bb1ca4ddc5076022d1bb063ca54e6b3f42e71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727064}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b40bf3083746..4bcfc4f47594 Created with: gclient setdep -r src-internal@4bcfc4f47594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4580059670d9d16b2cfea14b3372f171827aa372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979462Reviewed-by:
-
Samuel Huang authored
This reverts commit 162137c6. Reason for revert: crbug.com/1036648: This CL triggers heap-use-after-free in ASAN (although the root cause lies elsewhere, maybe inactive code). Reverting to denoise system. Original change's description: > Enable AppService InstanceRegistry feature. > > BUG=1011235 > > Change-Id: Icb262a58b4464d7963acb0b22a9d30ce7b070060 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972738 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726576} TBR=dominickn@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1036648, 1011235 Change-Id: Ib942d2a4f72e24871adea66626dc95b78a8f06c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979850 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727062}
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: If6c37c46b3736a936c84cae393fdbc71655a5033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973815 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727061}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2e2f25aec20..b40bf3083746 Created with: gclient setdep -r src-internal@b40bf3083746 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idc1c9adccf439d3885ecd99fa8ac8ccdd679d9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979461Reviewed-by:
-
Etienne Bergeron authored
Move the functions without dependencies to RunList into RenderText. R=pkasting@chromium.org Bug: 1025561 Change-Id: I257fdca2543d9a56823cdbcc7fed1e94467ebaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978097Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727059}
-
Etienne Bergeron authored
Trival dead code. R=pkasting@chromium.org Bug: 1025561 Change-Id: I1297bed599a55fd11fedcb810379173b8c17c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979368Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ebf5fd11de10..6ec826085b2a git log ebf5fd11de10..6ec826085b2a --date=short --first-parent --format='%ad %ae %s' 2019-12-21 reed@google.com Reland "make clipIsWideOpen virtual, so device's don't have to rely on regions" Created with: gclient setdep -r src/third_party/skia@6ec826085b2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I573ef092af17aff6e5f1598f9f5421d111f01733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979459Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: Ic7a12e3e08215eb588b4cb6b4cbb7feda1aaff4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979457Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc33b15dc48f..a2e2f25aec20 Created with: gclient setdep -r src-internal@a2e2f25aec20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifcc0672d17333e58073bef455ee6e6720ff0db66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979456Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I24b6338dd569dc9e5b8d154e18974ea9cda05874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978102Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727054}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I30886013cee28e427b12d2ebbbe0f15c1ea0e807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979458Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d892991127bf..34b3c0b066e5 git log d892991127bf..34b3c0b066e5 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@34b3c0b066e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id719fc774b94f21835367800fc8e7170f968c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979455Reviewed-by:
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I8e63fd3c0b5af0d88eca724e27e4c1fdcab65bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973825 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/af203a677aac..ebf5fd11de10 git log af203a677aac..ebf5fd11de10 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 reed@google.com Revert "make clipIsWideOpen virtual, so device's don't have to rely on regions" Created with: gclient setdep -r src/third_party/skia@ebf5fd11de10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: If27b5b53026e662273fd5586af288c346b34230f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979454Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I67bd9ad7280972eda936f5271fad0cbdcff518c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978101Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f7e5e79. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc smcgruer@chromium.org: external/wpt/css/css-position NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8a94a29d265a822e2338b6104ec545962739ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979683Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727048}
-
Hans Wennborg authored
To see if that greens the bots. TBR=thakis Bug: 1033863 Change-Id: I1763967f8d50967df8b7730a4ee333e43e0f5eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979789Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727047}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/291be9acc1d0..0af8b596129b git log 291be9acc1d0..0af8b596129b --date=short --first-parent --format='%ad %ae %s' 2019-12-21 xinghua.cao@intel.com D3D11: Translate uniform blocks to StructuredBuffer when necessary Created with: gclient setdep -r src/third_party/angle@0af8b596129b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I06a4c7dc6d7afd0e1453668365fbbf9149eb4b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979710Reviewed-by:
-
Bartek Nowierski authored
Privacy review: https://docs.google.com/document/d/1cgwwc8jY7A3MLCHAh7yvONTAWTUTlsjnBsHp2oIuMv0/edit?usp=sharing Change-Id: Ic7ee5a3664d592230e1e120391724dd4e7a0c5dd Bug: chromium:1018156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965747Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727045}
-
Mansi Awasthi authored
Added a new action PP_PDF_SET_SELECTION to PP_PdfAccessibilityAction and selection specific data in PP_PdfAccessibilityActionData. Implemented PdfAXActionTarget::SetSelection method to send selection data to plugin. PDFiumEngine handles PP_PDF_SET_SELECTION action and set the selection in plugin. Added the tests to validate if write action data is sent from Mimehandler to Plugin for selection and also if the action is correctly executed in Plugin. Bug: 1023283 Change-Id: I9112698757d7516d38f29e88174f10da71673b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934127 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727044}
-
Archie Pusaka authored
Bluetooth debug is handled through the btdispatch daemon using org.chromium.Bluetooth service name. However, as btdispatch is going to be taken out, we need to migrate to bluez with org.bluez as the service name. Most of the API calls have been migrated to bluez, but debugging has not been made ready yet. This CL directly use org.chromium.Bluetooth for debugging, instead of org.bluez like the rest of the clients. This needs to be updated when debugging is migrated completely. BUG=b:145967589 Change-Id: I36da87f1e860ca9c65edc8f984596ded3a711a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960048Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#727043}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.0-1576497268-benchmark-81.0.3995.0-r1 to 81-3987.0-1576497268-benchmark-81.0.4001.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icee99a50abbaaa67cbe705c4cbef81c844452697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979451Reviewed-by:
-
Emily Stark authored
With HTTP auth committed interstitials enabled, extensions were getting notified of each auth request twice: once when LoginHandler is first called to cancel the auth request and show a blank error page, and again when LoginHandler is called after committing the error page to show a login prompt on top of it. In common operation, the second extension dispatch was a no-op, because the request had been destroyed already by the second entry into LoginHandler. But, there was a race ticked by long response bodies. That is, it was possible that the second onAuthRequired event would be dispatched to an extension before the request was destroyed. The request was destroyed between the second dispatch and the extension's reply. When the extension replied,the WebRequestAPI would simply drop the reply for the now non-existent request, never returning control to LoginHandler so that it can proceed to show the login prompt. The fix is to ensure that auth requests are dispatched to extensions only once, on the first time LoginHandler is called, before the request is cancelled. Bug: 1034468 Change-Id: If9eb71b38dd1738a471c3dadab4093367ab0d03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978898Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#727041}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/041b5b6ffaa5..dc33b15dc48f Created with: gclient setdep -r src-internal@dc33b15dc48f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If3afd8a97c5532c43f14356eb6d8432ffa0403cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979709Reviewed-by:
-
Hans Wennborg authored
This reverts commit 6f7e5e79. Reason for revert: This broke the build, e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-device/144512 ../../third_party/zlib/cpu_features.c:75:13: error: unused function '_cpu_check_features' [-Werror,-Wunused-function] static void _cpu_check_features(void) ^ Original change's description: > Unify CPU features detection code > > This will allow to remove some duplicated code (i.e. thread synchronization) > while at same time removing unnecessary use of inline ASM for Intel features > detection. > > A few other advantages: > - remove some extra logic (e.g. no need to test the platform to include the > correct CPU detection header). > - simplifies the buildsystem (i.e. we always include cpu_features.c) > - get rid of the simd_stub file. > > Bug: 1032721 > Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 > Reviewed-by: Chris Blume <cblume@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727038} TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com Change-Id: I20c5dedb98ba8b5d304ff1339042bcf243505e88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979790Reviewed-by:
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#727038}
-
Nate Chapin authored
While there are some differences in how we determine whether it is a secure context depending on window vs worker, the core logic is the same and the policy is set at construction time. Also, this allows us to merge the SecureContextState and SecureContextMode enums. Bug: 1029822 Change-Id: Ia15fbe12c8874426228f6a8ebee19560c4f862c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978839 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
