GitLab

It seems that TouchActionFilter::scrolling_touch_action_ could have no
value in various cases:
1. Start a fling with a touchpad and then do fling boosting with a touch
screen.
2. We could have TapDown targeting an iframe and GestureScrollBegin
targeting the main frame.

This CL does the temporary fix to ensure that the scrolling_touch_action_
always have value. A proper fix with tests will come later.

This CL also fixes the case when we try to access the allowed_touch_action_
which could have no value.

TBR=creis@chromium.org

Bug: 850979
Change-Id: I8dc52a396970d20a7037fa64dc239a25def4fac1
Reviewed-on: https://chromium-review.googlesource.com/1099193Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566947}

A number of IETF framer tests were disabled to cope with the
incomplete merging of IETF Framing to chromium. Those issues
have been resolved and the tests can now be reenabled.

N/A is tests only.

This was manually merged to Chromium

Merge internal change: 200386798

R=rch@chromium.org

Bug: 109878472
Change-Id: I908510175c02a30d7d76b2931e8e61b863dbfe0c
Reviewed-on: https://chromium-review.googlesource.com/1099137Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566946}

This reverts commit a6b5210c.

Reason for revert: Breaks all tablets

Original change's description:
> Remove not-tablet check in DeviceFormFactor
> 
> This patch removes an early return from
> DeviceFormFactor#detectScreenWidthBucket that will allow tablets to
> return their screen width "bucket". This should prevent tablets from
> trying to load phone resources in certain cases.
> 
> Bug: 850096
> Change-Id: Ie25c66d7dcc5278300f628cdd58e7e7c8f1052da
> Reviewed-on: https://chromium-review.googlesource.com/1095642
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566246}

TBR=tedchoc@chromium.org,agrieve@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850096
Change-Id: Ia214bd8fc00e0c20bc79bb74f1d092348527bb1f
Reviewed-on: https://chromium-review.googlesource.com/1099395Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566945}

This reverts commit 83ce891c.

TBR=jdufault@chromium.org

Bug: 839593
Change-Id: I7dc8393ddc3101d7c47f4e770d4007a0a6c16f96
Reviewed-on: https://chromium-review.googlesource.com/1099268Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566944}

This addresses the following feedback provided during UI review:
 - Footer item height should be 40 = 36 (suggestion height) +
   4 (compensation for corner radius); in the current implementation,
   this is 44 (36 + 2 * 4).
 - All footer items should have the same value; in the current
   implementation, the last one is taller than the others.
 - Left and right padding should also compensate for the corner
   radius; it's 8 today, should be 8 + 4.

Bug: 851009
Change-Id: I0dad1c8bbbe97dce9341900d25af44df9efbde11
Reviewed-on: https://chromium-review.googlesource.com/1091158Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566943}

Reland of crrev.com/566724. Original commit message:

The presentation-time from gpu gives a more correct view of what the
user experiences, rather than the swap-time in the renderer process.
So switch to using the presentation-time to measure the various
paint-time metrics.

The various paint-time metrics in telemetry tests (loading benchmark)
will go up after this change, but it is expected, and it is not a
regression. Results on various platforms with this change:

Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000
Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000
Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000
Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000
Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000

BUG=811961

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7742fa669ab583dbfda8be2259c553385b7fef10
Reviewed-on: https://chromium-review.googlesource.com/1099187Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566942}

This is a requirement of our current AR image transport implementation.

Bug: 852445
Change-Id: I5b64a1dfe98fd6c8b26f0436e35645c49bc4da16
Reviewed-on: https://chromium-review.googlesource.com/1099490Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566941}

Previously, the MainThreadScheduler froze its pages when the renderer
was backgrounded for a certain amount of time and the freezing feature
flag was enabled. This CL moves this logic to the PageScheduler, which
now freezes a page when (1) the page freezing feature flag is set, and
(2) The page is freezable (hidden + no audio) for X time, where X is
either the default 5 minutes or a value set in finch.

This change also:
  - Removes the previous plumbing of the feature flag through the
    content layer and checks the flag directly.
  - Adds a new metric PageScheduler.PageLifecycleStateTransition to
    replace RendererScheduler.BackgroundedRendererTransition. This
    metric is recorded for lifecycle state transitions between active,
    hidden/backgrounded, hidden/foregrounded, and frozen.

Bug: 820634
Change-Id: I548daf643f090e161dc9afd8f788452a95669e03
Reviewed-on: https://chromium-review.googlesource.com/1086488
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566940}

This pulls the code out of the executable and moves it into the
//sandbox/mac:seatbelt target. This way it can be reused by
content_shell.

In addition, this also reduces the number of arguments used by the V2
sandbox. A prior design used a double-exec, requiring additional
switches to know the stage at which the sandboxed process was running.
However the double-exec is no longer done for performance reasons, so
some switches can be eliminated.

No-Presubmit: True
Bug: 850735, 749839
Test: No functional change. Sandboxed processes are still sandboxed.
Change-Id: I4eedf1e7e057d0650c805430fa53763b3909f923
Reviewed-on: https://chromium-review.googlesource.com/1097842Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566939}

In preparation of eventual onion souping DOMStorage this move the
SessionStorageNamespace and StoragePartitionService mojom interfaces
to blink/public/mojom as well, splitting them up in each their own
file in the process.

Tbr: dgozman@chromium.org
Bug: 781870
Change-Id: Icf85fee3eb327d81d2eee1cc68ce89b255cd13b4
Reviewed-on: https://chromium-review.googlesource.com/1087406
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566938}

The fix (crrev.com/c/1097624) is already rolled (crrev.com/c/1098715)

Bug: 851523
Change-Id: I6a4f35eb1448b14c2a28864236bcde9785ee768a
Reviewed-on: https://chromium-review.googlesource.com/1098634Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566937}

Adds StartDiscovery function to SmbHandler and is called when the Add
Smb Share Dialog is opened. StartDiscovery will be wired up to start
share discovery on the network

Bug: 757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied25d42b004d160f5b4486fbcfb4c8e8cceb3c37
Reviewed-on: https://chromium-review.googlesource.com/1073498Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566936}

This makes sure clicking the checked Picture-in-Picture browser context
menu (after entering Picture-in-Picture) exits Picture-in-Picture.

Screenshot: https://i.imgur.com/asJ1qgT.png

Bug: 840516, 806249
Change-Id: Ic283ca8cb431bfcb56613067e0fec43db2bbf53b
Reviewed-on: https://chromium-review.googlesource.com/1086796
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566935}

Bug: 850877
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc3c4520ab26400fbbca3490e038b1d25f4a8727
Reviewed-on: https://chromium-review.googlesource.com/1093262Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566934}

Fixes a bug when focusing an empty omnibox on incognito NTP that lead
to an incorrect layout of the placeholder.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id3215b4ca564789caca03473d029b088e2643ecf
Reviewed-on: https://chromium-review.googlesource.com/1098964
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566933}

This patch extends support for painting touch action rects (behind the
PaintTouchActionRects flag) to inline painting. With this patch, the
inline box's background hit test rect is painted. To reduce duplicate
code, InlineFlowBoxPainter::AdjustedPaintRect was introduced.

Because touch action rects are painted the same way as backgrounds, this
approach correctly handles vertical-rl writing modes.

Bug: 836905, 852013
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I53296e0fc6e939e220a90fee40e07492a9da113a
Reviewed-on: https://chromium-review.googlesource.com/1097562
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566932}

This caused some issues and we don't have time to address them for M69.
For example: crbug.com/849802, crbug.com/851852, crbug.com/848164.

Bug: 822075
Change-Id: I2b318ea6a9ff0b05120b21262088f6fbe2c3df10
Reviewed-on: https://chromium-review.googlesource.com/1098376Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566931}

FontCustomPlatformData::FamilyNameForInspector returns an SkString so
this adds an include for SkString.h. Previously this code compiled
because SkTypes.h has a forward declaration of SkString which was pulled
in though the SkRefCnt.h include. Skia is looking to remove this forward
declaration in SkTypes.h.

Change-Id: I638e13a0db4fba02e9caf73b448aa70ae2011100
Reviewed-on: https://chromium-review.googlesource.com/1099416Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566930}

The Refresh tabstrip does not draw the toolbar top separator, so this
test is unnecessary in that mode.

Bug: 846410
Change-Id: I0adac7e80227267e8a92556a4fef602d81e531db
Reviewed-on: https://chromium-review.googlesource.com/1098139Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566929}

No one is using the WindowServerTest interface, so remove it.

BUG=none
TEST=none

Change-Id: Ifff29e9601088586fb8a43306b231a5d6eb696b5
Reviewed-on: https://chromium-review.googlesource.com/1099367Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566928}

https://pdfium.googlesource.com/pdfium.git/+log/81a3085b250d..5f032995b3d7


git log 81a3085b250d..5f032995b3d7 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 tsepez@chromium.org CPDFSDK_Widget(): bDisplay arg always passed as true (default).


Created with:
  gclient setdep -r src/third_party/pdfium@5f032995b3d7

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib44d0051ab49ba858f40edc2732449946ab99eb2
Reviewed-on: https://chromium-review.googlesource.com/1098940Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566927}

SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames seems to be executing an invalid instruction.

Builders failed on:
- Mac10.12 Tests:
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests

TBR: ekaramad@chromium.org
Bug: 852452
Change-Id: If6592678a299db04184c55d1433a6558fa78816d
Reviewed-on: https://chromium-review.googlesource.com/1099364Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566926}

We were crashing if we ended up failing to publish a page when sharing.
An initial fix repaired it by sharing an item that was invalid in such
a way as to fail silently.

Initially I thought that the share callback needed to always be called
to continue processing and report failures.  However, all it does is to
share the item in the callback.  Therfore, a better fix is to just not
call the callback if there is some failure, as opposed to making sure
that we call it with an item which will fail to share.

Bug: 829099
Change-Id: I9b25cb67480a822cbbe8cef1b39d687fce076af1
Reviewed-on: https://chromium-review.googlesource.com/1098382Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566925}

The Finch experiment is showing that the experiment group has much more
extensions than the control group. Adding these new histograms may help us
understand more about what's happening.

Bug: 722942
Change-Id: Ia3308e61efeeb533c31638ca0f0ecf500c7e0f9c
Reviewed-on: https://chromium-review.googlesource.com/1091695Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566924}

Remove the  util class with a single method. Now Chrome gest the list of
processes without using the content API.

Change-Id: If519f153fd7833de439b41c311a7abe1b926da2a
Reviewed-on: https://chromium-review.googlesource.com/1091730
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566923}

Change-Id: I0e684cf415f600fd640abafd9b103a261b1032fe
Reviewed-on: https://chromium-review.googlesource.com/1098627Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566922}

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iabf8c04e3776a214af930547cbcf3366e3b10f0e
Reviewed-on: https://chromium-review.googlesource.com/1097844
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566921}

After creating new bug for including tough_pinch_zoom_cases in
rendering.mobile, fix TODO to refrence correct bug number.

Bug: 851499
Change-Id: I8657adb33b2e3ac246702a06356871c287522e4d
Reviewed-on: https://chromium-review.googlesource.com/1099037Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#566920}

The workaround was introduced because a user of rounded_rect_view.cc had
artifacts shown on intel devices. The impl of that user has changed a
bit, or something underlying has been fixed. So this workaround is no
longer needed.

Test: manual
Bug: 824860
Change-Id: Iad8213606400a9d5a0ca6108c67bda2cf6f1993c
Reviewed-on: https://chromium-review.googlesource.com/1097472Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566919}

Bug: 828655
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a4ca1e3d5e76bde27e7a634f50b991e3f2cb020
Reviewed-on: https://chromium-review.googlesource.com/1079703
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566918}

Added support for UIA_AriaPropertiesPropertyId in GetPropertyValue, which allows UI Automation to access the ARIA properties of an object

R=nektar@chromium.org,dmazzoni@chromium.org,aleventhal@chromium.org

Bug: 852052
Change-Id: I225572028251465263ad92d3e1f2f2f47b0f3104
Reviewed-on: https://chromium-review.googlesource.com/1097617Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566917}

Bug: internal b/80004505
Change-Id: I556e52aa344d0e6b93e642d8aa02e026566c161b
Reviewed-on: https://chromium-review.googlesource.com/1095983Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566916}

There is no "learn more" link in the new proposal for the save card
dialog, and there is no point in keeping it even for the old UI.
This CL simply removes it, so we can get rid of the additional
complexiy.

The link has also been removed from iOS and Android.

Bug: 852094
Change-Id: Ibf6e5add73dd43a5a6afee8a856d8fc88e71830f
Reviewed-on: https://chromium-review.googlesource.com/1097798Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566915}

Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1071886

This change updates all callsites in site_per_process_hit_test_browsertest.cc to use the new api.

TBR=kenrb@chromium.org
TEST=SitePerProcessGestureHitTestBrowserTest,
SitePerProcessHighDPIHitTestBrowserTest,
SitePerProcessInternalsHitTestBrowserTest,
SitePerProcessMouseWheelHitTestBrowserTest,
SitePerProcessHitTestBrowserTest.
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest,
SitePerProcessMouseWheelHitTestBrowserTestWheelScrollLatchingDisabled

Bug: 785986
Change-Id: I042d7fdf214b8045a9d5265c0fd7af3d547f0882
Reviewed-on: https://chromium-review.googlesource.com/1081998
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566914}

Bug: 837354
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic9727b6d9ef96c3f23c3fbbff4cd905e592010a6
Reviewed-on: https://chromium-review.googlesource.com/1089661Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566913}

Causes all VR tests to check if any VR-related activities are in the
foreground before starting, and if so, background them and wait for
VrCore to think that it's no longer in VR. This addresses two known
areas of flakiness: testPresentationPromisedUnresolvedDuringDon* tests
and testTrustedIntentAllowsAutoPresent, and potentially reduces
flakiness elsewhere.

Bug: 818369
Change-Id: I7629bce1541cba961cf5dccf19b7c9aa29b500af
Reviewed-on: https://chromium-review.googlesource.com/1098394Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566912}

- Ensure that messages intended for a previous instance of
PrintPreviewUI are dropped and not forwarded to the UI.
- Track request IDs in messages that resolve or reject preview
callbacks and maintain a map instead of a queue, since with the
addition of the PDF compositor service requests may not be
returned in the order they were received.
- Split more conditionals to improve stack traces in future.

Bug: 827056
Change-Id: I8a194a480be780ce4cf0a8544f60d9abe502bdf1
Reviewed-on: https://chromium-review.googlesource.com/1085747
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566911}

Change Assert to STA from MTA. Add comment and bug describing that
WinRT use really should be in a MTA, but currently is on the UI thread
which is STA.

BUG=852317,852386

Change-Id: I3a284010638ae848b1e9b5ee6c92646a5a9a1dea
Reviewed-on: https://chromium-review.googlesource.com/1099184Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566910}

There was an issue with the menu where if you scroll
down it, the selected item and tooltip doesn't get
updated. This CL address the issue by updating the
selection on a mouse wheel event.

On Mac, there is an issue where the incorrect tooltip
is shown on the menu item. This issue happened because
the tooltip manager doesn't get updated for mouse events
on the Views menu. This CL fixes the issue by calling
-updateTooltipIfRequiredAt: at -scrollWheel: and
-processCapturedMouseEvent:.

Bug: 847966, 847964
Change-Id: I183de9a5a824ab5798957a3432da1962d65b75ca
Reviewed-on: https://chromium-review.googlesource.com/1097739Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566909}

This feature has been turned on to 100% of stable in M63 and enabled by
default since M65.  We've held back on removing it for a couple of
releases in case of a bad interaction with other site isolation trials,
but it's time to remove it now.

Bug: 739418
Change-Id: I4c1ba5724bcfaaef4729b51a93ee279349057c9d
Reviewed-on: https://chromium-review.googlesource.com/1096664Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566908}