- 18 Jun, 2020 40 commits
-
-
Zhuoyu Qian authored
Remove unnecessary security check for uint32_t variable as it will never less than 0. Change-Id: I1c8efcc98c618c2955ed372275c970f8627ff19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249247 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#779894}
-
Xiaohui Chen authored
This CL removes one of the internal dependency on the public mojom type. Bug: b:154268518 Change-Id: I68d87c91331cb0347ff0fa23fbb02fe22500f490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250167Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779893}
-
Jonah Ryan-Davis authored
Mac DefaultPassthroughCommandDecoder is ready to be finched, so we need test coverage for both command decoders. This CL adds passthrough test coverage for context_lost, screenshot_sync, pixel_skia_gold, and maps_pixel_test. Bug: chromium:982292 Bug: chromium:1090853 Change-Id: Ib264875dc22cf15efe3a9395424da8e30554a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246630 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779892}
-
Xi Han authored
ScreenShot: https://drive.google.com/file/d/1jxjCXSdR_Wnz5Wu2HKu6gDiaOF0who1Q/view?usp=sharing Bug: 1016952 Change-Id: Ib3c840794aa9c527540ddbe3f0ada8b1ac66a1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250899Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779891}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I4785f465efb51cb7d2c63cc3df5ed86c8e53362d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248620Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#779890}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b621a997903..9c7a8fbc5977 2020-06-18 fmayer@google.com Document vfork known issue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:153893612 Tbr: perfetto-bugs@google.com Change-Id: I3efb52a66d1cb9a7a87420a06364a8328a1505f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252024Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779889}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d70c25298bc8..d438a6023a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1096383 Tbr: smcgruer@google.com Change-Id: Ibf9f6115bce930d5ed508aa9e116e96f49a2ad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252027Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779888}
-
Jochen Eisinger authored
This is a reland of ba58fd11 Original change's description: > Add logging to external intent handling > > I will revert this CL after a few canaries. > > Bug: 839751 > Change-Id: I823ec7c2eb47df905869d3f4f74c89e59a1433be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246596 > Auto-Submit: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779391} Bug: 839751 Change-Id: I620626407acbc482c7a7f6eee595dac57ee4ecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252039 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779887}
-
Sébastien Séguin-Gagnon authored
Bug: 1092180 Change-Id: Ib274cb26a85aa9ebc9de34793338c67b935b5cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248135Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779886}
-
Katie D authored
Flakes are only occurring in M84 because a flake fix landed after the 84 branch: crrev.com/c/2209281. This change will be cherry-picked to M84 and then reverted in M85. Bug: 1064776 Change-Id: I6518458ac57f268b8c762097877b077e8852d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250159Reviewed-by:
-
Stephen McGruer authored
This reverts commit 359f3700. Reason for revert: Broke build due to dependent CLs existing. Original change's description: > Revert "Desktop PWAs: Unit test helper method InstallWebApp" > > This reverts commit 7db3de6c. > > Reason for revert: MSAN failure, crbug.com/1096592 > > Original change's description: > > Desktop PWAs: Unit test helper method InstallWebApp > > > > Extract unit test helper method InstallWebApp from unit tests to > > web_app_unittest_util.h/cc and retire duplicate implementations. > > > > Drive-by: retire unused method FinalizeInstall > > in web_app_install_manager_unittest.cc > > > > TBR=agawronska@chromium.org > > > > Change-Id: I5f7574ef89dfe1543727c2376d8002e2e6fce822 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247991 > > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779607} > > TBR=ericwilligers@chromium.org,loyso@chromium.org,dominickn@chromium.org > > Change-Id: I1b50d2ed80fbe29b9e742c7a533d3a0b65e0df7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252561 > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779872} TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org No-Presubmit: true No-Try: true No-Tree-Checks: true Change-Id: I73d0c4893bd9f1f3dd397818faeaa743b0c9a97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252643 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779884}
-
Erik Chen authored
Bug: 1094461 Change-Id: I40ab98e429dc8d9cbec78fab2eb8ee8865b2facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244011 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iefd84e6173721d15d2ce6abc51cc16349c7c92b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78a17a82. With Chromium commits locally applied on WPT: d4954632 "wpt: fix webrtc simulcast rids" 78a17a82 "Fix timeout on RTCRtpTransceiver test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I4cd3acf78e00850589a038d55d8f4d797d42a5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252278Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779881}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I07587081f287085f218b8a1cf2f341751c919dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251404Reviewed-by:
-
Daniel Libby authored
In CAP, compositing state/group mapping is not known until after painting, so this information can't be used to isolate NeedsRepaint operations in MarkCompositingContainerChainForNeedsRepaint. Scope the querying to a non-CAP codepath. This was the last assert disabler in CAP codepaths, so add a DCHECK to the DisableCompositingQueryAsserts constructor so no further ones are added. Bug: 1007989 Change-Id: I72e4a82ccf856c9ace3f3714d5e3bd0c6ccc7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247322Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779879}
-
gogerald authored
This CL also solves the scroll issue of the incognito description. Screen records: Resume: https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing Scroll: https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing Bug: 1093506 Change-Id: I5d7365daa530b23f897a19665076cbc32238224f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Peter Wen authored
Add benchmark.py. Runs build speed benchmarks on the current repository. Example Command: tools/android/build_speed/benchmark.py all_incremental Example Output: Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.7s chrome_java_nosig: 36.1s avg (35.9s, 36.3s) chrome_java_sig: 38.9s avg (38.8s, 39.1s) chrome_java_res: 22.5s avg (22.5s, 22.4s) base_java_nosig: 41.0s avg (41.1s, 40.9s) base_java_sig: 93.1s avg (93.1s, 93.2s) Bug: 1092528 Change-Id: I5840f99762edbaf6b7c7cc58b0f52b98051ed33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241643 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779877}
-
Ben Mason authored
Adds extra 32_64 targets if the previous behavior is needed Bug: 1093993 Change-Id: I6ffd3fb69c439d0591c4f02ace999d3be67805b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242253Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Codify the expectation that isValidAndVisible() == true implies that location !== undefined. AX-Relnotes: n/a. Bug: None. Change-Id: I7ba047b47b82086699f1c17a48263f76f6a9773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248349 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#779875}
-
Sammie Quon authored
When dragging a maximized window, the window may resize. We try to position the window so that the ratio between origin and event location and width remains equal. The caption buttons have the same size even if the window shrinks though, so if the original click was near the caption buttons, the ratio result may end up on top of the caption buttons. This CL addresses them by checking the position of the caption and shifting the new window bounds such that the mouse will not be on top of the caption buttons. This won't have an effect on custom headers, as theres no way to determine how large their caption area is. Test: manual Change-Id: I15b235dae773fe90283ffabf9daff0e4ac984e24 Fixed: 1082839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238415Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#779874}
-
Vasiliy Telezhnikov authored
This is the second CL for cleanup after we started to use proper VideoFrame::visible_rect for Android. GetTextureMatrix always returned identity matrix after the change, so remove the call and assume matrix is identity everywhere downstream. Bug: 1076564 Change-Id: I0c06b7dc98c2c0719f484719052e6abe295748d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248060Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#779873}
-
Aleks Totic authored
This reverts commit 7db3de6c. Reason for revert: MSAN failure, crbug.com/1096592 Original change's description: > Desktop PWAs: Unit test helper method InstallWebApp > > Extract unit test helper method InstallWebApp from unit tests to > web_app_unittest_util.h/cc and retire duplicate implementations. > > Drive-by: retire unused method FinalizeInstall > in web_app_install_manager_unittest.cc > > TBR=agawronska@chromium.org > > Change-Id: I5f7574ef89dfe1543727c2376d8002e2e6fce822 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247991 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779607} TBR=ericwilligers@chromium.org,loyso@chromium.org,dominickn@chromium.org Change-Id: I1b50d2ed80fbe29b9e742c7a533d3a0b65e0df7e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252561Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779872}
-
Eugene Zemtsov authored
1. remove tune() from VideoEncoder 2. Remove promises from VideoEncoder 3. Split init and config Bug: 1094166 Change-Id: I47b347c89bb11991cdd61f52e0e4a7ce99b8b1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244660Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#779871}
-
Roger Tawa authored
1/ Pipes the access point to the router which will be needed eventually for event cleanup 2/ Removes dependency of the router on the protos directly 3/ Adds overloads for the MaybeReortXXX and ReportXXXBypass functions to accept the new protos. Bug: 1069068, 1069062 Change-Id: I0fc5e734a665ef88552aebabe5d63f1bb90bb0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229600Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779870}
-
Renato Silva authored
Enables double opt-in countries by default on the marketing opt-in screen during OOBE. Fixed: 1096091 Bug: 1090724 Change-Id: I0bfbd2d54e96058ebf4c7fa5b5742e03c83c290c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249999 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#779869}
-
Edward Lesmes authored
METADATA.chromium are new files defined by a proto schema that accommodates team, OS, and component information, and that is extensible and structured, to replace the metadata information currently stored as OWNERS files comments. See the proposal for more details: https://docs.google.com/document/d/17WMlceIMwge2ZiCvBWaBuk0w60YgieBd-ly3I8XsbzU/preview Change-Id: I271b8f4cee03951c1fe3c64dad5aa0661234636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248340 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779868}
-
Paul Lewis authored
Adds support for nav start times ahead of https://crrev.com/c/devtools/devtools-frontend/+/2252159 Bug: 974550 Change-Id: I67af15f1f21af81454e7683541646b1b8d4c0171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252140 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#779867}
-
Scott Violet authored
BUG=1042771 TEST=WebMessageTest Change-Id: I36a550146fc15bcb76bbcfaca617ddbf79fa5792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250923 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d3394c28b80c..73bba61486a0 2020-06-18 shaochuan@chromium.org Fix DetermineAndroidBranch in various places 2020-06-18 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-17 vapier@chromium.org gs: upgrade to gsutil-4.51 2020-06-17 vapier@chromium.org retry_util: fix bytes-vs-string handling in curl retries 2020-06-17 cjmcdonald@chromium.org cros_extract_deps: Add flag to disable solver backtracking 2020-06-17 tcwang@google.com afdo: Improve sample threshold on AFDO profile creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia686aa57f39e94d4734b620bc8c8522b67c8d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252023Reviewed-by:
-
Andrey Zaytsev authored
Screenshots: Light mode: https://screenshot.googleplex.com/c5hr9M0ypqp.png Dark mode: https://screenshot.googleplex.com/iv2wB2Dih0s.png Bug: 1070620 Change-Id: Ie256680755395d0de1713af48bb8975f96f7a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238066 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#779864}
-
Mehran Mahmoudi authored
This CL extracts the existing TabViewManager into an interface and moves it to the Tab module. It also changes the TabViewManager ownership model from being owned by UserData, to Tab. Design doc: http://go/modularize-tvm Bug: 1074348 Change-Id: Ie1d753f60daff0fab91bae71803d7672e7fa0380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230282Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Yves Arrouye authored
What used to be a check for zero-touch enrollment (initial enrollment) is now been shared with other features and is referred to as initial state determination. Update types etc. to use this language. A subsequent CL will deal with UMA. Bug: chromium:1093509 Test: check log messages Change-Id: Iad47ee2e4e6c687a9f05afe88d5bfdd4e52b40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240251Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#779862}
-
Chris Blume authored
This CL adds UMA histograms for the 1st, 2nd, and 3rd-5th animation loops. The histogram tracks the number of frames skipped. We expect to see a fairly large quantity of small skips in the 1st loop. This has the effect of leaving holes in CC's cache. The 2nd loop would then have a larger number of frames skipped because filling the holes in the cache will cause multi-frame decodes. The 3rd-5th loops should begin to normalize to 0 frames skipped. Bug: 1094716 Change-Id: I85d22e1223d65bde398451fba1a9aff36698c114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245665Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#779861}
-
Xida Chen authored
This CL removes TouchAction.* related histograms. The reason of removing those is that we can't get useful info out from it. Here is the doc for compositor touch action: https://docs.google.com/document/d/1bSv_qNsLLnpXImuH7sHa6D3R_0GdDYkTiNjxso8Rgxo/edit In the doc, there are 3 phases and currently we have phase 1 completed. Here is a short summary for phase 1 & 2: phase 1: for GSU, if it is not allowed by allow lsited touch action, then let's put it in a deferred gesture event queue, and wait for the touch action comptued by blink to process that queue. phase 2: for GSU, if the allow listed touch action is PanX or PanY, then accumulate the delta on the y / x axis, and then wait for the blink computed touch action to tell whether the accumulated delta should be dropped or allowed. This isn't carried out because it will have user-facing behaviro change. So in order to evaluate how impactful phase 2 would be, we need the following info: When a GSU is put in deferred queue (which is only 0.01% of all GSUs), how often does that GSU is allowed / filtered by the blink computed touch action. Our current histograms don't give us that. Also, basically on the amount of GSUs that are put in the deferred queue (0.01%), it is probably not worth to carry out phase 2. Bug: 1089591, 1089592 Change-Id: Iaa2e1011ac3fa1d4a124a60424d97b329b39647f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246934Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779860}
-
Leonard Grey authored
This fixes a glitch when detaching tabs. See bug description for details. Bug: 979743 Change-Id: If59f7144817ef2d7da917fd483408ee082a3192a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248739Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#779859}
-
Andrew Grieve authored
Bug: None Change-Id: I17a8d301b67a8b2a5fc94f921fd2121a5469e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242640 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779858}
-
Stephen McGruer authored
This test is flaking on all platforms and turning bots red. TBR=kolo@chromium.org Bug: 1090625 Change-Id: I0bc59e2e472e686df45265485b20ef54beea6d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251088Reviewed-by:
-
John Lee authored
With the introduction of TabGroupChange::kMoved, there were multiple tab-group-moved events being sent, one for the group moving and one for the tabs in the group moving. This CL removes one of these events. This CL also selects a group's tabs when the WebUI tab strip moves the group to mirror the native tab strip and to allow the TabStripModelChange::kMoved events of the group's tabs to be ignored correctly. Previously, tab-moved events were being sent for each tab when a group was moved using the WebUI tab strip which caused for multiple unnecessary animations. Bug: 1082344 Change-Id: I663d46e2e9a9857cdbaba8c17d2ff526f2a2fff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246956 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#779856}
-
Eugene But authored
Some crashes required changing device orientation in order to reproduce. This CL logs specific orientation value after receiving UIDeviceOrientationDidChangeNotification Bug: 1046225 Change-Id: Iacf291b3ee561759a2ccd2d5c866349aaafacdf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250505Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779855}
-
