GitLab

Adds support to setup.exe to both upgrade itself and chrome.7z through
Zucchini patches when "use_zucchini = true" as a gn arg.

Zucchini patches are NOT created at this time! This is primarily for
experimentation with the release infra. A security review will be
conducted before launch.

This has been successfully tested using Zucchini-based versions of
chrome_updater.exe for the following cases:

Patchers
| setup.exe | chrome.7z |
-------------------------
| Courgette | Courgette | Default (can also be used for downgrades)
| Courgette | Zucchini  | Upgrade: once enabled
| Zucchini  | Zucchini  | Target Default
| Zucchini  | Courgette | Downgrade: in the event of issues

Child Changes:
- setup.rc PATCHERTYPE:
https://chromium-review.googlesource.com/937400
- BUILD.gn zucchini.exe:
https://chromium-review.googlesource.com/937396

Bug: 729154
Change-Id: Iec2e514a8b8a5ee311fe210505ac2b31c0418f54
Reviewed-on: https://chromium-review.googlesource.com/916553
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539854}

As part of the ddos mitigations, implemented all three ddos headers in
the component updater. The base::Optional implementation of the
feature is removed. Instead, the headers are passed using a map of
string to string.

There is an unrelated error handling change to invoke the callback if
for some reason, the caller is passing in no component id in the Update call.

Bug: 813193
Change-Id: I26e86564c13c0a5991027a6612dcdefbf991bfab
Reviewed-on: https://chromium-review.googlesource.com/938636Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539853}

This is in effect a temporary fix to always use libappindicator (when
available, but we have deb/rpm dependency on the lib, so it should
always be available), whilst I fix the dependency issue we have on the
build bots which would allow me to add a hard dependency and clean up
the code.

Bug: 799144, 797332 , 419673
Change-Id: Id64a452029b00ec8d86f0d35d319bebcfd8bf99e
Reviewed-on: https://chromium-review.googlesource.com/939732Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539852}

When doing a 32-bit build on a 64-bit system, the 32-bit version of the
library is not available. This CL should fix that.

Bug: 799144
Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09
Reviewed-on: https://chromium-review.googlesource.com/940196Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539851}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7d15497f7538..fe1144246e7e

$ git log 7d15497f7..fe1144246 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 zhangxy988 Add documentation for VariantWith.
2018-02-27 misterg gmock merging -2
2018-02-27 zhangxy988 Add matcher for std::variant.
2018-01-24 pcc Use _CPPUNWIND instead of _HAS_EXCEPTIONS with MSVC.
2018-01-25 pcc Pass -EHs-c- to disable exceptions with MSVC.

Created with:
  roll-dep src/third_party/googletest/src

Bug: 813219, 801780
Change-Id: I50f91ea85c1f118b18820450fbff18716d63b61a
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official
Reviewed-on: https://chromium-review.googlesource.com/941061Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539850}

OffscreenCanvas will now be turned on when Experimental Web Platform Features
is enabled, instead of being turned on when Experimental Canvas Features flag
is enabled.

Bug: 803941
TBR: junov@chromium.org,mcasas@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idaefadc28f631f0997af5378a0950912faf8aec4
Reviewed-on: https://chromium-review.googlesource.com/937811
Commit-Queue: Olivia Lai <xlai@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539849}

This CL fixes a bug that causes a crash when the export feature is disabled.

Bug: 789122, 814574
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I19bca436ff86cb93b7b2fea786e8e4dfcb9dd4b9
Reviewed-on: https://chromium-review.googlesource.com/941123Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539848}

Per origin quota for storage APIs (Indexed DB, Cache API, etc) is
allocated out of a "temporary pool", the maximum amount of storage
that Chrome will use on a given device. Historically, this value has
been 1/3 of disk space, based on the heuristic that the web should be
ephemeral and not dominate the device's storage vs. native
applications and content.

Since Chrome OS is web-centric (most apps are web apps, etc) the
fraction significantly limits how much web apps can store on the
device. Bump the number to 2/3. We may increase it further in the
future.

Bug: 817128
Change-Id: I0fa9eb44f6526c9f8112e2c727c396dcd37af92f
Reviewed-on: https://chromium-review.googlesource.com/940434
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539847}

This change removes a linear layout from main.xml that only has a
single child. The one child has been moved to be a child of the root.

BUG=816715

Change-Id: I96f1ce26f19c56c9ff69587504bc9a8c6d46c326
Reviewed-on: https://chromium-review.googlesource.com/939650Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539846}

This is true in practice. This change is the first in a series of
changes to make SmartLock only available on CrOS.

R=jlklein@chromium.org, tbarzic@chromium.org

Bug: 817115
Test: Existing tests
Change-Id: Idc0e414730d8efb4b36d36071362625e700675e1
Reviewed-on: https://chromium-review.googlesource.com/940448Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539845}

TtsPlatformImpl#initialize() calls TextToSpeech#isLanguageAvailable for
each of the installed locales. This call can result in certain calls to
the platform which end up doing I/O tasks. Since this method is run on
the UI thread, it causes those I/O tasks to be performed on the UI
thread as well.

This change fixes that issue by ensuring that that method is called on a
background thread, and only the calls necessary to run on the UI thread
run on it.

Bug: 813669
Test: Manually verified that skipped frames are no longer reported
Change-Id: If092b23eeed35b5384daa5f045c09fb8eda63281
Reviewed-on: https://chromium-review.googlesource.com/925822
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539844}

This reverts commit 2093bb8f.

Reason for revert: The last flaky test shown in crbug.com/817068 is before the fix https://chromium.googlesource.com/chromium/src.git/+/788c11139b869d1fc5b82cbbd238af2fd543535e. According to flaky dashboard, there is no test failure from these browser tests after the fix landed. So it should be good to stay.

Original change's description:
> Revert "Print with dead subframes for pdf composition"
> 
> This reverts commit d20c0123.
> 
> Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068).
> 
> Original change's description:
> > Print with dead subframes for pdf composition
> >
> > Handle two cases with dead subframes for pdf composition:
> > -- When a web page has a dead subframe prior to printing, we need to
> > detect the liveness of the subframe, and avoid requesting printing for
> > such frame;
> > -- If after we request printing a subframe, the subframe dies, we add
> > monitoring for render frame's closed event to check whether it is one
> > of our pending ones. If so, notify pdf compositor service about that.
> >
> > We add an interface in pdf compositor service to be notified about
> > the frame's unavailability for either of the above cases.
> >
> > In this CL, we also add a map to record the subframes that are already
> > printed and use it to avoid printing the same ones repeatedly.
> >
> > BUG=814086
> >
> > Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0
> > Reviewed-on: https://chromium-review.googlesource.com/932018
> > Commit-Queue: Wei Li <weili@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#539291}
> 
> TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> TBR=dcheng@chromium.org
> 
> Bug: 814086
> Change-Id: I2062517c3f955523618be23a52ad507c4da3de90
> Reviewed-on: https://chromium-review.googlesource.com/941201
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539818}

TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org,blundell@chromium.org

Change-Id: Iab653dd94f117956059bf950a4c54fd133270c07
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814086
Reviewed-on: https://chromium-review.googlesource.com/941501Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539843}

Bug: 786245
Change-Id: I7b20bd9f27c9790548877fa580066c5f2d7a14f8
Reviewed-on: https://chromium-review.googlesource.com/940332Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539842}

Collection backings use raw pointers instead of Member so we need manual write barriers.
This CL emits a write barrier on collection backing assignment, and disables promptly free for any marked backings, as they may already be registered in the marking CallbackStack.

Bug: 757440
Change-Id: I56f676808bfa94f468594541f979161b8feb773e
Reviewed-on: https://chromium-review.googlesource.com/931141Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539841}

- Previously this flag was enforced in ValidateNotificationResources in
NotificationMessageFilter, in case of a compromised renderer which
didn't respect the NotificationContentImage feature flag.

- This patch ensures we continue to enforce this flag for notifications
which take the new mojo code path.

R=peter@chromium.org

Bug: 796990, 796991
Change-Id: Ic048757c8a2f3c5b063e4987da3a00347335927d
Reviewed-on: https://chromium-review.googlesource.com/930965
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539840}

This patch fixes safe-to-break offset vector in ShapeResult:
1. Fixed before the first glyph of each run to be safe-to-break.
2. Fixed before the last glyph of each run not to force safe-to-break.
3. Fixed non-cluster boundaries were off by one.

Also related, two fixes are made to NGLineBreaker:
1. When the whole item can fit, it does not consider when the start of
   the item is not safe-to-break. The optimized code path was removed
   to fix this. If this seems to hit performance, we can bring it back
   with safe-to-break support.
2. Add |start_should_be_safe| argument to ShapingLineBreaker to make
   the start of wrapped line safe-to-break, but not the middle of a
   wrapped line (i.e., when there are previous items.)

HarfBuzzShaperTest.SafeToBreakLatinDiscretionaryLigatures was fixed
to match to what HarfBuzz returns as HB_GLYPH_FLAG_UNSAFE_TO_BREAK.

This change causes a crash in
fast/inline/absolute-positioned-inline-in-centred-block.html
This is from an issue in HarfBuzzShaper, tracked in issue 817271.

Bug: 816614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id55ea10f0b6f879981e3725b7cac027b39f3f213
Reviewed-on: https://chromium-review.googlesource.com/939942
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539839}

Noticed while enabling AA for clips (in general.) This should prevent
regressing a few multicol tests when enabling AA clips.

Bug: 814876
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I06ad3aa535e7ba0781f0f78fb80e43d8b68d70e4
Reviewed-on: https://chromium-review.googlesource.com/937518
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539838}

Previously, this would crash.

Bug: 811269

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I672a77ef521537b2306ab174064c1af3e90df982
Reviewed-on: https://chromium-review.googlesource.com/938748Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539837}

Android apps are closed by BrowserBack key on Chrome OS.
To make the built-in app's behavior consistent and keep the app alive, we close
the built-in media players on BrowserBack.

Bug: 807521
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic5097216bc83f6fd78db6f7d9155b0705b2eea3b
Reviewed-on: https://chromium-review.googlesource.com/940784Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539836}

This is required for apk_operations.py to know which Activity to send
an intent to for the "launch" command.

This also adds a --nokill flag to apk_operations.py, which will allow
URLs to be sent to apks without the application being restarted (due to
the call to set-debug-app).

Change-Id: I9a326a2999afc3e3cf9d143462c2c3bc8d9a480f
Reviewed-on: https://chromium-review.googlesource.com/940762Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539835}

Followup to review comment on
https://chromium-review.googlesource.com/c/chromium/src/+/928654.

TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib2c5b3a86929491272399df515638e813b65db25
Reviewed-on: https://chromium-review.googlesource.com/939462
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539834}

Bug: chromium:757440
Change-Id: I7ae80b85a64245346d9b7a41aea351b80c86b4b9
Reviewed-on: https://chromium-review.googlesource.com/941221Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539833}

Chrome passwords settings on Android allow the user to export
passwords. The Java settings code asks the C++ code to serialise and
send over the passwords. The serialised result is in UTF-8 within C++
but gets converted into UTF-16 for Java and then back to UTF-8 on
writing to a cache file.

This CL changes the data type from String to byte array on Java side.
This eliminates the converstion to UTF-16 and back.

Note 1: This was pointed out in
https://chromium-review.googlesource.com/c/chromium/src/+/926527/2/chrome/browser/android/password_ui_view_android.cc#222.

Note 2: This might get further simplified if https://crbug.com/817293
gets implemented, but that's not happening in M66.

Bug: 788701
Change-Id: I0799b2c5f6d7e43e9b7449322d300fb9e9d82c54
Reviewed-on: https://chromium-review.googlesource.com/940226Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539832}

Benchmarks are executed as part of ChOps's smoke tests.
These smoke tests are also run on debug build, which is much slower.
This results in the smoke test framework's perception that Speedometer2
is hanging and thus crashes with a timeout.

Now there is the option to do something different in a benchmark in
case it is run as a smoke test.

R=nednguyen@google.com
Bug=792495

Change-Id: I338c39ba3377738e4e52f1869702d444bb266221
Reviewed-on: https://chromium-review.googlesource.com/941227
Commit-Queue: Michael Hablich <hablich@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#539831}

This patch fixed the missing part from the previous patch
https://crrev.com/c/939585 to completely disable the feature.

Bug: 814673
Change-Id: Id14a32351d6153221aabf36dec506533ad07b437
Reviewed-on: https://chromium-review.googlesource.com/941262
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539830}

The testing::Test fixture (used by TEST macro) does not drain the
autorelease pool after a test. PlatformTest should be used.

Add a PRESUBMIT check that neither TEST nor testing::Test is used
in iOS Objective-C++ test files. Files are assumed to be iOS if
either their base name match '\bios\b' or one of the component in
the path is 'ios'.

Expand MockInputApi to filter files in mocks of AffectedFiles and
AffectedSourceFiles function, adding missing mocked functions too.
Fix unit tests that were failing after the filtering is correctly
implemented.

Bug: none
Change-Id: I0af99b6658b8e15888dfcfb94345eb879ab9fd37
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/937204Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539829}

https://chromium.googlesource.com/catapult.git/+log/371be98a6bf6..c0485e380759

$ git log 371be98a6..c0485e380 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 nednguyen Remove [page_set] argument in help string message of benchmark run command

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I6b24cf58cacee3faaab8b47cda35dbfa57720ee4
Reviewed-on: https://chromium-review.googlesource.com/941263Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539828}

The ResourcePrefetchPredictor isn't going to be used in the near future.

Bug: 816545
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e15bef529e5f0b13a09275b8fe7b385ec8215ba
Reviewed-on: https://chromium-review.googlesource.com/939171Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539827}

This CL makes the sync illustration in the user menu
non accessible so it is not read by VoiceOver.

Bug: 814995
Change-Id: I280cd359fc389afdeed03bf914b1e8a5cc741bee
Reviewed-on: https://chromium-review.googlesource.com/934507
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539826}

This adds the remaining metric:
- PasswordManager.ExportedPasswordsPerUserInCSV

Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I913bedb9f3e716db6f7ac78975344f994ae02016
Reviewed-on: https://chromium-review.googlesource.com/939166
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539825}

Bug: none
Change-Id: Ie3adc12610b37a5021038664ab691c100e3fb652
Reviewed-on: https://chromium-review.googlesource.com/940224Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539824}

Bug: 817330
Change-Id: Ifb402ed997f4c2b4d96e1b4124ee518b8700f69a
Reviewed-on: https://chromium-review.googlesource.com/940140Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539823}

This CL adds an accessible name to the
"Sync with another account" dropdown arrow in
the contextual promos.

Bug: 814986
Change-Id: Icb43e48a398178d30cd7517b1aba2c1efa697492
Reviewed-on: https://chromium-review.googlesource.com/939397Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539822}

- Added TODO to move PageVisibilityState into core/.
- Pass weakptr in OnWorkerSchedulerCreated instead of adding a method to
  get a weakptr.
- Remove some leftover code.

R=haraken@chromium.org,dcheng@chromium.org
BUG=776416

Change-Id: I1d6705fe59d878f316809cf73ce6f61c8bfe77b6
Reviewed-on: https://chromium-review.googlesource.com/939469Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539821}

This CL doesn't show the progress bar during the loading of the page on
iPad.

Bug: 813073
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I94c2ca6b28906220aeaf7affca702bd36e49b0d8
Reviewed-on: https://chromium-review.googlesource.com/941223Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539820}

https://chromium.googlesource.com/catapult.git/+log/7a160b6bb44a..371be98a6bf6

$ git log 7a160b6bb..371be98a6 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 nednguyen Remove perf profilers in Telemetry

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I6aa5eade1047c6e079c448a7041b41171929b88f
Reviewed-on: https://chromium-review.googlesource.com/941181Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539819}

This reverts commit d20c0123.

Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068).

Original change's description:
> Print with dead subframes for pdf composition
>
> Handle two cases with dead subframes for pdf composition:
> -- When a web page has a dead subframe prior to printing, we need to
> detect the liveness of the subframe, and avoid requesting printing for
> such frame;
> -- If after we request printing a subframe, the subframe dies, we add
> monitoring for render frame's closed event to check whether it is one
> of our pending ones. If so, notify pdf compositor service about that.
>
> We add an interface in pdf compositor service to be notified about
> the frame's unavailability for either of the above cases.
>
> In this CL, we also add a map to record the subframes that are already
> printed and use it to avoid printing the same ones repeatedly.
>
> BUG=814086
>
> Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0
> Reviewed-on: https://chromium-review.googlesource.com/932018
> Commit-Queue: Wei Li <weili@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539291}

TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=dcheng@chromium.org

Bug: 814086
Change-Id: I2062517c3f955523618be23a52ad507c4da3de90
Reviewed-on: https://chromium-review.googlesource.com/941201
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539818}

The implementation is currently in content/ and used by download and pepper.
Download code is being moved to components/.
This CL moves the quarantine implemetation to components/ so it
can be shared between content/ and components/

BUG=803135

Change-Id: Id68afca113891abb8475b6b64f5854be28b0ca3e
Reviewed-on: https://chromium-review.googlesource.com/933287Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539817}

R=thakis@chromium.org

Change-Id: I53c11336429d7c0f3b42c3bb16b3906dfa54ad40
Reviewed-on: https://chromium-review.googlesource.com/939786Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539816}

Rename the android_library target so it doesn't overlap the
similarly named library in the cronet/ output directory.
This is an attempt to avoid some weird compile flakes where
a class file from one cronet_impl_common_java.jar somehow
ended up in the other cronet_impl_common_java.jar.

Bug: 816981
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia2f431dd7c2793ca5498fd5696cb2f613ef9f6af
Reviewed-on: https://chromium-review.googlesource.com/940586Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539815}