GitLab

Rebooting s3 devices causes device to be flaky during the deploy step. This is
likely because WaitForPackageManager() does not wait long enough on the s3
devices. I've verified locally on the bot that without the reboot in the
provision step, the devices are more reliable (i.e. deploy step passes).

BUG=321063
TBR=frankf@chromium.org

Review URL: https://codereview.chromium.org/122313008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243542 0039d316-1c4b-4281-b951-d872f2087c98

Also, re-arrange a bit of code in the implementation file for slightly clearer
structuring.

BUG=none
TEST=none
R=estade@chromium.org
TBR=joi@chromium.org,zea@chromium.org

Review URL: https://codereview.chromium.org/122313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243541 0039d316-1c4b-4281-b951-d872f2087c98

Adding parameters to Cast Streaming Extensions API to configure
AES encryption key and IV mask to CastSender.

BUG=315931

Review URL: https://codereview.chromium.org/121543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243540 0039d316-1c4b-4281-b951-d872f2087c98

Keep resource ID of these entries empty.
Remove IsSpecialResourceID().

BUG=324717
TEST=unit_tests

Review URL: https://codereview.chromium.org/118953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243539 0039d316-1c4b-4281-b951-d872f2087c98

When opened selected a USB volume in Files app, and crashed, the Files app is tried to be restored with the previous path. However, the volume may not yet be available. In such case, parent is considered. However, parent is /removable, which resolving causes an error, resulting in throwing an exception and going into a wrong state.

In such situation, we should fallback, and this is what this patch does. If the parent is not resolvable, then the fallback is used as the next current directory instead.

Moreover, after recent refactoring a regression has been introduced. When resolving a parent of the initial directory fails, then a wrong variable name was used, what caused a JS error.

TEST=Tested manually on Pixel.
BUG=331587

Review URL: https://codereview.chromium.org/124933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243538 0039d316-1c4b-4281-b951-d872f2087c98

First, turning on JS, which is disabled by default.

Also, no one guarantees that onload + writeln + onPageFinished must work as
you'd expect, so there is no point in testing this scenario. So just change this
test to verify that the title updated via JS is reported by GetTitle.

BUG=151012

Review URL: https://codereview.chromium.org/117993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243537 0039d316-1c4b-4281-b951-d872f2087c98

This avoids showing a double title bar on browser windows without a tab
strip, such as popups, Developer Tools and V1 app windows.

BUG=330090
TEST=On Unity, maximize Developer Tools window. There should be only the
Unity title and caption buttons, no blue custom title bar.

Review URL: https://codereview.chromium.org/117233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243536 0039d316-1c4b-4281-b951-d872f2087c98

No functional changes.

BUG=309578

Review URL: https://codereview.chromium.org/115013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243535 0039d316-1c4b-4281-b951-d872f2087c98

This CL addresses the remaining comments at http://crrev.com/121183002 .

TEST=none

Review URL: https://codereview.chromium.org/114033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243534 0039d316-1c4b-4281-b951-d872f2087c98

Page.disable clears all scripts to evaluate on commit. There is no way
to detect client side redirects because linkedin, for example, performs
its client side redirect after the page has fully loaded.

In order for the page_cyclers to work on pages with client side
redirects, the script to evaluate on commit must execute on the
redirected page.

So to workaround this, we avoid ever calling Page.disable. we don't
expect continuing to listen for notifications here to impact
performance, but if we do see any performance reduction on the bots we
should revert and search for another approach.

This is a reland of https://codereview.chromium.org/103373003 fixing failures
on the bots.

BUG=253604
R=pdr@chromium.org
TEST=tools/perf/run_measurement --browser=canary page_cycler tools/perf/page_sets/top_10_mobile.json --pageset-repeat=2

Review URL: https://codereview.chromium.org/112413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243533 0039d316-1c4b-4281-b951-d872f2087c98

This adds a DiscardableMemoryType enum and a function that
can be used to select what type of discardable memory to
use. This is generally useful for debugging purposes and
when evaluating the performance of one implementation vs
another.

The unit test framework for discardable memory is improved
slightly by testing every supported type on each platform
rather then just the one specific type.

Furthermore, it allows us to expose ashmem based
discardable memory on ChromeOS in about:flags before we
make it default.

No change in behavior unless the new
--use-discardable-memory=type switch is used.

BUG=327516
TEST=base_unitttest --gtest_filter=DiscardableMemory*
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/114923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243532 0039d316-1c4b-4281-b951-d872f2087c98

To fix use-after-free

BUG=331822
TEST=See no crash after following the repro steps described in the BUG.

Review URL: https://codereview.chromium.org/127613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243531 0039d316-1c4b-4281-b951-d872f2087c98

Implements ash::internal::LogoutConfirmationDialogView which is supposed
to be used by ash::internal::LogoutButtonTray.

BUG=223846
TEST=new unit test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242286

Review URL: https://codereview.chromium.org/40053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243530 0039d316-1c4b-4281-b951-d872f2087c98

The old approach chose the nav dot width by measuring a phantom
dot containing the string "Most Visited," but only when the Most
Visited dot is shown. This approach fails when it isn't shown,
or when the string "Apps" is longer than the string "Most Visited"
in the user's local language.

Screenshots on the bug.

BUG=248495

Review URL: https://codereview.chromium.org/110523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243529 0039d316-1c4b-4281-b951-d872f2087c98

Trace-viewer side change is here: https://codereview.appspot.com/39310043

Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png

Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit

TBR=phajdan.jr
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242671

Review URL: https://codereview.chromium.org/109933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243528 0039d316-1c4b-4281-b951-d872f2087c98

Finally - the first two functions which go for good!

BUG=322682
TEST=covered by other unit tests

Review URL: https://codereview.chromium.org/109823010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223574
TEST=manually tested

Review URL: https://codereview.chromium.org/108163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243526 0039d316-1c4b-4281-b951-d872f2087c98

Event names and dictionary values in the event router of Files.app can be
replaced with constants and types generated by the IDL compiler.

BUG=330638
TEST=none

Review URL: https://codereview.chromium.org/107813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243525 0039d316-1c4b-4281-b951-d872f2087c98

Add support for having multiple queries to be active at the same time
given that their targets are different.

BUG=328808

Review URL: https://codereview.chromium.org/106623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243524 0039d316-1c4b-4281-b951-d872f2087c98

 * Move shared constants between V1 and V2 to drive_backend_constants.
 * Drop dependency from FakeDriveServiceHelper to APIUtil

BUG=331991

Review URL: https://codereview.chromium.org/103013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243523 0039d316-1c4b-4281-b951-d872f2087c98

for assistive technologies on Windows. This changeset adds support for

- article (xml-roles:article)
- header (xml-roles:banner)
- aside (xml-roles:complementary)
- address (xml-roles:contentinfo)
- footer (xml-roles:contentinfo)
- main (xml-roles:main)
- nav (xml-roles:navigation)
- section (xml-roles:region)

Patch from Takeshi Kurosawa <taken.spc@gmail.com>
BUG=253027
TEST=content\renderer\accessibility\accessibility_node_serializer.cc

Review URL: https://codereview.chromium.org/98183011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332341
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/127753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243519 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243517 0039d316-1c4b-4281-b951-d872f2087c98

R=engedy@chromium.org
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/123423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332331
TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/127813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243515 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a revert of r234889 "[Files.app] Show files beginning with '.' (dot)", which causes Issue 330513.

BUG=196539, 330513

> [Files.app] Show files beginning with '.' (dot)
> 
> BUG=196539
> TEST=manually tested
> R=hirono@chromium.org
> 
> Review URL: https://codereview.chromium.org/71503003

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/127803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243514 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243513 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164506:164655&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/127673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243512 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/127653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243511 0039d316-1c4b-4281-b951-d872f2087c98

The API has long been in stable, so the test files shouldn't be in an "experimental" directory hierarchy.  Also, fixed minor issues caught by PRESUBMIT: 1) Removed tabs.  2) Corrected LOG(INFO) statements to more-appropriate LOG(ERROR).

Review URL: https://codereview.chromium.org/127353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243510 0039d316-1c4b-4281-b951-d872f2087c98

No one uses this class.

R=enne@chromium.org
BUG=NONE
TEST=NONE(No functional change)

Review URL: https://codereview.chromium.org/127173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243509 0039d316-1c4b-4281-b951-d872f2087c98

GCM API tests disabled on Windows due to the failure on official
window builds. Most of them are not enabled with the help from
using ScopedCurrentChannel trick.

BUG=324982
TEST=Enabling tests

Review URL: https://codereview.chromium.org/126913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243508 0039d316-1c4b-4281-b951-d872f2087c98

Add the override annotation to all necessary methods in .../quic/.

Merge internal change: 59008686
https://codereview.chromium.org/126243002/


Enabled StopPacketProcessing unit test.
Added EXPECT_CALL for OnUnauthenticatedPublicHeader.

R=rch@chromium.org
BUG=331630
https://codereview.chromium.org/113073003/


Add an end-to-end test which verifies that QUIC 13 does not generate
QUIC_STREAM_RST_BEFORE_HEADERS_DECOMPRESSED errors.

Merge internal change: 58990354
https://codereview.chromium.org/121883003/


Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where
the high water mark is not raised past the current transmission of a
packet whose previous packet has been ACKed. This bug was first
observer in jri's lab experiments.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58760014
https://codereview.chromium.org/125183004/


Correctly handle NACK-based "retransmission" of packets which no longer
have retransmittable data associated with this. These can be the result
of TLP retransmission or a current transmission of a packet whose
previous transmission have been acked.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58758718
https://codereview.chromium.org/125183003/


Simplify RTO interaction between the QUIC sent packet manager and the
send algorithm. The manager no longer needs to abandon each packet
individually.

Merge internal change: 58755766
https://codereview.chromium.org/125253004/


Remove a QUIC test only flag(limit_rto_increase_for_tests) to limit the
RTO increase in EndToEndTests.

This is no longer necessary now that two TLP's and early retransmit have
been added.

Merge internal change: 58591658
https://codereview.chromium.org/112953003/

Review URL: https://codereview.chromium.org/126513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311902
TEST=run install-build-deps.py in saucy chroot.

Review URL: https://codereview.chromium.org/126333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243506 0039d316-1c4b-4281-b951-d872f2087c98

In both aura and win this function is Not Implemented

BUG=

Review URL: https://codereview.chromium.org/126053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243505 0039d316-1c4b-4281-b951-d872f2087c98

This CL simplifies how DriveAppRegistry stores App info.
Main purpose is to add |all_apps_|, the explicit list of
all application currently registered.

BUG=332014

Review URL: https://codereview.chromium.org/125813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243504 0039d316-1c4b-4281-b951-d872f2087c98

Since these tests run on non-Windows platforms, the pak file seems to be loaded
fine and these .rc files should not be necessary.

BUG=297672
NOTRY=true

Review URL: https://codereview.chromium.org/125103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243503 0039d316-1c4b-4281-b951-d872f2087c98

Moved the 'if' clause to check if the translation is performed automatically to TranslateManager. TranslateBubbleView::ShowBubble is called not only from TranslateManager but also when the user clicks the icon explicitly. In the latter case, the translate bubble should be shown whether the automatic translation is done or not.

BUG=330684
TEST=manual

Review URL: https://codereview.chromium.org/124833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243502 0039d316-1c4b-4281-b951-d872f2087c98

Adds various metrics related to GCM connection stability and persistent store
usage.

BUG=284553

Review URL: https://codereview.chromium.org/123453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243501 0039d316-1c4b-4281-b951-d872f2087c98

The new design of the window headers does not use a super transparent window header when there is just one window on screen.
The solo window feature is also broken in the M32 and M33 branches (crbug.com/330212)

BUG=297187
TEST=None
R=jamescook
TBR=oshima (For trivial change in chrome/browser/chromeos/login/login_display_host_impl.*)

Review URL: https://codereview.chromium.org/123023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243500 0039d316-1c4b-4281-b951-d872f2087c98