GitLab

This reverts commit 23971187.

Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.>

Original change's description:
> Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase
> 
> Increase max_old_space_size to 4 GB based on availability of physical memory.
> The purpose of this finch is to support web apps that require more heap space
> for their data sets
> 
> Bug:958974
> 
> Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Commit-Queue: Maggie Chen <magchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656851}

TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 958974
Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484Reviewed-by: Maggie Chen <magchen@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657461}

Previously when a scroll container's snap type is changed to 'none' its
data was discarded including all of its snap areas. However this is
incorrect. Because while the snap type is 'none', the element is still
a scroll container which per spec [1] means  that is should continue to
captures the snap areas in its subtree for whom it is the nearest
ancestor scroll container . The only difference is that it no longer
snaps.

The fix is that we no longer remove the snap container data just
because is has a 'none' snap type and instead keep it and its snap
areas. But we check the snap type before performing any snap.

To ensure this does not introduce any performance regression, this CL
also includes an optimization where we avoid re-calculating
snap_container_data when the snap type is 'none'. So keeping these snap
data should not be cheap.

Note that there is another problem where if the current snap container
is no longer a scroll container (e.g., overflow: scroll => overflow:
visible) we release its snap areas and they become "orphan". But if we
are to do this correctly, we should re-assign these areas to the next
stroller in the chain. Similarly when an element becomes a scroll
container, it can potentially take over snap areas from its parent snap
container.


This patch does not address that situation yet but fixes the easier
problem.

[1] https://drafts.csswg.org/css-scroll-snap/#overview

Bug: 953575
Test:
 - wpt/css/css-scroll-snap/scroll-snap-type-change.html => Changing snap-type should work correctly
 - wpt/css/css-scroll-snap/scroll-snap-type.html => Add a specific test for type 'none' to ensure it does not snap

Change-Id: Ie493ad68ecba818ed41c0ee103ccf44725ff6e3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589899Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657460}

Instead of decompositing transforms of pending layers before updating
cc transforms, now decomposite a pending layer's transforms just after
we create cc effect, clip and scroll nodes. We don't decomposite a
transform if the cc transform node has been created during creating
other cc property nodes.

Because decompositing transform of a layer is just to move the
transform pointer up along the transform path, it won't affect other
layers which may not decomposite the same transforms.

This improves performance by avoiding hash map accesses and additional
pending layer iteration and blink paint property tree walks.

Change-Id: Idfdc6bc510cfb83a1b3eb3956cc2fb0a11d457a2
Bug: 954520, 954493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597205
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657459}

If `requireResidentKey` is false an authenticator may, at least with
CTAP 2.0, still create a resident key. RPs might want to set credProtect
level two for that case even though it's moot for non-resident keys.

This change allows that stance.

Bug: 941120
Change-Id: If4be7aabbb2d5b002942a0dc033f49b4c71b8538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595972
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657458}

https://chromium.googlesource.com/catapult.git/+log/1b3bbd05bd7b..195bcae748c7


git log 1b3bbd05bd7b..195bcae748c7 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 rmhasan@google.com [Telemetry] Add the --all command line argument to telemetry browser tests


Created with:
  gclient setdep -r src/third_party/catapult@195bcae748c7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:937516
TBR=sadrul@chromium.org

Change-Id: Ifd6e4e83480121c9295bb008d5a964c4ffd5cffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599739Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657457}

This reverts commit 6bff67f4.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 657321 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmJmZjY3ZjQ5MjI4OWVhMzk1MzVmYTQ4M2Q3MDNjY2MwZDNkZTg1Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/12268

Sample Failed Step: non_network_service_interactive_ui_tests

Sample Flaky Test: ScreenRotationTest.RotateInTable/1

Original change's description:
> [CrOS Perf Test] Rotatoin Animation Test
> 
> This runs the rotation ainmation with following conditions:
> with 2 or 8 windows,
> with NTP or blank page
> in overview mode or normal
> 
> Bug: 952885, 919707
> 
> Change-Id: I50f0a44a3c2a3f79d9ffd0d818f59d2e660784dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594043
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657321}


Change-Id: Ie2de9b64e8f23cd991b9d290ed488747af412fbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952885, 919707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598325
Cr-Commit-Position: refs/heads/master@{#657456}

It was using UnescapeURLComponent(), which, unlike
UnescapeBinaryURLComponent(), leaves certain characters escaped. The
behavior difference doesn't really matter for the purposes of these
tests, we're just trying to reduce the consumers of
UnescapeURLComponent() to only those that need and expect it not to
unescape UTF-8 characters that are unsafe to display, so we can expand
that logic.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I7d1f64b5fab51b8120a0c3504e4e8cd1610b79d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600092
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657455}

This is in an attempt to reduce the number of reviews that originally
get sent to us that should probably get sent to Caleb and his team.

R=eyaich@chromium.org,sullivan@chromium.org,crouleau@chromium.org

Change-Id: Ib57c78f369c2c4fbe0105975e0c55ff6719cdbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596836Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657454}

This change is a predecessor to moving AddTaskTime out of the
schedulers and into the PerformanceMonitor.  Since that requires a
large overhaul of the existing framework, this change will provide
actionable numbers for CPU performance on ad frames, even if some
events are still being missed (there is evidence rAF is a large
contributor to overall CPU time).

Bug: 937298
Change-Id: Ifd51400192cf008a3d4fd127f0cbead66955f5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594692Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657453}

Some UrlConnection impls require this before getOutputStream()
is called.  Calling this should be a no-op on Android but should
allow the Cronet Java API impl based on UrlConnection to
work in Robolectric.  Internal bug b/35665404.

Change-Id: Ib911ff4bb7bc9a7906c3e723f6583df1d510b1ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598493
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657452}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/378f007f127e..b58501a3b11b


Created with:
  gclient setdep -r src-internal@b58501a3b11b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:944752
TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org

Change-Id: Ie14b098723988d062965893df17f15d609abceaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599738Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657451}

Prevously we collected animation element ids after updating cc paint
properties, and traversed the parent chain until we find a node whose
element id had been collected. This might repeatedly traverse many
nodes without element ids unnecessarily.

Now collect animation element ids just after creating cc property
node to avoid the repeated traversal.

Bug: 954520
Change-Id: I923b610766d04d80041b8ddf46cc9828621d9237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598328
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657450}

Tapping the Done key whenever editing a username will now dismiss the
keyboard. This is required since the Save/Update button might be hidden
by the keyboard.


Bug: 945478
Change-Id: Ic26b5f667b11d27f6fcfc7ac08824781ff3ce857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599673Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657449}

If license allows, cast_shell always gets clear audio stream before
pushing buffer to media backend. Otherwise, playback fails.

Bug: internal b/131755006
Test: Stream mentioned in the bug, GPM
Change-Id: Ifcf4f6c6a856d4173d9b30b98b82943f8f0f1fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595508Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657448}

While the idea in
https://chromium-review.googlesource.com/c/chromium/src/+/1544880 was
correct, we forgot to consider what happens when a source stops and is
disconnected to the ScriptProcessorNode (AudioWorkletNode).  In this
case, the output of the node is disabled.  But that's incorrect in
general because the node's processing must continue because it has
user-defined outputs so a silent input does not imply a silent output.

Rather than adding a special case in DisableOutputsIfNecessary, let's
just revert the change.  The internal properties aren't exposed to the
developer.

Bug: 959125
Test: the-scriptprocessornode-interface/simple-input-output.html
Change-Id: I0f217be24eacff6031a537086df535e6c1e8d9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598427Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657447}

Specify the custom background image via a <link rel="preload"...>
tag that's inserted at the time the page is served.

Bug: 853042
Change-Id: Id24b1815c66b32f04b1811e55c54b5066cfc9873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592122Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657446}

The new condition is the same as cc::PropertyTreeBuilder.
This avoids unnecessary PAC::Update in js_poster_circle benchmark.

Bug: 954520
Change-Id: Ib547c828d4dee7e97fe8e72e2ed69f7a2545d63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597209
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657445}

This involves updating the shard number in bot_platforms.py and perf_data_generator.py,
and running the following commands to update the json files:

./tools/perf/generate_perf_sharding update --builders android-nexus5x-perf-fyi
./tools/perf/generate_perf_data


Bug: 959997
Change-Id: I83c028942493742f877385b59d5119fe998abe2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598174
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657444}

Avoids including assets/unwind_cfi in measurements, which is a canary &
dev-only feature.

Bug: 960197
Change-Id: I513f152ef0172804daaa563d5221eb501b2126f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598230Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657443}

It's unclear why, but we're suddenly hitting this error anytime we try to
upload accessibility changes:

ui/accessibility/PRESUBMIT.py had an exception.
invalid syntax (<string>, line 249)
Maybe your depot_tools is out of date?

NOTRY=true

Bug: none
Change-Id: Iac101d64cb971cd5ac32ad6a90db1d3f657caeb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600077
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657442}

This class is no longer needed.

Bug: 960392
Change-Id: If2a6bf13fad036c4133324df1ad41e00a4545439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598200Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657441}

We capitalise PIN elsewhere so this change aligns the UI with that.

Change-Id: I75c2aadbc29d6687806bf44af88a31012c394f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598336
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#657440}

Instead of maintaining two separate data structures (a bitmap) and an unordered
hashmap for updating interior slots, just keep track of interior slots in a
std::map.

- std::map::lower_bound is used to provide the bailout that was provided by the
  sparse bitmap.
- The iteration through the objects payload can just be done via iterator
  increment.

Change-Id: I569bd9155bf90bdf300104e8dc2d8ae2dd0dcb63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595873
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657439}

are in "Incognito" or "guest" mode.

Bug: 958054
Change-Id: I35e4adec0fd1800cff1ec2fcfe7983e2a65540e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591886
Commit-Queue: Siye Liu <siliu@microsoft.com>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657438}

New Win10 NVIDIA GTX 1660 bot is failing on 2 tests that are missing
expectations.

Bug: angleproject:3424
Tbr: kbr@chromium.org
Change-Id: I0cee6259845a4946aa11a9226f9bd082faa73c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600033Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657437}

Bug: 954907
Test: none
Change-Id: Id6fc0782fee4cb259aa5002043fcf4466a91f1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598482Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657436}

Bug: 945478
Change-Id: I98697e7c8a4f850c9816d1b1b5acd1563e5cd405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593865Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657435}

https://chromium.googlesource.com/angle/angle.git/+log/e76c5c3c3246..84e7932d2737


git log e76c5c3c3246..84e7932d2737 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 jonahr@google.com Roll SPIRV Deps (May 7th, 2019)
2019-05-07 syoussefi@chromium.org Vulkan: add uniform buffer object support


Created with:
  gclient setdep -r src/third_party/angle@84e7932d2737

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org

Change-Id: Ic340c479b9b8dc3211259abd3254cf445b46c1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598216Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657434}

Fix the test to pass on Mac 10.13.

Bug: 925517
Change-Id: Ifc630605dfd8de124a3d4af77d35f4374ca0c316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597910Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657433}

Texture::Buffer is using the deprecated ContextFactoryObserver interface
to find out about main thread context loss. The ContextFactory adds
itself as a ContextLostObserver, then on context loss forwards that
message along to all the ContextFactoryObservers.

There are multiple message pipes between the browser and GPU process
that have indeterminate ordering for when they find out about connection
errors. This leads to the following ordering problem:

1. The GPU process crashes. The old shared main thread
   RasterContextProvider is lost and any message pipes between the
   browser and GPU process will encounter connection errors.
2. A new shared main thread RasterContextProvider is created.
3. Exo allocates a new Buffer::Texture using the new shared main thread
   RasterContextProvider.
4. The new Buffer::Texture adds itself as a ContextFactoryObserver.
5. All ContextFactoryObservers get notified about OnLostSharedContext()
   for the old shared main thread RasterContextProvider loss. For the
   new Buffer::Texture this is wrong, the RasterContextProvider is still
   valid.
6. The new Buffer::Texture destroys all of it's resources incorrectly.
   This triggers a flood of GL errors from the GPU process.

Make Buffer::Texture a ContextLossObserver instead. This way the
Buffer::Texture gets notified about context loss for only the
RasterContextProvider it's using.

Bug: 954151, 944597
Test: BufferTest.OnLostResources
Change-Id: Ic68dbaab8864b835b2bbb83b3b43f03495902aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597390
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657432}

https://skia.googlesource.com/skia.git/+log/06e14afaa7db..056944747072


git log 06e14afaa7db..056944747072 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 halcanary@google.com experimental/editor: progress
2019-05-07 ethannicholas@google.com more SkSL interpreter performance work
2019-05-07 bungeman@google.com Fix some documentation for SkFont.


Created with:
  gclient setdep -r src/third_party/skia@056944747072

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I271c385dc25d09a24ec41444dfb1cd85d3b17131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599518Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657431}

History observers do not provide notifications on each visit removal.
Instead they provide observers updates when an enitre URLRow is removed.

Bug: 1531691
Change-Id: I92831d6b67698cfb9d8012e47cd3c17d55e1c570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594658
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657430}

TBR=tsepez@chromium.org

Bug: 958154
Change-Id: I21dadda1bd78fbd713eb3574edea7f2087100762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595982
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657429}

We are enabling FTL signaling by default to allow easier testing and
debugging.

Change-Id: Id7ea6e9dafa79ad40e2398674fca917ded59033d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598346Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657428}

Bug: 958152

Change-Id: I5ad52e1829c6698fa0042ef1ab9e4588d45c6e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596839Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657427}

Adds the concept of observers to KerberosCredentialsManager with one
function to notify when Kerberos accounts were added or removed. This
will be used to refresh the Kerberos Accounts UI.

Also removes dependencies on AccountManager since Kerberos accounts get
their own UI. The original plan was to put them into the Account Manager
UI.

BUG=chromium:952237
TEST=None.

Change-Id: If0d6941582cabdca6ec88b36c1b88f5d617ae568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588253
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657426}

Now that we've disabled the build warnings for unrar, I can remove the
patches and rollback the changes that existed solely to suppress those
warnings.

Since not every change to 5.6.8 was captured in a patch file, I created
a new patch file including all of the changes we made. There are no
longer that many changes, so I kept them all in one patch.

This CL will be the worst of the three when updating unrar. Luckily it
puts us in a much nicer state, where there are only 48 distinct changes
made to unrar src. Most of the changes to unrar source falls into one
of the following categories:

1. Removing the third_party_unrar namespace
2. Removing parentheses that weren't in the original 5.6.8
3. Removing curly braces around if statements that weren't in the
   original 5.6.8
4. Removing default behavior from non-exhaustive switch statement
5. Adding unused functions back in

The one meaningful change under unrar/src is the change to
unrar_wrapper.h. The forward-declared symbols are now in the top-level
namespace, rather than the third_party_unrar namespace, so I declare
them as such.

Bug: 936112
Change-Id: Icce266b0e685494cd425bb8c886c2f8f3b826d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592463
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657425}

This apparently saves about 90k of size, though it does potentially
make for larger differential updates.

Bug: 958522
Change-Id: Ibcf79739ff6d1cf734aa9649080f5be754d1200e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597126Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657424}

This new OOBE/Login page will handle custom setup needed for
supervised/child accounts. At the moment this version does nothing and
simply shows a placeholder screen. It will only be shown if the user
has the "EnableSupervisionOnboardingScreens" feature enabled.

Bug: 958995
Change-Id: I2ddec65ddd25d7850a04b166ba332a86e47688e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594112
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657423}

Change-Id: I4135a98530993749d653c23e26015096e8de0556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597963
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657422}