- 07 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcc417c0598c..7302723c092a Created with: gclient setdep -r src-internal@7302723c092a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iede51504e54dd95d922088d13e2663ad1ad5fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092981Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748015}
-
Ehimare Okoyomon authored
Add new string for incognito NTP toggle on desktop and android. Android: https://screenshot.googleplex.com/0jkU80X35Tn.png Desktop: https://screenshot.googleplex.com/UrfJiLVVfPt.png Bug: 1059186 Change-Id: I8d286725b3241ec41e374514de2294a49682675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089905 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#748014}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb391a519902..bcc417c0598c Created with: gclient setdep -r src-internal@bcc417c0598c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7c6440b3cc51cab163098de9726d7361b35ca8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092978Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/57d4742bbb10..ffd02955e668 git log 57d4742bbb10..ffd02955e668 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ffd02955e668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I76df5dabb59ba8bcc4f8690cf958860181907c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11f5795a70a2..eb391a519902 Created with: gclient setdep -r src-internal@eb391a519902 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7d78597eb62d01b222ca717c3fd10a75a56f2ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092975Reviewed-by:
-
Filip Gorski authored
Bug: 1054072 Change-Id: I5d549d6c9970bad857310b61c30b922ad5f1a5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087999 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#748010}
-
Andres Calderon Jaramillo authored
This CL fixes a GPU resource leak in the GLOutputSurfaceBufferQueue. Whenever we tell the BufferQueue to free all its buffers, GLOutputSurfaceBufferQueue should delete the corresponding textures and the stencil buffer. This was being done in the case of Reshape(), but not in the case of DidReceiveSwapBuffersAck() with a response of SWAP_NAK_RECREATE_BUFFERS. As a consequence, the underlying buffer was not being freed since there is reference counting in the SharedImage system. An example of this path happens in kukui when the screen is turned off and then on. If this is done many times, eventually too many buffers are allocated and leaked and we run out of memory. /sys/kernel/debug/dri/1/framebuffer Bug: b:149972616, 1054166 Test: turn screen on/off in kukui repeatedly and monitor Change-Id: Idfbd97a470951103e115cc3ecd9e3d2c4c05f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093021Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748009}
-
Rainhard Findling authored
* Splits safety check callbacks into 4 distinct events (one per child). * Aggregates all callback constants on top of safety_check_page.js. * Updates passwords and extensions callback to expect a UI string. Bug: 1032584 Change-Id: Ia10c4809da2331fbc648c628469797eff5dd0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080266 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748008}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64bb65eb045a..12ec6fce73b0 git log 64bb65eb045a..12ec6fce73b0 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@12ec6fce73b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3e9d5b5a6109a991fe75826aa6625add054723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092974Reviewed-by:
-
rajendrant authored
Adds to field trial testing config TBR=tbansal@chromium.org Change-Id: I895e38bdc966ad1dbceaf170861589a4c17f1301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090299Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#748006}
-
Sven Zheng authored
Currently the system make comments on changes which doesn't change pixel output. Bug: 1059469 Change-Id: Id8088fe9d63d1d92b52ed51b7e617db572d4ff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092554Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748005}
-
Jinsuk Kim authored
This CL removes OverlayPanel-related classes from Preview Tab implementation. - Some of the operations performed by OverlayPanelContent are now taken care of by EphemeralTab: - EphemeralTabCoordinator creates WebContents/ContentView. - WebContentsDelegateAndroid object is now created and passed to ThinWebView to have it populated when attaching WebContents. - OverlayPanelContent was listening to WebContentsObserver/ WebContentsDelegateAndroid and relays the calls to OverlayContentDelegate/OverlayContentProgressObserver. A new class EphemeralTabMediator takes over all this tasks. - Dependency on ChromeActivity was also removed. Bug: 998826 Change-Id: Idf166b67fa4b7ced94d2bc349d61f7751a49138a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082413 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#748004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83e394a59e78..11f5795a70a2 Created with: gclient setdep -r src-internal@11f5795a70a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I15de56796a88ee42d50d38cfff850d940e6d0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093118Reviewed-by:
-
Toby Huang authored
We want to track how many times custodians grant approval for child users to install extensions. This CL adds UMA histogram and user action metrics for child users using Chrome Web Store. Bug: 1022620 Change-Id: Ia89f38bde97723936fbe287751571dd0afe6351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904679 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748002}
-
Filip Gorski authored
Removes the knowledge of ActivityTabProvider class and ChromeActivity#getActivityTabProvider() from: * org.chromium.chrome.browser.toolbar.* * org.chromium.chorme.browser.omnibox.* Bug: 1054072 Change-Id: I362d425b2dd2927a00e0e28d6c641931ddf3f518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080089Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I760a86ee5aa29d3e5ea9fb20190a4890dca9f9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093134Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748000}
-
Sinan Sahin authored
Disable the test for Android L for now to avoid revert and reland of the previous CL as this test seems to fail on L only. TBR=twellington@chromium.org Bug: 1059421 Change-Id: I2533672b7d584db64af42a178b24df53b5e7ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092161 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97c0ebd7cc1e..64bb65eb045a git log 97c0ebd7cc1e..64bb65eb045a --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@64bb65eb045a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I88b22c15915156d74d6c3717c1d75430d3640169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093117Reviewed-by:
-
Mirko Bonadei authored
The usage of all_dependent_configs is considered a GN anti-pattern and it should be used only when the public_deps/deps/public_configs/configs system is not enough. There is no real reason to use all_dependent_configs in //third_party/googletest and since its usage has increased in crrev.com/c/2090420, this CL addresses the problems and removes its usage. Bug: 1059240 Change-Id: I4ff2bd0a19ad2ddd0b25866fcf738ab2d05a523b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091487 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747997}
-
Kyle Horimoto authored
This CL: (1) Adds a new os_settings_search_tag_strings.grdp file which contains search tags for this effort, and adds a few network-related search tags (see go/cros-settings-search for details). (2) Adds a SearchConcept struct and SearchResultIcon enum used to create metadata for a search result with potential alternate descriptions. (3) Creates an OsSettingsLocalizedStringsProvider class with a few Add*SearchTags() and Remove*SearchTags() functions for the tags added in step 1 above. Bug: 1059099 Change-Id: Ib5a126c3ff0ba16ffb734cb4cf0570500cec3b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086811 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#747996}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b32d49ba. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iebc2481d486645cdd42b642bf1347467f133683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093251Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747995}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c5c7ea9e66a..c5f5b9e95179 git log 0c5c7ea9e66a..c5f5b9e95179 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 jbudorick@chromium.org devil: don't retry system app modification on timeout. Created with: gclient setdep -r src/third_party/catapult@c5f5b9e95179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056214 Tbr: nuskos@google.com Change-Id: I45c2d156d59b32b01593a4a83ffcae2e9be7a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093113Reviewed-by:
-
Sophie Chang authored
Bug: 1050101 Change-Id: I3cb44dc5fd903b60a55a2850e43179ef78ff253d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090510 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b0124fec65c..cf573d844da6 git log 1b0124fec65c..cf573d844da6 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 chinmaygarde@google.com Prepare texture for cross context usage when using the Metal backend. Created with: gclient setdep -r src/third_party/skia@cf573d844da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I799eb9fef00100c1c9621ddb1fc3269645024a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093111Reviewed-by:
-
Marijn Kruisselbrink authored
When restoring a handle from IDB it won't be readable. If a website then requests write access we need to prompt for both at the same time. This CL implements this by removing a now invalid DCHECK in NativeFileSystemHandleBase and adding support to NativeFileSystemPermissionRequestManager to combine two requests into one prompt. Bug: 984769 Change-Id: Ib1574c8142943adc412e7310505b63fc061f4557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092189 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747991}
-
Ken Rockot authored
This introduces support for typemaps specified as GN targets, with new cpp_typemaps and blink_cpp_typemaps variables that mojom() targets can used to reference their typemap rules. The underlying work to use the typemap configuration is shared with the existing typemap infrastructure, but the net result is that we no longer need separate .typemap files or global "bindings configurations" once everything is converted to this approach. Bug: 1059389 Change-Id: Id2e5fe765d3c7600a3f50e337fb693f1b3a3cc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090716 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747990}
-
Ryan Hansberry authored
Bug: 953149 Change-Id: I9c06047e68b0dd2d4bd713dca0b6241d704e6847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089993 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#747989}
-
Noel Gordon authored
The asset is not used after CL:2093072. Tbr: alex Bug: 1035691 Change-Id: I719a15922acde88a4d0d4d1641e97d345dd7bc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093071Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747988}
-
Daniel Libby authored
This change adds a policy for ScrollToTextFragment, and plumbs a content switch down to blink, where it is used to override the state of blink::features::kTextFragmentAnchor. This policy is not marked as dynamic_refresh, since the values are set early on in renderer startup, with no ability to change dynamically. Bug: 1055513 Change-Id: I28aae1eb036e94d68974423c871b1d806275d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083383Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747987}
-
Avery Musbach authored
The argument to base::UserMetricsAction should always be a string literal. See the comment where base::UserMetricsAction is defined. Bug: 872319 Change-Id: I1b9de6000b06f51df5c429c3ceabf49607ef8a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092874Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#747986}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/727115e42480..83e394a59e78 Created with: gclient setdep -r src-internal@83e394a59e78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059158 Tbr: jbudorick@google.com Change-Id: I56b758926d24c7d7c3048075207eb5d34ebb6749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092714Reviewed-by:
-
Daniel Clark authored
This change moves the logic for handling highlight-on-hover for cells in date controls out of the JS and into :hover CSS rules. I'd originally planned for this work to wait until the old form controls implementation was removed. However, the highlight-managing code is setting ARIA attributes in a way that doesn't make sense now that the highlight positions no longer drive selection and are merely decorative. So as part of improving the screen reader experience for these controls it seems best to go ahead and do this work now. The highlight-managing code is now all effectively dead code when FormControlsRefresh is enabled that can be straightforwardly chopped out when the time comes to remove the old implementation. A follow-up change will ensure that the correct ARIA attributes are set for selection changes. Bug: 1046054, 1053798 Change-Id: Ie5081ef23b308a82bfc03887f96c912a82f411b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083866 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747984}
-
Ian Wells authored
Add StreamModelUpdateRequest and functions for converting wire protos into store protos Bug: 1044139 Change-Id: I243ebabc331884500dec480c69d843d38546a34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#747983}
-
Henrique Nakashima authored
CachedFeatureFlags should not have feature-specific code. Move the code in it related to Start Surface to a new class StartSurfaceConfiguration. Since many other packages check whether the start surface is enabled, the class is public. Bug: 1012975, 1058104 Change-Id: I3ee516ca4cab32f1b0f727192f0a32dfdbf3f050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070967Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747982}
-
Xinghui Lu authored
Based on the comment in https://crrev.com/c/2067462, to make the implementation of remote database manager and v4 local database manager consistent, remove the NOTREACHED() in the CancelCheck method. Bug: 1050859 Change-Id: I1bf9bbc5ec76864274085c57e3e4e98a8622bebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083569Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747981}
-
Chris Davis authored
This change removes a number of static initializers throughout the codebase. In most cases, code was moved to a function that returned a reference to a local static which is created on demand. I also made upstream changes to unrar, openvr and openxr which had static inits in their code which were appearing in chrome.dll. I am including the changes for unrar since that code doesn't get updated locally and the codebase had diverged with local changes. Bug: 341941 Change-Id: I3de5b282b0243dda86fa913f2677794373ae5c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088955Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747980}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ib823528514afe8743c6af5a055a8c7923e90ef95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089697Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747979}
-
Xianzhu Wang authored
The '_ms' postfix was redundant with the 'ms' unit of the measurement, and was inconsistent with other record_time measurements. This is a safe rename because the measurement is neither used nor monitored anywhere. Change-Id: Ibe8d72c41b6116213e0cddbd61085bd9e438474b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092672Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747978}
-
sauski authored
As part of the Friendly Settings Privacy settings redesign the "Do not track" toggle is being moved to the cookies page. To make moving cleaner this CL first creates a new custom polymer element and tests encompassing the toggle and the associated dialog. The new element is then placed in both locations in sections whose visibility is already controlled by the privacySettingsRedesign flag. Bug: 1032584 Change-Id: Id3190592989174fa7a0c51f7263844a1326e7ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092136Reviewed-by:
-
Philip Rogers authored
This reverts commit 3088046f. Reason for revert: Suspected as causing a ProxyCommit regression. Original change's description: > Skip commits for painted scrollbar thumb movement > > Painted scrollbars are used for overlay scrollbars on MacOS. Thumb > movement would cause a commit on every scroll change because the update > rect (set via Layer::SetNeedsDisplay) would change. This patch ignores > the update rect in PaintedScrollbarLayer::Update and uses part > invalidation for causing commits. With this change, scroll offset > changes do not cause commits. > > Bug: 1048384f > Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745544} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048384f, 1059436 Change-Id: I7e6e36fca7afecae35d969ca655965984a90e891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092185Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747976}
-
