GitLab

In order to support opaque ripples for cr-icon-button, the instances
that used the background-image CSS property to specify the icon were
changed to use --cr-icon-image. The reason is the mask-image property
is being used instead inside cr-icon-button to allow the icon color
to be easily changed as needed using CSS.

The colors that were specified in the original SVG files need to now
be specified in CSS using the --cr-icon-button-color CSS variable.

This does not work for the camera-shutter-icon and
videocan-shutter-icon which have two colors: one for the fill and one
for the stroke. The mask-image approach is not able to accommodate
more than one color. For this reason, the icons used in cr-camera
were changed to use iron-icon which is also support by
cr-icon-button.

In order to support icons that have different stroke and fill colors
the following CSS variables have been added. The *-focus-* variables
are for when the ripple is showing.

--cr-icon-button-fill-color
--cr-icon-button-focus-fill-color
--cr-icon-button-focus-stroke-color
--cr-icon-button-stroke-color

These new variables are to be used in place of the existing CSS
variables --cr-icon-button-color and --cr-icon-button-focus-color.

Bug: 1022752
Change-Id: I0a010e500186e029ca71445f200d4606312deb7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906962
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715060}

Change-Id: I11cef97eb166263b99b09e4fca09fcc1c34fb494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914965Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715059}

https://webrtc.googlesource.com/src.git/+log/06a394e036ab..60bd1aea3d6d

git log 06a394e036ab..60bd1aea3d6d --date=short --no-merges --format='%ad %ae %s'
2019-11-13 srte@webrtc.org Detach thread checker in RtcEventLogImpl destructor.
2019-11-13 peah@webrtc.org Correcting the ACM upmixing from mono/stereo to surround
2019-11-13 srte@webrtc.org Providing EmulatedRoute instances when creating TcpMessageRoute
2019-11-13 jakobi@webrtc.org Synchronize is_screencast_ state in AndroidVideoTrackSource.
2019-11-13 peah@webrtc.org Allow extracting the linear AEC output

Created with:
  gclient setdep -r src/third_party/webrtc@60bd1aea3d6d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:b/140823178
Change-Id: I2e16f71e06bec52c3c1cfd4fc6f91509582bf54e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715058}

SkiaOutputSurfaceImplOnGpu::RemoveRenderPassResource() assumes that
every RenderPassId exists in the |offscreen_surfaces_| map. If drawing
the RenderPass fails before SOSIOG::FinishPaintRenderPass() adds a map
entry, then the iterator in SOSIOG::RemoveRenderPassResource() will
point to offscreen_surfaces_.end(). Calling flat_map::erase() with the
end iterator is an error.

SkiaOutputSurfaceImpl::SubmitPaint() assumes that
SOSIOnGpu::FinishPaintRenderPass() will be successful. However if the
context is lost in FinishPaintRenderPass() it will return early and not
added a map entry. Both SkiaRenderer and SkiaOutputSurfaceImpl will
think there are RenderPass resources to delete leading to a potential
crash.

This is a speculative fix as I'm unable to reproduce it locally.

Bug: 1015613
Change-Id: Icd8f6922926892ccecb973041f5a626e75f78771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914298Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715057}

Share tab https://screenshot.googleplex.com/f3uD32mMtwU.png
Scan tab https://screenshot.googleplex.com/b8tCnu82tEu.png

Bug: 993920
Change-Id: I34c834e497e709fd12a300328b5d9bc5ea54907a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906877Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715056}

This has the changes needed to preserve focus.
This change adds both v2 and v3 tests to validate the patch.

Bug: 1020664
Change-Id: I7b4f62f14d6aa8a370b4ebb7c30494eacb48fd74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893547
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715055}

See attached issue. Accessibility users can now tab through the
dialog, getting specific information (such as permissions), with the
screen reader reading each element.

A new subclass of Label has been created to ensure that non-
accessible users can get visual feedback if they use TAB to traverse
the dialog, since normal labels do not paint a text focus ring when
focused.

Future work:
 - Eliminate AppInfoPanel::CreateKeyValueField()
 - Merge AppInfoLabel functionality into views::Label

Bug: 996764
Change-Id: I97655c925c02b7d0b943f7fbb916ec1a87eed175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910871Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715054}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b6857b74..4636c1f0

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I54437f71c6192a7bf34607c5769d02b2d2dff830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914659Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715053}

The BrowserActionApitest.CloseBackgroundPage was disabled in 2011
due to crashing on ASAN builds. I tested this for both regular
Chrome on Linux and ChromeOS builds and it didn't crash after 500
runs.

Bug: 98861
Change-Id: I3c896a4b6231b79fdc47d3be0c3ef3dca7683d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914605Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715052}

https://skia.googlesource.com/skia.git/+log/ae01f620091b..4f32a29a69b4

git log ae01f620091b..4f32a29a69b4 --date=short --no-merges --format='%ad %ae %s'
2019-11-13 nigeltao@google.com Move SkWuffsCodec's reset_and_decode_image_config

Created with:
  gclient setdep -r src/third_party/skia@4f32a29a69b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@google.com

Bug: None
Change-Id: I29a43a1daa15f7a418f192a0cb06c31c52f62a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914699Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715051}

The API returns the extension status for installation. It returns a value
based on an extension's install state, policy setting and request status.
This API will be used by CWS extension detail page.

Bug: 1006899, 995385
Change-Id: Icedc653829e255cf56d8c84c86fcd169fc4674e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885450
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715050}

Previously for a cc::Layer to have debug info (e.g. layer name, and
information for tracing, inspection, etc.), we needed to create an
instance of LayerClient implementation for the layer, and the layer
pulled debug info from the client during frame update.

Now change the pull model to push model to simplify clients, and
remove cc::LayerClient.

This fixes the issue in CompositeAfterPaint that foreign layers lack
layer names.

Change-Id: I06bbe689c8c9ee56be3c8dea8eb6b480faadc5d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906895
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715049}

It's possible for NormalizeTextRange to return an inverted range
when both endpoints are anchored within the same ignored subtree.

Expanding the range endpoints to their equivalent unignored text
position before calling "AsLeafTextPosition{Before|After}Character"
fixes the issue where the range becomes inverted.

This fixes another corner case related to :
https://crrev.com/c/1879778

Bug: 1021443
Change-Id: Ifeb178c5b3c2fdf68c925ea3def523f0ddc1b059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902255
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#715048}

This CL fixes the problem that Chrome settings page won't refresh
itself after exiting from a Incognito window and saving a new address.

The root reason requires more investigation but this CL will fix the
RB bug. SaveCardBubbleControllerImpl does not need to be created again
(even though creating a new controller should not hurt)
since if there is no controller then the promo is not visible.

Bug: 1016669, 932818, 1024041
Change-Id: I7a8c3dc144ddb1b6b11672efe8e1dfd6b9a15b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898717Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715047}

Updates EndOverview logic to mark session as shutting down sooner -
before any windows are minimized, or observers are notified the session
start was canceled, to prevent reentry in EndOverview() - in particular
to prevent reentry due to active window change while minimizing windows
while exiting to home screen (fade out, slide out exit types).

This also makes OverviewItem::SetBounds() triggered by minimization
exit early (instead of updating grid item widget bounds just before
the overview session exits) - the cl updates
OverviewSessionWithDragFromShelfFeatureTest.FadeOutExit expectations
to address this change in behavior. The test now tests that grid
item widget bounds remain the same during exit directly (instead of
checking for identity transform).

BUG=1024107

Change-Id: If0f301bccc41de7f33b30a6017e508c97767ced1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913508Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715046}

- If the card will be uploaded the Modal with the ToS needs is shown
before.
- Creates SaveCardModalDelegate that its used by the Modal to Save the
Card.
- Adds a currentCardSaved property to the ModalVC in order to disable
the SaveButton if the card has been already saved.


Bug: 1014652
Change-Id: I3dadaf24b307c8ffe3b68d499e9ef3840c299623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913023
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715045}

Moved from manual deps into //third_party/android_deps:
* Guava-jre
* AutoService
* ErrorProne

It looks like this CL adds other libraries, but they are just those
that already existed within errorprone-ant.jar.

This updates how ErrorProne is invoked to the JDK9+ method of being a
proper javac plugin. This move necessitated moving the above libraries
into android_deps, because the version of Guava that was already in
android_deps was conflicting with our non-android_deps one.

Change-Id: Iaa0f927263baaec8180808769f97db9c5393ad18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885951
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715044}

Bug: 1023533
Change-Id: I3c2165499bda87ae070982402ec5b5db02d2a776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913077Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715043}

This method is for deserializing paint ops from binary data, and append
paint ops to the PaintOpBuffer. It can be used for reusing
PaintOpBuffer to avoid re-allocating PaintOpBuffers.

It will be useful for multithread chrome GPU experimental. It needs to
deserialize paint ops from command buffer, and store it in shared image.
This change allows reusing existing PaintOpBuffer.

Bug: None
Change-Id: I2f86b6c62f454495e591bbd841b8aa7156780e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906938Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715042}

This change addresses two rendering issues:
1) The rounded corner changes dynamically when the value is close to 0.
The fix is to re-implement the value track using a rectangle plus clipping
(same approach as <progress>).
2) The thumb doesn't completely cover the track when the value is 0 or maximum.
The fix is to shrink the background track by 1px on both ends

Note the thumbs is also changed to solid color per design
and kProgressValue/kSlider/kDisabledSlider/kHoveredSlider are introduced
for different color designs between upstream and downstream.

Test: range-appearance-basic.html (3 new test cases for extreme values)

Bug: 1021232
Change-Id: Id9a5df157e42335f7afafa75376a461b85abc7ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911663
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715041}

This change introduces DialogDelegate::set_buttons as a replacement for
overriding DialogDelegate::GetDialogButtons(), and changes all the trivial
overrides to use the new setter instead. Future CLs will remove all the other
overrides and eventually remove the original method.

Bug: 1011446
Change-Id: I0735a217f581edfb25ddc4a118ebffe5d24e900e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912801Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715040}

Previously, ReportUploader is designed for reporting
ChromeDesktopReportRequest on Windows, Mac and Linux. To supporting
Chrome OS, now we change this class a little bit to reuse its logic.

Bug: 1010213
Change-Id: I724d203534ec1a831700842181aec4f1121b6d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908542Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#715039}

This will make the paint chunk id more meaningful and stable.

Change-Id: I5aaacc183c2c359fcfe8b44e3ac17c1a00f9d4da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912637
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715038}

Use mixer service for everything. Optionally move the mixer to a
separate process.

Bug: internal b/138938216
Change-Id: Ica1bd713babeda31ba267b657fc86ffc720ea651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895702Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715037}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I04573cf4f3a953a604225c715a1da356befd9887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913036Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715036}

CI builders:
- fuchsia-x64-dbg
- linux-archive-dbg
- linux-archive-rel
- linux-bfcache-debug
- linux-fieldtrial-rel
- linux-oor-cors-rel

Try builders:
- dawn-linux-x64-deps-rel
- fuchsia-angle-rel
- fuchsia-compile-x64-dbg
- fuchsia-x64-dbg
- gpu-fyi-try-linux-intel-rel
- linux_android_dbg_ng
- linux_angle_deqp_rel_ng
- linux_angle_ozone_rel_ng
- linux_chromium_compile_dbg_ng
- linux_layout_tests_composite_after_paint
- linux_layout_tests_layout_ng_disabled
- linux_optional_gpu_tests_rel
- linux-angle-rel
- linux-blink-rel
- linux-libfuzzer-asan-rel

Schedule of migration:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: I17a32e57cd786d205f0f84bf36bd31974d723742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875858
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715035}

This reverts commit fdda085d.

Reason for revert: Reland with fixing.

Original change's description:
> Revert "Add vulkan information in about::gpu page"
> 
> This reverts commit 2ef6fce8.
> 
> Reason for revert: This CL broke GPU FYI Win x64 DX12 Vulkan Builder (dbg)
> 
> https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20DX12%20Vulkan%20Builder%20%28dbg%29
> 
> lld-link: error: obj/gpu/vulkan/vulkan/vulkan_instance.obj: locally defined symbol imported: public: __cdecl gpu::VulkanInfo::VulkanInfo(void) (defined in obj/gpu/config/vulkan_info/vulkan_info.obj) [LNK4217]
> 
> 
> Original change's description:
> > Add vulkan information in about::gpu page
> > 
> > This CL adds VulkanInfo in GPUInfo, and then send it to browser
> > process with GPUInfo. And it will be serialized to binary data and pass
> > to about:gpu page for displaying.
> > 
> > This CL adds a vulkan_types.mojom generated from vulkan header file.
> > The structs in that files have many fields. It increases binary size.
> > The increasing is expected.
> > 
> > Bug: 887018
> > Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f
> > Binary-Size: Size increase is unavoidable (see above)
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Reviewed-by: Tom Sepez <tsepez@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: Jonathan Backer <backer@chromium.org>
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#714424}
> 
> TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org
> 
> Change-Id: I3b0aff2cfcfa8b65df2ca9109325451567cf8039
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 887018
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913565
> Reviewed-by: Chris Blume <cblume@chromium.org>
> Commit-Queue: Chris Blume <cblume@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714714}

TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org,cblume@chromium.org

Change-Id: I2061c0a8508be602777467b7ae16cb51827bf5f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914294Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715034}

This change moves the TransactionalLevelDB system into the Storage
Service directory.

Bug: 1015212
Change-Id: I4851810fc3d5bf031a97eacd935ad6394a9a49b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900154
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#715033}

Bug: 1003612
Change-Id: Idae4e5c015df0d9ee09129f26c8679892e42955e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913603
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715032}

This change adds a new file "Last Path" to the user-data directory
containing the path of the last chrome.exe that ran using it. The
implementation mimics the "Last Version" file implementation, so the
last-run chrome.exe path is updated each time chrome.exe is launched.

This will be used by Progressive Web Apps, whose launcher executables
will be located inside the user-data directory, to find the correct
chrome.exe to launch.


Bug: 960245
Change-Id: I0ec658d414dd1a67f03f7d02e645f21f03191360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891121Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#715031}

Bug: none
Test: build & run
Change-Id: If79049c13291f1ebfcd627c690dd1e33ee9a94ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903622
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Auto-Submit: Michael Montvelishsky <mont@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715030}

Bug: 1015194
Change-Id: I71947da1d8f77365244496754518d1d722c234d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912802
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715029}

The way post-doom operations worked --- including completion of an optimistic
create --- is by appending a callback to a table in the backend, to be invoked
upon the doom's completion.  This living in the backend meant that if the backend
went away the operation would be quietly cancelled with no callback invocations,
which is generally what is desired for backend operations... but in case of
optimistic create, we have already returned an entry pointer, and entry operations
do not get cancelled (and the entry is also expecting a callback to exit the
IO pending state).

Therefore, extract the table into a separate object with a refcount which entries
can hang on to for a bit after backend destruction. This required making cancellation
of ops that needed it be done explicitly. It also turned out this was not actually
covered by tests, so a test was added for that as well.

Bug: 1015774, 1016140, 1016251
Change-Id: Ib2bf64ead3b581795ba75b4d3c866f6f567a1a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888272
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715028}

Change-Id: I0ca748b3e9e0db012057f690ae676f6c5f5cfbb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913711Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715027}

Add "UploadZippedSystemLogs" feature to the config.

Bug: 940648
Change-Id: I2a1277eb37fbc8d6da20861a1adf1933f0e03d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914365
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715026}

Previous to this, a page would have to be unoccluded and visible in
order to create a new renderer, though the presence of a video capturer
would prevent the page from being unloaded.

This allows hover cards and the new touch tabstrip to cause tabs restored
when the browser reloads to render. Previously, some tabs would never
render until the user actually selected them.

Failure to generate thumbnails after browser restore was one of the
biggest complaints about hover cards in the user study that was done
earlier this year.

Bug: 1020782
Change-Id: I06a23c39ade22e15bef60798faca9fd4cdae53ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908060Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715025}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57d0093ac901..1ba6deba4dfb


Created with:
  gclient setdep -r src-internal@1ba6deba4dfb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: If0102945a9e35042d54fb0cf059918e5433143b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914602Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715024}

Float fragmentation currently doesn't work if the float is "inside" a
line. But three existing (but disabled) tests actually had no lines, so
they already behaved correctly. The expectation, however, was that we
created a dummy line beside the floats (which we did, back in the days),
but this is no longer the case, so I just removed that.

Bug: 915929
Change-Id: I6b5d04c044860d1225b155fc9c7e70512602b398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913254Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715023}

Wire NetworkIsolationKey through ProxyResolver API and all
implementations. Also wire it through the Proxy Resolver Service API.

net/ isn't yet passing a NetworkIsolationKey() to the ProxyResolver API,
so this shouldn't affect behavior yet.

Bug: 1021661
Change-Id: Ia9dab8ac7b5062ea85435022e85d1f1720c7da76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906247
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715022}

When the tear-down process of BaseAudioContext occurs rapidly along with
the destruction of an associated ExecutionContext, a scheduled task from
the audio rendering thread can attempt to access `this` pointer of
BaseAudioContext.

This CL add a check to verify the validity of an ExecutionContext before
the function accesses the `this` pointer for the audio graph lock.

Test: Ran the repro case locally with this patch for 20 minutes and no UAP occurred.
Bug: 1023810
Change-Id: I8e5b960b50aca5b0dcee52b5886804af2515806e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913872Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715021}