- 19 Aug, 2020 40 commits
-
-
Lukasz Anforowicz authored
The CL tweaks 1 remaining test that relied on the legacy/deprecated behavior that allowed CORS-exempt cross-origin requests from content scripts. The CL changes the test request to same-origin. This change should be okay - the cross-origin aspect of the request was not essential to the test, which mostly wanted to verify that the XHR results in the "blinkRequestResource XMLHttpRequest" |domExpectedActivity|. Bug: 920638 Change-Id: I9d9f765b91c7524586ac1b3280ba063274dba0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359392Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#799677}
-
Friedrich Horschig authored
This CL ensures that credentials who are compromised in two ways display both reasons in the list. Translation screenshot for https://storage.cloud.google.com/chromium-translation-screenshots/cf6c7eaf298250e9e14f7c244dacb7e11f07dd47 Bug: 1117489, 1092444 Change-Id: I214e5e2211d1732cb5fa745a582cc64a37890293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362616 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#799676}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5e15fd87. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7129bd03c2e980e29ffe30e08aa7d893f6fca437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362633Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799675}
-
Mark Mentovai authored
Change-Id: Id0c9619dc31cd2e2bcb510d03baebe6f27e6c03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364013 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799674}
-
Xianzhu Wang authored
This improves performance of RasterInvalidator when some paint chunks are moved from cached subsequences. No functional behavior change. Change-Id: I8cc492200c033ee2759c63f908571722c0a09df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363649Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799673}
-
Morten Stenshorne authored
Line and block fragmentation should cause leading / trailing borders to be painted only in the first / last fragments, as long as 'box-decoration-break' is 'slice' (i.e. the initial value). This hasn't been implemented for NG block fragmentation yet (only line fragmentation), but this CL will make that job easier. There were a bunch of methods and classes on the painting side that took two bool flags, typically named include_logical_left_edge and include_logical_right_edge. Rather than adding another two for "logical top" and "logical bottom", use a struct for all four sides. Also, use physical values, rather than logical ones. It made marginally more sense to use logical values in the legacy engine, but with NG it makes no sense at all. They are stored as physical values in NGPhysicalBoxFragment, and all painting cares about is physical coordinates. Not having to convert them to logical and back to physical makes things simpler (note, however, that on the legacy inline side, they are actually stored as logical values in the InlineBox tree, but we're not optimizing for that case, and adding a converter is easy enough). Remove NGBorderEdges (which dealt with logical sides, with converters to and from physical sides), and replaced it with LogicalBoxSide, and use it mainly on the layout side. Add PhysicalBoxSide, which is what we'll use on the painting side. Went for "side" rather than "edge", since there's already an existing class named BorderEdge, and, according to https://www.w3.org/TR/CSS22/box.html , "side" is a more suitable name than "edge". The writing-mode converter in PhysicalBoxSide is based on what we had in NGBorderEdges. There are some problems here, but currently they aren't exposable, since we haven't implemented border handling for NG block fragmentation yet. Added a TODO. Also remove border inclusion logic from FloatRoundedRect, and let RoundedBorderGeometry deal with it instead. No behavior changes intended. Note that AdjustOutsetsForEdgeInclusion() had a bug, where we converted directly from logical left/rigtht to physical left/right (which was hard for me not to fix). This code has no test coverage, though. But I think it will be needed by block fragmentation. Change-Id: If427f202e49cfcf21234170fdd6b10e3e7c8eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362908Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Orin Jaworski authored
This CL resolves the occasional case of disappearing Pedals. If a pedal is attached to a match that then becomes a duplicate, the remaining surface match will not have a pedal because only one is allowed in the whole set. In such cases, moving the pedal from the duplicate to the main surface match will preserve the pedal for presentation. Bug: 1118126 Change-Id: Ie25d6634f4face69e102521510d983ea5a723b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363872 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799671}
-
Charlie Hu authored
Bug: 1113375 Change-Id: I140619605e1262bf2f9a3b23972a932da84b4fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333498Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#799670}
-
Nate Fischer authored
No change to logic. This adds a histogram for the flag UI's new search bar, to determine if the search bar was used each time a user toggles a flag. Fixed: 1114247 Test: manually verify we log the correct value Change-Id: I57ce73641146b95ce31e44497f561c9a7aca852f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364003Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Gavin Williams authored
These boolean histograms capture the printer status of the selected printer and whether the user chose to print or cancel in Print Preview on Chrome OS. This set of histogram is useful for understanding how the new Printer Availability icons change users' behavior and confidence when it comes to printing on Chrome OS. Bug: 1059607 Change-Id: Ib69b4679d23695c420307e007d468f25c0b4a5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361024Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
Bug: None Change-Id: I310776c953be841c1aa48f25e48704f21ed74ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363657Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799667}
-
Yao Xiao authored
Use a cached swaa/nac/account_type status to avoid querying the server too often. This is to prepare for an upcoming CL that computes the floc (which will go through all the checks) on history-deletion. Bug: 1062736 Change-Id: I6d48e102f664c3dd1e673f63f5afaf4d7eadef05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363006 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799666}
-
OlivierLi authored
The IO thread param was used twice instead of the UI thread one. Bug: 1034046 Change-Id: I06abd5f50760cd5b02ac53125a5f35b722ce2a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363805 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#799665}
-
Lukasz Anforowicz authored
This CL removes all studies in fieldtrial_testing_config.json where neither the study name nor any of enabled or disabled feature names appear as a string literal elsewhere in the codebase. This CL has been generated semi-automatically: 1. Download cleanup.py attached to https://crbug.com/1053702#c3 2. Generate cleaned-up list of studies: $ python3 ~/Downloads/cleanup.py \ testing/variations/fieldtrial_testing_config.json \ ~/scratch/out.txt 3. Copy the output: $ cp ~/scratch/out.txt \ testing/variations/fieldtrial_testing_config.json 4. Format the output: $ python testing/variations/PRESUBMIT.py \ testing/variations/fieldtrial_testing_config.json Bug: 1053702 Change-Id: If7a17f06786bfa8dbda312401d291bf120251aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363717 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I11ca61ff56f98115ba70cdc0445876af6bb7d529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799663}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6177a5ec5b8b..9c907b44dac7 2020-08-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12f74d97f2302cc89626310ad8665fd704b606fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363377Reviewed-by:
-
Luke Zielinski authored
This also includes a generated set of metadata for the payments API. Bug: 1116091 Change-Id: Ie73e27eb79c3dbd7b9512418f2f3661ae5fe73dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327138 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799661}
-
Patrick Brosset authored
Right now, the grid overlay does not support vertical writing modes. The grid information collected by the backend (track and gap breadth, etc.) is collected "logically", as if the grid was in its default horizontal-tb mode. The approach here is to add the writing-mode value to the grid info object sent to the grid overlay frontend so it can apply the right transformation, as a whole, to the overlay. I decided not to convert coordinates on the backend as I thought the code would become quickly difficult to read and maintain as opposed to applying a transform on the frontend canvas which would achieve the same thing. In both cases anyway, displaying grid labels so they point to the right place has to be done on the frontend, so doing the writing-mode transformation on the front-end means we do everything there, making it easier to follow. Corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364455/ Bug: 1096971 Change-Id: I27fc7b24d73581439cd1fb9c5dd6e4c19d4846d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363050 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799660}
-
Nohemi Fernandez authored
Migrates MDCSnackbarManager dismissAndCallCompletionBlocksWithCategory to MDCSnackbarManager.defaultManager. TBR=yuweih@chromium.org Bug: 1117399 Change-Id: Iabfebf3086e2909a0dee1a4aedc47d8b19d2956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363758 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799659}
-
Oleh Lamzin authored
NOTREACHED() after switch across all union variants does not really make sense. For example if cros_healthd will have more variants for some union and Chrome Mojo interface copy will be outdated (i.e. without union changes), then Mojo library will crash and our converter method will not be called. So there is no way for us to handle out-of-band values for Mojo unions. Bug: b:158658869 Change-Id: Id72fff0ffe847408153ad2ecd8596ea8d2e89c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364495Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#799658}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bcdfc8975ea2..7ad1011a1965 2020-08-19 zhaoliang.ma@intel.com Support AVX2/FMA intrinsics in audio FIR filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f62bf45a9dcf4d5a4f02af646957a3896ae3df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364573Reviewed-by:
-
Mitsuru Oshima authored
There are multiple classes with this name for the same purpose. I'll consolidate them into single class in a separate CL later. Bug: None AX-Relnotes: n/a. Change-Id: I5c1ab39f4e3559a2e2fe9f4cd3f6f47c397860f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363880Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799656}
-
Roberto Moura authored
Addition of the thumb strip coordinator, pan gesture handler and animatee classes. The handler handles user pan gestures that reveal/hide the thumb strip and calls methods on other UI elements to be animated during thumb strip transitions. The view revealing animatee is a protocol to be implemented by UI objects that are animated in these transitions. Bug: 1094335 Change-Id: Iad91af43ea4956b47f6784ea138fe4d81a482489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313877Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#799655}
-
Oleh Lamzin authored
Change-Id: I063b84bbe05c7b31f566b90776e8a14a3711d0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362798Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0795384a7997..72e31331da03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6ebdf496191b1a9c016ba708342f7a69cffedeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362978Reviewed-by:
-
Friedrich Horschig authored
Change the entry title according to mocks. Translation screenshot for IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_REMOVE_BUTTON_CAPTION: https://storage.cloud.google.com/chromium-translation-screenshots/4498e485f2a7952b74d25537b1578da091430bbb Bug: 1106726, 1092444 Change-Id: Ic902a2f7f5a6bb6eada949beed220a7155b6cf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362935Reviewed-by:
-
Robert Sesek authored
The build system has not put files there in more than a year. Change-Id: Id2d1b95d05a67bd361dd58b26923fe5b0b0a024a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364011Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/356838b9f8c0..4a56f4c29ec5 2020-08-19 mtklein@google.com densify dump_record If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I0162cc6f54d27d7ffaa3c494bb98557ae64eeacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363381Reviewed-by:
-
Reda Tawfik authored
This Cl adds the controller and the model for AllPasswordsBottomSheet and sends the credentials from the bridge to the coordinator to the mediator. Adds a unit test for the controller. Bug: 1104132 Change-Id: I5a56ea9d3095cad29fed19a058805ed0121be47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317797 Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799649}
-
Xianzhu Wang authored
Only convert paint chunks if the layer bounds changed, we have invalidated raster or we are checking raster under-invalidation. Otherwise just keep the existing cc::DisplayItemList. Change-Id: I9ee584344ede6df8fb88af64b4347460389142e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363643Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799648}
-
Xianzhu Wang authored
This reverts commit 3fbd23bf. Reason for revert: Revert the temporary CL after several canary builds. Original change's description: > Temporarily disable text-on-opaque optimization > > This is to evaluate the performance improvement of the optimization in > 1 or 2 canary builds. Will revert after that. > > This disables the optimization for composited scrolling added in > crrev.com/771292 (based on the LCD-text on opaque optimization added > in crrev.com/768555). > > Bug: 1113269 > Change-Id: I20250169241d8f6d99e9bd917974aaf3fd0f675a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351400 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797498} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1113269 Change-Id: I113d4b8b995796ccd105d61a252743bf0239f2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363651Reviewed-by:
-
Raymond Toy authored
In ProcessARateVectorKernel we forgot to mask v_read0 to contain the index in a valid range. v_read1 was handled correctly, and ProcessKRateVector also masked the indices. Apply the mask. Manually tested this agains the repro case from the bug and no issues occur. Previously, I could easily reproduce the issue. Added simple test case where detune overflows. Output should be zero. Bug: 1115907 Change-Id: Id7af713b935bd7cc14669630ddb1d04c3b1b2c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358593 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90094abdc0a..69cb5514ee4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com,dullweber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:10918587 Tbr: mcnee@google.com,dullweber@google.com Change-Id: I7f08cbdc5bbd5813861db85184a2fa506a7e6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799645}
-
Thiabaud Engelbrecht authored
This is a reland of 3558d80a, initially reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/2321400, and reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/2360121 The reverted commit was not responsible for the failure and is safe to reland, since the build was already passing by the time it was reverted. (see my comment below for details) Bug: 1109209 Change-Id: I2df2de93ca97e43044ecf27c40793274c07d9685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363396Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#799644}
-
Sebastien Marchand authored
Bug: 1111437 Change-Id: I20ed7be5fa1b15214b7db7f37527e54cbe101be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353492Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
BUG=None Change-Id: I9452e29c5e9c7a70a5e64cd8cbfecffa3c834bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364074Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799642}
-
Andreea Costinas authored
Currently, if System-proxy requires credentials to authenticate to a remote proxy, it will send a request to the Browser to fetch credentials from the Network Service authentication cache. If the user didn't authenticate in the Browser yet, System-proxy will receive empty credentials. This CL changes the flow to notify the user that System-proxy requires credentials and allows the user to enter the credentials in a dedicated dialogue, without needing to go through the Browser. Bug: 1112722 Test: unittests, manually on DUT Change-Id: I0bb1e0e2d0a644b47dd022a87664cab1bb4e5205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356204Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#799641}
-
Nick Diego Yamane authored
Fast resize mode is set for web contents view every time tab dragging status changes for both window source and dragged browser window. Which was originally introduced as a performance optimization targeting ChromeOS' tablet mode, where both windows bounds change during the dragging session. This causes issues such as crbug.com/1114767, where the source window does not get correctly relaid out after a tab is dragged out of it into a new browser window, particularly when that tab dragging session started after a window resize or state change (eg: normal -> maximized). That said, this patch fixes it by not setting "fast resize" on Linux desktop builds. Where subtle bugs may happen, eg: tiling WMs not honoring bounds requested, etc. R=sky@chromium.org Bug: 1114767 Change-Id: Ic33fd2471fe6ddbb05af650e724106c6600319d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346795Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#799640}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I47aa52dc235f4f9f0cc63ecf32b4f3cb14fb1f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363756 Commit-Queue: Yunke Zhou <yunkez@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799639}
-
Andrei-Laurențiu Olteanu authored
Convert string from mojo handle. Create build target for mojo_utils. Change tests. Bug: b:162051831 Change-Id: I60017604fde2c55ca34165af3c5d10e16760ee8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352908Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#799638}
-
