- 03 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1a0ada7d208..6dc622fec32c Created with: gclient setdep -r src-internal@6dc622fec32c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6edf534955d05e79b04d0372b40407ae5a7f564b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035602Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737765}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09a9f1ba72d5..c809e8bd6289 git log 09a9f1ba72d5..c809e8bd6289 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 eshr@google.com Move quality scaling frame drop logic to adaptation module 2020-02-03 danilchap@webrtc.org in RtpFrameReferenceFinder VP9 case validate number of references in gof Created with: gclient setdep -r src/third_party/webrtc@c809e8bd6289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048013 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I15d3479007c1bf9802badde5123d0349b8879f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035603Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737764}
-
Finnur Thorarinsson authored
FindInPageControllerTest.FindMovesOnTabClose_Issue1343052 FindInPageControllerTest.FindMovesWhenObscuring This CL effectively reverts two CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2031539 https://chromium-review.googlesource.com/c/chromium/src/+/2028737 If the test fails as a result of this CL then the view.cc changes are not to blame for and this CL should be reverted. TBR: kylixrd Bug: 1041614, 1047427 Change-Id: I66191af28e988ded2a304fa14e2254c1248257be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035372Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#737763}
-
Matt Falkenhagen authored
"Mojo Linux" was really about running browser tests with the Network Service in different configurations: in-process and web request proxy. We don't want these to regress and have been watching the FYI bot, but this isn't sustainable. We considered putting the tests on the CQ but these tests are expensive so it would significantly increase CQ time. Move the tests to a new waterfall bot. This is step 2) and 3) from comment #5 on the bug: 2) Add an entry for the new builder to mb_config.pyl and to various files in buildbot/ 3) Add an entry for the new builder to ci.star (Doing both steps in the same CL seemed needed to pass presubmit.) Bug: 1040384 Change-Id: Ic77927dcca52a556729e1d6b1174fc87c77ed656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029395Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737762}
-
Jan Krcal authored
This reverts commit 7231941c. Reason for revert: It is indeed flaky, this provided some insights, reverting. Original change's description: > [User events] Re-enable a previously flaky test > > This CL re-enables a previously flaky test. If still flaky, the goal is > to gather failure logs to understand the root cause (logging has > improved substantially since this test got disabled). > > Bug: 1006155 > Change-Id: I384bbb3cf83068a6d1297592b9400a8ffe23ff73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031035 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737266} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006155 Change-Id: Ib59c61ffd0feae55d6db156e79c06f283c4ca41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035413Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737761}
-
Marc Treib authored
TBR=lukasza@chromium.org Bug: 1048148 Change-Id: I7393ce564ea09535810cf2b77c7854b05af1e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033770Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737760}
-
Marc Treib authored
This reverts commit a05d328d. Reason for revert: Flakiness should have been fixed by https://crrev.com/c/2035374 Original change's description: > Disable flaky AccessibilityActionBrowserTest.ImgElementGetImage on Mac > > TBR=yaoxia@chromium.org > > Bug: 1047921 > Change-Id: I5883ab91335fb7faa0a7ee45d93b5535b2cca794 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033513 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737708} TBR=treib@chromium.org,yaoxia@chromium.org Change-Id: Iafb9d0713816f66bb6f73ad20521b642dab7df97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033451Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb77d7d5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia596759a815b38ab80af5fdc6752035122673157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032308Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737758}
-
Greg Thompson authored
This CL introduces a new model for the state of the build and controllers to drive it for desktop Chrome and Chrome OS. In its introduction here, the model holds whether or not an update is available, its version, the "critical" version (if set), and whether or not the new version is a rollback. This CL does not activate the new model or controllers in the browser. A subsequent CL will give the browser a process-wide BuildState instance, a single controller to update the BuildState when an update is available, and make UpgradeDetector an observer of the process's BuildState. BUG=1043624 Change-Id: I50be6b313ee152f2351e823fbd8637aac0c5c52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017520 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737757}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b9bdb1d..352de2b8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f6ffd28c0f213cdb7cd3ae6acf51e0a7c3eac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035690Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6b755afe678..674dea0bd489 git log b6b755afe678..674dea0bd489 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-03 yangguo@chromium.org Fix NodeURL test on Windows 2020-02-03 tvanderlippe@chromium.org Migrate js_main/ to import cross-module 2020-02-03 tvanderlippe@chromium.org Migrate inspector_main/ to import cross-module 2020-02-03 bmeurer@chromium.org Move .editorconfig file to top level. Created with: gclient setdep -r src/third_party/devtools-frontend/src@674dea0bd489 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36f105d95be42ca3c84287b45d10daf55c7abe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035600Reviewed-by:
-
Marc Treib authored
This reverts commit 53b4c802. Reason for revert: Suspected of breaking various accessibility browser tests, see linked bugs. Manual changes to the revert: *Not* reverting web_feature.mojom or enums.xml (which are harmless but conflict-ey). Original change's description: > Implement overlay-interstitial-ad detection > > Why: We’d like to learn where and how often they are used. > > How: In LocalFrameView::RunIntersectionObserverSteps, fire a hit test > event in the center of the main frame with a 1 second interval. We check > the style of the returned element and its container elements, to see > whether it is immobile to scrolling and if it can overlay with other > contents in the page. > > Bug: 1032681 > Change-Id: I18acd22a7972a1e4ca361a7c466aa20705844dbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993140 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737529} TBR=szager@chromium.org,bmcquade@chromium.org,ikilpatrick@chromium.org,yaoxia@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032681, 1048137, 1047921 Change-Id: I3db5bb7ebf146e35b90e2cfff203337f82567435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035374 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I198903c06bc630bbcf6f9c2586cb060c3bc340f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033985Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737753}
-
Luca Hunkeler authored
In a follow-up cl a new section will be added that requires storing types other than strings. In this cl we change strings into ValueProto to accommodate that. Other minor modifications: -Collect user data will now only return additional values that were set by the action itself. -Keys with empty strings will also be added to the additional values (they were ignored before) Change-Id: I379c1061f7381dc75b68650602583e75ec5db7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027550 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737752}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f3c7e4750501..1ccc65258d95 git log f3c7e4750501..1ccc65258d95 --date=short --first-parent --format='%ad %ae %s' 2020-02-02 jophba@chromium.org Add notes/warning to README.md 2020-01-31 rwkeane@google.com mDNS: Add support for publishing multiple PTR records Created with: gclient setdep -r src/third_party/openscreen/src@1ccc65258d95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic1bcb6674918b83029306bd619b188f128c67c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035597Reviewed-by:
-
Henrique Ferreiro authored
Use pointers instead of references for blink::WebCursorInfo output parameters, as recommended by the Google C++ style guide: https://google.github.io/styleguide/cppguide.html#Reference_Arguments. Bug: 1040499 Change-Id: I32a38b71c5bffaa9b76cb91a67df57ff20c71edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035411Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#737750}
-
Markus Handell authored
This change updates the OnVideoFrame and OnEncodedVideoFrame mock methods to provide the received timestamp. Bug: 1048140 Change-Id: I89c4090050b59b03c57d9062d949bc34cc3351ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034522 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737749}
-
Simon Zünd authored
This reverts commit 459e299a. Reason for revert: Still causes test to become flaky on debug builds: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger%2Fsource-frame-breakpoint-decorations.js Original change's description: > Prepare breakpoint web tests for source map asyncification (4/5) > > This CL re-writes a breakpoint web test using a new SourcesTestRunner > helper introduced in https://crrev.com/c/2027427. > > This should not only prepare the test for the upcoming source map > asyncification but also reduce the overall flakiness of breakpoint > web tests. > > This CL superseeds the current in-flight CL https://crrev.com/c/2022642 > which will be abandoned. > > R=sigurds@chromium.org > > Bug: chromium:1032016 > Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737714} TBR=sigurds@chromium.org,szuend@chromium.org Change-Id: I771b2c18d94c6c3b7d124a206531806157404cac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1032016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030917Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737748}
-
Saurabh Nijhara authored
This CL includes adding device policy MinimumChromeVersionEnforced which accepts a list of minimum required version configurations and selects the best configuration in the order of preference min_version>warning_period>eol_warning_period. The policy restrictions are then applied on the basis of this config. This is the first CL in the implementation of Minimum Chrome Version. The subsequent CLs will include unittests and handling of different cases as critical updates, end-of-life, dusty devices, metered connections, update required screen. Bug: 944838 Change-Id: Ib1aadea43ea5692349b89ab54c1b58890ee27f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007570Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#737747}
-
Saurabh Nijhara authored
This CL adds a new browser test for captive portal on the update required screen. Bug: 944838 Change-Id: Iaf40f8668e762dd33cf5f80372f947a5bed60aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019108 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737746}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42bf253e3e43..09a9f1ba72d5 git log 42bf253e3e43..09a9f1ba72d5 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 srte@webrtc.org Adds simulated time controller API. 2020-02-03 srte@webrtc.org Accept undecoded frame pairs in VideoLayerAnalyzer Created with: gclient setdep -r src/third_party/webrtc@09a9f1ba72d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id43553e8e035a92dbaad3569b3275ddc977a2470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035598Reviewed-by:
-
Michael van Ouwerkerk authored
* Adds a pulse_interval constructor argument and getter to DeviceInfo. * Adds a pulse_interval field to the DeviceInfoSpecifics proto. Bug: 1030266,1048112 TBR=jeffreycohen Change-Id: I81bda5f8fb8e9356943b3b38e9036b7a7a9bf4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031028 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737744}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 1048113 Change-Id: Ib5eb4bc816f02cfdef0b7968cc2c8c92cd1601f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034525Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1863ec3f932b..c1a0ada7d208 Created with: gclient setdep -r src-internal@c1a0ada7d208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I028f5c25d0dfd25a9663e83af6196de88848d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035594Reviewed-by:
-
Nico Weber authored
...except on Android, where this fires once in libunwind's arm32 code, which we'll have to fix first. Bug: 1016947 Change-Id: I5f64a1805736a30f1cf4050e9ec0ceb4ff4eae2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032791 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#737741}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If9b0212fee64f28d35cc320a806bd54f4488ac7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035533Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737740}
-
Jan Scheffler authored
This cl adds support to the audits agent to collect and persist issues similar to how console messages are handled. Bug: chromium:1039607 Change-Id: Ie818516fd019bc9c6efa03888ab7dad5705e4d7f Design-Doc: https://docs.google.com/document/d/1F6R5Bpb3qHNzGPNBSXwEJ_eP8L-anIj0WinxOIyAh54/preview Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991507Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#737739}
-
Nazerke authored
This CL modernizes the ManageSyncSettingsCoordinator to remove the public property for dispatcher and to update the coordinators implementation to get it from self.browser. Bug: 1029346 Change-Id: I395a6235682f3983126dd546ca11f2b3192e5e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033258 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737738}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e27cd5339842..b6b755afe678 git log e27cd5339842..b6b755afe678 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 tvanderlippe@chromium.org Migrate workspace_diff/ to import cross-module 2020-02-03 tvanderlippe@chromium.org Prepare AuditsService for audits_worker change 2020-02-03 aerotwist@chromium.org [e2e] Update helper to use hosted mode instead of file protocol Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6b755afe678 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1047667 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f208b875ebe4c31cfb804d05a50e98bdaa7403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035593Reviewed-by:
-
Marc Treib authored
TBR=dtrainor@chromium.org Bug: 1048100 Change-Id: I747ea99ddcd9d41b598818784c872460b0591e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033449Reviewed-by:
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I37d416be30ccbf46d990548566f3d2521c7baeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033152Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737735}
-
Pâris MEULEMAN authored
This fixes three tests: - blob-popup.https.html checked for a random string to be empty, which makes test expectations unreliable, use length instead. - coop-navigated-popup.https.html had a failure in the cleanup, trying to use a non-existent object. This change defines the broadcast channel beforehand and uses the proper variable name. - historical/coep-navigate-popup-unsafe-inherit.https.html had an invalid expectation that navigating a popup from a COOP: same-origin document to a COOP: unsafe-none document should not create a new browsing context group. Bug: 922191 Change-Id: Ife24aee4369a3a25bbff32a2fe5e8c29abb2d468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030902 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737734}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9d56b0113fff..42bf253e3e43 git log 9d56b0113fff..42bf253e3e43 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 phoglund@webrtc.org Migrate static imports of org.mockito.Matchers. Created with: gclient setdep -r src/third_party/webrtc@42bf253e3e43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f4328f83f5837a698a6ccd9fcfab45fcb88068c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035369Reviewed-by:
-
Yuki Shiino authored
A set of overloading of ToV8({ScriptWrappable,EventTarget,Node, DOMWindow}*) has been expected to be used for each class, however, it turned out that ToV8(ScriptWrappable* value) is used even when |value| is a DOMWindow. Example case) void Func(ScriptWrappable* value) { ToV8(value); // resolved to ToV8(ScriptWrappable*) } Func(window); // ToV8(ScriptWrappable*) is invoked This patch removes ToV8(DOMWindow*) overloading and moves the special-handling of DOMWindow from ToV8 into DOMWindow::Wrap so that the special-handling always works. Change-Id: I483ba3293ce6736428947525e7a13d38c6071783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996111Reviewed-by: -
Marc Treib authored
TBR=chenwilliam@chromium.org Bug: 1044505 Change-Id: I18af5ad3da693eec837cbce5c21968f4b106a322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033073Reviewed-by:
-
anina koehler authored
When running tests from device_cloud_policy_manager_chromeos_unittest.cc, GMOCK warnings about uninteresting mock function calls are appearing. Similar to ConnectManager(), a helper method ShutdownManager() was created and expect calls for MockCloudExternalDataManagers Connect() and Disconnect() methods were added in the helper methods. Bug: 1046259 Change-Id: Ibb371bcf8bdaaf04974737f616e4081f8a994b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012281 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737730}
-
Marc Treib authored
TBR=kylechar@chromium.org,agawronska@chromium.org Bug: 1048073 Change-Id: Ie3822f2e9be287f31222fc24b0010d97ae799b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033516Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d9543d525ec..1863ec3f932b Created with: gclient setdep -r src-internal@1863ec3f932b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If9cec59d0492743f4586d6f698f6929863bff53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035363Reviewed-by:
-
Jihwan Marc Kim authored
Existing PasswordManager::BuildSuggestions helper is quite convoluted, reorder the parameters. Bug: 1046756 Change-Id: I82e50d08954bae9f94268759800051c6eb20465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032627Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737727}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3610dd0daf0f..e27cd5339842 git log 3610dd0daf0f..e27cd5339842 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 aerotwist@chromium.org [e2e] Have Mocha resolve on end instead of suite end 2020-02-03 szuend@chromium.org [cleanup] Minor code cleanups in BreakpointManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e27cd5339842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047672 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifbbb6d36c189b8d6558c9f4925b7693ee18b2ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035367Reviewed-by:
-
