- 13 Oct, 2020 40 commits
-
-
Mitsuru Oshima authored
Use these scale factor when 2.25, 1.77 and 2.66 are given from command line. Bug: None Change-Id: I20f227a80ed38eb3643a63abb50ba6c454036b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448651Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#816516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1df9e9aac9d3..e2dfd01ded55 2020-10-13 jleconte@google.com Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: nuskos@google.com Change-Id: Ifd87cae8526bb14bc204095441e6f2e5e6f8ccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816515}
-
Paula Vidas authored
This CL adds a test that checks the following: - When sync is disabled for a data type, it won't show up in interested data types. - When sync gets enabled again for that data type, it will appear in interested data types, and the device will receive invalidations for that type. The test uses only sync invalidations. Bug: 1135167 Change-Id: Ibe118a8281a332ebe64713d9dffdf1e9935e6262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466760 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ce65f04. With Chromium commits locally applied on WPT: cfa13307 "Revert "Enable "Immersive-AR" session for OpenXR runtime"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ie431e137de412c6946083c712892b507c3e9a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466440Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816513}
-
Weilun Shi authored
Bug: 758782 Change-Id: I4b7ff5cd8116d9b88ae1e9fe12adb7532a6ecf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466840 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816512}
-
Mikel Astiz authored
The concept of registered datatypes is somewhat advanced and should not be part of SyncService's public API. Instead, this patch moves it to the subclass, ProfileSyncService, and makes it private except for testing. Change-Id: I0934a6a97009bf6589f1075ba37fdc1a52490643 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463832Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816511}
-
Jacobo Aragunde Pérez authored
This bubble is modal: it takes focus when shown up and does not let users manipulate other UI until having explicitly dealt with it. For this reason, the dialog role is more appropriate. As a result of this change, the bug where the bubble content was not always read is gone. The deleted code was supposed to fix crbug.com/849910, but now this bubble is properly announced by JAWS 2020 in addition to NVDA. Bug: 1123107 Change-Id: I371523a4384b7338e35ba30f897bade1d3ba2ee5 AX-relnotes: always announce add extension bubble correctly. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461276 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816510}
-
Eric Seckler authored
As it turns out, the per-core time_in_state data from /sys/devices/system/cpu/cpuX/cpufreq/stats/time_in_state is wall time rather than CPU time and includes time the cores spend in idle states. Consequently, the data we currently report into Power.Approx* metrics isn't correct. We have to correct for the idle time when computing each core type + frequency state's proportional part of the execution. This patch adds a way to do so by polling per-core idle times from /sys/devices/system/cpu/cpuX/cpuidle/stateY/time (via a helper in base::CPU) and updates the CpuTimeMetrics code to account for idle time. Bug: 1081760 Change-Id: I7b8168b47b1e4d118bc7569aebb07952fa78693e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462088 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816509}
-
Mikel Astiz authored
It was only used for a DCHECK that always returned true and was not important anyway. Change-Id: I87fd0a856420e035cbd6381f79fa9cdd04f87b1f Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467520 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#816508}
-
Jaeyong Bae authored
This patch implements showing confirmation dialog for removing address. It makes easy user to recognize removing address. It is similar in looks and functionality to the already confirmation dialog of history. Change-Id: Idf7b819279b314d7ba85c6099302b4924e9155f9 Bug: 935227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009165 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816507}
-
Weilun Shi authored
The original cl is in https://chromium-review.googlesource.com/c/chromium/src/+/2246233 Change-Id: Ifeee8eb6c01c914b3f71c16feb1b44d602688b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467357 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Titouan Rigoudy authored
This browser test asserts failures we want to fix for crbug.com/1134601. As such it is important to re-enable and de-flake. I hope that by splitting the loop into individual tests, the strange check failure in DidCommitNavigation() that afflicted the old test will no longer happen. The old test is extended to cover is_web_secure_context as well as ip_address_space. This allows us to remove redundant assertions from the tests below that actually perform private network requests and check for success or failure. Bug: chromium:1134601 Change-Id: I11d783027a67087d50d8c6ff3d358777b72bf935 Fixed: chromium:1014325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454718Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816505}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df42b9a729b5..8567edac4fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ib1bd2e877ed242b17e3585538af162637c0ab000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816504}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8900cd2cdaec..ffd66905c46a 2020-10-13 wolfi@chromium.org Add dedicated workers to frame tree 2020-10-13 petermarshall@chromium.org Don't instantiate a SourceFormatter when modules are imported 2020-10-13 yangguo@chromium.org [ts] Type-checkk har_importer/HARImporter.js 2020-10-13 wolfi@chromium.org Fix overlapping text for COOP policy in frame details 2020-10-13 wolfi@chromium.org Add whitespace to frame details->secure context 2020-10-13 szuend@chromium.org Update DevTools protocol If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093247,chromium:1122507,chromium:1136848 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bdfc6027bc3fcb16a8f6bf2fd43c2cdcbe347cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467539Reviewed-by:
-
Henrique Ferreiro authored
Ash limits the cursor scale factor to the available resource scale factors, currently 100P and 200P. Lacros should follow this behavior; otherwise, the cursor may change sizes when hovering a Lacros window. Bug: 1127962 Change-Id: I17c0ded04153dd10efb7b90665e1426634c9a7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461227 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816502}
-
Nohemi Fernandez authored
Adds a comment explaining the flexibility of the AuthenticationFlow service and how this may cause issues in sign-in UI expectations. Bug: 1125631 Change-Id: Ia2f5aa12a7092c57a2c91f8eae1df6079ddd980d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461345 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
If the pseudo_id is set, the SelectorChecker::MatchSelector call for each subselector will fail completely because the dynamic_pseudo of the inner result will not match context.pseudo_id. This check does not make sense to perform for nested complex selectors, since pseudo elements are not valid in nested complex selectors. Hence, we can just set the pseudo_id to kPseudoIdNone at the :is/:where boundary. This fixes a bug where selectors such as ":is(.a .b)::before" would never match. This CL also adds a basic test for pseudo classes. (Not related to the fix). Bug: 568705 Change-Id: I119265836ac0f1b77868537c7685690300c265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466278Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816500}
-
Mario Sanchez Prada authored
Currently, the code in RFHI::SetEmbeddingToken() (which gets called as the result of a document being loaded in a renderer's RenderFrame for the first time) takes care of locating the correct RenderFrameProxyHost representing the parent frame remotely to send it the embedding token, so that the parent-child relationship can get established. However, there is a race condition for the particular case of inner web contents in that such propagation will only work if SetEmbeddingToken() gets called *after* the inner web contents are attached to the outer one. In that case, since the outer delegater proxy has not been created yet, SetEmbeddingToken() will fail to find the RenderFrameProxyHost and the remote frame representing the parent frame in one renderer will not have its embedding token properly set, breaking things such as the accessibility tree, for instance. To fix that, this CL splits RFHI::SetEmbeddingToken() in two parts: one that actually sets the embedding token and another one that takes care of propagating it to the parent frame. And with that in place, this CL does also make sure that such propagation is requested also after inner web contents get attached, so that the parent-child relationship is always guaranteed to be set. Bug: 1135691, 1094150 Change-Id: Ie3ddd24acb3ad224a08a31c622e319cd69affba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462128 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816499}
-
Joel Hockey authored
It is helpful to use linux-chromeos to see parts of the settings and FilesApp UI which relate to Plugin VM. Change-Id: I4f51642e87d52fd35b125df540173c72d4022ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466545 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816498}
-
Francois Beaufort authored
This CL adds the camera pan tilt zoom permission to devtools browser protocol. Spec: https://github.com/w3c/permissions/pull/204 Bug: 1136778 Change-Id: Ic11990413e2ceeeceb7da5c03930cd4049189b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460898Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Maggie Cai authored
The test fast/events/mouse-cursor-image-set.html is flaky on Mac 10.12 Tests builder. e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/38366. BUG=1137716 TBR=tkent@chromium.org Change-Id: Ib4d284ed30a1e1968ca02fef85ffe2690fd5c478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467577Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816496}
-
Joe DeBlasio authored
Safety Tips have always recorded histogram names based on NoAction, but histograms.xml has had NoActionTaken. That made it look like NoActionTaken just never happened. I now know better. This change lets us see the existing data from the dashboard. :-( The code in question is at: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/reputation/reputation_web_contents_observer.cc;l=69?q=Security.SafetyTips.Interaction&ss=chromium Change-Id: I2cc79ffaf70e962b24f34635e698db3aa145083a Fixed: 1137615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466512 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Marc Treib authored
This allows the corresponding factory to return refptrs instead of raw pointers, and lets remove the explicit Destroy() method. One downside is that now all implementations have to be refcounted, but this only affects some test implementations. One particular test implementation, TestHttpBridge[Factory], was unused and is deleted. Bug: 951350 Change-Id: I8c581136389e2ce470786dffefa3145e88c5d19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466237 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816494}
-
Victor Hugo Vianna Silva authored
(Most of the changes here are trivial renamings, the interesting parts to review are indicated below.) As explained in the linked bug, there's no need for a distinction between blocking and non-blocking sync data types anymore, so this CL removes instances of non-blocking/non_blocking/nonblocking from methods, class members, local variables, test names and documentation. After this CL only 2 references to this concept remain: non_blocking_sync_common.h, which will possibly be split into other files, and the ModelSafeGroup enum (GROUP_NON_BLOCKING/GROUP_PASSIVE), which will be addressed in crbug.com/1102835. The only interesting changes to review here are: - Documentation of classes, methods and members. - Test names and their comments. - SyncBackendRegistrar: this class still depends on ModelSafeGroup, so its somewhat hard to get rid of the blocking/non-blocking distinction entirely. What we do instead is reference GROUP_[NON_BLOCKING/PASSIVE] directly and add TODOs pointing to crbug.com/1102835. This makes it more likely that these instances get addressed. Bug: 1103583 Change-Id: I66f14afa0a0a96e8541021ba8b4136a3fcca8618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465751 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9b0de8c80ca..1df9e9aac9d3 2020-10-13 jleconte@google.com Fix pop up statement when triaging with an existing bug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: nuskos@google.com Change-Id: I182f3b651d9c85d43505f67724b31f4a045218a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464701Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602514791-92b25c346599f1253fe4b5957e8929536703cfb0.profdata to chrome-win32-master-1602536311-b12e3fd5e65df9379666839aba71278f41868f97.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib730131c3214f41774025e0d272fe67bf622b744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467066Reviewed-by:
-
Noel Gordon authored
This reverts commit 6e991fa7 Reason for revert: MSAN error that caused the original revert was fixed on CL:2466572. Original change's description: > Revert "[filesapp] Add missing includes and fail if host crashed" > > This reverts commit 4734ecf2. > > Reason for revert: https://crrev.com/c/2461602 breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 > Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage > > Original change's description: > > [filesapp] Add missing includes and fail if host crashed > > > > Adds #include's that were missing from the initial patch, and FAIL the > > test if the DevToolsAgentHost attached to crashes during the test. > > > > Fix HostString() helper to *actually* take an optional prefix: use C++ > > c++17 {} style initializer. > > > > Test: browser_test --gtest_filter="*DevToolsListener*" > > Bug: 1113941 > > Change-Id: I5901019add9fea92b6e3a8b5b881b8d3d197b6c0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465456 > > Commit-Queue: Ben Reich <benreich@chromium.org> > > Reviewed-by: Noel Gordon <noel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816070} > > TBR=noel@chromium.org,benreich@chromium.org > > Change-Id: I87ec9b3db970807af8fc75ca137fc83397f775bf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113941 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466016 > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816400} TBR=noel@chromium.org,mxcai@chromium.org,benreich@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1113941 Change-Id: I10432537826bc0ecd3938230b8454a9f1dbd8cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465900 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816490}
-
dpapad authored
The previous way of fetching the Closure compiler binary from [1] no longer works (endpoint removed), and using NPM is the suggested alternative. [1] https://dl.google.com/closure-compiler/compiler-latest.zip Bug: 1137293 Change-Id: I6047c760fa97e04b16258beee0dd59c78b231b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465685 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#816489}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602546992-ba4d1f5ead4061da7fd3853f89c3c9703bc786ae.profdata to chrome-linux-master-1602567235-76a4ea133fcdb6cde619178f9199537d86205f8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab4fc8e832116ae0dbd259d88cab186b424f8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467537Reviewed-by:
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: I7b69be39368da781a0ac95562ecab34c43fe6e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816487}
-
Rohit Agarwal authored
#testCloseAllIncognitoNotificationIsDisplayed. StatusBarNotification#getTag method can return null if no tag was assigned to a notification. This CL adds the null check here before comparing the tag with the incognito notification tag. Bug: 1134241 Change-Id: I548ec82aebbd15a2e837cf00316d30955d828510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463573Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816486}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6bb6691b933..8900cd2cdaec 2020-10-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-13 alexrudenko@chromium.org Enable TypeScript for LayerDetailsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3c337247cf32b656b7048cf6ab93df8da65c6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464700Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b073999c6f90..aa45aa62c3c6 2020-10-13 orodley@chromium.org [vpython] Update to e5cc6d29d10646efa. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123433 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I302d8b32c79ed3cd5e473bbc7b239eba66730991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464698Reviewed-by:
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I9d36850098c4b08e7cd406a0269e03a04ee05a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463090 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fa8ec27e929..df42b9a729b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: Ib3c09adec12b6208004683b994079130ccc7d211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466919Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602546992-4541e834d35741f8358d6360b79d19523776e3ad.profdata to chrome-mac-master-1602567235-69e1809554df433714edde9ed60539d7ae5c84b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib32f5dce8d4a14ecb485dfbfb2032ad04e66d713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464699Reviewed-by:
-
Ben Reich authored
This is a reland of c67306a2, which was reverted due to to uninitialized variable MSAN error. That was fixed on CL:2466572; re-landing the original change c67306a2 therefore. . Original change's description: > [filesapp] Add a browser_test for DevToolsListener class > > Test that JS code coverage of a JS IFFE injected in a WebContents gets > collected by DevToolsListener and stored in a ScopedTempDir. > > Test: browser_tests --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I8f04f2e704d677823ffa154272605798b7046f77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461602 > Commit-Queue: Ben Reich <benreich@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816064} Bug: 1113941 Change-Id: I491101bbe9a8cf050ddfe39842a3f0bd4fb2ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467165Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c6903a455df..df6b7298bb41 2020-10-13 cclao@google.com Vulkan: Use StoreOp_None_QCOM for read only depth stencil buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Iee16f2105cf3d71b72a8255bb91d5238f26ecd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464695Reviewed-by:
-
Alexander Cooper authored
The Oculus runtime is no longer considered for selecting an appropriate VR Runtime, as our plan is to unify behind OpenXR as the single, supported runtime. This removes the unused Oculus runtime. Fixed: 1121625 Change-Id: I327619423e7a3d6c160a176dffca1354515af4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435722 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816478}
-
Peter Marshall authored
Feature CL: http://crrev.com/c/2443620 Enable CL: http://crrev.com/c/2454085 Bug: 1127827 Change-Id: Ic7ad3ce77c222163794dd3173d046fa3fe6a8a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454721 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816477}
-
