- 08 Oct, 2019 40 commits
-
-
Alexander Timin authored
Do not cache the page if we have we have pending permission requests as we would lose a part of the state of the page. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 R=carlscab@chromium.org,engedy@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: Ib3d2619333767b141d25d23e015deaf2a06b5b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827432Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703729}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/720988d878a1..e986cb92544a git log 720988d878a1..e986cb92544a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 cwallez@chromium.org Vulkan: Add proper error handling for all regular object creation. 2019-10-08 bryan.bernhart@intel.com Fix MSVC build error due to implicit descriptor heap offset cast. 2019-10-08 cwallez@chromium.org Guard macOS or iOS specific code in #if guards 2019-10-08 cwallez@chromium.org Make dawn.h closer to webgpu.h 2019-10-08 cwallez@chromium.org Remove stray push constant code. 2019-10-08 cwallez@chromium.org Allow ResultOrError to downcast from backend to frontend types 2019-10-08 cwallez@chromium.org Fix RenderPassDescriptor to be extensible. Created with: gclient setdep -r src/third_party/dawn@e986cb92544a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5bedebf75c0f8f3a0a98cc63c1650d53e1e4ab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703728}
-
arthursonzogni authored
Following the discussion in: https://chromium-review.googlesource.com/c/chromium/src/+/1827280/16/content/public/browser/back_forward_cache.h#51 The previous API was very verbose to use. A second one was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1827280 This CL removes update the first one to match the second. Design for the new content public API https://docs.google.com/document/d/1brlmAs1mMumbGwgwdE_M_VGR81YbArzeViI0P-Uak14 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 TBR=dominikn@chromium.org (for the name change in AppBanner) Bug: 1001087 Change-Id: Idd39dff370bd45f7006318b2a1bbad9fec1baa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835617 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703727}
-
Sadrul Habib Chowdhury authored
Use RenderProcessHostObserver and RenderProcessHostCreationObserver APIs to replace the usage of NotificationService. BUG=357627 Change-Id: Idae690c3cc8bb7fffdca0558301b938df3ea1441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844274Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#703726}
-
Sidney San Martín authored
Previously, while an Incognito window was active, the History menu on Mac showed items from the original profile but always opened them in a non-Incognito window. Now, they open in the Incognito window. Bug: 973029 Change-Id: I50040b6c05ae3425335e577656daaec486dbc391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842431Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703725}
-
Roman Sorokin authored
Files found with: grep -L oobe_dialog_host `git grep --files-with-matches oobe-dialog | grep html` Bug: 1000606 Change-Id: I9d7f12253b1e9508a4a9f7096aa0ce2fc0e8fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844963Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703724}
-
Francois Doray authored
With this CL, we store the render_process_id and render_frame_id (if any) associated with each IndexedDBConnection. This is a prerequisite to notify content::LockObserver when frames must not be frozen because they hold IndexedDB locks. Bug: 980533 Change-Id: I474cb3079abc87d62b4785e3858f7bfca540b37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822824 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#703723}
-
Mike West authored
The conversation in https://github.com/whatwg/fetch/pull/948 makes me curious about how locked-in we are to the existing behavior around both `<embed>` and `<object>` when used for non-plugin content. They're basically strange `<iframe>`s, and it might be reasonable to push them closer towards _being_ `<iframe>` elements, or to push them further away, depending on how usage numbers look. Change-Id: I843ae37ae74033fdb3ea9b920ce3932004a067b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847291 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#703722}
-
chrome://omniboxTibor Goldschwendt authored
Moves resources used in chrome://omnibox out of browser_resources.grd into its own GRD file. Moves those resources into the Dev UI DFM to save binary size on Chrome Android. Bug: 927131 Change-Id: Iabef47e999a5504969595b1d403123157fc338fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845823Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703721}
-
ckitagawa authored
Adds the ability to inject paint_preview::PaintPreviewTracker into blink::GraphicsContext to act similarly to printing::MetafileSkia. This class will track various metadata about the Paint Preview capture process. Design Doc: go/fdt-design (internal) Part of Landing: crrev/1786583 Bug: 1008885 Change-Id: Iba2819491bee7b284de62a1bf888aa9486c788cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829277 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#703720}
-
arthursonzogni authored
The back-forward cache is a content/ layer feature and it is tested on this layer. For instance, this file contains a lot of tests: content/browser/back_forward_cache_browsertest.cc We also want to have some basic tests at the chrome layer to catch trivial regressions. In particular, there is now an API available to chrome/ to disable the BackForwardCache on arbitrary page. See: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1010932 Change-Id: Ic0f0fc667f0d1de5157f95aea5f0558bc3d8557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836413Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Saman Sami authored
This CL reverts https://crrev.com/c/1724558 which has increased the number of crashes in SchedulePageFlip. TBR=sammc@chromium.org Bug: 1006847 Change-Id: Ib1edf3d16f4a0f9141f37e5bd76f8ba969c7b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841663 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#703718}
-
Marc Treib authored
This is a followup to crrev.com/c/1844969. GetBestMatches now returns the best matches in a vector, instead of in a map keyed by username. For now, PasswordFormManager still sorts the matches by username; that'll be addressed in another followup. TBRing simple call site update in website_login_fetcher_impl.cc TBR=arbesser@google.com Bug: 1011399 Change-Id: Iaefbe3a29603ea319adcbeddadd6b908d029ab74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845225Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703717}
-
Tim van der Lippe authored
- Rename Workspace.js to WorkspaceImpl.js to not name clash with workspace.js in the Grit localization generation. Bug: 1006759 Change-Id: I56a496d866e4a453cd3ef84a24c29f8baa296876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847280 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703716}
-
Roman Sorokin authored
In OOBE handled by container In the session should be handled by DiscoverWindowManager Bug: 1001475 Change-Id: I3b63726bfcedcefca636ad51de993202693018f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844959Reviewed-by:
-
Friedrich Horschig authored
Currently, the sheet is asked to skip the peeking. Since this doesn't seem to work as intended (see https://crbug.com/1012231), we expand this sheet. Expanding immediately might have no effect — most likely a timing issue (see first screenshot in linked bug). Therefore, this CL allows the peek state and expands the sheet as soon as the peek state is shown. Bug: 1011856 Change-Id: I63cc403a9acc93f2e4f90c2549c32cf39757f042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847294Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703714}
-
arthursonzogni authored
The goal is to fix a big class of URL spoof issues. They happen when a NavigationRequest is canceled, but the associated pending navigation entry remains. This causes the wrong URL to be displayed in the omnibox. To fix it, delete the matching pending NavigationEntry in the NavigationRequest's destructor. This is a bit more complex: 1) During an history navigation, several NavigationRequest can starts at the same time for iframes. All of them are associated with the same pending NavigationEntry. 2) A pending NavigationEntry can be used, discarded and reused. It can is used twice, but not associated with the same NavigationRequest(s) on every use. The class PendingEntryRef is used to track one NavigationRequest being associated with a pending NavigationEntry for a given history navigation. Bug: 999932 Change-Id: I14582fd1d954a6f831959db0bb5d96eb1f5d53b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815129 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703713}
-
Elly Fong-Jones authored
This method is not safe to use in test contexts sometimes: it assumes that browser->window() is a BrowserView in Views builds, when in fact it is sometimes a TestBrowserWindow instead. Bug: None Change-Id: I1304eb1cc508d7a76c9a4cbc6954f69a7bcb1637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845955Reviewed-by:
-
Yann Dago authored
Policy conflicts used to be deep copied when merging policies, they are now simply moved using std::move instead of being deep copied. Bug: 1006422 Change-Id: I71239424fd7c2b31fc39c56e6f703bf68b6bd241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827545Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#703711}
-
Jan Wilken Dörrie authored
TBR=dvadym Bug: 957532 Change-Id: Id30d89d634c5645d29c5f110797afdf35bd62afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826788 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703710}
-
Charlie Hu authored
The renaming is because ParsedFeaturePolicy not necessarily represent a feature policy header. Previously the function is hardcoded to accept 2 declaration object as params. The new version accepts a vector of declarations, which makes it more generic. Change-Id: I9e6dfa828f0579776c941734c50c09c0b54194de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836373Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#703709}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b1af463167a..2d30369ce6b1 git log 0b1af463167a..2d30369ce6b1 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 dberris@chromium.org Do not use Datastore as a cache 2019-10-08 dberris@chromium.org Fix results2 dependency on internal functions 2019-10-08 khokhlov@google.com [Telemetry] Move --verbose option to run_tests Created with: gclient setdep -r src/third_party/catapult@2d30369ce6b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1006888,chromium:1012187,chromium:985712 Change-Id: I5f446ec608b9ffa499c9217bc2734fd38852592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847316Reviewed-by:
-
Friedrich Horschig authored
By setting the bottom sheet observer whenever we bring up the sheet, the closing signal will be captured reliably. This wasn't the case before which caused the bottom sheet to be permanently dismissed. Note: I removed the NOTIMPLEMENTED() call from onDismiss() since it crashes but has no real reason to do so — the cleanup happens in the destructor anyway. It might be late but it's not wrong. Side effect: for some reason, this seems to fix the intermediate peek state (see screenshot 1 in the linked bug). This is unexpected and since it's a timing-related issue probably not a reliable fix. It will be addresses and tested separately, later. Bug: 1011856 Change-Id: I8e2321ef920bc5adab116278521f95b449d10565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847214Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a639f7a24477..b4161d3c0d43 git log a639f7a24477..b4161d3c0d43 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 peah@webrtc.org AEC3: Add multichannel support to the residual echo estimator 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5ac2340a..977e7324 (703358:703537) 2019-10-07 dinosaurav@chromium.org Add/remove receive streams with SSRC 0 from media channels Created with: gclient setdep -r src/third_party/webrtc@b4161d3c0d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie684d8c1cb5d1f7f057cf68ae5109231993b33b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847475Reviewed-by:
-
Roman Sorokin authored
TBR=antrim@chromium.org Bug: 1011005 Test: checked locally saml login/saml interstitial Change-Id: I25888c67ff193bcd6555c71dd83c7f090009ee23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845010Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703705}
-
Rune Lillesveen authored
Shadow DOM V0 insertion points are not part of the flat tree, which means they won't have non-null ComputedStyle (unless cached by getComputedStyle()). Make sure we skip up to the flat tree parent to check if the style inheritance parent GetComputedStyle for the optimization of not marking style dirty unnecessarily in non-rendered subtrees. The TEST was failing with FlatTreeStyleRecalc enabled. TEST=fast/css/clear-activechain-list-shadow-dom.html Bug: 972752, 1012201 Change-Id: Ia36c418bb06d9988fe8cdb118e93d072a3c7cc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847273 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703704}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79eb4f5c..c4823069 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb96327130dfa283ff871872d68af5053b72b969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847253Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703703}
-
Ryan Daum authored
Bug: internal b/141853741 Change-Id: Iaa5f5ac1a6fe46addd11d8f666c9cee4fa6b08f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845674 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#703702}
-
Charlie Harrison authored
Bug: None Change-Id: I56ef31ecfaebe5bfd14ec57826d99578ae17a883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841231Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Replace it with a member var of DialogDelegate with an appropriate setter, and stash it inside the DialogDelegate's params. Bug: 1011446 Change-Id: I3b9e096b70e1fbac5a80c0171655c67c74c0379e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846291Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703700}
-
Geoff Lang authored
With the passthrough command decoder on Mac, backpressure fence and flush workarounds need to be done in the GLContextEGL as well. Move them to the base GLContext class so they are usable by both context types. Fixes flickering issues on UI elements on Mac when using the passthrough command decoder. BUG=1011017 Change-Id: Iba226caada24341abc58053e7d033e114d16df3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838371 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#703699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/482a6e85b167..a9e7e778b1db Created with: gclient setdep -r src-internal@a9e7e778b1db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic47f37120c54a30d574f4b314b3a6dbcc260bf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703698}
-
Rouslan Solomakhin authored
Before this patch, Context.bindService() could return false when connecting to payment app's org.chromium.intent.action.IS_READY_TO_PAY service, although ServiceConnection.onServiceConnected() was also invoked. The onServiceConnected() method would set mIsServiceConnected to true, which would cause Context.unbindService() call, which would throw InvalidArgumentException, because bindService() returned false. This patch removes mIsServiceConnected boolean that was set in onServiceConnected() method and adds mIsServiceBindingInitiated that is set to the return value of bindService(). If this boolean is true, then unbindService() is called. After this patch, unbindService() is called only if bindService() returned true, thus avoiding the IllegalArgumentException. Tested locally against BobPay.apk downloaded from https://bobpay.xyz and invoked from https://rsolomakhin.github.io/pr/skip-ui/. Bug: 828852 Change-Id: I00647791098f129b3a16f1f3430a363ee12ecee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845953Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703697}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ibe9df49abb07530e6613de0865db75420f7c396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837114Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703696}
-
Xida Chen authored
This test is just a sample to show how to write an interpolation test. Bug: None Change-Id: Ie66e8c6d290703052ea1f30d71bac44f2dfe8f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841938Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703695}
-
Rune Lillesveen authored
We do not consider dirty bits on shadow roots with FlatTreeStyleRecalc enabled. The skipped LocalStyleChange had no effect, even in the current code since ShadowRoot::RecalcStyle only checks for SubtreeStyleChange. With the FlatTreeStyleRecalcFlag enabled, mark the shadow host for subtree recalc instead. TEST=fast/css/invalidation/shadow-root-sibling-invalidation-crash.html TEST=fast/css/invalidation/shadow-root-sibling-invalidation-crash-2.html Bug: 972752 Change-Id: I1b4917f4d0cf30cb235284cbdcff26c7018190fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844984 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Nico Weber authored
This will hopefully "fix" the following tests in cross builds (by no longer running them) in interactive_ui_tests: ExtensionSettingsUIBrowserTest.ActivityLogInactiveWithoutSwitch ExtensionSettingsUIBrowserTest.ListenerRegistration ExtensionSettingsUIBrowserTest.ViewSource ExtensionsActivityLogTest.TestActivityLogVisible See comment 6 on the bug. If this helps, I'll try reverting #702844 which might then no longer be necessary. Bug: 1010561 Change-Id: Id31c4ea33493f6917d3a855d49cada56a032e9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845801 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#703693}
-
Xida Chen authored
Bug: 900581 Change-Id: Ide1ea499203b960fe59faeecda1a273a0689477c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841412Reviewed-by:
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I17818dd46ad42882388a145cdd49400f2f2e5a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845711Reviewed-by:
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I1893aedc7584da2d31507eb16b284c2a9ea495cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847611Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703690}
-
