- 14 Oct, 2019 40 commits
-
-
Egor Pasko authored
The code has stabilized, the failure rates are low. Stop tracking this. Bug: 988785 Change-Id: If3e33e46177973bf4cbad05a2e239b12565d5ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845971Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705641}
-
Tarun Bansal authored
Curretly, client configs are not fetched if data saver holdback is enabled AND lite page redirect preview is not enabled. This CL changes the logic to allow client configs to be fetched for all data saver users. This is expected to ensure that the client config is available to lite page redirect users when they switch from control finch arm to enabled arm. Change-Id: I95184e9d377386434a605afe37cdfb96a6c385f5 Bug: 1012299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857713Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705640}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: Icedf0b2b72b24d8b45b39b027ab37f60c6ac4a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860689Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705639}
-
Asanka Herath authored
Bug: None Change-Id: I37729941b4e3ca3837d259c6064d236635dd8b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857399Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705638}
-
chrome://sync-confirmationdpapad authored
- Only updating the DICE enabled codepath (sync_confirmation.html), and related tests. - Forking signin_shared_css.html so that the old (Polymer2) version of it can still be used by the pages that are not migrated yet. - Drive-by: Added type-checking target for sync_disabled_confirmation.js which was missing. Bug: 965770 Test: Page still works, no more HTML imports warnings in DevTools. Change-Id: I714e4d539316f21d7f45c8516c0c4175c267c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848348Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705637}
-
Bettina authored
Create a new metric that will log when information of a URL that matches the allowlist on a password reuse or on a password field focus event is sent to Safe Browsing. Bug: 953106 Change-Id: I1bfe040db792f3f8e13b1905b4bd570ad11e3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817177Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#705636}
-
Thomas Lukaszewicz authored
Ensured that functionality that runs tests + launcher in a single process is consistently referred to with the switch --single-process-tests rather than previous content:: specific --single_process in both code and documentation. Performed basic cleanup to ensure that unused declarations were removed and made sure switches in content:: are more consistently declared in the appropriate headers. Bug: 460513 Change-Id: Ic901d7af972ad43c9e0e2d31e34cc778d388d34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848365Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#705635}
-
Kevin Marshall authored
* Adds support for isolated CastRunner instances, which run without networking capabilities and only have access to resources served by local ContentDirectoryProviders. * Defers web.Context creation to WebComponent creation time, so that CastRunner can defer shared Context creation until it's actually needed. Bug: 1004505 Change-Id: I4af9ca7c04b9c86e93c30b2d0aaa7f39ee3f8d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808159 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705634}
-
Adam Kallai authored
Windows ARM64 build bot is broken on copying runtime dlls. A recent change switches the MSVC version to VS 2019 as preferred ( https://chromium-review.googlesource.com/c/chromium/src/+/1836195 ). This affects the search of runtime dlls, since currently VC141 toolset is selected. As a workaround select the proper toolset directory based on VS version. Bug: 1013508 Change-Id: Iaebee100be727f60d7bd651202af725abf4726d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855966Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705633}
-
Raphael Kubo da Costa authored
This is another big update to the implementation, which now follows the API proposed in https://github.com/w3c/wake-lock/issues/226. From a Blink/Chromium internals perspective, things have not changed much, and we still perform the same permission checks and connect to the wake lock service via WakeLockStateRecord. The biggest change is that WakeLockController was merged into WakeLock itself. From an end-user perspective, though, the API now looks like a mix of the old, navigator-based API and the one we implemented a few months ago: * The main idea is that WakeLock.request() no longer returns a promise that does not resolve while the lock is held, as that is not very intuitive. Instead, it returns a new WakeLockSentinel object. * WakeLockSentinel is a new interface that can release() a lock and receive "release" events. * We do go back to a Navigator-based API, but we also support WorkerNavigator. * There is no WakeLockRequest interface or state tracking in the WakeLock interface. * WakeLock.requestPermission() was removed. * Consequently, we now have a WakeLockEvent interface. The changes to the spec still need to land, but there is some rough consensus on what the API should look like, and we do not want to miss the M79 branch cut. Bug: 257511, 1010162 Change-Id: If1baed914ccd9eb7103a1bb71a40529976777ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849683Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#705632}
-
Lei Zhang authored
SitePerProcessAutoplayBrowserTest.PropagateUserGestureFlag is flaky. TBR=mlamouri@chromium.org Bug: 1014175 Change-Id: I0de4853597b0c6b1060218838c3278a43a67efc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860678Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705631}
-
Nico Weber authored
Microsoft rc.exe has its built-in preprocessor that has a limit of 32 characters for macro names. We already use clang-cl's preprocessor for our own rc that we use in cross builds. That works well, so feed the output from that into Microsoft rc.exe too. This allows removing some workarounds for BUILDFLAG() use in .rc files and shouldn't change behavior. Bug: 961769 Change-Id: I21ea2e62323a27c61f8c79c267814ed2f522eded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860097 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705630}
-
Klaus Weidner authored
Currently, WebXR's immersive-ar mode requires Android O due to using SharedBuffer image transport which needs AHardwareBuffer support. On Android N, use a Surface/SurfaceTexture pair instead. This is based on the existing XR frame transport method SUBMIT_AS_MAILBOX_HOLDER that's also used by the GVR immersive-vr backend. Bug: 1012972 Change-Id: I87759daf7d317873dea0fb569fffaee379783ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854802Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#705629}
-
Jan Krcal authored
This CL makes sure ToolbarIconContainerView destroys its children before its own observer list (this is needed so that childred that observe ToolbarIconContainerView can remove themselves from the observer list). Bug: 1013418 Change-Id: Ica6b8c89b9d0683933c84d65faf6f9a4641e55b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860339Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705628}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/50dc0de928ba..8dda56311c7d git log 50dc0de928ba..8dda56311c7d --date=short --no-merges --format='%ad %ae %s' 2019-10-14 fmayer@google.com Merge "Minor heapprofd doc improvements." 2019-10-14 treehugger-gerrit@google.com Merge "Remove usage of 'awk ${print 2}' from webUSB control." Created with: gclient setdep -r src/third_party/perfetto@8dda56311c7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib09ce18b9d62236a6ade9c35d31436b93b1f5afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705627}
-
chrome://test/dpapad authored
Also remove unnecessary |extraLibraries| since those are included for every WebUI test anyway. Bug: None Change-Id: I0da58060b0ea8b5218c9f65d4179d8f631f0bfc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857185 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705626}
-
Lei Zhang authored
This TwoClientPreferencesSyncTestWithSelfNotifications test case is flaky. TBR=mastiz@chromium.org Bug: 1012688 Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705625}
-
Aaron Tagliaboschi authored
Change-Id: I25a939d855620ce60fd0cec9e2503d717019f23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860096Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#705624}
-
Matt Jones authored
Bug: 805160 Change-Id: Ic15b71f86c68bb3ffad5d2a08996637aa9a93729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849269Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705623}
-
siashah authored
Bug: 980716 Change-Id: I45df011bf61cd4030b3a7f360d90f096026fdedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857041Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#705622}
-
Kelvin Jiang authored
This is CL 1/2 which moves the construction of RequestAction from RulesetManager to RulesetMatcher. This is done in order to attribute RequestActions to the matched rule it was constructed from. Bug: 1009887 Change-Id: Ife65eec7b9a81b589753eeac7b4a712a300ff262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834561 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705621}
-
Ahmed Mehfooz authored
This CL fixes the check for the message center being visible. Also adding a unit test to cover the case that caused the crash. Change-Id: I37b82b4d3cd08c6c8823dab0b7ddd9342a3c7673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857378Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705620}
-
Guido Urdaneta authored
Add original owners from content/renderer/media/webrtc to the new directories in Blink. Bug: 787254 Change-Id: I8981c3e171f47191223bc16872d7ba85fb635b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860027 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#705619}
-
Lei Zhang authored
The test is flaky on all desktop platforms, not just Linux/ChromeOS. TBR=dgozman@chromium.org Bug: 1000654 Change-Id: I63893e3835fad57b6983798a999b64902e7aeb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860324Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705618}
-
Lei Zhang authored
Similar to copyBetweenWindowsDriveToUsb, copyBetweenWindowsLocalToUsb and other related tests are also flaky. Disable them all, but this time only in debug builds. TBR=austinct@chromium.org,noel@chromium.org Bug: 1008909 Change-Id: I11f621367dd981787296544e30b8b532633cfdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860501Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705617}
-
Lei Zhang authored
This reverts commit e4dc12db. Reason for revert: Broke the tree: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/55541 Original change's description: > Add disable_secure_dns support to net/quic, net/http, and net/spdy. > > This change is a no-op. It puts into place the needed support in the > net/quic, net/http, and net/spdy directories for disabling DoH. A follow- > up cl will add a similar field to URLRequest. > > Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d > Bug: 1012268 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#705610} TBR=mmenke@chromium.org,dalyk@google.com Change-Id: I123d6d067d010e1710dd20a87f5accd54192b5b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860685Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705616}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d232f656. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I883a822ec3c70a2c07ca1e187fd6d601db185f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859840Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705615}
-
Sven Zheng authored
Bug: 1010568 Change-Id: I34de7b8c34964dc46cd9f5e925ee31f2f7c7f4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856730 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#705614}
-
Sasha McIntosh authored
Support for the current |best_fourcc| value of kCVPixelFormatType_422YpCbCr8 by FourCCToChromiumPixelFormat was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1732895. This change updates the |best_fourcc| to a supported format. Bug: 1012204 Bug: 988538 Change-Id: I4cbff3bdf495806f7290bd2edf2c33cee5d67925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853864 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705613}
-
Tommy Steimel authored
This CL adds gesture handling to the GMC dialog to allow users on touch devices to dismiss sessions by swiping. Bug: 1008905 Change-Id: I115a21ca37af7d128478139d25a1bc0dae4c0c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829671 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#705612}
-
Michael Lippautz authored
Blink must not report back memory changes during Scavenge (== non-tracing GC) as those could trigger (or finalize) full garbage collections. GC while GC is not supported and we have to delay the reporting in those scenarios. Bug: 1014078 Change-Id: I24ecbfa93639b67f54bbfd103c7b7753ef9e52aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859973 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#705611}
-
dalyk authored
This change is a no-op. It puts into place the needed support in the net/quic, net/http, and net/spdy directories for disabling DoH. A follow- up cl will add a similar field to URLRequest. Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d Bug: 1012268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#705610}
-
Mike Dougherty authored
On devices, since iOS 13.1, the page needs time to stabalize. Without this wait, getting the location of the element will be incorrect. Bug: 1012326 Change-Id: Iae60e2db1e2a6c438c3ab5541f9d8fa7c2b0199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852024 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705609}
-
Hesen Zhang authored
- Change based on accessibility review Bug: 1012450,952425 Change-Id: I0eb9deef8e5d731a59a421ffbc42b40e2fc938c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857600 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705608}
-
Anthony Polito authored
This reverts commit 5d17f9ea. Reason for revert: breaks builds when looking for ../../chrome/app/theme/google_chrome/BRANDING Original change's description: > Add is_chrome_branded to kythe codesearch builds > > Bug: b/140589523 > Change-Id: I01e015551729dc440187735fd689486eaabd6cf8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838053 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Anthony Polito <apolito@google.com> > Cr-Commit-Position: refs/heads/master@{#704808} # Not skipping CQ checks because original CL landed > 1 day ago. TBR=agable@chromium.org Bug: b/140589523 Change-Id: Iba284db236c97c0400adb8d0371182135227b947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857518Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#705607}
-
Ionel Popescu authored
This feature flag is still being used. Bug: 959883 Change-Id: I7d1595454a271c6beba854f3a0565e40c1bc7928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857862Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705606}
-
Olivier Yiptong authored
When a permission prompt is shown, the user should have the URL bar visible so that they can make an informed decision before accepting or denying the request. This change exits fullscreen mode, which would hide the URL bar, when a permission prompt is shown. BUG=1007038 Change-Id: I6d2b600390b0297d0711de48b76fa492f16a71b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854789Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#705605}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5abb9b7c5d0c..033004652faf git log 5abb9b7c5d0c..033004652faf --date=short --no-merges --format='%ad %ae %s' 2019-10-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@033004652faf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I515a23dcecbce587b996c1b4482fdfe7baf7be54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705604}
-
Kai Ninomiya authored
I can't remember why I originally moved this to NeverFixTests, but I don't think it's necessary anymore. Bug: 984818 Change-Id: Id28508ca3e034bfb06c0f671ababc6abfb691ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858344 Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#705603}
-
Kuang-che Wu authored
Bug: chromium:992979, chromium:1009074 Change-Id: I7c0a1e5a3bfcea05314db3ab57de518b7acaf5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855628 Auto-Submit: Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705602}
-