- 24 Jun, 2018 12 commits
-
-
jdoerrie authored
This change introduces the possibility to query a FidoBleDevice whether or not it is currently in pairing mode. In accordance with the CTAP spec this is done by looking at the advertisment data flags if possible, and falling back to investigating service data if required. Bug: 763303 Change-Id: I373151a10d63e83ca2ac57f7b53c1269b9d60cfc Reviewed-on: https://chromium-review.googlesource.com/1096234Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569929}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3cb3fb81..fa532590 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ief67196bf237f06ffe129819398cc4b400372683 Reviewed-on: https://chromium-review.googlesource.com/1112948Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569928}
-
Daniele Castagna authored
HardwareDisplayPlaneManagerUnittest allocated CTMs with new, while they are deleted with free. This patch fixes that so that we can run ozone_unittests with asan on trybots. Bug: 855588 Test: ozone_unittests Change-Id: If5827d38b34cb8df2f56c770e8f9d28c587c022a Reviewed-on: https://chromium-review.googlesource.com/1112964Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569927}
-
Blake O'Hare authored
ChromeLauncherController is resetting the virtual keyboard when the active user changes. However, the SessionController (which is already in ash) can have an observer that can listen to the same event. By making the VirtualKeyboardController a SessionObserver, we can move the keyboard reset to the other process to make it mustash-friendly. Bug: 826391 Change-Id: I70b622105c3bf6dd415b1eee5f0521a38b6d1bf1 Reviewed-on: https://chromium-review.googlesource.com/1100672 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#569926}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7454cbdd1596..5f0cc0e06651 git log 7454cbdd1596..5f0cc0e06651 --date=short --no-merges --format='%ad %ae %s' 2018-06-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@5f0cc0e06651 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I86cc73faa5e8270a7e61977a6a876f78763ad82a Reviewed-on: https://chromium-review.googlesource.com/1112927Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569925}
-
jonross authored
Updating testing filters for the Mojo Android FYI bot. Surface Sync is a new consistent failure. Viz Android are failures that occur on all Viz platforms, and are now confirmed on Android as well. TBR=fsamuel@chromium.org TEST=surface_sync_content_browsertests, viz_content_browsertests Bug: 849746 Change-Id: Id1ba7e03aa28f28b21e59c694a7cb6f39b9d843c Reviewed-on: https://chromium-review.googlesource.com/1112966Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569924}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I851adfaa79ecfda41127f18fb304b9275131c7fd Reviewed-on: https://chromium-review.googlesource.com/1112962Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569923}
-
Alexander Alekseev authored
This implements shared style for the updated UI. Major changes: 1) oobe-dialog slot="header" replaced with two slots: "title" and "subtitle". 2) shared oobe_dialog_parameters.css removed, all parameters are styled in oobe-dialog CSS. 3) All dialogs could be displayed both full-screen or windowed. 4) If any dialog is full-screen, all subsequent will also be displayed with full-screen style. 5) Elements hosting oobe-dialogs must implement OobeDialogHostBehavior. Bug: 852034,852043, 852041 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id282d2f3385def8fc6a376bc85fc32734653e466 Reviewed-on: https://chromium-review.googlesource.com/1111025 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569922}
-
Yuli Huang authored
CrOS Camera app needs to be whitelisted to use fileManagerPrivate API to show the taken photo/video under Downloads/ and be notified for their changes under Downloads/. BUG=854551 Change-Id: I0ef7654db7b1ac504e051bf64ef9c30e0cb375a4 Reviewed-on: https://chromium-review.googlesource.com/1109674Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569921}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2cc67b5c3a7..7454cbdd1596 git log c2cc67b5c3a7..7454cbdd1596 --date=short --no-merges --format='%ad %ae %s' 2018-06-23 egdaniel@google.com Add legacy flag for vulkan interface for flutter. Created with: gclient setdep -r src/third_party/skia@7454cbdd1596 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: If5faf5a8623477e838e8d7df978057f3785c7b76 Reviewed-on: https://chromium-review.googlesource.com/1112141Reviewed-by:
-
Xianzhu Wang authored
For SPv175, we use a display item type instead of the paint phase. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1dfaf54f832e5179b96601bf9654b59a90d7df34 Reviewed-on: https://chromium-review.googlesource.com/1111686 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569919}
-
Xianzhu Wang authored
Also removed the stale expectation files on mac TBR=thakis@chromium.org Bug: 855222 Change-Id: Iaaaebfcb5dc00c0d1c42f3a2ecbb5bbfcbbbf57c Reviewed-on: https://chromium-review.googlesource.com/1112949Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569918}
-
- 23 Jun, 2018 28 commits
-
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If07f02931603c49223106373ebf039ab48f30cae Reviewed-on: https://chromium-review.googlesource.com/1112947 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569917}
-
Nico Weber authored
This reverts commit 981a543f. Reason for revert: These tests have been failing since they were added: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/20683 Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG=825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} TBR=mlamouri@chromium.org,beccahughes@chromium.org,futhark@chromium.org Change-Id: I32fbe3682558bdd2d117c8f647750e5d8bcbf740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825890 Reviewed-on: https://chromium-review.googlesource.com/1112982Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1deead13f98b..abae09e75336 git log 1deead13f98b..abae09e75336 --date=short --no-merges --format='%ad %ae %s' 2018-06-23 vapier@chromium.org pylintrc: drop unused warnings 2018-06-23 xixuan@chromium.org chromeos_config: Add enable_skylab_hw_tests for migration. 2018-06-23 dgarrett@google.com commands: RunBranchUtilTest -> RunLocalTryjob Created with: gclient setdep -r src/third_party/chromite@abae09e75336 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:854862,chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I75ca467c1b3140a61ac4a5d38292e541ad0d23d8 Reviewed-on: https://chromium-review.googlesource.com/1112140Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569915}
-
Jun Choi authored
Current Cancel operation on FidoHidDevice does not conform to behavior defined by the CTAP spec. More specifically, CTAP spec mandates that once Cancel operation is invoked, all pending transactions must be deleted and cancel command must be sent before any remaining transactions. This is not how current FidoHidDevice works. Currently FidoHidDevice will simply add Cancel command packet into a queue and wait for prior transaction to finish before sending Cancel command to the device. Bug: 833806 Change-Id: I66f67e1ff36aa724c0340fd6630a941da911921b Reviewed-on: https://chromium-review.googlesource.com/1111617 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569914}
-
George Burgess authored
This reverts commit 5e32cab2. Reason for revert: The cause of the failures has (hopefully) been fixed. Original change's description: > Disable several failing blink_perf.parser stories on Nexus 5X webview > > NOTRY=true > TBR=nednguyen@chromium.org > > Bug: 851539 > Change-Id: Ia51f717aa8c7ca47b47007fa4aa5077767a86e91 > Reviewed-on: https://chromium-review.googlesource.com/1095676 > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566043} Bug: 851539 Change-Id: I69b8f51a4e91171448f6d61c052168deaa3dc222 Reviewed-on: https://chromium-review.googlesource.com/1112181Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569913}
-
Sergey Ulanov authored
Also enabled gl_image_native_pixmap.cc on Fuchisa. ExportHandle() is currently stubbed as NOTIMPLEMENTED. Bug: 852011, 766360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2978a320fef928f32b3ff27473c593293a8168d6 Reviewed-on: https://chromium-review.googlesource.com/1112592Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569912}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b59b36610e39..27d3aa2ed234 git log b59b36610e39..27d3aa2ed234 --date=short --no-merges --format='%ad %ae %s' 2018-06-23 thestig@chromium.org Fix some nits from commit 27cf78d8. Created with: gclient setdep -r src/third_party/pdfium@27d3aa2ed234 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idff059fc4113b6ed1958ead821952a1b3261bcd1 Reviewed-on: https://chromium-review.googlesource.com/1112231Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569911}
-
Nico Weber authored
Bug: 855269 Change-Id: I8ab4534f2ede8c0b8d2f3348309046ee0de9d164 Reviewed-on: https://chromium-review.googlesource.com/1112043Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569910}
-
Mathieu Perreault authored
- Also updating a string per UX writer, to add ellipsis to "Confirming card" - Reordered functions to match header. - Exposing Verification Result from controller Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-interactive Change-Id: I463709247157bd9a82e708e510d14f1b182a58db Reviewed-on: https://chromium-review.googlesource.com/1105517Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569909}
-
Eric Willigers authored
text-indent values such as "each-line calc(2em + 3ex)" and "each-line hanging -5vh" now parse successfully and serialize in canonical order: <length-percentage> hanging? each-line? Spec: https://drafts.csswg.org/css-text-3/#text-indent-property BUG=855268 Change-Id: I17fece32135140637880a47303062fa8b23c291c Reviewed-on: https://chromium-review.googlesource.com/1111177 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569908}
-
Kevin Marshall authored
fuchsia_package_runner() targets can now specify multiple packages for deployment, using the "package_deps" argument. Bug: 855242 Change-Id: Ib9bb67be14d6b120ea2bf008edd2941d14c36e46 Reviewed-on: https://chromium-review.googlesource.com/1111274 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569907}
-
Han Leon authored
We're saving the raw pointer of an EmbeddedWorkerInstance in a base::ScopedObserver member of ServiceWorkerRegisterJob, but, the EmbeddedWorkerInstance is not guaranteed to outlive the ServiceWorkerRegisterJob, it may get destroyed and lead to a situation that ServiceWorkerRegisterJob holds a stale pointer, which could lead to crash. This CL lets ServiceWorkerRegisterJob listen OnDetached() from the EmbeddedWorkerInstance so it can be aware that the EmbeddedWorkerInstanc pointer is going to be stale and should be removed from the source list of base::ScopedObserver. This fix should be safe enough now, but in longer term we'll try to remove EmbeddedWorkerInstance::Listener interface and let EmbeddedWorkerInstance talk directly to its owner ServiceWorkerVersion, then let ServiceWorkerRegisterJob observe the ServiceWorkerVersion it's manipulating to get OnScriptLoaded() notification. BUG=854063,855394 Change-Id: I9c5a46beda1aafff32a86b9055be2b53d50fda97 Reviewed-on: https://chromium-review.googlesource.com/1112904 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569906}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dff3cfd6..3cb3fb81 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7079939e9b46e9fb46b5d7be8615e3f01dab9a84 Reviewed-on: https://chromium-review.googlesource.com/1112859Reviewed-by:
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/63256264a978..1c2430a2e13a $ git log 63256264a..1c2430a2e --date=short --no-merges --format='%ad %ae %s' 2018-06-21 niva213 hbd lpf sse2 perf and code quality improvement 2018-06-21 ddvfinite Speed up av1_optimize_b 2018-06-21 zoeliu Merge two flags to one for hierarchical structure 2018-06-22 anorkin [NORMATIVE] level_idx=31, initial_display_delay 2018-06-22 birkbeck Clear {cb,cr}_grain_block when there is no scaling function 2018-06-21 sachin.kumargarg Add ARM Neon optimization of aom_highbd_dc_predictor Created with: roll-dep src/third_party/libaom/source/libaom BUG=chromium:783519 TBR=tomfinegan@chromium.org Change-Id: I86949822c95cd18d2739ca9c3c99fbdc9d0028cd Reviewed-on: https://chromium-review.googlesource.com/1112944Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#569904}
-
Michael Thiessen authored
Bug: 854626 Change-Id: I97da35144ee3a8de2c4d6e04d8456dc56b0fc076 Reviewed-on: https://chromium-review.googlesource.com/1112583Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#569903}
-
Evan Stade authored
Update the last few tests that used it to pass the browser context around in other ways. TBR=sky@chromium.org Bug: 826374 Change-Id: Ic6de0e33b8ccc20ab84a0dcf8309cc103595f5f5 Reviewed-on: https://chromium-review.googlesource.com/1112666 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Previously, to let the painting layer of a repeating table header/footer in paged media initiate multi-fragment painting, we created fragments in the painting layer. This caused several problems: - The fragments didn't have proper fragment clips, causing non-fragmented contents to be painted multiple times. It's also not feasible to create fragment clips for the forced fragments on the painting layer because we couldn't insert them into the clip tree. - The previous "if (paint_info.FragmentToPaint(layout_table_section_)) return;" in TableSectionPainter caused nested repeating header/footer not repeated. Now don't fragment painting layer of repeating table header/footer in paged media. Instead, let the repeating table header/footer repeat by itself when needed. Bug: 852773 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1172a334b5021eb7e987404bb72d9b841a4d39d4 Reviewed-on: https://chromium-review.googlesource.com/1112578 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569901}
-
Reilly Grant authored
The requestDevice() IPCs can race with navigation. This change ensures that choosers are closed on navigation and adds browser tests to exercise this for Web Bluetooth and WebUSB. Bug: 723503 Change-Id: I66760161220e17bd2be9309cca228d161fe76e9c Reviewed-on: https://chromium-review.googlesource.com/1099961 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569900}
-
Jacob Dufault authored
It is possible for the PIN to timeout while on the lock screen. Bug: 855629 Change-Id: Ib23cebdec84bb4713b7fcb78c2f72d6877d6d859 Reviewed-on: https://chromium-review.googlesource.com/1112207 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#569899}
-
Mounir Lamouri authored
Bug: 855883 Change-Id: I383e660319c86bf64872d2183cb36998cabbffe8 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1112945Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569898}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3524d99338e48de260f1ff7acf7fa2cda537ed10 Reviewed-on: https://chromium-review.googlesource.com/1112313 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569897}
-
Steve Kobes authored
The first is redundant with PLSA::ScrollsOverflow; the other is unused. Also remove LFV::GetScrollingReasons, which was used in a confusing way by MainThreadScrollingReasonsPerFrame. Bug: 823365 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff0e8dae4bf80979868f5718427856d2efff7575 Reviewed-on: https://chromium-review.googlesource.com/1112066Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73be50da2a1f..c2cc67b5c3a7 git log 73be50da2a1f..c2cc67b5c3a7 --date=short --no-merges --format='%ad %ae %s' 2018-06-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c2cc67b5c3a7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I5d565acb96cbd8973ab678db7252f417908520b9 Reviewed-on: https://chromium-review.googlesource.com/1112821Reviewed-by:
-
sczs authored
- Checks the IndexPath instead of the Cell on canEditRow, the previous method was causing new cells not to be on edit Mode when the table did was on edit Mode. - Moves back the editingCell setup to cellForRowAtIndexPath (like legacy) since it was crashing on willDisplayCell. - Creates a test to check the previous case. Bug: 854185 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4f7b27a6a48d48d26a68b9297a4b17e535a542f Reviewed-on: https://chromium-review.googlesource.com/1112675Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569894}
-
Mitsuru Oshima authored
BUG=788782 TEST=manully tested with gtk3-demo Change-Id: I4a381b9350675d4e5407b378fbe07ae9de64fe8a Reviewed-on: https://chromium-review.googlesource.com/1108558 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569893}
-
Morten Stenshorne authored
-webkit-margin-collapse is a shorthand for -webkit-margin-before-collapse and -webkit-margin-after-collapse (and there's also -webkit-margin-top-collapse and -webkit-margin-bottom-collapse that will only work in horizontal writing modes). These are all about controlling whether we should collapse block-direction margins (default), separate them, or discard them completely. If we separate margins, we'll separate (otherwise) adjoining margins before the margin from the margin in question, AND separate the margin in question from (otherwise) adjoining margins after it. If we discard a margin, we'll discard all (otherwise) adjoining margins, both before and after the margin in question. There's no spec. This is based on the behavior in legacy Blink / WebKit. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I91c869013d11a0ce9327908ce724d518a19209e8 Reviewed-on: https://chromium-review.googlesource.com/1111117 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569892}
-
Ned Nguyen authored
NOTRY=true NOTREECHECKS=true TBR=thakis@chromium.org Bug: 855689 Change-Id: Ie4c77e59bd642d581a73954723470d5920ae8865 Reviewed-on: https://chromium-review.googlesource.com/1112946 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Ned Nguyen authored
This reverts commit 3161a1df. Reason for revert: the roll wasn't causing the test failure. THe test is also disabled in https://chromium-review.googlesource.com/c/chromium/src/+/1112946 Original change's description: > Revert "Roll src/third_party/catapult 34451063bc29..2e625dcb82db (1 commits)" > > This reverts commit bca5514b. > > Reason for revert: TestShardingMapGenerator.testGeneratePerfSharding > fails on many mac bots, e.g. here: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33316 > > Error: > [18/22] core.sharding_map_generator_unittest.TestShardingMapGenerator.testGeneratePerfSharding queued/b/s/w/ir/.swarming_module_cache/vpython/fe1f6b/bin/python: can't open file 'tools/perf/generate_perf_sharding': [Errno 2] No such file or directory > > File is probably missing from isolate and needs to be in some gn data list. > > Original change's description: > > Roll src/third_party/catapult 34451063bc29..2e625dcb82db (1 commits) > > > > https://chromium.googlesource.com/catapult.git/+log/34451063bc29..2e625dcb82db > > > > > > git log 34451063bc29..2e625dcb82db --date=short --no-merges --format='%ad %ae %s' > > 2018-06-23 nednguyen@google.com Disable MEMORY_AMOUNTS diagnostic > > > > > > Created with: > > gclient setdep -r src/third_party/catapult@2e625dcb82db > > > > The AutoRoll server is located here: https://catapult-roll.skia.org > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > > > If the roll is causing failures, please contact the current sheriff, who should > > be CC'd on the roll, and stop the roller if necessary. > > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > > > BUG=chromium:854676 > > TBR=sullivan@chromium.org > > NOTREECHECKS=true > > > > Change-Id: If0ebad6d392890f8aaf4b2336dad28367d83973d > > Reviewed-on: https://chromium-review.googlesource.com/1112138 > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#569878} > > TBR=sullivan@chromium.org,nednguyen@google.com,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com > > Change-Id: I6e51636a5151616cc5ade6f3ddd4a556d05303fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:854676 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1112978 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569880} TBR=thakis@chromium.org,sullivan@chromium.org,nednguyen@google.com,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I64954dacf7cc9ef68610f479f34ca9bf5eec7189 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:854676 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1112919Reviewed-by:
-
