- 18 Jul, 2019 40 commits
-
-
Gyuyoung Kim authored
After removing CString in blink, the performance degradation(1.6%) has been reported on Android Nexus6 WebView Perf bot with system_health.memory_mobile benchmark. To fix the performance regresssion, this CL makes FontFaceCreationParams::Filename() return const std::string& to avoid a copy of std::string, And also, this CL moves |fallback_data.filename| to |fallback_font->filename| by using std::move in FontCache::GetFontForCharacter(). Bug: 974762, 950077 Change-Id: I7e08f56e58b96d326982e7d4d26866d4cafab881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701628 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678541}
-
Satoshi Niwa authored
BUG=chromium:983047 TEST=Opt-out ARC and check if SelectFileDialog is closed Change-Id: I3301d3c66b621f5cfbf1f0823bf4e9a17d6a57d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705910 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#678540}
-
Vlad Tsyrklevich authored
crashpad_tests should work on Linux and will help keep MSan, among other tests, from regressing. Bug: 932205 Change-Id: I488a0c6e0f3c1d51021b4ed7312ab703c53bae92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684301Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#678539}
-
Kai Ninomiya authored
Bug: 985135 Change-Id: I820dc3964671bbf87e9e0cbb186ea20528c0b8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707575Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#678538}
-
Mason Freed authored
This DCHECK could be fired in a few corner cases that are actually correct. Removing it, and adding a comment. Bug: 983157 Change-Id: Ibec4f881d4a9a9c538f22f6b24187a164e15648e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707067 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678537}
-
Min Qin authored
If a download is resumed and the server immediately returns an error response that requires the download to restart, |download_file_| is not created. As a result, resuming the download will not clear up the current path, and causing the DCHECK to fail. BUG=982819 Change-Id: Ibe0832e79ca80bd2e76deba454dab2c3d8cb2be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706781 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678536}
-
Johannes Henkel authored
New revision: d114a62e144cdfdae697fe0af6581ce39a31af37 Change-Id: I80987378dfe7b65951cfba945c5f92fb0a68d32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707170 Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#678535}
-
Antonio Gomes authored
... from content/common/media. This is part of phase 4.5 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ TBR=clamy@chromium.org (for content/browser mechanical changes) BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4211d558b0c1f608537518b7a6a7b833e0e32a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706549Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#678534}
-
Yuly Novikov authored
TBR=kbr Bug: 981736 Change-Id: Ie76816fd34b898413db4018515208f9b34837c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707808Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678533}
-
Austin Tankiang authored
Bug: 735208 Change-Id: I0deb6bc039b23401b6b3c5549d6528e0895f5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705911Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#678532}
-
dpapad authored
This was residing in util.js and was used by icon.js (3 calls) and ntp4/new_tab.js (1 call). Given that this is icon related, moving to icon.js and updating ntp4/ accordingly. Rationale: Generic "util" files are generally an anti-pattern, and often end up as a bag of unrelated functionality. Given that icon.js already exists and holds icon-related functionality, moving getUrlForCss() over there makes sense. Bug: None Change-Id: I586b2653ba09d6d144f1d99aa9ab331f96095726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706807Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#678531}
-
Jack Steinberg authored
This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue #48 on the explainer here https://github.com/jackbsteinberg/std-toast/issues/48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug: 972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678530}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/faec9ebf..be95495a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c9c352bf8b86181820cc584bd3d32eefaa9f267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706454Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678529}
-
Patrick To authored
To try out this code with the Microsoft OpenXR Runtime in Chromium, perform the following steps. - Install 'Mixed Reality OpenXR Developer Preview' from the Microsoft Store - If prompted also download the compatibility pack Add the following to custom_vars in .gclient, located at the root of the chromium clone: "checkout_openxr": True Add the following to args.gn, located in the out folder: enable_openxr = true gclient sync and build Once you've built and installed Chromium go to about:flags and: - Enable WebVR or WebXR - Enable 'OpenXR Support' Bug: 976430,976436 Change-Id: I8a7c69b3a13349aa9e083d6206121b69a1f724cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688443Reviewed-by:Bill Orr <billorr@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678528}
-
ssid authored
The java trace event strings cannot be checked for string literals at runtime. So, add a compile time check to verify that all uses are passing in string constants. A few exceptions are marked with suppress warnings. Total overhead of running the plugin is about 100ms with 20ms measurement overhead. BUG=984827 Change-Id: Ia10fe6f9f255c7402936a287bdde8b86684dbd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705518Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#678527}
-
Kyle Milka authored
The background reset event was being logged twice. Move the logging into searchbox_extension instead of JS. Bug: 984752 Change-Id: Ibb42186dc6cb9054a3785b7818dfd99ff9f33ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707193 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678526}
-
Xi Han authored
When comparing the metrics Servicification.Startup2 and Android.NativeBackgroundTask.TaskStarted.ReducedMode, we see a large gap for browser's cold startup in ServiceManager only mode. It is unclear whether Servicification.Startup2 loses UMA data when running in ServiceManager only mode or Android.NativeBackgroundTask.TaskStarted.ReducedMode overcounts the number of tasks that started native. In this CL, we add the metric Servicification.Startup3. The UMA data is cached in the SharedPreferences before full browser starts, which is the method that Android.NativeBackgroundTask.TaskStarted.* use. Thus, we can verify whether UMA data is lost in ServiceManager only mode and avoid this loss. Bug: 984559 Change-Id: Id0ca8adc9b1ee9c04e913123962775e4774b6bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702862Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678525}
-
Wez authored
This reverts commit d6fe2c47. Reason for revert: This causes us to lose backtraces from crashes under the runner scripts. Although the output can be re-enabled via the --system-log-file option, that bypasses symbolization so is also not useful. Original change's description: > [Fuchsia] Remove system logging logic from RunPackage() > > Previously runner scripts implemented system logs collection in two > enabled by default, but could be turned off with --exclude-system-logs. > (2) was disabled by default, but can be turned on with > --system-log-file. (2) is enabled on the bots now. This CL removes (1) > in order to remove noice from runner script output and to simplify code. > When necessary --system-log-file=- flag can be used to get the previous > behavior. > > places: (1) in RunPackage, and (2) in Target implementations. (1) was > Change-Id: I787ff4d8ac54f5c0cd13d0e9d8a71aad05cdd45c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674668 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672180} TBR=kmarshall@chromium.org,sergeyu@chromium.org Bug: 984993 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib84af3efcb5c5859938328977a2aecb4a5428422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707051Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678524}
-
Takuto Ikuta authored
Test from this builder consumes 23~24 machine hour in chrome pool per hour averagely. I took the stats from http://shortn/_EstLqOoMvH Bug: 954450 Change-Id: Ic6ea8f1f7d5b70c42d26853e3f7ce98fb3619633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703225 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678523}
-
Sam Sebree authored
The purpose of ModuleRecordResolver::GetHostDefined has been to convert from a Module Record to the corresponding Module Script, which previously happened to always be the [[HostDefined]] -- however that is no longer the case. The root cause of the divergence from the spec is that while the spec defines [[HostDefined]] as a field on the ES Module Record, the Chromium implementation chose to define it in Blink using ModuleRecordResolver. Now that the usage of [[HostDefined]] has been expanded for other purposes, this divergence is more obvious. Therefore we propose the following to make it clear that ModuleRecordResolver functionality does not correspond to the spec's concept of [[HostDefined]]: 1) Remove the spec reference comment: "// Corresponds to the spec concept "[[HostDefined]]"." from the GetHostDefined method. 2) Change the name of the ModuleRecordResolver::GetHostDefined to GetModuleScriptFromModuleRecord. This need for this CL was exposed by a related CL: https://chromium-review.googlesource.com/c/chromium/src/+/1694604 Change-Id: Ie020443d7618803e422cb833ac6e173cfabb045f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707468 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678522}
-
dalyk authored
Use a string constant for the User-Agent header and a wildcard for the Accept-Language header. This reduces the ability of providers to group traffic from a given user across connections but allows providers to trace the queries back to Chrome in debugging efforts. Bug: 878582 Change-Id: I9c51b7400640f7df7c0d51cb6290d6a37f564f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689398 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#678521}
-
Min Chen authored
Bug: 982950 Change-Id: I8e5a45f88daf23b7b64216e461454f97f99d3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704678 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678520}
-
sczs authored
- Adds a stop method to InfobarCoordinator that needs to be called by its subclasses. This nils the animatedFullscreenDisabler_ which prevents crashes while testing when trying to access it when BrowserState has been dealloced. - Adds more test cases to InfobarContainerCoordinatorUnitTests Bug: 961343 Change-Id: I9957968de7fe4f00f9e951c49bd39d885989ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703460 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#678519}
-
Shakti Sahu authored
Added field trial testing config for the new download backend provided by DownloadOfflineContentProvider. Also fixed the tests to run in this mode as well. Bug: NONE Change-Id: I44405ab964055dd884842411b90a3ba6e01262b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702593Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678518}
-
Natalie Chouinard authored
Typo was causing script to fail with: TypeError: __init__() got an unexpected keyword argument 'actino' Change-Id: I9ea784032a5a5a5e4fe7659804d797db799068f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707171 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#678517}
-
Drew Stonebraker authored
To indicate ownership. Bug: 983197 Test: Run browser_tests browser_tests Test: --gtest_filter=*.NoFindBarControllerOnBrowserCreate Change-Id: I9e028d89348114ac70be7a339b1b1cfb1ffc86d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706780 Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#678516}
-
Marijn Kruisselbrink authored
If the user selects a sensitive directory, a parent of a sensitive directory, or anything in certain extra sensitive directories, prompt the user to pick something else. Bug: 968851 Change-Id: I5ad144f89c823f20e766f463383959bc2a595327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696183Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678515}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db2e9fb45392..34f3be0173a3 git log db2e9fb45392..34f3be0173a3 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 ntfschr@chromium.org Devil: delete ANDROID_SERIAL before running tests Created with: gclient setdep -r src/third_party/catapult@34f3be0173a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:955155 TBR=sadrul@google.com Change-Id: I37ad9981328e635d1baddbd5f527ebf408a06f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678514}
-
Wez authored
This is a reland of ffa05b99 logging::LogMessage has a special-case to write LOG_ERROR messages to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and FATAL messages more visible, especially in tests. Restrict this behaviour to apply only when no log destinations are set, other than LOG_TO_FILE, so that binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam to stderr. Tested by adding a unit test for this case. Bug: 968387 Change-Id: Ibe3369eb2a47accdd17cd3cbb19c921de827ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704917Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678513}
-
Miyoung Shin authored
This CL resets own mojo binding in the internal function of ManifestManager::ContextDestroyed because Blink's GC objects that own mojo bindings manually need to reset the bindings to prevent use after poison issue. Bug: 979621 Change-Id: I38c4c3b532111f9ff721ef75b98d9e33a3f96441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705580Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#678512}
-
Ian Kilpatrick authored
ComputeAbsoluteHorizontal & ComputeAbsoluteVertical were almost identical. This added with the many writing mode switches generated a lot of code. This collapses most of the functions within the utils file to work in the logical writing-mode of the candidate. Change-Id: Ic678d5b46858fea402eda9839d1eb580dc30f7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681180 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678511}
-
Xida Chen authored
Right now the include rules for cc/paint is written in BUILD.gn, this CL write it in DEPS file to make it more clear. This CL should not cause any behavior change. Bug: None Change-Id: I6654d784fa135cc8e397f852388b6c2cbbd1cad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707251Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Min Chen authored
Delete related finch experiments: https://critique.corp.google.com/#review/258627188 Bug: 982537 Change-Id: I913809629a0fd92860ff5bf2983ec00d90203eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707238Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9dbb81f004b6..d6cc1fe099d4 git log 9dbb81f004b6..d6cc1fe099d4 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 cwallez@chromium.org Add an implementation of Result<const T*, E*> Created with: gclient setdep -r src/third_party/dawn@d6cc1fe099d4 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I30113a21546052fa5e5694ccef4ec5025c6f4ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707453Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/68fb145dca2b..9d03368411cc git log 68fb145dca2b..9d03368411cc --date=short --no-merges --format='%ad %ae %s' 2019-07-17 tsepez@chromium.org Replace UnownedPtr with RetainPtr to parser objects in fpdfdoc 2019-07-17 thestig@chromium.org Properly check for Windows path names in presubmit checks. 2019-07-17 thestig@chromium.org Properly run Python scripts on Windows in presubmit checks. 2019-07-17 thestig@chromium.org Add click_form.pdf test PDF. Created with: gclient setdep -r src/third_party/pdfium@9d03368411cc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:983867 TBR=pdfium-deps-rolls@chromium.org Change-Id: I6369b8090009bbb886506af1eb5d50a9415ef683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707378Reviewed-by:
-
Reilly Grant authored
This replaces the placeholder serial port icons with the "developer_board" icon from the Material Design icon set. Bug: 917204 Change-Id: Ic1b7e8f4a62aeb7b20e9e5152d1f708650500095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695846 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#678506}
-
Natalie Chouinard authored
Migrate the SingleCategoryPreferences and ChosenObjectPreferences from deprecated Framework preferences to Support Library preferences. This change also removes the complete fragment layout override used by Storage preferences in favor of simply appending the custom views to the bottom of the layout. Because this is the first fragment migrated which contains a ChromeImageViewPreference, it includes some duplication of code so that the compat and non-compat image view preferences can coexist. Once the remaining ChromeImageViewPreferences are migrated to support library, this duplicate code will be removed (https://crbug.com/967022). Bug: 968592, 929743 Change-Id: I3a0ed1ec24d2824d22cfecf50c2053bd62a45add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706540 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678505}
-
Sophie Chang authored
Bug: 969558 Change-Id: Iff43356255c9e72dd85db61ce971c41851ada005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707130Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678504}
-
Sergey Ulanov authored
The new test verifies that GpuMemoryBuffer implementations handle the case when buffer size doesn't match the underlying buffer. Bug: 957314 Change-Id: I7f1e0ead35d88390599d1edc2b719e5d81d48327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662830 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#678503}
-
Kelvin Jiang authored
Implement a new upgradeScheme action type for DNR rules. These rules are evaluated along with redirect rules as they are matched based on their specified priority. When an http or ftp request matches with an upgradeScheme rule, the request's scheme is changed to https. Bug: 974388 Change-Id: I0d9524e1c7d405a413868626da99e805c26ac601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674748 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678502}
-
