- 06 Nov, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium b680e487. With Chromium commits locally applied on WPT: 9a749c24 "[scroll-animations] Handle implicit 'auto' offsets correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7ec9f31d4fc2153623d578c83184e3354404bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522232Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824835}
-
Ewann authored
This CL replaces the font for the 'Tap to cancel' label. Bug: 1146347 Change-Id: I0e7922f7fb71c5e6d23c65781677f66b734a1810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523031Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#824834}
-
Jan Krcal authored
This reverts commit 6b7290b3. Reason for revert: memory regression on Mac (crbug.com/1146299) Original change's description: > [Profiles] Use new colored default avatars for taskbar badges > > Recently, all logic around profile avatars has been integrated into > ProfileAttributesEntry::GetAvatarIcon() incl. new features such as > colored default avatars. > > This CL updates code that generates taskbar badges on Windows to > delegate most of its logic to GetAvatarIcon(). Only the pieces needed > for obtaining ImageLoadStatus remained in this code. > > The only behavioral change is for non-GAIA avatars: high-res / > 2x windows old avatars are returned instead of low-res avatars. This > means more downscaling is needed than before. This will be addressed > by further CLs that will make GetAvatarIcon() respect preferred_size in > more cases. > > Bug: 1122559 > Change-Id: I5eecc7c6647dc78f9ff92d74edb64214a48e8e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514153 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824494} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I66f7b806a25b910d35b55f02805c4c8216049f55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122559, 1146299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521118Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824833}
-
Tanmoy Mollik authored
The sign in API uses CoreAccountInfo. So in the long run its better to use CoreAccountInfo for helper methods that interact with sign in API. This cl refactors AccountManagerTestRule so that the methods to add account and check signed in account return CoreAccountInfo. Bug: 1117006 Change-Id: I08245ea7b6325b1a62b3c27d53cc1f9877e9e75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521571Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824832}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia6afa428aa33860f425f2b934391fbdbfa3eceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824831}
-
Tanmoy Mollik authored
Updating the promo state forcefully is not required for these tests. This cl does not change the behavior of the tests. It changes how the environment is set up. This cl also enables testPersonalizedSigninPromoInBookmarkPage test. Bug: 1123478, 1133426 Change-Id: I4382f857ca1e91676404fce1a1c6e76c315e4493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517684Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I573f8984ef5f6aae3f7aa9990f4c29d492749962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522007Reviewed-by:
-
Friedrich [CET] authored
This reverts commit 264cfbbf. Reason for revert: The fix seems to be worse than the problem (see newly linked bugs). Original change's description: > [Desktop][PwdCheck] Even icon paddings > > With https://crrev.com/c/2260639, the paddings weren't distributed > evenly anymore (start/end padding) causing misalignments. > Additionally, the non-square icon dimensions caused rounding errors > increasing that effect. > > This CL ensures consistent paddings for RTL and LTR mode. Screenshots > are in the linked bug. > > Bug: 1144629 > Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823262} TBR=jdoerrie@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144629, 1145943, 1145931 Change-Id: Ifa4e0cd1cb705dec80968392506582c4894edd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521512Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824828}
-
Yuki Shiino authored
It turned out that a single function collect_forward_decls_and_include_headers does the job for IDL callback functions, IDL callback interfaces, IDL dictionaries, and upcoming IDL unions, so moves the function into codegen_utils.py to be shared among them. Bug: 839389 Change-Id: Ieee0e75388a90367c04da9c2adb40ce4bfad072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521873Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824827}
-
Regan Hsu authored
Accessing an empty sessions::SessionTab's |navigations| vector is resulting in an out of bounds access, causing BrowserTabsMetadataFetcherImpl to crash. Fixed: 1142562 Bug: 1106937 Change-Id: I0ec890135f6acafd61a39a7d06b52ef1956bed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522497 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824826}
-
Jan Krcal authored
The test CreateSignedInProfileSigninAlreadyExists is flaky on multiple platforms. Bug: 1144065 Change-Id: I6382c9d8757de99c1e5575a1101bdae647dc0cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521184 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824825}
-
Jan Krcal authored
This CL adapts terminology in the profile menu to the new terminology in the profile picker: namely replaces "people" with "profiles". It also removes two strings not used any more. Bug: 1063856 Change-Id: I467a6ee9a3e5c4eb2600fd47698ea74e6e3c4fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521510Reviewed-by:
-
Sigurd Schneider authored
DevTools CL: https://crbug.com/1057090 Bug: chromium:1057090 Change-Id: I95d92d1325db9c381a3423ca3abbdf7eb2cf924c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521814 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 2020-11-06 primiano@google.com Docs: add GitHub PR template and link to contributing docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I84469c4a4e58475b3dedaead9ca7696e8710f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522885Reviewed-by:
-
Bartek Nowierski authored
Bug: 11297512 Change-Id: I4d09c4705105e8ba66bbb4282cecebf2b33e56f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517351 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824821}
-
Gauthier Ambard authored
This CL updates the way the SSLBlockingPage are detecting the page for which an exception is being added by using the URL passed in the initialisation rather than the URL of the page sending the JavaScript command, as it is a file:// URL when using the new error page workflow. Bug: 1139303 Change-Id: Ia27a656ecdca52c16503b3c5d1b9cbf594543b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509518Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824820}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutFlowThread - LayoutMultiColumnFlowThread - LayoutMultiColumnSet - LayoutMultiColumnSpannerPlaceholder This CL has no behavior changes. Bug: 891908 Change-Id: I5af2d59eeed6fde57c8eff80ae1904083e0d030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521884 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824819}
-
Fredrik Söderqvist authored
Also make sure dynamic changes are reflected earlier by calling AnimationAttributeChanged() when the parsed attribute value changes. Previously it would only refresh when moving to the next value range, or otherwise invalidating animation state. Fixed: 1145548 Change-Id: I8ff82c02e6bf8e3cb82ef4d21e2381cbc99bcd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520783 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#824818}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9554189c71b..eb8e1e991bc9 2020-11-06 petermueller@chromium.org Increase contrast of pseudo-element syntax color 2020-11-06 szuend@chromium.org [markdown] Remove MarkdownView bridge 2020-11-06 wolfi@chromium.org Fix event propagation for link from FrameDetails to Network request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1145525 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3b806aa24c74374b8934a0e8dcdf6d2a6dc51ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521205Reviewed-by:
-
Irem Uğuz authored
This CL moves CertProvisioningSchedulerUserServiceFactory to chromeos::EnsureBrowserContextKeyedServiceFactoriesBuilt() which is meant to initialize browser context keyed service factories for chrome on chromeos. Bug: 1142449 Change-Id: I494ec23d1f3357912ae1b43a0c76ee3fa4eb06b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517560Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#824816}
-
Sylvain Defresne authored
When building for the "catalyst" environment, the selector -viewController is overloaded and the compiler is confused about the type of the value that is returned (as it can be either `UIViewController` or `NSViewController`). Add an explicitly checked cast to fix the compiler error about incompatible value type being stored in the array. Bug: 1138425 Change-Id: Ib5381993520bd1c2723439c6ad04c04d4d07f8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521732 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Henrik Boström authored
Pixel buffers originating from a CVPixelBufferPool are recycled when no longer in use, previously only tested by releasing the last pixel buffer reference and not touching the IOSurface. This CL tests what happens when we are retaining not references to the pixel buffer, but references to a pixel buffer's IOSurface or incrementing its use count. Outcome: - Retaining references (base::ScopedCFTypeRef<IOSurfaceRef>) to an IOSurface does NOT prevent recycling. - Retaining use count (IOSurfaceIncrementUseCount) to an IOSurface DOES prevent recycling. This behavior is now documented in pixel_buffer_pool_mac.h. Bug: chromium:1132299 Change-Id: Ibdcd3752a4467bc495eba4b543ecd73da1b2f41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520829 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#824814}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3dfaeeb00271..dc515d41bba9 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c7580ad to 52d33a46 (441 revisions) 2020-11-06 lexa.knyazev@gmail.com Metal: Fix typo in TextureMtl::bindToShader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I30ef867a463bd59f13045a42a197b0833d2d7334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522620Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b6b0f45ff05..973d145df865 2020-11-06 cwallez@chromium.org Make dawn_platform a component. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2c1e7bcf2cf22a34f7d3fa8b24d25b180995803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b8b4d61dd32f..a61d347b99c9 2020-11-06 landrey@webrtc.org Add logging about inserting diagnostics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146040 Tbr: skyostil@google.com Change-Id: Ic0cd8321c1f630fa86c61ec33612481a3e3fec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523021Reviewed-by:
-
Renjie Tang authored
All the code under this directory has been converted to using modern callbacks. Bug: 1007792 Change-Id: Ide911f55b785201c3327658a0b2c191392b6e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521970 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824810}
-
Devlin Cronin authored
It's only used in a single method. Just make it a function-local. Bug: None Change-Id: I0ebcc1f9a6ff8d724490e2e41aa7c4fe35096f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518196 Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824809}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abc1b79a1564..41bb19c60930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ife96b3fd197f0dda10db78ad40757f5c96b0d618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523014Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824808}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3268aab08638f3aafe9bd93734c83d7d4c95e281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522884Reviewed-by:
-
Mathias Carlen authored
Add a TabHelper feature to the list Autofill Assistant features. This feature is about restructuring ownership lifecycle relationships in the Autofill Assistant stack. Bug: b/169389571 Change-Id: Ic59d239adf25cad574b075d4f6aba616af4ae972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521146Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824806}
-
Gauthier Ambard authored
This CL makes sure that the WebView is no longer in the view hierarchy when the quicklook screen for AR is presented. When the WKWebView is added/removed from the view hierarchy, the visibilitychange event is fired. Bug: 1132085 Change-Id: I4043a4d3e5e24dc52aa467a82c7a62e78dd8a492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463567Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824805}
-
Javier Fernandez authored
As per Unicode UAX#9 L1.4, line trailing whitespaces should always have the direction of the paragraph no matter the direction they had before line breaking. To accomplish that, in inline layout algorithm CreateLine, when an NGInlineItemResult is only trailing spaces, we ignore the bidi level coming from the NGInlineItem, and just use the base direction of the line. This should fix the case of an LTR line with trailing space and pre-wrap in an RTL line that would end up putting the trailing space to the right of the last LTR line instead of to the left of the line. This fixes css/css-text/white-space/eol-spaces-bidi-002.html with width of 7 characters. It is still not fixing the case for 8 characters. Bug: 316409, 1142926 Change-Id: Iab220f79ba0b2526fd51d5341363cc8e9087e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505486 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824804}
-
Egor Pasko authored
The useSharedRelros() was renamed into provideSharedRelros(). Update stale comments to match the new name. No functional changes. Bug: None Change-Id: I278f1eccc650a24957a28825ffe4b107bda74577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521176Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824803}
-
Side Yilmaz authored
This CL removes deprecated GetLastUsedProfileKey function, while replacing last occurrence of the function with GetLastUsedRegularProfileKey method. Since both regular and off-the-record profile use the same offline content aggregator, it is safe to use regular profile in the factory class. Note: This CL does not change any code behaviour. Bug: 1041781, 1075562 Change-Id: Ida23b329e1f4da6ad37abefea7a49e6c4575420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519454Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824802}
-
Stanislav Pikulik authored
Unlike CLang in GCC with libstdc++ the expression std::max(alignof(T), sizeof(size_t))) is not recognized as an constant expression, which leads to the following error: requested alignment is not an integer constant. Bug: 819294 Change-Id: Ia1cad4d4b29b22960a7a824216f3d32d228f69cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521116Reviewed-by:
-
Yunke Zhou authored
Bug: 1134567 Change-Id: I8b278acaa2fab943ce136d7d7de578da7a63e992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520778Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#824800}
-
Findit authored
This reverts commit 37c7a793. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 824767 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM3YzdhNzkzMTA0NjU2ODAyYjRhNjkxNWYwYWI0YTRlZGQwNTY2YzkM Sample Failed Build: https://ci.chromium.org/b/8864392849428929040 Sample Failed Step: browser_tests Original change's description: > Put logic to disable Lite video on seek behind finch > > This CL moves the logic to disable lite videos on seek > behind experiment parameter, and also disables that by default. > > The param can be enabled again once we are reasonably confident > that it's not too aggressive and we can run an experiment to > verify that. > > Change-Id: I950b6d42750f11156ba0f0afad5989ac19832a7b > Bug: 1145646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519719 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824767} Change-Id: Ia1e4c0a2239fe64b3073ad3ebd5806cc41cfb51f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522621 Cr-Commit-Position: refs/heads/master@{#824799}
-
Peter Marshall authored
This CL plumbs in everything needed for a new HaTS Next survey that DevTools trigger. The survey config doesn't exist yet so this CL won't cause surveys to be shown yet. Bug: 1112738 Change-Id: I2ccd087ad510f849616bf567a14a96aa8f0f439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517719Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824798}
-
Mikel Astiz authored
By enabling this feature by default, it will cause that small fraction of users redownload all their sync bookmarks, in order to determine their authoritative/final GUIDs. With this, the migration phase is considered complete and bookmarks are guaranteed to use the same GUID across syncing devices for all users. Metric Sync.BookmarkModelMetadataClientTagState suggests the majority of sync clients have knowledge of all authoritative bookmark GUIDs, first introduced in M81 and gradually being populated in the commit path with https://crrev.com/c/1981610. For the remaining few clients, it may take very long to receive the authoritative bookmark GUIDs, presumably due to inactive users or users that have just upgraded from old versions of the browser. To resolve this faster, the alternative is to redownload all bookmarks from the server (including their authoritative GUIDs). This is precisely achieved with the feature toggle enabled by default in this patch. The actual impact of this change will be measured using metric Sync.BookmarksModelMetadataCorruptionReason bucket MISSING_CLIENT_TAG_HASH, which prior to this patch was dominated by the soft counterpart of this logic, already enabled by default (feature toggle InvalidateBookmarkSyncMetadataIfClientTagMissingWhileInSync). Change-Id: Id9957b420e78f5f8d4f1dbd6a5853cf14c31d560 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#824797}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604609790-b9d65003227996f3e38071970a83664b74f65abb.profdata to chrome-win32-master-1604629242-25a4011689f36cdb7c5ac3ab0a40a3994e18267e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a2604b855566115216172bbd36688e3fc2ed035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522952Reviewed-by:
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
