- 12 Sep, 2019 40 commits
-
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::WebTestBluetoothFakeAdapterSetter interface. Bug: 955171 Change-Id: Id2bafecb0801db9b6f2e2ae7f3af9bb17084090c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800867Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#696059}
-
Imranur Rahman authored
trait to CanRunWhenVirtualTimePaused. Renaming the virtual time queue trait should make it more clear and precise. Also, renaming should_use_virtual_time to can_run_when_virtual_time_paused. Bug=988403 Signed-off-by:
Imranur Rahman <ir.shimul@gmail.com> Change-Id: I378b2906a42fb77d5efe5d3b527375efa9f75fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792031Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696058}
-
Andrew Xu authored
Disable tests about overflow when scrollable shelf is enabled. Bug: 1002576 Change-Id: I248cc1261dc571eddcb4ef93982436f641f7d8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797043Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696057}
-
Steven Bennetts authored
This fixes the following: * Fixes an issue where the scanning spinner wasn't showing for cellular * Fixes logic causing the 'connectable' property to be ignored, except for Cellular (where it should be ignored), for 'Connect' button visibility. * Fixes incorrect logic determining when to show 'Allow Shared Proxies' * Only shows the 'Restricted IP' property when 'True' (matching previous logic). Bug: 853953, 1001996 Change-Id: I2461a4e6520f6016731c6d16920cf34d4ab897f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799802 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#696056}
-
jonross authored
This change re-enables the SnapshotBrowserTest.AsyncMultiWindowTest on Linux. While adding an early exit for variants running Vulkan. We currently lack a way to mark gtests as expecting to fail for certain flag variants. This will enable us to maintain coverage on Linux, while we separately investigate the root cause on Vulkan. TBR=kbr@chromium.org, jam@chromium.org TEST: SnapshotBrowserTest.AsyncMultiWindowTest Bug: 1003176, 1003375 Change-Id: I290f812546a9d1d02dceea40966b29f616562fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801053Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#696055}
-
Alex Clarke authored
PassedPromise is a binary size oprimization which lets us move out of line the overhead of the scoped_refptr<> constructor (which conditionally performs an AddRef). This reduces binary size by ~8kb across all the PostTasks. WrappedPromise is a non-base::internal wrapper for scoped_refptr<base::internal::AbstractPromise> which contains the API surface needed by TaskRunner implementations. Bug: 1729267 Change-Id: I3b29745c670edb7b56f206c3e52faaef3b06e498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781437 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#696054}
-
Ilia Samsonov authored
ClearLogoOnSignOut sometime fails due RunLoop exiting early. The initial SetCachedLogo(nullptr) call from SignIn might not run. Bug: 1003172 Change-Id: I46df0b4461f8e974160f22cbdf08ce1cba2280f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799032Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#696053}
-
Sergio Collazos authored
This reverts commit 7044d791. Reason for revert: Since this is launching to 100% in M77 the flag should be at least enabled by default in M78. Original change's description: > Revert "[iOS] Enable the new Clear Browsing Data UI flag" > > This reverts commit 9223cbe0. > > Reason for revert: Not getting leadership-full approval before branch point; will rollout with Finch. > > Original change's description: > > [iOS] Enable the new Clear Browsing Data UI flag > > > > This change is to enable the new-clear-browsing-data-ui flag. > > > > The new Clear Browsing Data dialog adds the time range selection functionality > > and shows browsing data volume details for each data type. > > Launch Bug: crbug/627147 > > Screenshots: https://drive.google.com/open?id=1q1zJzB1abRsY1zCD4rLewvMxCnMr8WGf > > > > Bug: 627147 > > Change-Id: If2e16f4697a7aac2308a430c48880eb2f0c58c19 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624906 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662278} > > TBR=rohitrao@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 627147 > Change-Id: I26afad9076841353b0210f4537d8842aab9631e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635617 > Reviewed-by: Huanzhong Huang <huanzhong@chromium.org> > Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664723} TBR=rohitrao@chromium.org,huanzhong@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 627147 Change-Id: Ib4f4a1bda447bc4f28541191c99fd5427f2b3844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797180Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#696052}
-
Justin Cohen authored
It's possible for sessions to be serialized while navigating to a SlimNav restore URL, leading to a brief moment where the wrong last committed index is serialized. This leads to a DCHECK on restore. Bug: 1003049 Change-Id: I6181609a2e91370c2e3eecdb6e63e24801513d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797244 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#696051}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/69f8c42d2c95..d8ac383bba8e git log 69f8c42d2c95..d8ac383bba8e --date=short --no-merges --format='%ad %ae %s' 2019-09-12 danilchap@webrtc.org Delete temporary accessors in RtpDepacketizer::ParsedPayload 2019-09-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0d1efbbb..783ccff9 (695897:696001) Created with: gclient setdep -r src/third_party/webrtc@d8ac383bba8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I53daf988861e14cb34a70e68a0147f86da1a1c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696050}
-
Vasiliy Telezhnikov authored
This CL moves destruction of root DDL recorder of critical pass (till after SwapBuffers has been submitted). It also recreate recorder to use on next frame and save time in BeginPaintCurrentFrame. This helps to reduce time before SwapBuffers called Bug: 974359 Change-Id: I4c21d4f97ead6495193ed19d3d2df25edc5710d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797179 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696049}
-
Daniel Rubery authored
I missed one reporting field in the malware deep scanning events (the SB threat type). This CL populates that field. This field should also be populated in the dangerous download event, but those events aren't working as expected (see https://crbug.com/1002976), and work adding threat types to the current events would be thrown away. Bug: 1002977 Change-Id: Ife0a449a8b46ad18766516f9c570739606825d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799742Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#696048}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a7bda6a..9baaac63 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I864f79e86e78851fa4df0c6820c1a845b1460114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801066Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696047}
-
Robert Ma authored
TBR=foolip Bug: 997202 Change-Id: Ib4677dfb1c047991fa637c1acad36e4b46c31c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801052Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#696046}
-
Sorin Jianu authored
This reverts commit b0784c2f. It's breaking the chrome bots at compile time, for example: https://ci.chromium.org/p/chrome/builders/ci/chromeos-amd64-generic-google-rel/7364 ../../chromeos/services/assistant/platform/volume_control_impl.cc -o obj/chromeos/services/assistant/lib/volume_control_impl.o ../../chromeos/services/assistant/platform/volume_control_impl.cc:26:23: error: no member named 'ash' in namespace 'mojo'; did you mean simply 'ash'? mojo::PendingRemote<mojo::ash::mojom::VolumeObserver> observer; ^~~~~~~~~ ash gen/ash/public/mojom/constants.mojom.h:45:11: note: 'ash' declared here namespace ash { ^ ../../chromeos/services/assistant/platform/volume_control_impl.cc:103:3: error: use of undeclared identifier 'volume_control_ptr_'; did you mean 'volume_control_'? volume_control_ptr_->SetVolume(new_volume * 100.0, user_initiated); ^~~~~~~~~~~~~~~~~~~ volume_control_ ../../chromeos/services/assistant/platform/volume_control_impl.h:48:52: note: 'volume_control_' declared here mojo::Remote<ash::mojom::AssistantVolumeControl> volume_control_; ^ ../../chromeos/services/assistant/platform/volume_control_impl.cc:108:3: error: use of undeclared identifier 'volume_control_ptr_'; did you mean 'volume_control_'? volume_control_ptr_->SetMuted(muted); ^~~~~~~~~~~~~~~~~~~ volume_control_ ../../chromeos/services/assistant/platform/volume_control_impl.h:48:52: note: 'volume_control_' declared here mojo::Remote<ash::mojom::AssistantVolumeControl> volume_control_; Original change's description: > Migrate assistant_volume_control.mojom to the new Mojo types > > Convert the implementation and all users of the > ash::mojom::AssistantVolumeControl and VolumeObserver interfaces. > > Bug: 955171 > Change-Id: Id4fd8931ecc2d29eaff0b25defb909bf0f491aca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795422 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#696007} TBR=oshima@chromium.org,estark@chromium.org,hferreiro@igalia.com,oksamyt@chromium.org Change-Id: I2eedac2da7539200787789a6436666b68bd067e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800516Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696045}
-
Alexandre Courbot authored
The V4L2Device class has grown a bit chaotically, and proper sequence checking is not currently being enforced, although other classes of the same unit (V4L2Queue notably) do sequence checking. Add a sequence checker for the queue-related methods, which must always be called from the client's sequence. The use of this checker will be expanded to new use-cases and hopefully to older ones as well as we confirm they are safe. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: I60aa8eb52e48a13fa99c42990af2f621982c44e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799651 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#696044}
-
Anton Bikineev authored
This adds a check that identifies incorrect uses of GarbageCollected or GarbageCollectedFinalized similar to this: class NavigatorGeolocation : public GarbageCollected<Geolocation>. Change-Id: Ie4f4d9b1e4af48992a15757f70089420d456f304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800767Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#696043}
-
Fernando Serboncini authored
Before, performance.now used to be unsafe to expose to users. Now performance.now() is safe to be exposed to users (and it is on the IDL), so RAF doesn't need to do its own cut. Bug: 995235 Change-Id: Ib547abcd0d05cc81d3d461420725c74cffcc826c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801224 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#696042}
-
Naoki Fukino authored
When a disk's device label is not available, Files app uses the base name of the mount path as the volume's label. Settings screen should use the consistent label with Files app. Although we should share the implementation in Files and Settings for the labels, I'd like to keep this CL as simple as possible for safer merge to M78 branch. I filed crbug.com/1002535 for the refactoring. Bug: 1002161 Change-Id: I84a83c42c0645c8e1a105dd010a73d8a9994e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795533 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696041}
-
Stephen McGruer authored
The spec defines these on GlobalEventHandlers, not on Window: https://drafts.csswg.org/css-animations-1/#interface-globaleventhandlers-idl https://drafts.csswg.org/css-transitions-1/#interface-globaleventhandlers-idl Bug: 999894 Change-Id: Idf3d5f9ba44a5cc8045315baa8c204fdc326d5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783058Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696040}
-
Toni Barzic authored
Does not seem to be used from anywhere. Bug: None Change-Id: I6046a34d852c2234489d673ef842b20df21e46d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799423 Auto-Submit: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jonathan Backer authored
This allows SkiaOutputSurfaceImpl to add the ImageContextImpl to images_in_current_paint_. This will ImageContextImpl::BeginAccessIfNecessary for every ImageContext displayed in the current frame. This guarantees that ImageContextImpl::promise_image_texture_ when Skia calls fulfill on the promise SkImage. This particular fix was picked because (a) it is obviously correct (b) is easy to merge onto M78 branch Bug: 1000004 Change-Id: I9c46a22813cc474738b744fcefb34c4a765bec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801029Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696038}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/429f0d380c28..a424536401d3 git log 429f0d380c28..a424536401d3 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 mtklein@google.com rewrite tricky loop to avoid -Wsizeof-array-div Created with: gclient setdep -r src/third_party/skia@a424536401d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I7a7934a4668fb81c41f8d4b8a4fb1b50a956b8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801030Reviewed-by:
-
Sigurd Schneider authored
This CL adds a missing await which causes the performance recording to now wait until all models are suspended. Bug: chromium:1000155, chromium:1002427 Change-Id: I4d87159b6c03e52d54f48f4ddaf5a937c4b19751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795447 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#696036}
-
Christopher Grant authored
- Add a new test case to exercise a native library. - Generalize the display of the result dialog for multiple test cases. - Specify a "pass" or "fail" in the results dialog text, to be parsed by the test, and also aid in manual testing (where the test activity may be spawned manually). - Component build coverage is stubbed out; it will be added once the component build places feature libs in DFMs. Bug: 989646 Change-Id: I724d0725f71ad7897ceb7b81d9fe7d22183889ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796308 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696035}
-
Yi Gu authored
The fuzzer may produce invalid FrameSinkId for hit test regions which incorrectly breaks a DCHECK in HitTestQuery. Bug: 1001552 Change-Id: I0207dc7c1594f847e8fd3801c121ff04cd938e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796114Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696034}
-
Vasilii Sukhanov authored
Bug: 1003362 Change-Id: Ic403601498287275fbfbe6a511ace44cd8dede83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800989Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696033}
-
Anton Bikineev authored
Change-Id: I8a5af2eed40d7a378680cad4af08ffcd5d51aaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800865Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dc7d2c6fd7ca..69f8c42d2c95 git log dc7d2c6fd7ca..69f8c42d2c95 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 henrika@webrtc.org [RELAND] Add support of AudioRecord.Builder in the ADM for Android Created with: gclient setdep -r src/third_party/webrtc@69f8c42d2c95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5447943541cce627f7e95c5b59e06045789dc0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801028Reviewed-by:
-
Peter Kasting authored
This was first turned on for Android back in 2014. According to crbug.com/419051 the binary size impact was minimal. According to danakj on https://chromium-review.googlesource.com/c/chromium/src/+/1790724/3/ui/gfx/geometry/quad_f.h#66 this is part of the gfx critical path, so it makes sense to optimize it for all platforms in non-debug. That also matches the condition set we use most other places we enable -O2. Bug: none Change-Id: I67e9d50e10d7c21d686226caf6172dc7d64713b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799312 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#696030}
-
Yi Gu authored
Prior to crrev.com/c/1452790, a cc::Layer created by ui::Layer was hit testable if its type_ != LAYER_NOT_DRAWN. That patch updated the logic with new hit testable critia but it missed the initial assignment. This patch addresses that issue and defines a helper function to check hit testability to avoid breakage in the future. Bug: 924294 Change-Id: I6957539cbfddc12ae24a35c451186c21ff85246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785080Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696029}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c6e48a6. With Chromium commits locally applied on WPT: 20133397 "[sensor] Upstream sensor layout tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iedd633c6c4765a114e343c4f447c24c403568082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801064Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696028}
-
Anton Bikineev authored
Blink GC plugin has been updated with a new option -no-gc-finalized. Bug: 990913 Change-Id: I8bc320162e936bb85be9e53e2beaec63163768ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798609Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696027}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/subresource_filter. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=pkalinnikov@chromium.org Bug: 891670 Change-Id: I2b50b464bf35451ba478a29b25888b4c4ee97854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786808 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#696026}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: I0b56ac7f2bf659f28ebdbf8a04e425301033b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787114 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696025}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/metrics. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=nikunjb@chromium.org Bug: 891670 Change-Id: Ia47c792059528981fcbe3b0ca40baadfece43154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786976 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696024}
-
Khushal authored
There is no ordering guarentee in the destruction order for objects in thread local storage. Since Thread and SharedGpuContext are both in thread local storage and destruction of CanvasResource can be triggered by SharedGpuContext being destroyed, we shouldn't access Thread in the CanvasResource dtor since it may have already been destroyed. R=fserb@chromium.org Change-Id: Id7efe3eb51fa242382f7446b731f0531c6bd9816 Bug: 1002792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799223 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#696023}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/updater. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=borisv@chromium.org Bug: 891670 Change-Id: I4c7eee29b7dcd6b8f553dbaab0e168faec4fede7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786981 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts FingerprintObserverPtr and FingerprintObserverRequest in chrome, services and ui to the new Mojo type, and uses pending_remote<FingerprintObserver> in fingerprint.mojom. Bug: 955171 Change-Id: Ide42fdb94bc69b100b5fce68f672cc86ef6f7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792464 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#696021}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3fe6946d..7a7bda6a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8bbe836f4945cbbc8914dd217dfe15af318e0d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801065Reviewed-by:
-
