GitLab

Bug: 924136
Change-Id: I5c360800f32e65855d6107f190d66f78abf622d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724409
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682863}

I have received various emails from chirp indicating that this histogram
does not have data. After searching for it in Code Search, it looks to me
as this histogram is never used hence I am removing it.

BUG=None

Change-Id: I9cf654d4e4f4ccfdc18936338a962c9e3ecb76e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722843
Auto-Submit: Armando Miraglia <armax@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682862}

Android WebView uses the system's PAC support (via localhost proxy) rather than Chromium's PAC implementation.

Bug: 989222
Change-Id: Ia0dcc436890fe5d92fb5124c1bc278d61979f8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726763Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682861}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=nparker@chromium.org

Bug: 968047
Change-Id: I11dd0befca765ffa4b25c8df66bd7557621b2b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729223
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682860}

Revert TextFragmentAnchor matching behavior back to case insensitive.
Case sensitive reduced ambiguity, but also reduced match rate on CSS
transformed text and &nbsp (see bug 982031). Ambiguity can, in most
cases, be reduced by providing more context terms, so case insensitive
is probably best.

Bug: 982031, 982035
Change-Id: I633c674affb16b571294e5d81b6ae3b24ec9a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729550Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682859}

Change-Id: Ifd1be95869fa4b3c8bea29fff2e07671abe82e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725189
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682858}

This reverts commit bd32f816.

Reason for revert: Reverted the CLs that appear to have introduced the flakiness.

Original change's description:
> [Sheriff] Disable CacheStorageManagerTest.TestErrorInitializingCache.
> 
> Disable CacheStorageManagerTest.TestErrorInitializingCache in Fuchsia
> (flaky).
> 
> TBR=wanderview@chromium.org
> 
> Bug: 989313
> Change-Id: I18802fc677a99b9a83fc99a356f7c02ff568d11b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729150
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682694}

TBR=vitaliii@chromium.org,wanderview@chromium.org

Change-Id: I56f467459e882d5586a3aa57c1ae8bc94ae1ead8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 989313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729833Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682857}

Sort headers and include what you use.

Bug: none
Change-Id: I5173a232342a6288d6d1a67ca0705e1e963e15ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728542
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682856}

https://android.googlesource.com/platform/external/perfetto.git/+log/e2248cbc238c..2c1dec165ba6


git log e2248cbc238c..2c1dec165ba6 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 treehugger-gerrit@google.com Merge "shmem: Avoid synchronous commits if in kDrop mode"
2019-07-31 ilkos@google.com Merge "Add trace duration and rename the metadata proto"
2019-07-31 treehugger-gerrit@google.com Merge "Add ability to generate UUIDs"
2019-07-31 treehugger-gerrit@google.com Merge "Log if max. number of data sources exhausted in client API."


Created with:
  gclient setdep -r src/third_party/perfetto@2c1dec165ba6

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I221f6655b9df14124f91a0a43110bb78bc814541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729555Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682855}

This is a CL to minimize os-settings's dependency on pageVisibility.
This includes removing some references to non-existent paths as in [1]
and replacing any pageVisibility path that only depends on guest mode
in OS Settings with an explicit check on whether the machine is in
guest mode from loadTimeData.

This doesn't completely eliminate the pageVisibility fork [2] bug
because the people-page still provides a pageVisibility subpath to sync-
settings, but it removes the vast majority of the dependencies on the
browser settings' pageVisibility. The people-page issue will be handled
in a later CL to avoid bloating.

LOGGED IN SCREENSHOTS:

Screenshots for OS Settings logged into a GAIA account with this change
deployed.

Page 1 http://screen/Tcbdf04X2Q4
Page 2 http://screen/9t80k4pRAGj
Page 3 http://screen/dRCw3iZcQUU

Compare to the top level 'settings-section's in UX mock [1] (modulo
reordering and renaming).

GUEST MODE SCREENSHOTS:

As per specs sent out by jessejames@, in guest mode, the visible
sections[2] are Network, Bluetooth, Device, Search engine, Date and
time, Privacy and security, Languages and input, Files, Printing, and
Accessibility. Compare this with screenshots of guest mode with this
change deployed:

Page 1 http://screen/AriC9twWUi3
Page 2 http://screen/qnrUthAru3G

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1716338
[2] http://crbug.com/974906

[1] https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQLWgsMW9gCl/files/MCEJu8Y2hyDScYKiC7u07no3e21TaxzYd_w
[2] There is a possibility that 'People' may be shown in guest mode
    depending on the outcome of a UX design discussion on the correct
    place for Kerberos settings, but this CL is working under the
    assumption that it is not shown. This can easily be changed after.

Bug: 987349, 974906
Change-Id: I7f384437f9008742926eb7cf9d4d623bd8415591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724828Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682854}

The new positioning logic is hidden behind a flag.

R=sammiequon@chromium.org

Test: added test
Bug: 978112

Change-Id: If9a565f3587e588041245be3f2dd8a2baa28c643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685517
Commit-Queue: Danton Vu <dantonvu@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682853}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 968047
Change-Id: I61bc20b765ad68c07e33d14e7ef3e28ee2282c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729153
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#682852}

This relands https://crrev.com/1725318 with a fix for the crash
that can happen under certain circumstances.  The error in that
CL was that dispatch_context() shouldn't be used outside of the
context of a Mojo connection.  Here's the updated commit message:

As part of cleanup from CL https://crrev.com/c/1626660, this CL
moves creation of CursorImpl into IndexedDBDispatcherHost by
refactoring AddCursorBinding into CreateCursorBinding.

As a result, the OpenCursor calling path no longer needs to pass
the sequenced task runner into the OpenCursorOperation task and
ownership of CursorImpl and the mojo binding steps is made
simpler.

Bug: 988868
Change-Id: I8444f53b0c4f362d3152cb9bea232d65f99375a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728540Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682851}

SSLErrorHandlerDateInvalidTest.
  TimeQueryStarted
  NoTimeQueries
are not disabled properly.

TBR=agl@chromium.org

Bug: 989225, 989128
Change-Id: I7dbf620da6d5d542ab4a5bbcbf531c5155ba6a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729393Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682850}

https://skia.googlesource.com/skia.git/+log/1a607e7b6e9a..38037fb44311


git log 1a607e7b6e9a..38037fb44311 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 ianloic@google.com [fuchsia] Update for new FIDL API
2019-07-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-07-31 halcanary@google.com tools/sk_app/macos: support command key
2019-07-31 benjaminwagner@google.com Set mac_sdk_min=10.13 for CommandBuffer builds
2019-07-31 halcanary@google.com SkPDF: SkPDFMakeShader handles pathological inputs better.
2019-07-31 bsalomon@google.com Remove GrCaps::SupportedRead::fSwizzle and supporting code


Created with:
  gclient setdep -r src/third_party/skia@38037fb44311

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=benjaminwagner@google.com

Bug: None
Change-Id: Id392d7c07146e701b091ac9be37f1a9c0c627505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729693Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682849}

When TestPageFlip, choose the FourCC format that takes opacity into
consideration.

BUG=983937
TEST=GPU doesn't crash anymore on Kefka

Change-Id: I72af7f1755c9cd9c4464246fc73d38adbec57b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724558Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#682848}

(1) The class originally assumed that every Cellular-capable device must
    provide a MEID value. However, it turns out that this is not the
    case, so this check was removed.
(2) The class assumed that it would always notify its delegate via
    InvokeOnFinishedCallback() asynchronously. However, if the device
    has already been activated before the process starts, the reply
    comes synchronously. This CL starts the activation flow as part of a
    new task to ensure that the process is asynchronous.

Bug: 968858
Change-Id: Ie1d57a2a38465c6e2f1eb93632c6dbc7dcaf40bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726821
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682847}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 968047
Change-Id: I87eaadb182875ed512ed3527a506aad45a881be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728663
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682846}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5aab967f546e..f7b43d76692c


git log 5aab967f546e..f7b43d76692c --date=short --no-merges --format='%ad %ae %s'
2019-07-31 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@f7b43d76692c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I158504c133f71adfaddab3a5b67d72c0a1f2b29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728472Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682845}

My ssd ran out of space to build Android so in the meantime,
I symlinked it into my home dir.  However, when I did this, my Android
build resulted in an exception where it would try to symlink a file to
itself: ~/out/gn_android/gen/components/version_info/android/java/org/chromium/components/version_info/VersionConstants.java

This patch checks and avoids this case.

Change-Id: I0d0f6b90e40a1e9af710ccca8a626116f0ec6f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710783
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682844}

Bug: internal b/138104456
Change-Id: I8d68f1b9cae2bab415ca0093ac8b94268d3efe2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729512Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682843}

This CL fixes
1 - Overall OMA download flow for DownloadOfflineContentProvider
2 - Fix auto-open for downloads that should be auto-opened immediately.
3 - Fixed a bug, where OMA mistakenly assumes the given download path
and queries mime type from it, rather than content Uri, since the
given file path and actual file path can be different.

Bug: 989110
Change-Id: I7bad385f0a72d40b555e94b47ee760377519e6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727382Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682842}

When a receiving a new interval from a syncbase it
is meant to take precedence, we now clear the old
interval so it gets updated with the new time. This
solves some sorting bugs related to syncbases.

A new test has been added "onhover_syncbases.html" which
tests repeted "mouseover" and "mouseout" events.

Bug: 740541
Change-Id: I7a8e3691593a537c4dbc1da3bdbbe09eaf30e500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718704Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#682841}

Currently, we only support thread instruction delta values on
PHASE_COMPLETE events. Since we'll soon replace complete events
(at least on TrackEvent proto level) with begin/end event pairs, this
patch adds support for emitting absolute thread instruction count
values on begin/end events.

Also ensures that we write sensible timestamps for all metadata events
in TraceLog.

Bug: 925589
Change-Id: Ie01339aefb3d148457f51057e0722c4506dda82f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729262
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682840}

VizCompositorThread should have a TYPE_DEFAULT message loop on all
platforms except for Fuchsia where it needs to be TYPE_IO. Plumbing in
GpuPreferences::message_pump_type does the right thing for Fuchsia but
potentially the wrong thing elsewhere. Add platform specific #ifdef to
properly handle this case and remove plumbing.

Bug: 958387
Change-Id: Idfa0e1b21a37642d297f2601c9a9f52ca8770fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728313
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682839}

The existing code assumed that if the defer commits restarted due
to the time being beyond the timeout, it must mean that commits were
deliberately deferred. But if the frame in question does not ever
defer main frame updates, it never explicitly starts or stops deferring
commits, so the timeout trivially kicks in on the first frame
update.

Manually tested, seeing most first commits are because deferral was
not allowed at all. This is more in line with expectations, but also
makes the metric less useful for determining who has the feature
enabled.

Change-Id: Id44cc74a1afdd78e3ba7ef96d8ca133a7c948af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716330Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682838}

android_dlopen_ext() and dl_iterate_phdr() don't need to be accessed via
dlsym(). Access the symbols directly instead.

Bug: 979638
Change-Id: I4b6b4d097cd1e107f7a1d0e7f5e540d4cc472552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729072
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682837}

This CL makes the data saver checks more resilient.

Moving the checks to the very beginning at the navigation start also
prevents recording of some of the Previews histograms for
non-DRP users.

Change-Id: I26c96d654180a2202eef5f0899c89c37bf4c6da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716121Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682836}

Disables the SendTabToSelf feature in
WebXrVrTransitionTest#testNonImmersiveStopsDuringImmersive, as it's
suspected that the feature is the cause of recent flakiness.

TBR=bialpio@chromium.org

Bug: 986580
Change-Id: Ic1b22a9ba48d5c96729c4e57439c590dcdd1ca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729537Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682835}

This reverts commit cca6943d.

Reason for revert: This appears to have made CacheStorageManagerTest.TestErrorInitializingCache flaky - see https://crbug.com/989313

Original change's description:
> CacheStorage: Allow reads to be executed in parallel.
> 
> This CL adds the CacheStorageParallelOps feature with the associated
> "max_shared_ops" parameter.  Enabling the feature and setting the
> parameter to greater than one will allow read-only cache_storage
> operations to run in parallel.  By default parallel operation is
> disabled.
> 
> The overall design is to treat each CacheStorageScheduler as if it
> has its own read-write-lock.  When an operation is scheduled it must
> be flagged as either "shared" or "exclusive".  Some number of shared
> operations (determined by the feature param) may run in parallel.
> Exclusive operations always run by themselves without parallelism.
> 
> This CL also includes the ServiceWorkerCache.PeakParallelSharedOps
> histogram which will measure how much parallelism we actually see in
> practice.  The peak is measured across a small time period defined by
> when an idle scheduler begins running its first shared op to until it
> stops running all shared ops.
> 
> Bug: 985379
> Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680986}

TBR=dmurph@chromium.org,jwd@chromium.org,jam@chromium.org,rayankans@chromium.org,wanderview@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 985379, 989313
Change-Id: Iad71c64d0446d3e9bc09392ffa0ce38914d6c85f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728071Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682834}

Expansion includes parsing OWNERS files, creating DOM Elements for the
owners found in the files, and replacing the files' respective DOM
Elements with newly-created owners elements.

Bug: 924136
Change-Id: Ice1bffeddf490a28bb3983858a75c1844a23c712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715407
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682833}

Remove bugs with a comment by
"425761728072-pa1bs18esuhp2cp2qfa1u9vb6p1v6kfu@developer.gserviceaccount.com"
from the filter for finding unlabelled network bugs. These are bugs
reported by FindIt and other related tools. They generally already have
a label attached, and there tend to be rather a lot of them.

Going through 200 bugs titled "x% regression in whatever" isn't terribly
productive, and skipping over them makes it easier to miss user-reported
bugs.

Bug: None
Change-Id: I680691ca987746e219a4edb307d418d7fa0bfede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728176Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682832}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Iba4526020982e0b8355c9b75637d1f78d4a94638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700903
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682831}

As per the linked bug, non-null anchor views will become mandatory in
LocationBarBubbleDelegateView. This change modifies IntentPickerBubbleView to
always pass a non-null anchor view. In fact, it already always passed a non-null
anchor view in actual use, since it is only ever invoked in one place
conditional on the anchor view being non-null. As a consequence, this change
deletes the null anchor view path in IntentPickerBubbleView, which removes some
bespoke layout constants (yay!)

This change also refactors IntentPickerBubbleView a bit: IntentPickerBubbleView
itself is built on all Views platforms, but its tests were only built on
ChromeOS. This change therefore makes the tests build on all platforms alongside
the code. As of right now, I think this code is only invoked on ChromeOS, but in
a runtime way that makes it difficult to be sure.

This change also makes private a couple of test-only methods on
IntentPickerBubbleView that used to be public.

Bug: 989080
Change-Id: Id1a9d28ffb5c11e164547ce5c5aac5b26c0ef6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726431
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682830}

This change drops additional checks that rejected the tail suggestions, if the
offered suggestion also came with additional corrections (spelling, spaces etc).

Bug: 973036
Change-Id: I7186593d698fc22cc94992fe1c8df7827adcb7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719267
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682829}

This change replaces the clearReadError() method with implicit behavior
in the getters for the readable and writable attributes. This should be
much more convenient for developers without any change in functionality.

Bug: 893334
Change-Id: I76cab6656a2ad117fcc3d1fda5eaebd052e4d2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722011Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682828}

Right now chrome crashes when user clicks to open dialog right after
the tab model is changed. This is because that we are trying to open up
the current group while it no longer has reference in the new tab model.
This CL fixes this issue.

Bug: 987221
Change-Id: Ia2e3384780f2d56a816ef8def00e02beb50e6493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726614
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682827}

This test was failing under SkiaRenderer, but the failures have not been addressed.
Re-enabling the test, which runs in Chrome-GPU FYI bots.

TBR=ynovikov@chromium.org
Test=ContextLost_WebGL2Blocked

Bug: 984110
Change-Id: I686ac2a6c8fc9dc50976fe5efc94059a10884b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721025Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682826}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 968047
Change-Id: I5202fae8fa6ac5c7567ca9a46cb42a0716eda2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729249
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682825}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 968047
Change-Id: I3be206ebb5e570854acdc961182286e670de7d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728668
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682824}