- 18 Aug, 2020 40 commits
-
-
Ioana Pandele authored
This is not needed. The Java code checks to see if the package string is not empty to determine whether the credential is an app credential or not. Bug: 1102025 Change-Id: I38dbdc771a4bcce6eed2a4e18d3ee38d21b5e73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359139Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#799169}
-
Philipp Hancke authored
Adds a test which verifies that setCodecPreferences changes the order of codecs in the SDP generated by createOffer. Drive-by: close all peerconnections after the tests, https://bugs.chromium.org/p/chromium/issues/detail?id=836871 BUG=None Change-Id: I75d252bc43919ba2f27c6bd97493f94b3b5a2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362024Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#799168}
-
Ella Ge authored
This CL changes the how the TWA quality enforcement enabled with the flag and enable the flag for now: * If flag is not enabled: * Show a Toast if local build * If flag is enabled: * if TWA client enabled quality enforcement: * crash * client not enabled, forced flag enabled: * crash * show a toast if local build * otherwise * show a Toast if local build The NOTIFY callback is not needed and removed. Bug: 1109609 Change-Id: I6959092f97d2c2f55cc3b57dbd152147527ae829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353171 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799167}
-
David Roger authored
The profiles were named after the email of the account. This CL changes to use localized string "Work" instead. Bug: 1076880 Change-Id: I5a0782ae83d6660bcabcea041761f2f3b493ee04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362827 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#799166}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: I06c026e4788c8225d1acdfa1792d4f221806c2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359018 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799165}
-
Xianzhu Wang authored
This mainly fixes the crash when we tried to update the property of a GraphicsLayer that ShouldCreateLayersAfterPaint. The crash could be fixed by checking if the pending layer's paint artifact is the same as the passed in paint artifact, but marking the compositing type of the pending layer can also simplify the code. Change-Id: I3deef1c60057b1925c7a8d9d891904404f5509bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360506Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799164}
-
Sebastien Lalancette authored
Now that the feature is almost completed (but not rolled-out anywhere), fixing up the enum values and adding histograms for the new context menus. Bug: 1093302 Change-Id: Ib3e32c703ed18ddd24c6f7f75c19505cf4e9e343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354530 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799163}
-
James Vecore authored
This adds the contact visibility component which will be hosted in the on-boarding experience as well as in settings. This is just a roughed in version of the component without the back end/mojo functionality to retrieve contacts yet. String, a11y, and final specs are still pending. Eventually this component we need to support a compact layout for on-boarding and a full layout for settings. Screenshots: Zero-state (no-selection): https://screenshot.googleplex.com/079678b4-8a72-43db-a46b-b853286a41ba.png All contacts selected: https://screenshot.googleplex.com/cfd1c5ee-565a-4908-99f1-cd3b7ef5683a.png Change-Id: I6c3558e8f747fade5ee7f7d0c0e0d5a710d77457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352520Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#799162}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9fb0716512d..a8b16365f92a 2020-08-18 csmartdalton@google.com Stop discarding stencil buffers on tilers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I0f7d3135cb55c6f60a6ba7b9fde0d5bf418a3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799161}
-
Jonathan Backer authored
This is mostly based on the OOM detection added to SharedContextState, but may apply to Skia detected errors as well. If we detect |driver_needs_reset_|, we should have |GpuChannelManager::OnContextLost(false)| called to LoseAllContexts when context virtualization is enabled. Change-Id: Ife7e6c4db744b24ab2ed55476bed90b05eb1aebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363071Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799160}
-
kylechar authored
Change kInProcessCommandBufferClientId to kDisplayCompositorClientId. InProcessCommandBuffer is no longer used for the display compositor with SkiaRenderer so the constant name is inaccurate. Bug: 1114763 Change-Id: I03b9680930c61e1cb922d97c76959eb06e689638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352761Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#799159}
-
George Steel authored
Animated properties are now counted in the KeyframeEffect constructor and in SetKeyframes instead of in ProcessKeyframesRule. This makes WebAnimations trigger the use counters as well as CSS animations/transitions. Bug: 992430 Change-Id: I7f0d453d7cde1333863a1127c3dcc68931814c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354946 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#799158}
-
Adam Langley authored
EIDs will no longer just contain nonces, thus extracting a single value no longer sufficies. Additionally, caBLEv2 will no longer be based on |FidoCableDevice| and thus we don't need a special handshake handler for v2. This change tweaks the handling of received BLE adverts in several ways to accommodate this. BUG=1002262 Change-Id: I6af0a9a3990f8fabd2144f4b8a69687538ee08b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340387 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799157}
-
Chris Lu authored
When Chrome is the default browser, it will receive all URL opens, which is likely to change certain stability metrics. Thus, it will be good to filter those metrics by default browser status. This metrics records whether the user was deemed to have set Chrome as the device's default browser. Bug: 1107489 Change-Id: Ie0bc34e7ac2979a82c67267e80fb8318dd2c6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347954 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799156}
-
Himanshu Jaju authored
- Posts a delayed task to close connection - Adds a test to check kTimedOut status in TransferMetadata Bug: 1085068 Change-Id: I7c74b19533a97272d0aede9940eaa3f477e47827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359129Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#799155}
-
Karandeep Bhatia authored
Document::domWindow() can be null when a Document is constructed without a browsing context. To prevent this possible derference, use Document::GetExecutionContext which is guaranteed to be non-null. BUG=1116743 Change-Id: Ib679e9689692f6b24a046ba43a17e16b2db858f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360493 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799154}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008180800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/50LmdZ87Aei15bQBU0QVN59IeJPvU-acRxSAEOTzcrYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163948970 Tbr: help-app@grotations.appspotmail.com Change-Id: I8c005ecbf906685b044a9a4d8d3e9dd5292e2c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363060Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799153}
-
sauski authored
To support not showing a user a survey too soon, the preferences checked by the HatsService to determine survey eligibility are updated when the HaTSNextWebDialog shows a survey. Bug: 1110888 Change-Id: I54a977a1aebf7b2345abace84c2c66aa3c2cb600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326171Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#799152}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/988f19e208bb..9aed03dcb02f 2020-08-18 dpranke@google.com Fix visibility rules for configs enforced by latest GN. 2020-08-18 cwallez@chromium.org OpenGL: Unconditionally set glFrontFace 2020-08-17 rharrison@chromium.org Roll 4 dependencies 2020-08-17 enga@chromium.org D3D12: only lazy clear OutputAttachment textures with render target ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I724187c67fcf79b1401f7e7be199a4db2ca27479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363052Reviewed-by:
-
Brandon Jones authored
The "mapAtCreation" attribute that the warning currently recommends doesn't exist. Spec and Blink implementation both specify that the correct name is "mappedAtCreation". Change-Id: Ibd4eafac535390afe410d55d5ce922c8d7ae2247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363267 Commit-Queue: Brandon Jones <bajones@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799150}
-
kylechar authored
SurfaceAggregator can enforce a maximum texture size but this was only plumbed in for GLRenderer. Add this value to OutputSurface::Capabilities and implement for both GLRenderer, with the value from gpu::Capabilities, and SkiaRenderer, with the value from GrContext. Also add an arbitrary limit for SoftwareRenderer. If we get an OOM while allocating a RenderPass texture it will crash the GPU process, so placing an upper limit will hopefully reduce OOM crashes. Bug: 1116745, 1099158 Change-Id: Ie12dedeb2e64ce6b24859adc12a3d73d69c18c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359152 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799149}
-
Saurabh Nijhara authored
This change was introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2302639 All OOBE dialogs may not use the same color for subtitle and footer slots. Having color in top level css is affecting some OOBE screens as the Network screen. Hence, reverting the change for now. Bug: 1112744 Change-Id: I00cf2fc673bfeb01513705b232fa278087c3494e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358670Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#799148}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/12c6d67a4298..e0a44a28c5be 2020-08-18 cjmcdonald@chromium.org pytest: Clean up & remove 'sigterm' marker 2020-08-18 cjmcdonald@chromium.org Migrate depgraph visualization project to contrib 2020-08-18 bpastene@chromium.org cache: Pass quiet=True to cros_build_lib.run() when extracting tarballs. 2020-08-17 rrangel@chromium.org ap_firmware_config/zork: Use futility 2020-08-17 zhuohao@chromium.org puff: add factory branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I55a683ca4ed01c6a0c1cf2b1c90ca804a153b591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363055Reviewed-by:
-
Dan Harrington authored
We already have sequential numbers for actions, we just weren't populating the proto yet. Bug: b/155774256 Change-Id: Ie12b718079e44e9c8f2d702d5eb1e216c396db48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359375 Auto-Submit: Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#799146}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b30e90492c5..c2cee61d1ff6 2020-08-18 jleconte@google.com Revert "Chrome Perf Dashboard UI links to Monorail bugs are missing project id." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: rmhasan@google.com Change-Id: Ief910339cd2ab131ee12adcbf69f1b653e0d298b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363056Reviewed-by:
-
Matthias Körber authored
Change-Id: I77d17601928655d563cab39daf5ba9c04f97fbde Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362911 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#799144}
-
Aaron Tagliaboschi authored
Bug: 973801 Change-Id: I0c1616e85080c1048f6777caaa7769ce8398e507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354270 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799143}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6a272ffee65..d5044cd209a6 2020-08-18 fmayer@google.com Merge "Update heapprofd CHANGELOG." 2020-08-18 eseckler@google.com Merge "Save and load local configurations" 2020-08-18 lalitm@google.com Merge "docs: fix build + add language annotations on code" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc881128027375332ffc4c9993f8775eb888bfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363057Reviewed-by:
-
Liquan (Max) Gu authored
Fix a bug introduced from CL https://chromium-review.googlesource.com/c/chromium/src/+/2346730 where the failed parseAndValidateDetailsOrDisconnectFromClient() does not cause the ComponentPaymentRequestImpl to be discarded by the MojoPaymentRequestGateKeeper. Bug: 1102522 Change-Id: I0b99b6aea2ada05e5a0474e3cb93eaed9a4ee789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363249Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799141}
-
Sergei Datsenko authored
Bug: 1115963 Change-Id: I240b2132ee9285f9b2cc88478394b32c383744ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355232 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#799140}
-
Azhara Assanova authored
Create a field isHidden in CrashInfo class which is reflected in the crash log json file. When the user presses "Hide crash" button, the field is updated and the crash log json file is modified. WebViewCrashInfoCollector's mergeDuplicates() also removes crashes that have to be hidden. Demo: https://drive.google.com/file/d/1EUlEzi4HXgzdgES0csWJpbVwaoiSJ9lU/view?usp=sharing Dark theme: https://drive.google.com/file/d/1fmK5JStvNWv3ce17NUyQzSxTaUNyDdMB/view?usp=sharing Bug: 1059944 Test: Manual - verify the hide button works as expected Test: run_webview_instrumentation_test_apk -f DeveloperUiTest.* Change-Id: Id08aab424a222c8acae2a22fcf1bb777bb2ac330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339976 Commit-Queue: Azhara Assanova <azharaa@google.com> Auto-Submit: Azhara Assanova <azharaa@google.com> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799139}
-
Joey Arhar authored
Bug: 1116592 Change-Id: I2fcd95f6310539bbb5f9bd4ec998a6cf0fd92aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358650Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#799138}
-
Roman Sorokin authored
The feature is not used at all. Bug: none Change-Id: I9ecbed46b513ce7b1dff4ddbfc45f4741af4209a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362813 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#799137}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If42bb28f8dba5b0ea1b4b0fe0720ed329d7e8213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363068Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799136}
-
Evan Stade authored
This is in preparation for componentization of the contacts picker. Bug: 1016938 Change-Id: Iba35bbd752087f17c5636fb10706f029a2522da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321563 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#799135}
-
David Roger authored
Bug: 1076880 Change-Id: I7bc1498f85a9f23bc182a17261d58b4b8e1a62e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362889 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799134}
-
Ilya Nikolaevskiy authored
Bug: chromium:949112 Change-Id: I33b42200891e72bc00cfc44933d312ce918f8839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362287 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799133}
-
Claude van der Merwe authored
kPhoneHubClientEnabled was inserted instead of kPhoneHubHostSupported. Bug: 1106937 Change-Id: I1a31c7904c0aae335e84289ed217d9495055c351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363250 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
-
Samuel Huang authored
This CL adds the "Container" option under "Group symbols by". This is meaningful only for .size / .sizediff files with multiple containers. Bug: 1040645 Change-Id: I93ea1548c3c11f7dbcbbdd4779e378715c1c373a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362989Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799131}
-
Sebastien Lalancette authored
The issue: Triggering "Open in New Tab" from the tab grid recent tabs' context menu did not navigate the user to that tab. The tab count was incremented, but it was hard to tell from the UI that something happened. The fix: Navigate the user to the new tab. Other fix: - Added a similar solution for incognito. The issue didn't happen in incognito, but I found it awkward to not have a similar approach. Bug: 1093302 Change-Id: I0513a1195b768bfaa802788443f411b8a24879c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359557Reviewed-by:
-
