GitLab

This CL removes direct dependencies on HelpAndFeedback from the Site
Settings UI, which is in the process of being componentized so it can be
reused by WebLayer. The existing help logic is moved to
ChromeSiteSettingsClient, since it contains Chrome-specific URLs and
logic.

Bug: 1058597
Change-Id: Id676437e447377e19f062ee5d1524bd2de0511d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128369Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755139}

Change-Id: I8883e99c1a412b4489781c1b556895af07260c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128833
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755138}

Previous versions of Chrome (M48 and earlier) looked for policy data
under the "ChromePolicy" key, but current MDM vendors do not support
placing policy data in a child dictionary.  This CL updates
PolicyLoaderIOS to read policy data from the top-level dictionary.  In
order to prevent existing configurations from taking effect as we enable
policy support, this CL also adds the requirement that an
"EnableTrustedTesterSupport" key be present and set to true, or else
PolicyLoaderIOS will not load any policy data, even if data is present
in the configuration dictionary.

This CL adds EG tests to verify that policy data is ignored when
the required key is not set.  It also splits the existing tests into
two files and simplifies how policy data is passed on the command line.

BUG=1065261

Change-Id: I4434b863dc9c52e3312c91365487a1fb05dc028e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123408
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#755137}

This is a follow up to crrev.com/c/2079303.

The PZPS header information is expected in the following format in the
Chrome suggest response. Every suggestion that must appear under a header
has a suggestion group id in its respective "google:suggestdetail" dict
which maps to a header text inside "google:headertexts>a".

...
"google:headertexts":{
  "a":{
    "40009":"Recommended for you"
  }
},
"google:suggestdetail":[
  ...
  {
    "zl":40009
  },
  {
    "zl":40009
  }
],
...

This CL improves on its predecessor by storing the header mapping
information in the ACResult and the suggestion group id in the ACMatch.
This allows hiding/showing matches that belong to a certain group id
(possibly using prefs) regardless of the internationalized header value.

Also as opposed to the previous CL that discarded the headers if they were
deemed incorrect, this CL assumes the server provided suggestion group ids
are correct and instead demotes the grouped suggestions to the bottom of
the list of suggestions do that the backfilled local suggestions would not
appear under server provided headers.

Bug: 1065152,1052519
Change-Id: I2c4e6a8a76606047e9350715fff0316190d24bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128843
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755136}

Change-Id: Ib7bf8c6c399953527fe8e988322502197f596a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130767Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755135}

When running under Xvfb, no visual will be set.  We allow this case
because it is useful for testing.  However, an error message still gets
printed out that says to report the issue to a specific bug on the
tracker.  This CL avoids printing that error message.

BUG=1025266
TBR=msisov

Change-Id: I1e692225f84a87bd6d9ab218e1b04102b4971ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127907Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755134}

While waiting for a pending navigation, verify that the current
frame still exists. Otherwise we might wait forever for a frame
that has already been destroyed.

Bug: chromedriver:3353
Change-Id: I0e80631a3880d24bf207e0871db07f31dad8100b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129088
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#755133}

Bug: b/152883420
Test: Unit tests
Change-Id: Ia2f77ed7f5557dd25bd4fd355319ff93e4df3ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129998Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755132}

This CL adds the token to the response, and the filename and digest
to the request for more context.

Change-Id: I9bb27473cca340f0fc3d23bdf8eaa042e7e466a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130629
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755131}

This is required as the shelf wants to use the same bounds animator to
record multiple histograms. See crrev.com/c/2105675 for a usage.

Test: added a tests
Bug: 1051490
Change-Id: Ie749ddd254ac8ae5e66229ec4b64cf86b5baa542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128373Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755130}

When the user doesn't swipe, the container is animated open or closed based on
the final height from dragging upon gesture end. Previously, only down-swipes
were treated specially: swiping down fast enough opened the container regardless
of its height.

This treats swiping up specially too, causing the container to close.

Bug: None
Change-Id: I7555e00dbddb21128175d36a2209139c15cf52d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128968
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755129}

Roll broadwell AFDO profile from 83-4044.62-1584958487-benchmark-83.0.4097.3-r1 to 83-4085.6-1585564150-benchmark-83.0.4097.3-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I3a4ee5f621f35aede8486c04a184bbf4b622bb67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755128}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3acfab72..1668abdd

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic4a3986b1f19818888625cfb9e1ff9507c4e7f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130707Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755127}

We still use these histograms.

Change-Id: I4db292322907924211c02c0a5d3c3a204b5ff4d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128788
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755126}

Change-Id: Ib985375a552b06dacf7a647fafcdc87b30afd9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108161
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755125}

Bug: none
Change-Id: I224b071422037d7e16b96339f3849367ae29f305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127889Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755124}

https://imgur.com/a/FuGtnqh

There needs to be a more long-term solution for alert states being
added, but this fixes the issue for now.

Fixed: 1066572
Change-Id: I7d09c453a206ea4d9a91dbb7a352f727b430ac4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129343Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755123}

Currently, the permission prompt bubble's title is "$origin wants to:",
which causes a confusing screenreader announcement when the bubble
appears: "Chrome has new window. $origin wants to."

This change introduces a new accessible title, which includes some of
the requested permissions. Specifically, it is one of:

* "$origin wants to: $permission"
* "$origin wants to: $permission and $permission"
* "$origin wants to: $permission, $permission, and more"

To accomplish that, this change:
1) Adds new strings for those messages
2) Adds logic to PermissionPromptBubbleView to build the accessible
   title
3) Slightly refactors PermissionPromptBubbleView to make it possible to
   construct without a live Browser and BrowserWindow, which allows...
4) Adds unit tests for PermissionPromptBubbleView to cover the new
   behavior

Bug: 434574
Change-Id: I3b72f1a51489776c059e952da470034e2e8b131b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116926
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755122}

Targets should start depending on these directly rather than going
through the legacy androidx_appcompat_appcompat_java target.

Bug: 896775
Change-Id: Ic1a6371882f70fb6da6731409c34d32d27017bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119542
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755121}

Both the Secure DNS Policy Handler and the Secure DNS Settings UI
support entry of multiple DoH templates.  However, the Policy
Handler requires all the entered templates to be valid, while the
Settings UI only requires at least one of them to be valid.

This change harmonizes the two, to require that all entered
templates be syntactically valid.  It also reduces duplication
of string manipulation for splitting groups of templates.

Change-Id: Ia66d939a93b6efae70e2fbdd31a6811c110be36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125874
Commit-Queue: Ben Schwartz <bemasc@chromium.org>
Auto-Submit: Ben Schwartz <bemasc@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755120}

To support an isInputPending implementation that supports
off-main-thread attribution, propagate compositor attribution decisions
to the main thread scheduler.

Issue: 910421
Change-Id: I23d643f790b7c7b8a4f9d32ec4fc88d930ae76ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083684Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#755119}

Mac key event handling works by first sending a key to the renderer.
When the renderer ACKs the event as unconsumed, the browser re-injects
the NSEvent back into the app. This is done so that the browser can
perform commands if the renderer didn't consume them (e.g. Command-T).

The Event.Latency.OS_NO_VALIDATION metric was temporarily added to
investigate the cause of long instances in the InputDelay metric. It
measures the delta between the event's OS-provided timestamp and the
current time when a WebKeyboardEvent is built from an NSEvent. This
metric is meant to narrow down where these long InputDelay values are
coming from.

OS_NO_VALIDATION assumes that the call to it happens close to where the
OS event is received by Chrome.  However, the reinjection mechanism
mentioned at the top breaks this assumption. When the event is
reinjected, there are cases where it must be passed to the content/
layer (e.g. when being passed to the Views FocusManager[1]) and a
WebKeyboardEvent is reconstructed.  Hence we record this metric multiple
times for such events, the second time causing the metric to depend on
delays in the jank.

This can reproduced by visiting a page with a very busy main thread
(e.g.  https://rbyers.github.io/scroll-latency.html and set a high
periodic jank) and performing "key equivalents" (i.e. browser commands
like Command-C) while the main thread is blocked. You'll notice very
high values reported in [2].

This CL adds a temporary constructor to NativeWebKeyboardEvent on Mac
that causes us to record this metric only on the code path that will
eventually send the event to the renderer (i.e.  avoid reinjected
events). This is temporary to prove this hypothesis and determine how
much of the problematic reports are due to other causes. It will be
reverted after a few days of data is collected.

Note: In https://crrev.com/4a7404eceeb I added a DumpWithoutCrash in
cases where we saw a big discrepancy in the Now() and event timestamp.
The issue addressed in this CL shows up in these stacks but there are
other cases that have a big discrepancy and are captured from
RenderWidgetHostViewCocoa::keyEvent. This CL will help cut down on the
noise so we can keep diagnosing the root cause.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm?l=44&rcl=fb1021a791d9141b4df6d639f0d50bfe0c0ce944
[2] chrome://histograms/Event.Latency.OS_NO_VALIDATION.POSITIVE.KEY_PRESSED


Bug: 1039833
Change-Id: I17af7f76db0f69024ec75b45822d69178a4cd565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129238
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755118}

This reverts commit e033ca47.

Reason for revert: Not needed yet.

Original change's description:
> [iOS] Add Safe Browsing opt out setting.
> 
> Bug: none
> Change-Id: Iaf328b22a6fba65a1d9a6deb837f379cd9405b5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088187
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751135}

TBR=rohitrao@chromium.org,ajuma@chromium.org,kkhorimoto@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: Ibc388798926a634d76b014b2f8dd931d22b6f7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130666Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755117}

Bug: 1059898
Change-Id: I22482839c28491a00d7f473e924de0710e8c94db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127741
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755116}

This reverts commit 8aee0918.

Reason for revert: Test being added is flaky. See
https://bugs.chromium.org/p/chromium/issues/detail?id=1066619

Original change's description:
> Add MainSettingsFragmentTest
> 
> MainSettings.java have bit less test coverage over some of the
> preferences, for example, the HomepageSettings at this moment. Adding
> MainSettingsFragmentTest is aiming for more test coverage for the
> list of preferences on the settings screen.
> 
> Bug: 1052060, 1066362
> Change-Id: Ib51c133f2a73f4ec85cc185c4101833bc3fa0b58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124729
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754957}

TBR=twellington@chromium.org,wychen@chromium.org,chouinard@chromium.org,wenyufu@chromium.org

Change-Id: If15e22de962484fc87b3b5dc5eb1cfcf550cf024
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052060, 1066362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131017Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755115}

https://quiche.googlesource.com/quiche.git/+log/1bcd0c3f96e1..0abcd8febd32

$ git log 1bcd0c3f9..0abcd8feb --date=short --no-merges --format='%ad %ae %s'
2020-03-30 wub gfe-relnote: (n/a) When QUIC switches from BbrSender to Bbr2Sender, let Bbr2Sender copy the bandwidth sampler states from BbrSender. Protected by --gfe2_reloadable_flag_quic_bbr_copy_sampler_state_from_v1_to_v2.
2020-03-30 renjietang Remove QuicStreamIdManager::DelegateInterface::OnCanCreateNewOutgoingStream().
2020-03-30 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_use_quic_time_for_received_timestamp2.
2020-03-30 vasilvv Ensure QuicTransportStream::Visitor::OnFinRead() is only called once.
2020-03-30 bnc Fold QuicReceiveControlStream::HttpDecoderVisitor into QuicReceiveControlStream to remove one layer of indirection.
2020-03-30 fayang gfe-relnote: Reset consecutive_pto_count and loss detection when discarding keys. Protected by existing quic_enable_version_draft_25_v3 and quic_enable_version_draft_27.
2020-03-30 bnc Do not send a MAX_PUSH_ID frame if SetMaxPushId() has not been called yet.
2020-03-27 bnc Simplify Http3DebugVisitor methods.
2020-03-27 bnc Pass payload length or compressed header block length to some HttpDecoder::Visitor methods.
2020-03-27 fayang Enable IETF QUIC for more gfe/gfe2/e2e tests. Also let quic_spdy_client process MAX_STREAMS if it cannot open new streams.
2020-03-27 dschinazi Move some QUIC tests to QuicTest

Created with:
  roll-dep src/net/third_party/quiche/src

R=bnc@chromium.org

Change-Id: I5fb2f81dd0a8d7aa81edc19831554e7335de35b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128716Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755114}

Moves the enums I thought could belong to either class that uses them to
a shared location. Left ones that I thought were clearly associated
with their class (OverviewItemView::HeaderVisibility,
OverviewWindowDragController::DragBehavior). Also removes unused enum
OVERVIEW_ANIMATION_SELECTION_WINDOW.

Test: compiles
Bug: none
Change-Id: I1b280f29e3330b238754e019509f0da35ce4d5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125553Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755113}

This CL makes WebAPKs use TwaSharingController as part of merging the
WebAPK and TWA codebases.

BUG=1059580

Change-Id: I32db42b90854937318b06ed2a295078659ae7bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100817
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755112}

Use the activity context instead of the application context to tint the
icons in the share sheet.

Bug: 1009124
Change-Id: I5f0fc4175dce70031c41b4f8f7e0d31578a267ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130670Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755111}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17ffd9875c34..a680c23e7859

git log 17ffd9875c34..a680c23e7859 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 ehmaldonado@google.com git-cl: Fix checking if parent branch has been uploaded.
2020-03-31 ahaas@chromium.org [man] Fix order of depot_tools in PATH
2020-03-31 ehmaldonado@google.com git-cl: Move GCE detection when creating a connection.

Created with:
  gclient setdep -r src/third_party/depot_tools@a680c23e7859

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I429219759bd40684408b8c78063d53c401a91ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130828Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755110}

Bug: 1060805c
Change-Id: Id2ca8e91cd3f9626d570f68f69563d830f2ff7b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128940Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755109}

This reverts commit 950810de.

Reason for revert: Loading behavior fixed

Original change's description:
> Revert "Record split UMA histograms when rendering has been delayed for font preloading"
> 
> This reverts commit 4a7fe529.
> 
> Reason for revert: The loading behavior is designed wrong.
> 
> The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is.
> 
> Currently: the behavior is observed when rendering is delayed by font preloading.
> 
> What's actually needed: the behavior is observed when font preloading occurs
> 
> Original change's description:
> > Record split UMA histograms when rendering has been delayed for font preloading
> > 
> > This patch adds split histograms of the following metrics when
> > rendering delay for web font preloading has been triggered:
> > - PaintTiming.NavigationToFirstPaint
> > - PaintTiming.NavigationToFirstContentfulPaint
> > - PaintTiming.NavigationToLargestContentfulPaint
> > - LayoutInstability.CumulativeShiftScore
> > 
> > This will help us understand the effectiveness of this optimization, and
> > adjust the length of the delay to the best value.
> > 
> > Bug: 1040632
> > Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251
> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> > Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#754771}
> 
> TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org
> 
> Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1040632
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755081}

TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org

Change-Id: Ibae7230089fe9e56e91cf1480d19c7bc70778567
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131011Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755108}

After TooltipControllerCaptureTest was renamed to
TooltipControllerTest, the filters were not updated.

The CL that did that - https://crrev.com/c/2117335

Fix that.

Bug: 1065474
Change-Id: Ibc8df1137f45d001eb81ce3624a59e2c1c81b4ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130248
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755107}

An extension can use the privacy.websites.ThirdPartyCookiesAllowed
extension api to set the kBlockThirdPartyCookies preference.
kCookieControlsMode needs to be set to the corresponding value if
kBlockThirdPartyCookies is controlled by extension.

Bug: 1065392
Change-Id: Ib450349cb33251b3eccc06ff2dcc18a0899a028e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127034
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#755106}

This provides access via the system menus to a new setting that is
currently only present in the omnibox context menu. To achieve that,
this change:

1) Adds a new IDC_SHOW_FULL_URLS command and handling logic
2) Adds a new conditionally-present item to the main menu bound to
   that command
3) Has OmniboxViewView listen for changes in the backing pref and
   update its appearance
4) Remove the logic in OmniboxViewView to manually update appearance
   when changing the pref, since that is now accomplished via
   listening to changes on the pref

This change doesn't have any automated tests. I spent some hours
trying to write one, but ran persistently into two problems:
1) All the existing tests of OmniboxViewView are Views unittests
   and do not have a "real" LocationBarView/Browser/PrefService
2) Adding a new test, using BrowserWithTestWindowTest instead,
   means having to construct a real LocationBarView and quite
   a few other backing services/classes/etc.

The effort involved and brittleness of the resulting test quickly
exceeded the value of the test, so I decided to just do without.

Bug: 1061576
Change-Id: I17d86124e334fb7f85407a16f2c8c31d9f77ebbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120854
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755105}

Add missing trailing semicolon.

Bug: 1065504
Change-Id: I98fe899a3934a1c4e6df34f7e08b171647bd9be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130447
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Qijiang Fan <fqj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755104}

This reverts commit 350ec69f.

Reason for revert: After this change, changing android_channel in args.gn and rebuilding doesn't reliably cause a manifest rebuild and some of the built APKs end up still using the package name/etc from the previous channel. crbug.com/1066594

Original change's description:
> Android: Add md5check to compile_resources.py
> 
> Using md5check speeds up the build by not re-compiling resources if its
> dependencies have not changed.
> 
> Shaves 5 seconds off for Chrome Java Signature Change (77s -> 72s).
> Shaves 12 seconds off for Base Java Signature Change (174s -> 162s).
> 
> Bug: 906803
> Change-Id: Idccbc080dfdfb75b1ce801f3fcd934b93c2c3bb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120047
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Auto-Submit: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754507}

TBR=wnwen@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 906803
Change-Id: I66045a49a1076b1c2644cc1a1b96a5d4c3cf547d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130866Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755103}

* Keydown 'Enter' causes the selected row to trigger a route change.
* If the selected row is focused, keydown 'Enter' triggers route change.
* Clicking on specific row causes the row to trigger a route change
  (iron-list also causes the row to become the selected row on click).
* If a user deselects a row, re-select the row (one row should always be
  selected). Deselection is an <iron-list> behavior we must work around.
* Add test to confirm <os-search-result-row> has the correct behaviors.
* A route change won't cause the cr-input to lose its text, nor will it
  cause the results to be lost, nor the selected item to be deselected.

Bug: 1056909
Change-Id: I00c151acd7439b916b4b01bec188cb48197c775d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123787
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755102}

Problem :
AXObjectCacheImpl accumulates events when it's not clear whether layout
is in a clean state then fires these events when layout is clean.
Unfortunately this means that if an event is enqueued that isn't
associated with a layout change then there's no guarantee the event
will be fired.

This CL attempts to fire these deferred events more regularly by
hooking up an accessibility DocumentLifecycle state, and scheduling
a lifecycle update whenever a deferred event is enqueued to guarantee
the events are fired.

Bug: 1050792
Change-Id: Iceb9fe5252aff5538435710b1d285b93c609bba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055361
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755101}

Extends the expiration of Extensions.Checkup.TimeSpent,
Extensions.Checkup.NtpPromoClicked, and
Extensions.Checkup.NtpPromoShown to after M85.

Bug: 1066034
Change-Id: I082734ceacb0ea66dfd8893dfc35b7b8fb88dbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129027Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755100}