- 23 Oct, 2020 40 commits
-
-
Wei Li authored
These buttons are subclasses of ImageButton or LabelButton. Since they didn't set their focus behavior, they inherit the beahvior. This CL uses DCHECK to assert such behavior, and set the behavior explicitly. So when we change ImageButton and LabelButton's focus behavior later, these buttons won't be affected. Bug: 1001103 Change-Id: I88675c772b83348f68234d588a3c3884387fea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495820Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820469}
-
Robert Sesek authored
Also crash on sysctl-read failures. Bug: 1126350 Change-Id: I9d69c69979ab076e257ca079f6e5f09aed5c28be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493440 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820468}
-
Dana Fried authored
This CL moves the logic for calculating size and placmeent and for drawing the "New" badge into any View. It also provides (as a convenience) a drop-in version of Label that displays a "New" badge that can be used in almost any situation a plain label can be used. Bug: 1055150 Change-Id: Ib9227c9dfc630eb0c03650adf5b8f177a086b431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486575Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#820467}
-
Max Curran authored
As part of the refactor and improvements to Translate's metrics, added two UMA histograms related to TranslateRanker. This information will eventually be logged in UKM as well. Updated TranslateRanker's unit tests and added unit tests for TranslateMetricsLogger to confirm that the metrics are recorded as expected. Full Design Doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I56ea8fc167599688596da015cef00454790f991c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481472 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#820466}
-
Lei Zhang authored
It's been replaced with LOGGING_NUM_SEVERITIES. Bug: 849450 Change-Id: Ib43718d39a8d171a53e88d6d51942d28f42b7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494504Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820465}
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: If9bc0044ad01654eb4a92f81acd28d346ab291d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495786Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820464}
-
Steven Bennetts authored
Static IP configuration for Cellular networks does not work and can only break things. Bug: 993587 Change-Id: I734c25ccabd5330134aa59be9eea04f3dc6ad0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495704 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820463}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42c17639..c572b425 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie07fa49ce28eecad493eff84d3a92452e7232393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495247Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820462}
-
Scott Violet authored
BUG=1141927 TEST=test only change TBR=xdai@chromium.org Change-Id: I150f47081d1d88afc15c0c90f7f1fc6c333aee48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495831Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820461}
-
Liquan (Max) Gu authored
Context: Currently, //components payment targets depends on //chrome resources ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. It's because the payment view templates depend on them. This CL is written to break the dependencies. Changes: * this CL changes to set fre_product_logo and product_logo_name programmatically from //chrome, from having them referenced in //components templates. * ic_edit_24dp.png is moved from //chrome into //components Before: The two //components xml templates depends on the //chrome resources ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. After: No //components payment targets depends on the //chrome resources. Bug: 1141076 Change-Id: Idea99bdb55d1dd633a540eee4d2db27e2c471634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490162 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820460}
-
Joe DeBlasio authored
This CL re-arranges some early-abort behaviors to avoid calling GetDomainInfo() when possible, since GetDomainInfo() is very expensive. This is a pretty small change that'll hopefully help some performance regressions. A better long-term way to make a difference is to put off the expensive parts of GetDomainInfo, possibly by lazily populating the IDN-related parts, until needed. I might give that a shot in a follow-up CL. Bug: 1135279 Change-Id: Iaddc566274501501a7d8a141bc58c21639ee0f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495611 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820459}
-
Austin Sullivan authored
Bug: N/A Change-Id: I2fa776ab02969c19fec3cc1bffd0745a181da598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488393Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bec20b5b70c..3691164b7e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sky@google.com,mohsen@google.com Change-Id: Ia54a6ddcbb17f39c8a1dd734de351d8898db8a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820457}
-
Dana Fried authored
This change switches the extensions menu to enable focus traversal at the focus manager level, allowing both right/left and up/down key traversal. It also removes BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is only used in one other place - in favor of FocusManager::set_arrow_key_traversal_enabled(), which also supports left/right arrows and pre-exists the bubble dialog method. These changes mean that when the scroll pane is active in either dialog, up and down will scroll the pane but left and right arrow keys will still allow the user to traverse the dialog (at least on Windows and Linux; on Mac, up/down may still work within the pane). Bug: 1140632 Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#820456}
-
Jeffrey Kardatzke authored
Expands testing in a few ways: 1. Adds an additional test file to fully parse. 2. Checks validity of parsed fields in SPS. 3. Adds a fuzzer (it even found a bug already). BUG=chromium:1141237,b:153111783 TEST=media_unittests pass, fuzzer builds/runs Change-Id: I3036c2e28466e460ba35647bea38fd53d491b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495344Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#820455}
-
Eric Orth authored
Change the return type of DNSDomainToString() to base::Optional<std::string>, so it can return nullopt on malformed and empty string on root. This is needed because HTTPS records can have root names in some cases, so we need to be able to differentiate that from actual malformed names. While messing with the method interface, also fixed the camelcasing in the method name, and changed the type to StringPiece value instead of the unnecessary const&. A subsequent CL will have more substantive fixes to make DnsDomainToString() stricter to the standards validations we need, but I wanted to get the mostly-mechanical stuff out of the way first in a separate CL. Bug: 1138620 Change-Id: I23d092051fe48826972a5fb5b3279dedf473ee1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495296 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#820454}
-
Bruce Dawson authored
When running blink web tests it is important to invoke the wrapper script (run_isolated_script_test.py) with vpython or else psutil and six will fail to import. This change wraps the import of psutil and six in an exception handler so that a useful error message can be printed. This should make it easier for users to find the correct solution. Change-Id: Ia2712e97790d8b54bb9cc640ace37a0fe01ce1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495868 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820453}
-
Lei Zhang authored
Bug: 646113 Change-Id: If54ca0e37d47fcd40ac4abab7f0f586c31c0640c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483028 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820452}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/530933006d3c..42a741a2145c 2020-10-23 robertphillips@google.com Allow vertex data to be stored in the thread safe cache 2020-10-23 jvanverth@google.com Add control to toggle immediate/delayed MTLDrawable acquisition 2020-10-23 kjlubick@google.com [canvaskit] Use portable fonts for GMs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: I0d79db5a392a394d65b335e9d9acde044c3ed1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820451}
-
Nate Chapin authored
HID becomes a Supplement<Navigator> instead of an ExecutionContextClient. This means it retains a references to the Navigator, which is itself an ExecutionContextClient, so it still has access to the ExecutionContext. Change-Id: Ie1d789fb6588c816f39c5b0645d1973aee43caef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495503 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Lei Zhang authored
Mechanically convert OneArgument(std::move(value_unique)) to OneArgument(base::Value::FromUniquePtrValue(std::move(value_unique))). Bug: 1139221 Change-Id: I0d7bbfebc3d4397bfef68e77fb1b09bffa4bb696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473502 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820449}
-
Vidhan authored
Bug: 1127001 Change-Id: Ic565865326ca4d75ed5c21e34bc2ca207f1f5c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404640Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#820448}
-
Victor Costan authored
Change-Id: I07613815b937259cac8a4ffe9128740a3877a0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496020 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820447}
-
cfredric authored
MakeURLRequestContext. Change-Id: Ib70802646e93f7f03d26d0db5a708193db94b4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495291 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820446}
-
Sinan Sahin authored
Bug: 1084025 Change-Id: Ibda57e17ab9c1177601cb4e398938e1b5f769a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490867Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL fixes a regression introduced in an a11y fix for the tray menu https://crrev.com/c/2465518. This caused the zero state "Scanning for devices" message to appear multiple times. Fixed this by re-using this label as well. Fixed: 1139559 Change-Id: I24bf7e6c8edb1c59086e127f38d3bf9029023c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482443Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820444}
-
manukh authored
- Adds system_bundle_version field to CastAssistantLogsProto. - Adds feature_triggered_in_session field to OmniboxEventProto. Change-Id: I259d6ea5cacbbfe3a2da0ec18f9578d8417ef960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480883Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#820443}
-
Robert Ogden authored
head_ can be null, which need to be checked. Bug: 1141966, 1136174 Change-Id: Iacf1fa42928394da070d5d033ef6edaa041c416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495675 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
George Steel authored
This allows transform animations on css boxes to be composited regardless of whether keyframes are absolute of contain percents. Exclude SVG targets from flag (keeping keyframes with percents non-composited) as they do not support compositor animation invalidation on box-size changes, and supporting this requires SVG transform logic in the paint property tree builder to become stable. Design doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I6c774d4adfdb1dfea4ed252e92642a0aaa256030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495604Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820441}
-
Dave Tapuska authored
ViewHostMsg_ShowWidget becomes a message on the PopupWidgetHost channel requesting a previously created widget to be shown. Previously a WidgetMsg_SetBounds_ACK was sent after the ShowWidget message was received this turns into a mojom callback. BUG=1097816 Change-Id: Iaefef58ed882abd0cd3c13b0eaf2a023789d047f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492563Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#820440}
-
Peter Boström authored
This turns a previously broken DLOG into a DCHECK that triggers if a subpixel-rendered label is painted on top of a non-opaque layer without using an opaque background for any of its parent views. This DCHECK is not yet turned on for ChromeOS as tests are failing. Bug: 1139395 Change-Id: I2422a9e66220780b1f2a105ac9c9320fa9a3aae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488066 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#820439}
-
Bo Liu authored
VulkanContextProvider currently owns things such as GrVkSecondaryCBDrawContext that is per-webview rather than (assumed) global. Factor out a AwVulkanContextProvider::Global that provides of sharing things that are (assumed) global, and create new instances of AwVulkanContextProvider for each draw functor instance. Need to pass the right instance of AwVulkanContextProvider into viz. Only hook this up for the viz code path. Bug: 1141683 Change-Id: Ia98a2e9edb74ccdda56f75944a3257e64efc79fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485778Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820438}
-
My Nguyen authored
Language preference does not work for ARC++ apps so it's confusing to have Languages for apps and websites. Update to Web content languages as per UX instruction in http://screen/9BzyiPBEKPaxJ7d Screenshot view: http://screen/BHQBr82CjccbZmv Bug: 1140779 Change-Id: Ida3067f6a04bb09efa28c25ccf723e979873e5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494298 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820437}
-
Daniel Cheng authored
Bug: 1047547 Change-Id: I9632a961521ac6818e67662b13d7e24ea320c977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494510 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#820436}
-
Victor Costan authored
Change-Id: Ic6febb7dde96dbc3a52b306eea37dde5c5bcf3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495399 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#820435}
-
Victor Costan authored
Change-Id: If6540fc63a02a012dc903beed9644e3eac478a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495783 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#820434}
-
Josiah K authored
(For use in Accessibility Common, to enable Magnifier Panning Improvements including Keyboard Panning) AX-Relnotes: n/a Change-Id: I751e8b319488c4dcd0d9e28775a3990ef93cdf10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491601 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820433}
-
Ahmed Fakhry authored
- Both AudioEncoders and WebmMuxer were using ThreadCheckers to assert operations being called on a valid thread. However, there's no need to enforce all operations happening on the exact same thread. What we care about is the sequence of operations, therefore a SequenceChecker is good enough. - Add mechanisms to flush any buffered frames in the encoders or muxer to avoid dropping frames, and also enable manual flushing rather than having to destroy the object to have it flush its buffers. BUG=1126586 TEST=Modified a test in media_unittests --gtest_filter=*AudioEncodersTest* Change-Id: Ife44c440c48408553dacdd92fd8800cdc5c7a233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490884Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
rbpotter authored
This reverts commit 7c245642. translation.py script parses all checked-in grd/grdp files. This means that the dummy test expectation file was causing failures, because the grdps it includes don't actually exist (the lines are just there to validate that the generate_grd.py script can correctly generate grdp lines). P3 (see PS1->PS3 diff) fixes the issue by putting the test expectations in a string instead of in a checked-in expected grd file. TBR=dpapad@chromium.org Original change's description: > Revert "WebUI: Add support for producing/consuming grdp files in generate_grd.py" > > This reverts commit 448e1b37. > > Reason for revert: Breaks translation, crbug.com/1141934 > > Original change's description: > > WebUI: Add support for producing/consuming grdp files in generate_grd.py > > > > This will be leveraged in follow up CLs, to auto-generate parts of > > webui_resources.grd. > > > > Bug: 1132403 > > Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920 > > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > > Commit-Queue: dpapad <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820148} > > TBR=dpapad@chromium.org,rbpotter@chromium.org > > Change-Id: Ie0e71ef0d9a7dd8bbe5c0da452692b3e9c3f96db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1132403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495518 > Reviewed-by: Krishna Govind <govind@chromium.org> > Commit-Queue: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820344} TBR=dpapad@chromium.org,govind@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132403 Change-Id: Ic2f5d9aecd4843113fae189351a6748a675e7ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495292 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#820431}
-
Yue Li authored
Deprecate and clean up Quick Answers simple UI. Bug: 1084284 Test: Run existing tests Change-Id: I03d93b36e2945a5b45ff50eafd8dc5907340b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374505 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
