- 02 Jan, 2020 40 commits
-
-
nancy authored
The ARC app shelf id could have prefix "shelf_group:", and AppService can't find the app type for that shelf id, so check ARC app shelf id first before checking from AppService record. Update ARC tracker to use the app shelf id as the app id and checking the profile when getting the ARC shelf id to resolve the unit test failed issue and user switch crash issue due to the above change.. BUG=1011235 Change-Id: I817f059bb0cf65dc89a458b6b2bdf78ab22afc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984783Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728038}
-
Avery Musbach authored
The drop target in each overview grid shall have bounds representing anticipation that if the dragged window is dropped into that grid, it will shrink to fit into the corresponding work area. Bug: 961170 Change-Id: I909723441c859dce0e0131e4f7e990b54b6e9e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982233 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#728037}
-
Haiyang Pan authored
This enables the android app bundle, as introduced in crrev.com/c/1975037 Bug: 986990 Change-Id: Ie63c87936fae97ee72fd1fc96dbb4aa3968eac54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959377Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#728036}
-
Dave Tapuska authored
Add helper to MainThreadEventQueue unittest to compare the fields of the classes instead of using a memcmp function. BUG=836826 Change-Id: Iaa280074743593d8687ce923c48f778d16f1d4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979260 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728035}
-
nancy authored
Set the window's property AppType for Crostini apps. This is the current implementation in Crostini app window launcher controller: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc?q=ash::AppType::CROSTINI_APP&l=275&dr=C BUG=1011235 Change-Id: I82a816e0f6dc631608bd368b16b765dfc345d131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985623Reviewed-by:
-
Vincent Scheib authored
Convert base::Callback to base::OnceCallback in device/bluetooth/dbus/bluetooth_agent_manager_client.h This changes BluetoothAgentManagerClient::ErrorCallback to a OnceCallback, and updates calls in bluetooth_adapter_bluez.cc to be base::BindOnce. Bug: 1007780 Change-Id: I32af4f619b5cfeccc70bb1b33e6d3b61fbdeea3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982243Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#728033}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7499856e853c87c1e374a22ca84d94133b3c4a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984344Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728032}
-
Anubha Mathur authored
Adds a layout test to validate accessibility in DatabaseQueryView (i.e. WebSQL console in Application panel) Change goes along with - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1974461 Bug: 963183 Change-Id: I7666a3ca14f446a65337d95f9c0bb0e047d4d589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713810Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728031}
-
Tricia Crichton authored
Alter the element and window size to reduce flakiness of tests caused by scrolling. Bug: 1038366 Change-Id: I448ffd291a55d596f2a832021645061fde168931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984533Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728030}
-
Sven Zheng authored
Currently e2e tests randomly fails with: 1 No real error, just failed to wait for data to sync to clients. 2 PostClientToServerMessage with SERVER_RETURN_NOT_MY_BIRTHDAY 3 PostClientToServerMessage with NETWORK_CONNECTION_UNAVAILABLE 4 Failed to log in to GCM, resetting connection. With 401 error code. Most of time it is just because we didn't wait for enough time. 30 seconds is not enough. And I did see once, after reseting account, I logged in in a new client and saw NOT_MY_BIRTHDAY in chrome://sync-internal So adding a wait there to prevent flakiness. This cl includes two fixes: 1 Wait for NOT_MY_BIRTHDAY to propagate. 2 Extend the invalidation wait time by flag. The actual timeout will be added later. Test: Run test suite 10 times with no retry and all passing. Bug: 1032731, 1034716 Change-Id: Ia4a5d6baa048fe16c311999ddfcdfcaac9b24e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977183 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#728029}
-
Dana Fried authored
See notes on attached bug, but here's a precis: - Incorrect indices were being used in slide animations in some cases which can result in bad behavior/crashes. - Multiple slide animations which are redirected now resolve correctly. Bug: 1037947 Change-Id: Ic37df566de811a01c35e63300bab644159658fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983446 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728028}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0e9b55a7fb886150e915207e6f23f2bbe387443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728027}
-
Kehuang Li authored
A defined struct uses int64_t but didn't include cstdint, which causes issue if some class doens't have cstdint included but have constants.h included. Bug: NONE. Test: NONE. Change-Id: I0a1700fac5c4a91735f889514d95c9a03b59edda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986013 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#728026}
-
Peter Kasting authored
This looks better than tiling in many cases when themes do not provide a tall enough image, and matches what we already do with frame and background tab images. Bug: 900424 Change-Id: Ib03567b32dfab13e1c17393a72d900a3c8edfe43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979512 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728025}
-
Dan Beam authored
If anything on the new /security page is searched for, search fails an assert()ion because there is no associated control. So we just add no-search to the security page for now. R=rbpotter@chromium.org Fixed: 1038420 Change-Id: I91bf27c93e31eb4898e9dd74701c3dddadd5b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984636 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728024}
-
dalyk authored
This is a reland of 3de13806 Only the HttpWithDnsOverHttpsTest.EndToEndFail test has changed from the original cl. Rather than causing DoH failures in this test by shutting down the DoH server (which caused ERR_DNS_TIMED_OUT errors on Win7 rather than the expected ERR_CONNECTION_REFUSED errors), the DoH failures are now created explicitly in a request handler. Original change's description: > Add is_secure_network_error field to ResolveErrorInfo. > > This new field represents whether a host resolution error resulted > directly from a DNS-over-HTTPS attempt. It will be used in future cls to > prepare the error page for secure DNS errors and to trigger captive > portal probes. Note that if a result was obtained from the cache this > field will be false, regardless of whether the result was originally > obtained securely, because this field is intended to identify secure > DNS *network* failures. > > Bug: 1037899 > Change-Id: I21b8afaeb103f12d7d572f8cf8b29d2e1228d007 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978106 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727821} Bug: 1037899 Change-Id: I70dc447ac1bcc6b67b6d249fea6fc6cf74d0b9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984642Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#728023}
-
Dave Tapuska authored
In preparation of removing the WebFloatSize class remove unused includes and references to it. TBR=tdresser@chromium.org Change-Id: If6436da38b91129f0fc74579f3f28527617a74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979110 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Toni Barzic authored
Shelf::ProcessGestureEvent expects an event with in-screen coordinates (for example to properly calculate window transform during window drag from shelf). Update ShelfNavigationWidget to pass gesture event copy with the location in screen coordinates to Shelf::ProcessGestureEvent. Updates ShelfLayoutManagerWindowDraggingTest.DraggedMRUWindow to verify that the dragged window is scaled as expected during the drag, and to test gesture starts from navigation and status area parts of the shelf. BUG=1034145 Change-Id: I839c6daaaf7577f09444e8094a4fe55dc2502e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985132Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#728021}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbbfa2f28a0e..1fdf6ca5141d git log cbbfa2f28a0e..1fdf6ca5141d --date=short --first-parent --format='%ad %ae %s' 2020-01-02 xinghua.cao@intel.com D3D11: Restrict to translate uniform block to StructuredBuffer Created with: gclient setdep -r src/third_party/angle@1fdf6ca5141d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I282f069d884085a0e6a556b0e7b96966354fd4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985693Reviewed-by:
-
Rob Buis authored
Handle out-of-flow elements in MathML containers. This matches the tests and what we decided in [1], i.e. positioning the element relative to the start-start corner of the containing block. [1] https://github.com/mathml-refresh/mathml/issues/16 Bug: 6606 Change-Id: I9f010adf60085924199867aae7917e9abd1d9b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978752Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#728019}
-
Dominic Battre authored
This CL enables the two experiments in fieldtrial_testing_config.json. Bug: 956560 Change-Id: I82940976641e32b53671a4bb46d4363b71f35fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985014Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#728018}
-
Eugene But authored
Convert the following test: - testAccessibility (partially) - testTranslateSwitch - testAddLanguage - testLanguageDetails - testUnblockTargetLanguage - testUnblockLastBlockedLanguage - testUnblockUnsupportedLanguage - testEditMode - testDeleteLanguage Create LanguageSettingsAppInterface to allow reading and writing language prefs. Add -[ChromeEarlGrey dismissSettings], because back button matcher does not work in EG2 and there is no need to dismiss settings via UI in each test (testAccessibility can cover back button usage). TBR=droger@chromium.org Bug: 987646 Change-Id: Ie6584086e8c8d347494d6a382b25f9f1cc799ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979508 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#728017}
-
Mugdha Lakhani authored
Bug: 1036959 Change-Id: Ifafe1b8af1005a47beb6408dd3e947c2b91cc2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985018 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Approved I2S https://groups.google.com/a/chromium.org/d/msg/blink-dev/gDLl4fKCr8Y/35aaeQ0fAgAJ BUG=872777 Change-Id: Ib45c1cebca2181f61d2fa29bd702fed8a99ff530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979005Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728015}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/45ab65a9bfcc..0bad0c3f9858 git log 45ab65a9bfcc..0bad0c3f9858 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 michael.liao@microsoft.com [Performance]: SR fix for flame chart canvas groups 2020-01-02 janscheffler@chromium.org Fix waterfall column shift in network panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@0bad0c3f9858 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibdd6c5278188d23e7e1cc033cde8a2bf22b1fec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984997Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5abfe3af46e6..7af927e60755 git log 5abfe3af46e6..7af927e60755 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 mmortensen@google.com query_build_logs: Check/set prodaccess before dremel query 2020-01-02 engeg@google.com cbuildbot: add todo for branch release archive filename mismatch Created with: gclient setdep -r src/third_party/chromite@7af927e60755 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iaaeefac0cf22b48285dcafccbdf180fc6c766b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986010Reviewed-by:
-
Oriol Brufau authored
<img> elements are usually replaced, so they can't originate a ::marker pseudo-element even if they have 'display: list-item'. However, if they point to an invalid image and have an alternative text, then they are not replaced. Therefore they can have ::before and ::after pseudo-elements, and also a ::marker if they have 'display: list-item'. Before this patch, markers with 'content: normal' were never generated. And non-normal ones worked fine in the inside case, but when outside they triggerede a DCHECK failure because the marker was created but not laid out. BUG=1038644 TEST=external/wpt/css/css-pseudo/marker-content-017.html The test fails in legacy because the 'content' property is not supported yet in ::marker. Change-Id: I4420bc2e9a0460f3a59fa030e5e3d249428aa6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985759Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#728012}
-
Clark DuVall authored
This should not be in org.chromium.chrome.browser since it is part of components/content_settings. This will be needed to move chrome/browser/permissions into a component for WebLayer. Bug: 1025609 Change-Id: I828c7c11c8ae6786e0f91399c105a4871a44c600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981134 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#728011}
-
John Abd-El-Malek authored
We weren't passing a profile name so it was always in-memory. I'm using this in a follow-up cl to force all downloads in weblayer_browsertests to go to this temp profile directory instead of filling up the default download folder. It also makes sense that WebLayer Android browser tests match desktop, and non-WebLayer as well. Bug: 1025603 Change-Id: I1f4fe20e77e6405b97365a9dfa30917fd1c5d486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984761Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728010}
-
Andrew Grieve authored
Bug: 1036426 Change-Id: I44ca24f69b23169860ab115a6e4e7de720d67841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984799 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728009}
-
Avery Musbach authored
Near the end of SplitViewHighlightView::OnWindowDraggingStateChanged, there is a DCHECK that the previous window dragging state is kNoDrag, when actually it is expected that the previous window dragging state also can be kOtherDisplay. I should have removed this DCHECK in https://chromium-review.googlesource.com/c/chromium/src/+/1977155 Bug: 961170 Change-Id: Ifdd27ae5e610f05e754c401e7805798df4a95098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981648Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728008}
-
Brian Sheedy authored
Updates several VR goldens that were affected by a slight difference in antialiasing. TBR=alcooper@chromium.org Change-Id: I63dec08f93eea81cfa3e1c7eb0be7b90ea688e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985824Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728007}
-
Marijn Kruisselbrink authored
The file system provider API passed metadata back from the extensions without any kind of sanitization. This means that for example "valid" blobs with negative sizes could exist. We don't want to have to deal with these weird beasts on the blob size, so add some assertions to the blob code to make sure this doesn't happen, and sanitize negative sizes on the file system provider side before passing them back. This is part of a series of changes to improve consistency surrounding how snapshot state of files/blobs is implemented. Bug: 844874 Change-Id: Ie3dd1de9d49b071b615e969ec68529bf3074c875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976431Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Bettina authored
For saved password reuse warning text, the domains are reordered based off of which are most commonly spoofed. Thus, the correct domain ranges should be used when bolding. Bug: 1038132 Change-Id: If7f372b3bd7b8f2aaf379f556dee5348f1441dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983352Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728005}
-
Olivier Robin authored
NavigationManager can return -1 as the last committed index when back/ forwarding to a restored URL (even if IsRestoreSessionInProgress returns false). Accept -1 from navigation manager in that scenario. Also rename storage_has_navigation_items variable. Bug: 1035960 Tbr: eugenebut Change-Id: Ie3c126c76c884c91997303728265ee2b5572851f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985762 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728004}
-
John Abd-El-Malek authored
Per the comments in BrowserTestBase, PreRunTestOnMainThread is meant to be inherited just by test harnesses. Change-Id: I8e3e0e20589219f4a1561ca194ea3d73c7378b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980983Reviewed-by:
-
Adithya Srinivasan authored
Changes browser side implementation to use last committed origin instead of receiving and checking an origin sent from the renderer. Bug: 1030892 Change-Id: I5a2c007b80bd1a0a71ac041efc046eb7b8a2317e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978998 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728002}
-
Daniel Libby authored
There are a few tests which call PageScheduler::EnableVirtualTime at the start of the test, then PageScheduler::DisableVirtualTimeForTesting at the end of the test, to reset state. Disabling virtual time currently does not reset the MainThreadSchedulerImpl's initial_virtual_time* fields. If a subsequent test then calls EnableVirtualTime, since the MainThreadScheduler is shared across tests, we can end up in a situation where the ThreadLoadTracker sees inconsistent timestamps and DCHECKs. This happens due to the fact that there is at least one task that runs and records timing between DisableVirtualTimeForTesting and EnableVirtualTime - the ExitRunLoop task from blink::test::RunPendingTasks, which is invoked from SimTest::TearDown. When the next test comes along and does EnableVirtualTime, the MainThreadSchedulerImpl sees that there was a previous initial_virtual_time and proceeds to apply the BaseTimeOverridePolicy::OVERRIDE policy to the AutoAdvancingVirtualTimeDomain along with a timestamp in the past. When the next task's timings are recorded by ThreadLoadTracker, it sees that time has gone backwards and we DCHECK. This change makes it such that the initial_virtual_time fields are reset when DisableVirtualTimeForTesting is called. This will cause them to be re-populated on the next test's call to EnableVirtualTime and time won't go backwards. Bug: 845197 Change-Id: I756949db2b4dbbdd1b7b2b35b92fab80a4b20d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984875Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728001}
-
Rune Lillesveen authored
If the flat tree children of a a slot is not up to date during DetachLayoutTree, they may contain nodes adopted into another document since the previous reassignment. Make sure we don't DetachLayoutTree for such nodes during when a flat tree ancestor is RemovedFromFlatTree. This bug is a regression for FlatTreeStyleRecalc since we used to traverse the tree for DetachLayoutTree in light tree order. This regressed with crrev.com/b225e2e7 Bug: 1035228 Change-Id: Ibd4c03dee855851c120eebf1010a9b127827f7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985839Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#728000}
-
behdad authored
Revert "Roll src/third_party/catapult c9e75ab1ff47..b3788f22c908 (1 commits)" This reverts commit 570f192d. Reason for revert: run_benchmark fails TBR=sadrul@chromium.org Bug: chromium:1038690 Original change's description: > Roll src/third_party/catapult c9e75ab1ff47..b3788f22c908 (1 commits) > > https://chromium.googlesource.com/catapult.git/+log/c9e75ab1ff47..b3788f22c908 > > git log c9e75ab1ff47..b3788f22c908 --date=short --first-parent --format='%ad %ae %s' > 2019-12-31 khokhlov@google.com Reland "Reland "[Telemetry] Make proto trace format the default"" > > Created with: > gclient setdep -r src/third_party/catapult@b3788f22c908 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC rmhasan@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1028612 > Tbr: rmhasan@google.com > Change-Id: Ifbffcda56802cd5b133a445bdfe9f552f34c898e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984905 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#727871} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,rmhasan@google.com Bug: chromium:1028612 Change-Id: I098e9df293c9f245ca664ffb15e3e3f2798afffa Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986025 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727999}
-
