- 10 Dec, 2020 40 commits
-
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2581542 Re-enable tests CL: https://crrev.com/c/2581839 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I488a7ef1c88d9ff56080918f0154c22b76ea529b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580885Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835622}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/067a12f05951..55b7f38f9036 2020-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3fc522ff to 2db43e77 (469 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ic390734f921ced45dc4788e79d274fef62916a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835621}
-
Elad Alon authored
In this CL, we only apply the display-capture permission policy to getCurrentBrowsingContextMedia, because it's behind a flag and therefore safe to change. As follow-up work, we will introduce UMA histograms to check how many sites would be negatively impacted if this policy were applied to getDisplayMedia. We will then decide how to go about applying this policy to that API as well. Spec: https://w3c.github.io/permissions/#dom-permissionname-display-capture Intent-to-Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/gBpWuawy-Ms Chrome Platform Status: https://chromestatus.com/feature/5144822362931200 Bug: 1150788 Change-Id: I058f84ab6b2e3427e4990b3d01f057c9811f9487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551098Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#835620}
-
Pavol Marko authored
Transform the sequence of ifs to set authentication headers to a switch-case over the token type. Bug: none Change-Id: Id636342873c77f76cf6adb8abe7f5668c448b2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567219 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#835619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607547301-0ddf36656043436fe87b3dfd771fe4fe3bc2c5ce.profdata to chrome-win64-master-1607568819-189005e62ee8b8bdd63cb408a8a785cae17219c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e5e18cc16c0a68c0a7a6df6acf1f7b7afacf8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583747Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f5478d8ceb7..b11fabe60575 2020-12-10 alcastano@google.com Keep associated IssuesModel in all Issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I965cb0eb5fb80e68be4133b9d0d5db7ca0f85981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583867Reviewed-by:
-
Patrick Brosset authored
With this extra piece of information, the overlay frontend can now show how tall or wide gaps in a flex container are, from DevTools. Corresponding devtools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579039/ Bug: 1150832 Change-Id: Ia001a4950658624219bef05f169f2ec11566ec56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582260 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the ContextMenu callback parameters used by the WebKit API to use ContextMenuParams instead of just the URL. This will be necessary to check the new implementation where the interaction is added to the whole view. Bug: 1140387 Change-Id: Iabc574d4e0a88d43b4c2e1b7a9c1caeddda3c701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582041 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#835615}
-
Polina Bondarenko authored
Add OnSnapshotsDisabled() processing to ArcDataSnapshotdManager. All available snapshots must be removed and ongoing flows stopped (except when MGS is already running with loaded snapshot) once the feature is switched off. BUG=b:170187468 TEST=components_unittests Change-Id: I9f2c64817589639407f4294f04b077fea85aefea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558403 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#835614}
-
Marc Treib authored
Reconfiguration can't happen while certain operations (e.g. loading of data types) is ongoing. The member |needs_reconfigure_| indicates that a reconfiguration should be performed as soon as it becomes possible. This CL adds one additional point where a pending reconfiguration may be started, in OnAllDataTypesReadyForConfigure(). Previously, we'd still start the old configuration, and process the reconfigure only after all the previous data types had been downloaded. Bug: 1102837 Change-Id: Icc971f29229665832255baebfc545bfd34d83feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580882 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835613}
-
Mario Sanchez Prada authored
This migrates these legacy IPC messages to the media.mojom.MediaPlayer mojo interface, now implemented by HTMLMediaElement inside of Blink, and updates its callers in the browser process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I2cb9a39813e3078212e4a1a4a513b4bc0d0770bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537704 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Irem Uguz authored
This cl adds CertProfile id to certificate provisioning details UI page as a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2562250. Bug: 1137523 Change-Id: Ib00c266afbd4d13378dc0d5820b689328d9216ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574199 Commit-Queue: Irem Uğuz <iremuguz@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835611}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie9fab0462f26d6bbc7a1bc4b063888ad9d76ca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583415Reviewed-by:
-
Yunke Zhou authored
Bug: 1156080 Change-Id: I43d7639d4bdc78ef5147180ae285b1ec8431b6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574847 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835609}
-
Antonio Sartori authored
Some Web Platform Tests for Content Security Policy were wrongly expecting the violated directives of CSP reports for CSS styles to be 'style-src' instead of 'style-src-attr' and 'style-src-elem'. This change fixes that. Bug: 694525, 651742 Change-Id: Id13f697eaf8ed72fba1e56eb7b0f7ac2a5837408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580810 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#835608}
-
Evan Stade authored
1. Don't null-check after pointer cast, because it will never be null (unless the DCHECK on the previous line had already failed, however this clearly never happens because the same pointer is de-reffed on the next line, so we'd have seen crashes) 2. Combine two methods instead of having one method thunk to the other. Bug: none Change-Id: Id67f5cf04fda40ec694689452c403601402cc306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575892 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#835607}
-
Antonio Sartori authored
The policy container is a project to unify and fix security policies inheritance for local scheme documents. In the first prototype, we added referrer policy to the policy container behind a flag. Since this seems to be working well, let's enable the flag by default. Bug: 1130587 Change-Id: I66bd8fd823b3c114ba7f3e671eb73902955219f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573080 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#835606}
-
Tim van der Lippe authored
They are replaced by Karma unit tests in https://crrev.com/c/2581919 R=aerotwist@chromium.org Bug: 1024752 Change-Id: I0222c355d2a57848716772b1be7bbfa72a3019b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581922 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835605}
-
Fergus Dall authored
RegisterClientWithToken posts a task to |proxy_thread_| which does the actual work and runs the callback. But the callback is the response to a mojo message that must only be run on the sequence that created it. This causes a DCHECK failure in mojo::ResponderThunk::Accept. Fix this by having RegisterClientWithTokenOnProxyThread post a task back to the original sequence to actually run the callback. Also have RegisterClientWithTokenOnProxyThread call AddClientObserverOnProxyThread directly instead of going via AddClientObserver, as it is already running on the right thread anyway. This issue appears to have been introduced in CL:2501104 Bug: none Change-Id: I4ae88c0c508e9120be7526c7b46c492592176500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583596 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#835604}
-
Gauthier Ambard authored
This is preparing for the new implementation of ContextMenuController. Bug: 1140387 Change-Id: I690d2f60bb9fde71ad48322afd14074fb1209814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575665 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835603}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: Id9ceb55e431fb952540eb2c1c2eed3d3bd220c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578582Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#835602}
-
http://crrev.com/835582Eugene Zemtsov authored
Change-Id: Id48ff016d5162417624988478c693408bb9f4e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583865Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#835601}
-
Antonio Sartori authored
This change fixes a few blink unittests so that they work with the feature PolicyContainer enabled. This is a preparatory CL to enable that feature by default. Bug: 1130587 Change-Id: I9ac10a4c1c06b77721aebf0b983992adebf0c4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582221Reviewed-by:
-
Swapnil authored
This CL adds a new flag |override_update_url| to the ExtensionSettings policy. If the flag is set to true, update URL from the ExtensionInstallForceList or ExtensionSettings policy will be used for updates, not only for the first install. The flag is taken into consideration in these 2 cases: 1) Extension is listed in ExtensionInstallForcelist policy, and installation mode is not set in ExtensionSettings policy. 2) Extension is marked as 'force_installed' or 'normal_installed' in ExtensionSettings policy. We also ignore the extension ids if the update URL of the extension is a Chrome Web Store URL. This CL only adds the flag, the main logic is implemented in https://crrev.com/c/2510992. Bug: b/168097360 Change-Id: Id4e77669baf495b33b5887d6f4d68abc68b682f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485936 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45a63bacb6df..6520135abe88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I9adf1c0def851cf76f2d7774f7e62fcd082e48b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835598}
-
Alice Wang authored
This CL moves two confirm sync data dialogs to signin.ui target. Bug: 1155131, 1155132 Change-Id: I26a78b7f44ca073ef7bb6192f69d359c9fae0c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577228 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835597}
-
Fredrik Söderqvist authored
This method shouldn't need to mutate the buffer. Clean up by adding some local variables for the document and the associated parser while here. Change-Id: Ic0f4541d557a07da833637906c01a1aa7dc37473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582220Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#835596}
-
Yuzu Saijo authored
This CL allows renderer to specify eviction reason, which is currently by default set to JavaScript execution. This CL also adds new reasons for eviction: kNetworkRequestRedirected, kNetworkRequestDatapipeDrained kNetworkRequestTimeout, kNetworkExceedsBufferLimit. Bug: 1137682 Change-Id: Iac59f98afd837a4876cb63a74c714a12d58c04c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567016 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607450253-e5743bc31deb2e7a7a12ff155c587ac00d61c43d.profdata to chrome-win32-master-1607547301-1c0b0723d82aa4adb619c24bc9fd155c854d2040.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If072d16c2df852c8e1534ce110e9c8c5b4382ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582964Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2f1f82efe5b4c83eca00f86a76b0cae7e1650177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582932Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835593}
-
Pavol Marko authored
Verify authentication passed as DMAuth or in query parameters. Remove related unused arguments. Bug: 1150887 Change-Id: I4500f05b890fbc751a360747b40a28edfa6d8498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563847 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL cleans up the unused class SigninInvestigator. Bug: 1153022 Change-Id: I5bdf590191570048c54fecd3fb6d063906c076fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581479 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#835591}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dd9c4208af2e..81356f4bf38c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3da86f86f080f027930c871266d7edcbc5e924f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583844Reviewed-by:
-
Alice Wang authored
This CL moves ProfileDataCache and its tests to signin.services target. Bug: 1153049 Change-Id: Ifb301649f8ad6dc4a496cbc93edac0b69f33ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571301Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835589}
-
Friedrich Horschig authored
This CL removes the dialog warning to prevent accidental reuse. The dialog allows to crash Chrome if the filling sheet is used in an Incognito tab that is closed by tapping the Android notification (see issue 1154595). It's harder to fix that than to remove the dialog entirely which is an orthogonal goal (see issue 1153660). Since this crash fix needs merging, the warning string will keep being on two lines which prevents a new translation or a risky concatenation that might not work in all languages. Screenshot in the first bug. Bug: 1153660, 1154595 Change-Id: Iaa4aad18e8508087f10600ad14fc1b038b06d1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577469 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835588}
-
Martin Šrámek authored
This reverts commit 2db43e77. Reason for revert: Failure on the linux-bfcache-rel bot. See https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/12034/overview Original change's description: > BackForwardCache: Add a flag parameter supported_features > > This CL adds a new flag parameter supported_features to BackForwardCache > feature. This parameter can specify the set of the features to be > allowed with back-forward cache. This enables us to enable the feature > remotely. > > Bug: 1155449 > Change-Id: Idb7eb55b114af688533ba2e069a9334714be725c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573850 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835571} TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org,fergal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ie806efc5caecaa1b66c125e9e90c1a1edc0bdd5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582122Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835587}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607558393-ecfec5cb12c3793b6b05707a914c348608cba34b.profdata to chrome-mac-master-1607579988-85272d8bbf93007898b77e84b51d31a40000a6a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I17dad9bda10bd9bb045570bc9c1d9d66aa178106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582839Reviewed-by:
-
Martin Šrámek authored
This reverts commit e16309d9. Reason for revert: This landed in the same build batch where the TwoClientEventSyncTest broke. Looking at the CL description, this seems related. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8861341071397738112/+/steps/sync_integration_tests_on__none__GPU_on_Mac_on_Mac-10.13.6/0/logs/Deterministic_failure:_TwoClientUserEventsSyncTest.SetPassphraseAndRecordEventAndThenSetupSync__status_FAILURE_/0 Original change's description: > [floc] Remove the EventTrigger field in the FlocIdComputed event > > Why: That field is never used & not useful for the server side analysis. > > This CL also removes a workaround that disables the initial floc > loggings when permission disallows > (in FlocIdProviderImpl::LogFlocComputedEvent). We had this workaround > because otherwise the logging would mess up with the user event > expectations in SingleClientUserEventsSyncTest, but that workaround is > not ideal. This CL fixes it by disabling kFlocIdComputedEventLogging for > the test suite, and adds a new test for the enabled case. The impact > of this fix is it will cause additional events to be logged. > > > Bug: 1148358 > Change-Id: I70cef531b89b434b5572b419acc8dd2412888498 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572733 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835468} TBR=treib@chromium.org,jkarlin@chromium.org,yaoxia@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1095984a9a38063e0d722d7c78fb9f83538977eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582222Reviewed-by:
-
Javier Ernesto Flores Robles authored
This will cause the buttons to dim when touched instead of looking darker Bug: 1100887 Change-Id: I0ed01c9844e23623fc44f3cbb4002ac557bfe297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583147 Auto-Submit: Javier Flores <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#835584}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607558393-7b448dadc25433e8ca3294be917bb2299ab3dcfb.profdata to chrome-linux-master-1607579988-31aafc9e6ecd14c47d53bc6af437bfedef1daa8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9b58d950a0f77dbc2b56d3d227101e8c4597009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583413Reviewed-by:
-
