- 08 Apr, 2020 40 commits
-
-
Chris Sharp authored
TBR=sebmarchand@chromium.org Bug: 1069043 Change-Id: Icc0aec1af963580139869c86f1d9ff886d387087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142038Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757510}
-
Dominique Fauteux-Chapleau authored
Bug: 1065880 Change-Id: Ieb3264606cb1188c08e085328ab4e69bd64f3840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132030Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757509}
-
Ted Meyer authored
And, as a use case, logs failure reason for decoders when they can't be initialized. This currently just dumps the status as JSON into the media log. I've not implemented a frontend for this in devtools yet. Change-Id: I3aea5f027078e3f2979eaeeebc08549aa8a393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141622Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757508}
-
inglorion authored
tools/clang/scripts/goma_link_tests.py was originally written to work with both Python 2 and Python 3. I intend to add some unit tests that will use unittest.mock, which is not part of Python < 3.3. Instead of complicated workarounds, let's just a modern Python version for the tests. Bug: 877722 Change-Id: I475091b005e1f2e4b804e1c884d255ff60669847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140598Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#757507}
-
Nasko Oskov authored
This test has been disabled on Windows as flaky. Running locally 100 iterations of the test passed successfully, so this CL enables it. Bug: 662160 Change-Id: I21d192e02b157c35cb95e9aa6f5ad40425d16ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141135 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#757506}
-
Corentin Wallez authored
The GN targets have moved in Dawn and the former names are groups that proxy to the name path. Change the paths in Chromium so that the proxy groups can be removed in Dawn. Bug: chromium:1064305 Change-Id: I75abda829d8677699bc0165d2fd27c4466a815cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142213Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757505}
-
David Bokan authored
This is now all dead code, from the ill-fated "touchless" project. This CL is a manual revert of the following CLs: https://crrev.com/c/1490195: Add feature flag for Fallback Cursor Mode https://crrev.com/c/1504845: Add event handler for cursor fallback mode https://crrev.com/c/1517155: Pumping Android cursor visibility state https://crrev.com/c/1515636: Add Tab observer for TouchlessEventHandler https://crrev.com/c/1525468: Mouse event handling for fallback cursor mode https://crrev.com/c/1525353: Call platform API for fallback cursor mode. https://crrev.com/c/1533259: Pumping Fallback Cursor Mode state to render https://crrev.com/c/1532538: Add spatnav back key event handling Bug: 1062457 Change-Id: I3feb32ded7ffcf4ef01bb226873c24a57152967c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108183Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757504}
-
Katie D authored
When a user bookmarks a Reader Mode page, we want to bookmark the original instead. Add page title to Reader Mode URLs so that the bookmark_utils::GetURLAndTitleToBookmark can determine it. This makes page title a required parameter to build a Reader Mode URL. Bug: 1066165 Change-Id: Iff8e0eb421946a36516262425da79190c2dbe037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128930Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#757503}
-
Greg Thompson authored
The multi-install support was deactivated in 2017 but there were still many remnants remaining in the Chromium code base. These remnants have been a source of friction for changes being made in the install and update infrastructure. Some additional house-keeping is included by reviewer request. TBR=rsesek@chromium.org NOTRY=TRUE Bug: 1067489 Change-Id: I75d6f633a5ec2132470e3c88fd64c9d080e5c58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135203Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757502}
-
Daniel Libby authored
We've seen a number of bug reports in Edge of the mouse cursor not showing. There doesn't seem to be much tracing in the area, so adding a few trace events to try and help narrow this down.s Change-Id: I18c01a3847ae1d4cc16c36c9be3a5b9216b65e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140600Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757501}
-
Rohit Rao authored
Breakpad has a 255-byte limit on the size of a single value, but will internally split values up to 10 ways to stay under that limit. Breadcrumbs has similar, redundant functionality, so this CL disables it by increasing the maximum allowed value size. BUG=1068802 Change-Id: Ibb668f7270d6f48fb62844de88789f528b323bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139996Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757500}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: I9d984924273755bf0b13a03642af117b99dbbd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142037 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757499}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 6e35691a. Reason for revert: errorprone failure https://ci.chromium.org/p/chromium/builders/try/android_compile_dbg/515354 Original change's description: > Reland "[PlayBilling] Support app-store billing in AndroidPaymentAppFinder" > > Original patch: https://crrev.com/2135152 > Revert: https://crrev.com/2141209 > Reason for revert: > Test failure - > AndroidPaymentAppFinderTest#testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps > Reason for reland: > The test get fixed. > Before: the test expectation assumed a fixed order in Set elements. > After: the test doesn't assume it, compare set with set instead. > > Original change's description: > > Revert "[PlayBilling] Support app-store billing in AndroidPaymentAppFinder" > > > > This reverts commit cc5487e9. > > > > Reason for revert: testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps is failing consistently on KitKat: > > https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 > > > > Original change's description: > > > [PlayBilling] Support app-store billing in AndroidPaymentAppFinder > > > > > > After: > > > When a merchant page runs in a Trusted Web Activity that's installed > > > from an app store (e.g., Google Play) and the PaymentRequest is not > > > requesting shipping or payer contact, if it satisfies the following > > > conditions, the TWA itself would be included: > > > - the PaymentRequest supports the (TWA installer) app store's > > > billing method in the payment request. > > > - the TWA can handle pay intents. > > > - the TWA can handle the app store billing method. > > > > > > Before: > > > AndroidPaymentAppFinder could not include a TWA for an app store > > > billing method. > > > > > > Change: > > > * In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the > > > merchant page is a TWA installed from app store and if the > > > PaymentRequest is requesting shipping or payer contact. If it is, > > > add the TWA itself as a payment app if it's eligible. > > > * remove mIgnoredMethods. > > > > > > Note: > > > * Counterintuitively, the merchant page would send the pay intent to > > > the TWA instead of the Play Store, because it would be the TWA who > > > is responsible to interact with the app stores. > > > > > > Bug: 1064740 > > > > > > Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152 > > > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > > > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#757128} > > > > TBR=rouslan@chromium.org,maxlg@chromium.org > > > > Change-Id: I954a5d5589704b2c8ad13400fcb487eac00bc677 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1064740 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141209 > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Commit-Queue: Patrick Noland <pnoland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757427} > > TBR=rouslan@chromium.org,pnoland@chromium.org,maxlg@chromium.org > > Change-Id: Id55022716d27a12c46d1cf4d0166d7bdb7a9ffcf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1064740 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142334 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757456} TBR=rouslan@chromium.org,pnoland@chromium.org,maxlg@chromium.org Change-Id: I3470242894219da445ed70238eb21b7e572c027f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142396Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757498}
-
Dominique Fauteux-Chapleau authored
Change-Id: I86fb26961667fb08b6c35a87682198c02cf5b769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137519 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#757497}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I12b4ceab21c9d0e69847768716e8027224bc726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139821Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#757496}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I2dc1737f17186f434ebe0b98c88c16efba911bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141208 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#757495}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/36cd17488a63..7119a0278da3 git log 36cd17488a63..7119a0278da3 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 cwallez@chromium.org BUILD.gn: enable additional warnings. 2020-04-08 cwallez@chromium.org Roll third_party/swiftshader/ 51b2800bb..63ed0e445 (131 commits) 2020-04-08 cwallez@chromium.org Fix wgpu::WholeSize to count until the end of the buffer. Created with: gclient setdep -r src/third_party/dawn@7119a0278da3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I72d21fa25a77fecb0736d56b0743d25bec4400c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757494}
-
Monica Basta authored
Bug: 1059818 Change-Id: Ie6857e0e78ad0c299fa6ae7cf41e364f3e0394ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141101Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#757493}
-
Miguel Casas authored
crrev.com/c/2070820 moved the buffer allocation in the BufferQueue from using CreateGpuMemoryBuffer() to letting the SharedImageBackingFactory decide if it's OK; this broke HDR playback on ChromeOS, where we import GMBs as 1010102 formats when high bitdepth is needed. This CL fixes that by adding support for {RGBA,BGRA}_1010102 where appropriate. Bug: 1064385 Change-Id: Ia0ca81db2619bc0c000c698e15ba49fbca3266fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131029 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757492}
-
Philip Rogers authored
This is now set via PaintArtifactCompositor::Update. This is possible because will-change: transform is a compositing trigger, so we do not need to inspect the properties of paint chunks within the layer. Change-Id: I9c62e1d85575eb23512d1098763e7b8e3f18c07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142391Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757491}
-
Dominic Battre authored
Bug: 1066190,736415 Change-Id: I3803471b302988ac7354350698ff9a007c8d4b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142254 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#757490}
-
Jonah Ryan-Davis authored
conformance/misc/type-conversion-test.html started flaking recently on Win10 opengl passthrough. Suppress this failure until the issue is fixed. TBR=kbr@chromium.org Bug: angleproject:4555 Change-Id: I9d37627b2b75028c069e3bc6cfef2382ef513ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142314Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#757489}
-
John Chen authored
Add documentation on objects used by ChromeDriver to keep track of connection to Chrome. NOTRY: true Change-Id: I61d629923b9ef6e311792e64ff3f78a8c33d2aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138507Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757488}
-
David Van Cleve authored
This CL adds a new method to Document, hasTrustToken(<issuer>), returning whether the user has any trust tokens (https://github.com/wicg/trust-token-api) for the token issuer origin given by |issuer|. This works by querying a new Mojo interface provided by the network context via BrowserInterfaceBinders. More specifically, the method first checks if it can associate the calling top-level context (in the sense of TrustTokenStore::SetAssociation) with |issuer| and, if not, fails. For this reason, the Mojo handle is bound by trusted code to the document's top-level context. New code: - //content, NetworkContext: boilerplate to bind the Mojo interface - blink::Document: add a new mojo remote and bind it; pack API calls into mojom::HasTrustTokenAnswerer requests and unpack responses - Blink scheduling: boilerplate to add a new TaskType (necessary in order to use HeapMojoRemote) correctly; WPTs exercise the interface end to end. Test: unit tests check that the logic in the network service behaves Bug: 1061116 Change-Id: I0f7835cac15b5af3582bb560e116511c601f3b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103082 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757487}
-
Dominik Röttsches authored
Testing in [1] shows that Mac OS 10.13 is unable to retrieve variable font underline metrics correctly, thus for issue 1068559 we need to move to the hybrid approach where we use FreeType for variable fonts already on Mac OS 10.13. Test will be added in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2134018/ Bug: 1068559 Change-Id: I218d57dad8a788533890dc139d11dc2034430b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141917Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#757486}
-
Elly Fong-Jones authored
This is always the empty rect these days, which is the default anchor anyway, so just remove it. Bug: 1064663 Change-Id: I37b901c2f9e907a0339c66555f42482fd2e73b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140175Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#757485}
-
Wei-Yin Chen (陳威尹) authored
TabListDelegate::getLastDirtyTimeForTesting is used in prod code as well, so rename it to reflect the real usage. Bug: 971802 Change-Id: I226987bd70356b35ec64343d6556dd63f2a790dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138778Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757484}
-
Dominic Battre authored
TLSDeprecationConfigTest.NoProto is currently in the top 10 flakes on the Flake Portal. The test is so flaky because it relies on global state of a singleton but the test on trybots are executed in random order. The test expects that the singleton is uninitialized but observes the state left by other tests. This CL resets the state before performing any validation of the behavior. Bug: 1069016 Change-Id: If3f78c5809490166e233f67e60d0b9551b85c6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141099 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#757483}
-
Ahmed Fakhry authored
This system was added in 2015 in the hopes that it will deliver actionable results to detect and fix performance and memory consumption regression. The rappor metrics (which this system is using) was deprecated, and the system failed to give us any useful stats. Therefore the decision was made to remove it. BUG=976423 TEST=Should compile, and tests should pass. Change-Id: Ib57283ae6b8eda6d46ca1f3d67c68648de8c02c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140594Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#757482}
-
Xi Han authored
In this CL, TabContentManager will return the fetched jpeg file to the caller if it finds the file. This makes TabContentManager can fetch cached jpeg on the device before native initialization. Bug: 1041865 Change-Id: Ic4570ff7132dfd5477a1a2b4a0933113ff188438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134957Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757481}
-
danakj authored
The display-mode is currently passed to the renderer and through to blink only for the main frame. Secondly, when navigating and re-creating a main frame RenderWidget, the display-mode is set on the RenderWidget during construction which accidentally prevents it from getting the value to blink. This introduces tests for same-site/same-process child frames as well as child local root frames which are in a separate renderer process. Problems fixed: 1. WebContentsImpl would return the wrong value for child local roots because it tries to return kBrowser always for non-frame widgets. But it checks this condition by checking if the widget is the main frame widget only by converting it to a RenderViewHost. Now we only call it from frame-based widgets and it gives the right value to them all. 2. RenderWidget would throw away the value if it was not attached to the main frame. We remove that condition and give it to blink regardless. These two fixes are verified by a new browser test. 3. RenderWidget no longer stores a display-mode on construction but gets it through the following call to update VisualProperties that comes with the CreateFrame IPC message. Because it is no longer stored on RenderWidget at all, we ensure it always gets through to blink and that blink reads the correct and only value being stored. 4. The display-mode is no longer passed through WebView which causes different local roots in the same process to clobber each other. Instead it goes to the WebWidget. 5. When it changes in the local root frame, we also notify all local child frames' documents about the change recursively. This is verified by a new unit test in web_view_tests.cc. R=avi@chromium.org, dcheng@chromium.org Bug: 1060336, 1058633 Change-Id: Ic67e24b298ad4e8be107305531dfefc68a45c85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100433 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757480}
-
Bruce Dawson authored
In the Setup() function for ServiceProcessControlBrowserTest the process handle is closed (on all platforms) in order to avoid unspecified failures on MACOSX. However doing this means that the error code checking in TearDown() is never run. This hides an apparent bug on Linux and avoids useful error checking on other platforms. This change makes it so that Close() is only called early on platforms where it is necessary. Bug: 1059446 Change-Id: I5a408e92a5587a8f52718b6c56660453abce5eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137856 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#757479}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6c17bc33. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 932a0034 "[css-filters] Migrate effect-reference-merge-no-inputs.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib27fc9362d4d1ca69364634d91073c6048977c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142035Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757478}
-
Gang Wu authored
Update ClipboardRecentContentGenericTest to handle 10 minutes max age. Bug: 1068866 Change-Id: I81fe82b876783ee82fa3782a1f83d1fcd4c68ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141139Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757477}
-
Dominique Fauteux-Chapleau authored
DeepScanningDialogDelegate now validates various policies by reading an AnalysisSettings instead of reading each policy. Tests are updated to call IsEnabled since that's what sets data.settings. Bug: 1062348 Change-Id: I4f949e3300fa477737c1189e47dd8f8e4051cfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134191Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757476}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ic2ce5e2ef8d265fd54b1d76efea7a9dae1c076c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139694Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#757475}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d03d968b75ce..f7065f441485 git log d03d968b75ce..f7065f441485 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f0a39ac5..32ec1c1c (757292:757394) Created with: gclient setdep -r src/third_party/webrtc@f7065f441485 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iffbd875b6627278d3198ebb95acabd8b56de2b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757474}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, this test has been slightly modified to become a reftest instead of a crash test, so that we not only check that applying a CSS filter to a <span> element does not crash, but also that it yields the expected results. Bug: 1063749 Change-Id: Icd7234480f6f64a15c4af0ae17c8a19199a12080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141930 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#757473}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca6b5b7a1781..eb17dbb23599 git log ca6b5b7a1781..eb17dbb23599 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 morg@google.com Add kukui-arc-r to chromeos config boards 2020-04-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-08 engeg@google.com cbuildbot: just output csv channels instead 2020-04-08 cjmcdonald@chromium.org cros_sdk: Set encoding for command output 2020-04-08 saklein@chromium.org flash-ap: Remove unneeded is_fast_required. 2020-04-08 saklein@chromium.org flash-ap: Make the is_fast_required function optional. 2020-04-08 cjmcdonald@chromium.org pytest: Make CIDB mock fixture more robust 2020-04-08 camurcu@chromium.org arc: Publish org.chromium.arc.cachebuilder.jar on chromeos bucket 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 richardfung@google.com Remove eve-arcnext 2020-04-07 bpastene@chromium.org vm: Correctly add Qcow2 args to qemu's args when enabled. 2020-04-07 saklein@chromium.org flash_ap: Remove flash_ap wrapper.py symlink. 2020-04-07 morg@google.com Make VMRVC PFQ runs more frequent 2020-04-07 richardfung@google.com Add betty-arc-r to configs 2020-04-07 cjmcdonald@chromium.org pytest: Don't skip 'mock_error' marker 2020-04-07 cjmcdonald@chromium.org pytest: Add fixture to initialize CIDBConnectionFactory 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 kimjae@chromium.org build_dlc.py: Fix typo LoadEbuildParams 2020-04-07 mmortensen@google.com Improve autotest logging prior to refactoring BuildAutotestTarballsForHWTest. 2020-04-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-06 mmortensen@google.com In cros_build_lib.CreateTarball, log context on failures. 2020-04-05 vapier@chromium.org Revert "cbuildbot: switch to python3 only via virtualenv wrapper [reland]" 2020-04-04 vapier@chromium.org cros_build_lib: run: only return output when requested 2020-04-04 vapier@chromium.org cbuildbot: switch to python3 only via virtualenv wrapper [reland] 2020-04-04 sanikak@chromium.org auto_updater: reboot device before au kicks off if device is not idle 2020-04-04 saklein@chromium.org run: Fix output capturing calls. 2020-04-04 kimjae@chromium.org build_dlc.py: Non sudo copying from build directory 2020-04-04 engeg@google.com release_stages: add an output tag for channels 2020-04-03 seanabraham@chromium.org chromeos_config: add R83 schedule 2020-04-03 gredelston@google.com Stop using self._current_board as a buildstore 2020-04-03 saklein@chromium.org metrics_unittest: Fix flake. 2020-04-03 tcwang@google.com afdo: Reduce the frequency of AFDO updates to 2x/week 2020-04-03 morg@google.com Add -arc-r boards to unified lab board names hack 2020-04-03 vapier@chromium.org table/upgrade_table: require python 3 2020-04-03 bpastene@chromium.org vm: Add retries to vm.Start() if WaitForBoot fails. 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'redirected_stdin_error' marker 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'requires_portage' marker 2020-04-02 engeg@google.com chroot_util: preserve env for emerge call for unit tests 2020-04-02 cjmcdonald@chromium.org run_pytest: Add namespacing & chroot initialization 2020-04-02 cjmcdonald@chromium.org pytest: Skip flaky CIDB mock tests 2020-04-02 rkolchmeyer@google.com Revert "lakitu: Turn off GCETest stage" 2020-04-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@eb17dbb23599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6b853545e7decd17786b22170e8bb49e0e3e0164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757472}
-
Wez authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2134299 which had broken handling of dependencies on the CMX manifest fragments of each package's "primary" component. Processing of the fragment to generate the full CMX file is now broken out into a distinct build target, on which the primary component target depends. Some unused Python and CMX files, missed in the original migration CL, are also removed. Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. TBR=dpranke Bug: 1050703, 1068782, fuchsia:49479 Change-Id: I217d9276f85602c4120e3ad0db6d64c47c691f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141094Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757471}
-