GitLab

Add basic unit tests for ensuring that the banner appears,
appears after being ignored, and appears after being blocked.

BUG=457414
TEST=AppBannerManagerTest

Review URL: https://codereview.chromium.org/914403006

Cr-Commit-Position: refs/heads/master@{#316690}

BUG=425339

Review URL: https://codereview.chromium.org/879793002

Cr-Commit-Position: refs/heads/master@{#316689}

When the browser sends a blob reference to the renderer it holds an
extra reference until the renderer "acks" receipt, to keep the blob
alive. Normally this is done when a "result" containing blobs is
handed off to a blink::IDBRequest.

When we "prefetch" for a cursor, multiple results are sent from the
browser to the renderer at once, but only seen by blink::IDBRequest
when script actually requests them. If script never does (e.g. it
abandons a cursor midway through iteration) then the blobs would never
be acked.

Add blob acking to the cleanup step when prefetch entries are dropped.

BUG=457498
R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/924033003

Cr-Commit-Position: refs/heads/master@{#316688}

This is needed to resolve a dependency cycle when use_ozone=1:

  gn gen out_gn_ozone --args='os="chromeos" use_ozone=true'

  ERROR Dependency cycle:
    //ui/base:base ->
    //cc:cc ->
    //gpu:gpu ->
    //gpu/command_buffer/service:service ->
    //ui/gl:gl ->
    //ui/ozone:ozone ->
    //ui/ozone/platform/test:test ->
    //ui/base:base

The ui/base -> cc dependency is very small (2 files) and only used for
Android builds. We can fix the issue by restricting this dependency to
ui/base/android. Two functions in common code needed moving to drop the
dependency from non-Android builds.

Also add the cc dependency to the gyp build as it's missing there.

BUG=445627
TEST=built android chrome_shell_apk (both gyp & gn)
  gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (last one!)

Review URL: https://codereview.chromium.org/908033003

Cr-Commit-Position: refs/heads/master@{#316687}

If the Linux host is killed (due to changing PIN or other reason), the
Android client sees that the connection has failed with error
PEER_IS_OFFLINE. This is the same error that would occur if the JID
were stale, which the client normally handles by auto-reloading the
host-list and reconnecting. But since the session was already
connected, the Desktop activity does not properly get torn down and
re-initialized (which is something to address at a future date).

This CL fixes the linked bug by ensuring that the automatic reload does
not happen after a successful connection.

BUG=424759

Review URL: https://codereview.chromium.org/926263002

Cr-Commit-Position: refs/heads/master@{#316686}

When PDF have lots of named destinations then as we are fetching
all the named destinations at load time, so this will increase
loading time.
This is a workaround so that we will get named destination whenever
it is required by passing message from page to plugin.

BUG=457457

Review URL: https://codereview.chromium.org/918953002

Cr-Commit-Position: refs/heads/master@{#316685}

BUG=

Review URL: https://codereview.chromium.org/930353002

Cr-Commit-Position: refs/heads/master@{#316684}

Review URL: https://codereview.chromium.org/912233004

Cr-Commit-Position: refs/heads/master@{#316683}

BUG=449895

Review URL: https://codereview.chromium.org/918093002

Cr-Commit-Position: refs/heads/master@{#316682}

BUG=358315

See comment #20:
https://code.google.com/p/chromium/issues/detail?id=358315#c20

Review URL: https://codereview.chromium.org/931533002

Cr-Commit-Position: refs/heads/master@{#316681}

Currently HistoryApiTest.Delete, HistoryApiTest.GetVisits, and HistoryApiTest.SearchAfterAdd are disabled. These do not flake or time out locally nor on the try bots, so this CL re-enables them.

BUG=88318, 79074, 76170

Review URL: https://codereview.chromium.org/926283003

Cr-Commit-Position: refs/heads/master@{#316680}

BUG=416929
TEST=WebstoreInlineInstallerTest.ShouldBlockInlineInstallFromPopupWindow

Review URL: https://codereview.chromium.org/908063002

Cr-Commit-Position: refs/heads/master@{#316679}

Skip making a pending tree, we'll want to wait for it anyways before
we draw in single-thread mode. This should bring the single-thread
impl-side painting in line with the legacy compositing mode when
using a single thread (for the browser compositor).

R=enne@chromium.org, vmpstr
BUG=441012

Review URL: https://codereview.chromium.org/873473006

Cr-Commit-Position: refs/heads/master@{#316678}

This adds perf tests for CSS and Web Animations over the following
CSS value types:
 - Color
 - Filter
 - Length
 - Length 3D
 - Shadow
 - Transform

BUG=309981

Review URL: https://codereview.chromium.org/931723002

Cr-Commit-Position: refs/heads/master@{#316677}

As the app is not added to the dock the current name is misleading.

BUG=459082

Review URL: https://codereview.chromium.org/929163002

Cr-Commit-Position: refs/heads/master@{#316676}

BUG=

Review URL: https://codereview.chromium.org/931113005

Cr-Commit-Position: refs/heads/master@{#316675}

Cr-Commit-Position: refs/heads/master@{#316674}

ShelfLayoutManager has three methods from which the ShelfAlignment can be
applied. For supressed user sessions the shelf is forced to the bottom, however
this was only addressing locked screens, and adding new users.

When the first login occurs a different state transition takes place, where the
SessionState becomes active while the user session is still supressed.
ShelfLayoutManager was not applying alignment changes made during this time.

Update ShelfLayoutManager to unify the logic for overriding the user set
ShelfAlignment. Update this logic to account for having to apply alignment
during the initial login.

Manual testing was also done for: logging in; locking screen; unlocking screen;
adding a new user; switching users.

TEST=ShelfLayoutManagerTest.SideAlignmentInteractionWithLockScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithAddUserScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithLoginScreen
BUG=456199

Review URL: https://codereview.chromium.org/909293002

Cr-Commit-Position: refs/heads/master@{#316673}

This adds 'clang-newlib' as new possible value for
$TOOLCHAIN and enables building of most examples
and libraries with the new toolchain.

Initially adding without ARM support.  ARM support
will follow shortly.

Also, update buildbot_common.py to output shorter
filenames (making output easier to read).

BUG=454962

Review URL: https://codereview.chromium.org/924253002

Cr-Commit-Position: refs/heads/master@{#316672}

re-entrant WebContentsObserver events running during ExtensionHost destruction.
This also reverts the fix I made in crbug.com/456920 since this should cover it.

BUG=459239, 456920
R=mek@chromium.org

Review URL: https://codereview.chromium.org/930413002

Cr-Commit-Position: refs/heads/master@{#316671}

This emulates in C++ and in the GN tool what
 https://chromium.googlesource.com/chromium/src/+/master/build/landmines.py#82 does.

gn-dev mailing list discussion for more background is:
https://groups.google.com/a/chromium.org/d/topic/gn-dev/KTyLEh2Um98/discussion

The link to the doc proposing this command is:
https://docs.google.com/document/d/1DH-t-jYwQxZAXhqoBvnWGHWeF1z4Lltxny9D7lgC4HU/edit?pli=1

Tested with the following command lines:

$ gn gen out_gn_testing_clean_command/Debug --args='is_component_build=true'

$ out_gn/Debug/gn clean out_gn_testing_clean_command/Debug

Then:

$ ls out_gn_testing_clean_command/Debug
args.gn  build.ninja  build.ninja.d

To verify the files were written to disk correctly.

And:

$ cat out_gn_testing_clean_command/Debug/args.gn
$ cat out_gn_testing_clean_command/Debug/build.ninja
$ cat out_gn_testing_clean_command/Debug/build.ninja.d

To see if everything was written to the files correctly.

BUG=None
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/909103003

Cr-Commit-Position: refs/heads/master@{#316670}

Previously AudioPump would buffer infinite amount of audio data even
when the network is congested. With this changed the amount of data
it can buffer is limited to 5kB and it starts dropping packets after
that.

Review URL: https://codereview.chromium.org/914133003

Cr-Commit-Position: refs/heads/master@{#316669}

With this change failure to close UDP socket will crash the process.
This will help to debug bug 452121, but is also necessary to avoid
leaking file descriptors.

BUG=452121

Review URL: https://codereview.chromium.org/932913002

Cr-Commit-Position: refs/heads/master@{#316668}

BUG=457691

Review URL: https://codereview.chromium.org/917063008

Cr-Commit-Position: refs/heads/master@{#316667}

To improve performance, again we try to fetch all the info once through
an internal command glGetUniformsES3CHROMIUM.  Basically it gets all the
information that can be provided by glGetActiveUniformsiv except for those
that can already be queried through glGetActiveUniform, which will be cached
on the client side through internal command glGetProgramInfoCHROMIUM.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/921023002

Cr-Commit-Position: refs/heads/master@{#316666}

BUG=454500

Review URL: https://codereview.chromium.org/927463004

Cr-Commit-Position: refs/heads/master@{#316665}

Since we can now have active script restriction without the scripts-require-
action switch, we need to adjust the reporting criteria for scripts injecting.

BUG=452756

Review URL: https://codereview.chromium.org/922403002

Cr-Commit-Position: refs/heads/master@{#316664}

Per this patch, Web Notifications on Android will inherit the system
default settings for the notification sound, vibration and light
indicator. These cannot yet be changed by the developer, but can be
fully customized by the user in the Android Settings screen.

BUG=459268

Review URL: https://codereview.chromium.org/934053002

Cr-Commit-Position: refs/heads/master@{#316663}

To support Slimming Paint, page overlays are now expected to declare the size
of the content they draw to a canvas. This moves the two subclasses, both
solid-color overlays, to use the new interface.

Following this CL, the deprecated method will be removed on the Blink side.

BUG=450761

Review URL: https://codereview.chromium.org/920843002

Cr-Commit-Position: refs/heads/master@{#316662}

Revert of Remove dependency on content from remoting_host. (patchset #5 id:160001 of https://codereview.chromium.org/929493002/)

Reason for revert:
Compile failure on Linux ChromiumOS Ozone Builder:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/11867

Original issue's description:
> Remove dependency on content from remoting_host.
>
> The host was depending on content just to access content::BrowserThread.
> It's cleaner to just pass the references to the threads explicitly.
>
> BUG=458581
>
> Committed: https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388
> Cr-Commit-Position: refs/heads/master@{#316648}

TBR=kelvinp@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458581

Review URL: https://codereview.chromium.org/923773003

Cr-Commit-Position: refs/heads/master@{#316661}

BUG=None

Review URL: https://codereview.chromium.org/917303002

Cr-Commit-Position: refs/heads/master@{#316660}

BUG=none
TEST=Compile video_decode_accelerator_unittest with component build

Review URL: https://codereview.chromium.org/934753003

Cr-Commit-Position: refs/heads/master@{#316659}

This fixes and reenables liblouis chromevox tests.  Instead of relying on
the 'load' event of the nacl component, just queue up requests to
the component as soon as it is attached.  This simplifies the state management
in the wrapper.

As a bonus, the tests are fixed to use the appropriate callback
wrappers so that errors are immediately reported in failure cases
instead of making the tests painfully block and time out.

BUG=458910

Review URL: https://codereview.chromium.org/927313002

Cr-Commit-Position: refs/heads/master@{#316658}

I just discovered a source code spell checker tool called `codespell`.

BUG=

Review URL: https://codereview.chromium.org/925703002

Cr-Commit-Position: refs/heads/master@{#316657}

Fix for incorrect previous patch.

TBR=ajuma
BUG=458240

Review URL: https://codereview.chromium.org/937463002

Cr-Commit-Position: refs/heads/master@{#316656}

BUG=458939

Review URL: https://codereview.chromium.org/929383002

Cr-Commit-Position: refs/heads/master@{#316655}

user has opted-in to malware-extended-reporting.

BUG=447772,342617

Review URL: https://codereview.chromium.org/923263002

Cr-Commit-Position: refs/heads/master@{#316654}

Revert of [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper. (patchset #5 id:80001 of https://codereview.chromium.org/924003003/)

Reason for revert:
Collision with https://codereview.chromium.org/929603002, see failurs on trybots like http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2499/steps/pylib_py_unittests/logs/stdio

Original issue's description:
> [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper.
>
> BUG=267773
>
> Committed: https://crrev.com/bcec82d59869b43f0507d244e84798c6ce1cfcf9
> Cr-Commit-Position: refs/heads/master@{#316624}

TBR=perezju@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/934893002

Cr-Commit-Position: refs/heads/master@{#316653}

BUG=457393

Review URL: https://codereview.chromium.org/935533002

Cr-Commit-Position: refs/heads/master@{#316652}

The idea being that this make it easier to diagnose and fix issues like http://crbug.com/439598.

Sample run: http://simonhatch0.mon.corp.google.com:8013/builders/Android%20Nexus7v2%20Perf/builds/337/steps/host_info/logs/json.output

The output from this run on the Nexus 7v2 bots looks like:
{
  "failures": [
    "build_versions"
  ],
  "host_info": {
    "devices": {
      "build_types": "userdebug/dev-keys",
      "build_versions": "MISMATCH",
      "build_versions_list": [
        "4.4.2/KOT49H/937116",
        "5.0/LRX21P/1570855"
      ],
      "device_names": "google/razor/flo",
      "devices": [
        "09275b25",
        "09e0cda5",
        "09e19954",
        "09e19f78",
        "09e28a6c",
        "0a38ca3e",
        "0a9f170a",
        "0a9f1772"
      ]
    },
    "free_disk_space": 543.9997482299805,
    "num_cpus": 40,
    "os_release": "3.13.0-44-generic",
    "os_system": "Linux",
    "processor": "x86_64",
    "python_path": "/usr/bin/python",
    "python_version": "2.7.6"
  },
  "valid": false
}

This can be enabled by adding this to testing/buildbot/chromium.perf.json:
{
  "Android Nexus7v2 Perf": {
    "scripts": [
      {
        "name": "host_info",
        "script": "host_info.py"
      }
    ]
  }
}

Needs to land before enabling (that CL enables src-side tests for perf bots): https://codereview.chromium.org/873403002/

BUG=443708, 454934

Review URL: https://codereview.chromium.org/899693002

Cr-Commit-Position: refs/heads/master@{#316651}