- 18 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4a9d347da1..2e941d00c837 git log 3c4a9d347da1..2e941d00c837 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 fmalita@chromium.org [skottie] Store scalar keyframe values inline Created with: gclient setdep -r src/third_party/skia@2e941d00c837 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I88bc5a162db5a1aa53f23499dd2caaf602e88b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742274}
-
Michael Sun authored
Stop displaying the dialog window when user initiated connection failed. If the device status changing from "Not Connect" to "Connecting" and then to "Not Connected", it is very clear to the user that previously initiated connection was not succeeded. Displaying a pop-up dialog showing connection failed is disturbing and unnecessary since a failure notification is shown. BUG=b/147671276 Change-Id: I2a27ea6c14225dd8cd0249559dda3228d1ec0f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031600 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742273}
-
Michael Sun authored
Chrome OS Bluetooth stack generated KEY_PLAYCD for media control versus keyboards use KEY_PLAY. Modify Bluetooth specific key into existing keyboard's one. BUG=b/147366099 Change-Id: I9cb060a1942a71ab16d40095a4e7fe7a542149df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031999Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742272}
-
Mia Glaese authored
Change-Id: Id8a6ff85d690d406feb46310d0e3a1925564e965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036361Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#742271}
-
Xing Liu authored
When resuming a download, the suggested path can be content URI. This will hit a DCHECK in CreateReservation. Bug: 1045642 Change-Id: I61c452afafbbc9606f747c84ff18e6b9dc9a0fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062759Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ef17447d64b..01663f71bc87 Created with: gclient setdep -r src-internal@01663f71bc87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052560 Tbr: jbudorick@google.com Change-Id: I6ca06f08d187d7f6adb49de1011e3a794a5efdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742269}
-
Gil Dekel authored
This CL sets the cursor to remain visible during and after the privacy screen is toggled via the keyboard key. Bug: b:147451643 Change-Id: Idb9bf7332d3fea48d015e4acee1d6652f54df754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063108Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742268}
-
Michael Sun authored
- Provide DOM |code| mapping for MediaPause, now that it has a distinct evdev code from Pause. - Map DOM |code| MediaPause to DOM |key| MediaPause in the US English layout data. - Map DOM |key| MediaPlay and MediaPause to custom VKEY values in POSIX builds, so that Chrome can handle them as accelerators. BUG=b/148560217 Change-Id: Ifad05827d91df74b5f0ef8e60ff8eb125716f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029291 Auto-Submit: Michael Sun <michaelfsun@google.com> Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742267}
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: Iae8a083d00e95c4214e360303f30bd2d7dea45e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056107 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#742266}
-
Mikel Astiz authored
Modern clients only deal with lowercase GUIDs because base::GenerateGUID() currently only produces GUIDs in such form. However, in M51 and below, and prior to https://codereview.chromium.org/1906723003, the GUIDs used to be uppercase, and they got synced across devices via proto field |originator_client_item_id|. When introducing GUIDs for bookmarks, and exposing this field via sync in BookmarkSpecifics, things get simplified subtantially if the protocol enforces the invariant that all GUIDs are canonicalized. This patches achieves so by lowercasing when GUIDs are inferred from the problematic originator client item ID, and similarly canonicalizing when GUIDs are loaded from the bookmarks' JSON. TBR=sky@chromium.org Change-Id: I973a2f9058f7e4450f4934fcdc20aedab9c5d0d4 Bug: 1053511,1052789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742265}
-
Tomasz Wiszkowski authored
This flag will allow us to work and experiment with onboarding suggestions for new users. Related CL: http://cl/285006555 Bug: 1050831 Change-Id: Ie6de46f043c50857098a7ee66097b08a2eb6dbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048765 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#742264}
-
Garrett Beaty authored
The ci buckets set module-level defaults so that if the triggered_by field isn't set it will be triggered by the appropriate git poller, so it is unnecessary to explicitly set it for builders that are only scheduled by the poller. Change-Id: I6f8e345ea60d84b821e7273a02f31a97589a687e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062011 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#742263}
-
Shimi Zhang authored
We removed the usage of HostForURL() in this function, IPAddress::AssignedFromIPLiteral() is tolerated to '\0', so there is no need for this check anymore. Bug: 1030092 Change-Id: I1f37ff138ad1f06eab2bf82223bf7d567dc73e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057542Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742262}
-
Tom McKee authored
Bug: 1045064 Change-Id: Iea209c164e7bb4fdd6ca6aff6f692749fbd74659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050017 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742261}
-
liberato@chromium.org authored
During re-init, we sometimes don't have a codec. This causes a dcheck if we also decide to re-init the codec to increase the input buffer size. If there really is no codec when we re-init (e.g., if we're already in the middle of a reallocation from a previous re-init), then we'll just re-re-init the codec and continue. So, just omit the DCHECK. Bug: 1048341 Change-Id: I199c4ccdce1c169be069ab96593188de76250648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036277Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#742260}
-
Daniele Castagna authored
.*DrawQuad::OverlayResources::size_in pixels used to be a vector of 4. Looking at the code, we always index the first one and we never use the rest of the array. This reduces the size of TextureDrawQuad that is the biggest DrawQuad. Since QuadList uses the size of the biggest DrawQuad to allocate any quad, this CL will reduce the memory used by QuadList, even if TextureDrawQuads are not used. Change-Id: I554cb1b313519094a893cba6342ad47c15882827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058834Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#742259}
-
Christos Froussios authored
The save payment icon currently talks with the SaveCardBubbleController. With this CL, it gets its own controller interface. The implementing class stays the same. Bug: 986289 Change-Id: Ic7370ca998fdd9ee8baf453fc2c9919d074cce08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060960 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742258}
-
Michael Thiessen authored
Going through each of the usages will take some care, so I want to essentially fix the API in a no-op pass and properly migrate each of the callsites independently (or in batches). I'm still working on migrating users of WebContents#getVisibleUrl, but some to the APIs those usages call into are shared by users of Tab#getUrl, so exposing a GURL Tab#getUrl early makes this less painful and requires less duplication and converting. This will be a 3-sided patch: 1. Add the getUrlString() method and migrate upstream usage. 2. Migrate downstream usage to getUrlString(). 3. Change getUrl() to return a GURL (this CL). Bug: 783819 Change-Id: If841d509bff8ea9d2da048021da6ba8635a8cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044379 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742257}
-
Sadrul Habib Chowdhury authored
The sequence numbers in BeginFrameArgs are expected to be incremented based on vsync intervals. Refactor the code for this from DelayBasedBeginFrameSource and ExternalBeginFrameSourceAndroid into a BeginFrameArgsGenerator. This is a simple refactor of the code, and does not change behaviour. BUG=none Change-Id: Idb51e1306dc6e6c64acbe2027cc28df0ba440055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058032Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742256}
-
Chong Gu authored
Excluding tests that will crash before we enable cc unittests that use Vulkan renderer. Bug: 1047032 Change-Id: I75d52b9499808d10ce64ab61dfa3a4098f63b590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053448Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#742255}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. Responses' inputTexts are trimmed of leading whitespace. The previous CL crrev.com/c/2019927 began trimming both leading and trailing whitespace from the requests' inputTexts. This fixed the case where inputs had leading whitespace, but broke the case where inputs had trailing whitespace. This CL trims only the leading whitespace of requests' inputTexts to match the responses' inputTexts behavior. Bug: 1045343 Change-Id: I93b6158255a99951a8643998e219c9913474e1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062669Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742254}
-
Dominic Farolino authored
This CL adds a URLLoaderFactory mojo disconnect handler for OriginPolicyManager to recover its URLLoaderFactory, after factories are reset. This CL also adds a browser test that exercises the disconnect handler, demonstrating that it plays a critical role when e.g., an extension with the declarative web request permission is loaded in the browser, and the NetworkContext's URLLoaderFactories are reset. Co-authored-by:
Domenic Denicola <domenic@chromium.org> Bug: 1047275 Change-Id: Iaa978348d069dfd61bc157ddbe159b1766a0e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053228Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742253}
-
Avi Drissman authored
BUG=1023913 Change-Id: I11d24c83ca1f8f99fc64c612c383fd3979e00551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036406Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742252}
-
John Rummell authored
Due to problems on some bots failing to start PulseAudio and causing Chrome startup to hang, avoid trying to initialize PulseAudio if audio output has been disabled. Bug: 986021,1023029,1026849,1035472,1049467 Test: media content_browsertests pass Change-Id: Ib75e44843df6e9e54d85ee4bd164b091ab2ade70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062694 Commit-Queue: John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742251}
-
Tom McKee authored
TBR=pkasting@chromium.org Change-Id: I906a7918779e5dc17d4cc35406470bca43e1deb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062912Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742250}
-
James Cook authored
It was accidentally being registered twice. This didn't cause any user-visible issues, but made the code confusing. Bug: none Test: wallpaper picker still opens from OS settings Change-Id: Ica83d04267ae16d79e4f379e03ea7b6e47110fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062796 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742249}
-
Joey Arhar authored
As explained in crbug.com/958524 this post data was only used when using the xhr replay feature on the OPTIONS request of a CORS preflight. Now that OOR-CORS has launched crbug.com/905971 CORS preflights won't show up in DevTools anymore so we don't need to store this extra copy of post data. Bug: 958524, 780935 Change-Id: Ifecb37042c5845dc1bfbd594deb6cb635a3d7c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051443Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#742248}
-
Guillaume Jenkins authored
Potential fix for the flaky SpellcheckServiceBrowserTest.CustomDictionaryChanged test. I believe the problem is that the EXPECT_TRUE is executed before spell check initialization finishes, since spell check initialization is now async after the Windows native spell checker integration. I simply added a run loop after spell check initialization before the test continues. I don't know for sure if this was the true cause of flakiness, but I ran 1500 iterations locally with and without this fix. Without this fix, I had 12 failures. With this fix, I had 0. #Squeegee Bug: 1051777 Change-Id: I1f38cbffc82783b0274623631f2e1266d97ed3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055286Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#742247}
-
Eugene But authored
"Success" will be the most common page load result and can be omitted as default. Bug: 2056565 Change-Id: I866aa24ea6da824fd3ff7c11f72fd4ca5acd1ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057784 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#742246}
-
Wenyu Fu authored
Homepage should always be visible to user even when the homepage is disabled. Add test for non-converted UI. Bug: 1047606 Change-Id: Ia7e3453a4014b7c23f17f37771bee8a3088d5b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045146 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#742245}
-
Joey Scarr authored
Bug: 1007685 Change-Id: I1a783decfc2b00e0b124543b8ee3aeee5a8e35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059748 Auto-Submit: Joey Scarr <jsca@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742244}
-
Lei Zhang authored
The libexif code were removed in r381121. Change-Id: Ie66360817896cfbdd2b849c243e7c80d9eeaffd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050750Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742243}
-
Eugene But authored
Breakscrumbs (feature which attaches steps to reproduce to crashlogs) relies on not_user_triggered="true" to filter out non-interesting events. This CL adds not_user_triggered="true" attribute to Clear Browsing Data user actions which can be triggered from browser cude without user's involvement. Bug: 1046231 Change-Id: I2f26fce5f9f6e904c4f8c50e7e08c5c64069747b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056565 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742242}
-
Findit authored
This reverts commit 16c153e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 742233 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE2YzE1M2U2ZWUzMzYxMjE2NThjMDA3ZGMzYjJjZGQ3MDZiMmYzN2UM Sample Failed Build: https://ci.chromium.org/b/8888089659985838672 Sample Failed Step: compile Original change's description: > Enable ATK and Glib on Linux/Ozone > > BUG=988094,1014934 > R=sky > CC=nickdiego,msisov,adunaev > > Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742233} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=988094,1014934 Change-Id: If3f5a60b81a9e80ba326f3fdddef15dad08d8628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062760 Cr-Commit-Position: refs/heads/master@{#742241}
-
Christopher Cameron authored
When moving between two screens that don't change scale factor, but do change color space, this message was getting dropped. Remove the early-out, because the call to UpdateSurface has its own early-out. Change-Id: I8772a8cf982739039800f41e89857856aa5693ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062749Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#742240}
-
John Budorick authored
Promoting from a nightly build. Bug: 922145 Change-Id: I41e858309178ff785d0a47d6416f9182bfe5ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062750Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#742239}
-
Sebastien Marchand authored
Remove georgesak@ as he's no longer working on this. Update some other metrics owned by Georges while I'm here. Change-Id: I042c5e4d96b7c5a880a22751309d0a7104ced987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062249Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#742238}
-
Wenyu Fu authored
Per Google style (https://screenshot.googleplex.com/K2X2oRG3VCN), we use "homepage" as one word. This CL changes "home page" that appears in Chrome on Android. Bug: 1028210 Change-Id: Id8b4f7d55dde174aedde6789400705562c3d6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036438 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#742237}
-
Christos Froussios authored
These will remain until the migration code is deleted: - PasswordManager.LinuxBackendMigration.AttemptResult - PasswordManager.LinuxBackendMigration.Adoption These are no longer in use: - PasswordManager.LinuxBackendMigration.TimeIntoEncrypted Bug: 1053264 Change-Id: I861ff61d5e9e0177eaac5a5e0f933ef5e79fdcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062409 Auto-Submit: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742236}
-
Jose Torreguitar authored
The modern Xbox Elite Series 2 controller firmware reports on less axes than the previous firmware. However, the only way to distinguish between firmware versions is to check the length of the axes reported. This change updates the mapping function to work for all firmware versions by checking the axes length. On the older firmware, the axes are shifted by one after axis 3 because axes 4 and 9 are redundancies. BUG=1052543 TEST=Testing this requires two Xbox elite series 2 controllers, one with modern firmware and one with release firmware. When using them on production code users will notice that on pressing the DPAD on modern firmware either the triggers or the opposing dpad axis is pressed. Change-Id: Ie51fd897a14180d664463d196b2fe744338c61c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057624Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: José Torreguitar <jtguitar@google.com> Cr-Commit-Position: refs/heads/master@{#742235}
-