- 26 Apr, 2018 5 commits
-
-
Lei Zhang authored
- Implement a TestDocumentLoader and a TestClient. - Hook them up to PDFiumEngine to observe its behavior. - Load a simple 2 page PDF and perform a text search. Change-Id: I03417880c3b6c3f493f7e08ba07b694272b5b5fc Reviewed-on: https://chromium-review.googlesource.com/1012976 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#553836}
-
Kevin Marshall authored
GetAppOutput relies on a platform-supplied shell interpreter to exercise ProcessUtil's output handling codepaths and the GetAppOutput tests rewritten to use it. This doesn't work for Fuchsia, as packaged executables aren't allowed to access other binaries that aren't included in the package. This CL defines a trivial test executable "test_child_process", which behaves similar to "echo", and the GetAppOutput tests are rewritten to use it. Bug: 836341 Change-Id: If681b62f4ecf486a6b62387be0610fec6771ae4e Reviewed-on: https://chromium-review.googlesource.com/1026796 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553835}
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I254691f260d8a7d02b7e7fe093201b39adb162f0 Reviewed-on: https://chromium-review.googlesource.com/1029125 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553834}
-
John Abd-El-Malek authored
Bug: 729849 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I28f621849bbc3260df2cd818a1daf58c5969755f Reviewed-on: https://chromium-review.googlesource.com/1029009Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553833}
-
Misha Efimov authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 836823, 829429 Change-Id: Id69a596b5d260ceec0794c6c6478ad01ce61a0da Reviewed-on: https://chromium-review.googlesource.com/1028630Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#553832}
-
- 25 Apr, 2018 35 commits
-
-
Malay Keshav authored
rebase_path is being applied twice on skia_workaround_list file path. This patch removes the redundancy. Component: Gpu config Gn Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieea6c860dabbd0d76983a67a7fa7de53c014a963 Reviewed-on: https://chromium-review.googlesource.com/1028578Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553831}
-
Lukasz Anforowicz authored
Blink Intent to Implement and Ship discussion and approval happened in https://groups.google.com/a/chromium.org/d/topic/blink-dev/hnAWBzq1qys/discussion Bug: 802835 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I608817ddbbf538f5074774715eeb9b27920c1bf7 Reviewed-on: https://chromium-review.googlesource.com/1028356 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553830}
-
James Cook authored
Clarify kiosk test failures. Bug: none Change-Id: Ie238700e76dcb279453917e3d2075f42bd821fae Reviewed-on: https://chromium-review.googlesource.com/1029201Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#553829}
-
Takuto Ikuta authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/99be318..bf58b9 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5964f90bad824754fc3d6b4354ec13d9cbad643c Reviewed-on: https://chromium-review.googlesource.com/1028250Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553828}
-
Sean Kau authored
on-manually-add-discovered-printer was being called with invalid parameters. Refactor so it's easier to call properly and fix the bad callsite. Observed behavior was that the setup dialog would close without any messaging. User is prompted for a PPD now. Bug: 835476 Change-Id: I85ae96cf1f9638098cd819fccb47b30e16274a58 Reviewed-on: https://chromium-review.googlesource.com/1023040 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#553827}
-
Peter Boström authored
This reverts commit 30e23517. Reason for revert: This script turned animated PNGs for ChromeOS into flat PNGs. Scary! Original change's description: > Run tools/resources/optimize-png-files.sh > > Optimizes a significant number of .png files and cuts ~3.6M in total. > > Bug: None > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I53a951a6410839c3b21f7155f22e2fedb3fb963f > Reviewed-on: https://chromium-review.googlesource.com/1012263 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551066} TBR=sky@chromium.org,bauerb@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:835197 Change-Id: I4852e2ee84ac51ffb765649ff838c03dfba564d3 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1028336 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553826}
-
Peter Boström authored
* Adds 2dips of bottom margin and 2dips of padding between items (for all layout modes). * Uses 4dips of rounded-corner radius under Refresh (already in use under touchable). Bug: chromium:822072 Change-Id: I6fba6c49a01fa5f79cc33fe2e53aa998e350e03b Reviewed-on: https://chromium-review.googlesource.com/1026392 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#553825}
-
Filip Gorski authored
Bug: 836851 Change-Id: I6d83b276596cb41770161f40283e6638463cf67d Reviewed-on: https://chromium-review.googlesource.com/1028377 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#553824}
-
Xiaocheng Hu authored
ax_layout_object.cc includes rendered_position.h to use some hacky utility functions there. As editing code no longer uses those functions, this patch moves the functions to AX, and stops AX from including rendered_position.h to improve code health. Change-Id: I85a50fbd81f05eded792721e8fd99eac0373b6c3 Reviewed-on: https://chromium-review.googlesource.com/1024734Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553823}
-
John Budorick authored
Un-breaking WebRTC to let them revert a CL to un-break CrOS. TBR=agrieve@chromium.org Bug: 836344 Change-Id: I48abc7353825571873f63f37af54026db6c429c8 Reviewed-on: https://chromium-review.googlesource.com/1028571Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553822}
-
James Cook authored
This eliminates a call into ash::Shell::GetRootWindowForNewWindows, which we need to do for out-of-process ash (go/mustash). The existing code looks like it was just copied from another place that shows a similar notification. Regardless, the primary display should be fine. Bug: 372857, 826569 Test: browser_tests KioskUpdateTest.* Change-Id: Iebe8a3a614bdb346fc30f8baab8b77e24ad466c2 Reviewed-on: https://chromium-review.googlesource.com/1029115Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#553821}
-
rbpotter authored
Original change: https://crrev.com/c/1015850 Chromium and Google Chrome show different messages when the PDF plugin is missing in Print Preview. Modify the test to accept either message, to fix official build failures. Bug: 814860 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1672512db0c50bbf2e95ae6c9798dca82e4ee71c Reviewed-on: https://chromium-review.googlesource.com/1028566Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#553820}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c56c9493dbc3..6376ebcedebd $ git log c56c9493d..6376ebced --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic5adff09355d66c0d0ddb752674c42dd4b96683e Reviewed-on: https://chromium-review.googlesource.com/1028970 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553819}
-
Patrick Noland authored
TBR=tdresser@chromium.org Bug: 836996 Change-Id: Ieb41ef895cdc2ea3ca26b47c4f3a2e9694bacf78 Reviewed-on: https://chromium-review.googlesource.com/1029110 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#553818}
-
Nate Fischer authored
No change to production logic aside from metrics changes. This changes SafeBrowsing.WebView.UserOptIn into an enumerated histogram in order to capture when the underlying API for user consent (SafetyNetClient#isVerifyAppsEnabled) returns neither true nor false, but indicates a failure. Technically, this also covers the case where PlatformServiceBridge#canUseGms() returns false (we also invoke the callback with 'null'), however we don't log UMA metrics in this case anyway. This renames entries in enums.xml for clarity. Bug: 836461 Test: check that metric is logged under chrome://histograms/SafeBrowsing Change-Id: I570e88a66c5955026988ebe05ed6acc55685b0e2 Reviewed-on: https://chromium-review.googlesource.com/1027007Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553817}
-
Lei Zhang authored
To make it easier to write fake DocumentLoaders for testing. Split the implementation off into DocumentLoaderImpl. Change-Id: I44f16c757b8a9be133936c41c231a552a7e05f0a Reviewed-on: https://chromium-review.googlesource.com/1013998 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Peng Huang authored
This CL adds a new interface viz::SkiaOutputSurface which extends viz::OutputSurface for SkiaRenderer to support compositing with SkDDL (skia deferred display list). SkiaRenderer draws quads into a DDL SkCanvas, and draw operations will be recorded into a DDL. In OutputSurface::SwapBuffers(), a GPU task will be scheduled with gpu::Schduler. The task will be executed on the GPU thread when all resource sync tokes are satisfied. The task will play the DDL back on a GrContext which is backed by a native platform GL context. We have a goal to use SkiaRenderer everywhere, and remove GLRenderer and Software Compositor. The new viz::SkiaOutputSurface interface and viz::OutputSurface interface will be merged into one interface when DirectRenderer subclasses are removed. The new interface is for making development faster because when we change methods in viz::SkiaOutputSurface, we will not break all other existing OutputSurface implementations. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I776a76dc8496d40f88950856867596f5c44f735f Reviewed-on: https://chromium-review.googlesource.com/978366 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#553815}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/ba32080311ac..16ee25d20583 $ git log ba3208031..16ee25d20 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 dalecurtis Allow msvc builds to keep working with inline assmebly. Created with: roll-dep src/third_party/ffmpeg BUG=783021 TEST=none TBR=liberato Change-Id: I7e113fab5b3e03393a40bee445c26290778481cb Reviewed-on: https://chromium-review.googlesource.com/1028842Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553814}
-
Ria Jiang authored
Bug: 835628 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I06c983e2e12b804a3fd31ef909917c30d6cf1b06 Reviewed-on: https://chromium-review.googlesource.com/1027801 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#553813}
-
Malay Keshav authored
The paint cache used by layer paint delegates(views) do not work well with Mirrored layers that are on different device scale factor. This patch forces a schedule repaint when the user stops dragging the window so that the invalid data in PaintCache is not used. Bug: 786628 Change-Id: Ic249d592d4f93b47dc4ede4461f44a59ce7b18d7 Component: Window, Drag window, phantom window Reviewed-on: https://chromium-review.googlesource.com/1028620Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553812}
-
David Tseng authored
Original change: Initial Google tts engine settings page - hooks up a message to retrieve display voice name and language (for *only* Google tts engine) - adds the initial page UI (under UI review) - adds string resources (under review) Bug: 831286 TBR=dtseng@chromium.org,hcarmona@chromium.org,katie@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1bb2780758992ed9f8e240ed28a8176201d06f05 Reviewed-on: https://chromium-review.googlesource.com/1028766 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553811}
-
Max Moroz authored
Also, alpha-ordered the links. Bug: 829116, 759794 Change-Id: I5e71079964122591df68268136b23de3f605a8d6 Reviewed-on: https://chromium-review.googlesource.com/1028838 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#553810}
-
Xiaocheng Hu authored
This patch introduces LeadingBoxOfEntireSecondaryRun() to wrap some traversal logic, and also reduce the frequency |box| gets changed. Change-Id: I8bf6c8170370bfb92e8a44a0620069015f11a07d Reviewed-on: https://chromium-review.googlesource.com/1026930 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
The reported crashes likely come from accessing objects in WebContents when it's on the way to destruction. Adds a check to ensure it won't attempt to access objects that already become invalid. Bug: 788278 Change-Id: I8d4ef4907c73a93ac4d6d12e78540bbbbfbae08e Reviewed-on: https://chromium-review.googlesource.com/1027170 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#553808}
-
Georges Khalil authored
Before this patch, the browser identification contained the version number as well (which happens to be the last directory of the path). This patch strips that directory so that the identification stays stable after upgrades. Change-Id: I11b3b37c37f01eb07d8003174ecf5c80da1ba718 Reviewed-on: https://chromium-review.googlesource.com/1028663Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#553807}
-
lgcheng authored
Invoke GetDeviceList permission check rather than treat as it is always granted to apps. Bug: b/78231419 Test: Manual Change-Id: I838c00fd2d87719c8e9e8d5c9194144a279c0eca Reviewed-on: https://chromium-review.googlesource.com/1014602Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#553806}
-
Justin Cohen authored
Start the scroll from the middle of the screen incase the default bottom of the screen is obscured by the bottom toolbar and stop using kGREYContentEdgeBottom. BUG: 825431 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I704954672bf46e9cb138ea0be6a325ba4aeb3d69 Reviewed-on: https://chromium-review.googlesource.com/1028462Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553805}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=hubbe@chromium.org Bug: 825327 Change-Id: Ifccb0682900e0015ef59bed96592d03275217e24 Reviewed-on: https://chromium-review.googlesource.com/1024663Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553804}
-
Eric Orth authored
Bug: 824970 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5adf0dc043bb6e3683f013036f1c42eb7364f016 Reviewed-on: https://chromium-review.googlesource.com/1017322 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#553803}
-
Kevin McNee authored
This test is flaky on android when viz hit testing is enabled. Bug: 835058 Change-Id: Ia746468e3595806ca01df494c95fc97ab2927602 Reviewed-on: https://chromium-review.googlesource.com/1028975Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#553802}
-
Rakina Zata Amni authored
We are moving find-in-page related functions out of web_local_frame_impl_find_in_page.cc to its own class (FindInPage) for easier mojoification and so that we can add new find-in-page related functions more easily. In this CL, we are moving functions out of web_local_frame_impl_find_in_page.cc. In the next CL we are going to entirely remove the functions from the WebLocalFrame interface. Previous CLs: crrev.com/c/956648 crrev.com/c/1025242 Next CLs: Remove find-in-page functions from WebLocalFrame Introduce FindInPage mojo interface Bug: 819919 Change-Id: Ia82b5e8f1e08701b014236039d2c6e5e45410222 Reviewed-on: https://chromium-review.googlesource.com/1027013 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
This is a reland of 4f376c3e Original change's description: > Convert xml_parser.mojom to use mojo/public/mojom/base/values.mojom > > This change also converts the minimum necessary amount of C++ code to pass > objects of base::Value by value instead of std::unique_ptr. > > Bug: 646113,799482 > Change-Id: I86dcd6b4cfbb061942cb73f6ffddcf9e712f355f > Reviewed-on: https://chromium-review.googlesource.com/1012931 > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551470} Bug: 646113, 799482 Change-Id: I54fdbc1cfd23f7065673a78c2e8e1376717baf62 Reviewed-on: https://chromium-review.googlesource.com/1026471Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#553800}
-
https://chromium.googlesource.com/angle/angle.git/+log/10434f67672d..23dc90b81efb $ git log 10434f676..23dc90b81 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 lfy GLES1: Enable/disable for texture targets 2018-04-25 oetuaho Handle negative float to uint conversion robustly 2018-04-24 lucferron Vulkan: Enable UnpackAlignmentTest and remove useless warning. 2018-04-24 lucferron Vulkan: Fix issue with texsubimage2d barriers 2018-04-25 jmadill Clean up DEPS style. Created with: roll-dep src/third_party/angle BUG=chromium:835868,chromium:782846 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I7ff0b0ad560ed9fadcce00db4c136232330826c9 Reviewed-on: https://chromium-review.googlesource.com/1028521 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553799}
-
Ehsan Chiniforooshan authored
It is still flaky: https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.chromiumos%2Flinux-chromeos-rel%2F109818%2F%2B%2Frecipes%2Fsteps%2Fmash_browser_tests__with_patch_%2F0%2Fstdout Bug: 832981 Change-Id: Idd9646c0bfe7ebec3c1ff9068c39d11ba02faf67 Reviewed-on: https://chromium-review.googlesource.com/1028730 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#553798}
-
Vaclav Brozek authored
Currently, IsCreditCardVerificationPasswordField creates a static string16 object. That involves a static destructor, which is forbidden by the style guide: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables This CL fixes that by using base::NoDestructor. It also restructures the function slightly. There should be no visible change caused by this CL. Bug: 833838 Change-Id: Id879c5595113aae295e858bebf6cacc7f211b373 Reviewed-on: https://chromium-review.googlesource.com/1028272 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553797}
-
