- 04 Dec, 2020 40 commits
-
-
Moe Ahmadi authored
This is in preparation to promote the canary experiment which originally landed in cl/339288320 to Beta. Fixed: 1155314 Change-Id: I4b87b89736e4cb461d416aacef98ed888596568c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573130 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#833576}
-
Moe Ahmadi authored
Fixed: 1150983 Change-Id: I3be6ad5f6a0e2e8bfbca2f7cb67d8a0e532799d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572239 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833575}
-
Nina Satragno authored
When trying to use a security key with the forcePINChange flag on, display an informative message telling the user they need to set a new PIN before using it. UXW review: go/force-pin-change-ux Bug: 1143427 Change-Id: I69812293b3db42599d5e350974510b15409cddf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562878 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#833574}
-
Luciano Pacheco authored
For our unittests Polymer wasn't working, this CL changes it by: 1. Always adding the HTML import polyfil. 2. Always importing the the Polymer config at the top, so any test using Polymer elements work. 3. If there is any dependency in the Files app Polymer elements (files inside //ui/file_manager/file_manager/foreground/elements/) it uses the elements_bundle.html instead of individual JS files. When I activated Polymer and imported the elements_bundle.html some tests started failing because they require the chrome.fileManagerPrivate mock. FileTransferController test uses ListContainer that requires the <files-spinner>. Also add the closing tag </cr-input> so the adjacent <input> remains outside the <cr-input> allowing the focus to flow properly as the test setting the focus on #test-input started failing once <cr-input> Polymer became fully functional. NOTE: This fix is only relevant for non-JS module unittest, we're migrating unittest to JS module and this problem doesn't happen when using the built-in JS import. Bug: 1102263 Change-Id: I2ea80bbe93afca2521bfa5ab9fcd6c32fcf8ecc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573696 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833573}
-
Hirokazu Honda authored
This is a reland of 5a3ffeb6 Original change's description: > media/gpu/video_encode_accelerator_tests: Validates each temporal layer stream > > The test originally validates the entire bitstream. This CL > enables the test to validate each temporal layer stream. For > instance, when --num_temporal_layers=3, the test validates three > streams, TL0, TL0+TL1 and TL0+TL1+TL2. > BitstreamFileWriter and VideoFrameFileWriter ignore bitstreams > and frames in upper layers than to be processed by them. > VideoFrameFileWriter also writes a file with a different prefix > from other VideoFrameFileWriter, so that multiple instances don't > write to the same file names. > > Bug: b:174318867 > Test: video_encode_accelerator_tests --codec=vp9 --num_temporal_layers=3 w/o output_bitstream --output_images=all > Change-Id: Idf2a1e4d2a50e11ca359435ec4495a43b61139f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562801 > Reviewed-by: David Staessens <dstaessens@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833103} Bug: b:174318867 Change-Id: Ifd87576869aebab313933afa7c7c0f202b152e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570476 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#833572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/38f2fff09dac..5d919472c98c 2020-12-04 jegarc@microsoft.com This CL adds an accessible name to boolean columns that are checked in a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152607 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1519ae9f643a1623de6cb2b3c15afdd4ec6395ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833571}
-
Yicheng Li authored
Since u2f credentials are not handled properly on ChromeOS, we decided to disable platform authenticator when U2F is enabled. This is done by making ChromeOS Authenticator return IsUvpaa=false when U2F is enabled. Thus ChromeOS platform authenticator and u2fhid are mutually exclusive for WebAuthn. Bug: 1155335, b/174709984 TEST=Enable U2F and enable ChromeOS WebAuthn feature flag, register PIN, ==> PublicKeyCredential .isUserVerifyingPlatformAuthenticatorAvailable() .then(console.log) returns false even if PIN is available. ==> When attachment=undefined or cross-platform, can use u2fhid to do WebAuthn MakeCredential and GetAssertion. ==> When attachment=platform, "Your device doesn't support the type of security key requested by this site". TEST=Disable U2F and enable ChromeOS WebAuthn feature flag, register PIN, => PublicKeyCredential .isUserVerifyingPlatformAuthenticatorAvailable() .then(console.log) returns true. => When attachment=undefined or cross-platform, u2fhid doesn't show up. => When attachment=platform, can use ChromeOS PIN to do MakeCredential and GetAssertion. Change-Id: I4ce5c9de4aecaa5c1569101065a1278576c9d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572130 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by: -
Michael Crouse authored
Implement the service that will handle loading TFLite models needed for the translate service in Chrome. Bug: 1151404 Change-Id: Ibcf242d7d4d54e032fd980fd244247bc1196fc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553526Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#833569}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b42686ad015b..c0c5106bd4d4 2020-12-03 johnstiles@google.com Add Type::isArray and Type::isStruct helper methods. 2020-12-03 mtklein@google.com add missing unit test for 128-bit ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I2c8b82a479f33c4baf968080b1a2d9232d9eaa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573519Reviewed-by:
-
Josh Simmons authored
We will be running experiments using this starting in M88, but I anticipate further integrations with Assistant will keep this metric relevant at least until mid-year 2021. Setting this to M91 for now. Bug: 1153777 Change-Id: I4fd788c6bed0220781ee1c6f519eab83a52e97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572171Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#833567}
-
Kent Tamura authored
property * core/css, core/style, web_tests/external/wpt: Changes to recognize new keywords 'disclosure-open' and 'disclosure-closed'. * layout/layout_details_marker.*, layout/layout_tree_as_text.cc, paint/details_marker_painter.*: Changes to make DetailsMarkerPainter::GetCanonicalPath() static in order to share it with ListMarkerPainter. These files has no behavior changes. * paint/list_marker_painter.cc: Calls DetailsMarkerPainter::GetCanonicalPath() to get a Path, and draw it on |context|. * layout/list_marker.cc: Adjust the layout size for 'disclosure-*'. The size of 'circle', 'disc', 'square' is "ascent * 1 / 3", and it's too small for 'disclosure-*'. We apply "font_height * 2 / 3" instead, and it's same as the default size of ::-webkit-details-marker. * layout/list_marker_text.cc, wtf/text/character_names.h: Add text representations of 'disclosure-open' and 'disclosure-closed'. This CL adds a simple rendering test. A following CL will add more coverage. I2S: https://t.co/1a7z357RV9 Bug: 590014 Change-Id: I1acad5a102c7cfcc91101fca283fde32fefae06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567548 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#833566}
-
Devlin Cronin authored
Label the detail_view.html's icon with an aria-label, indicating it's related to the extension, similar to what's done in item.html. Move the code to be part of ItemBehavior so it can be easily shared between the two. Bug: 1100943 Change-Id: Idb888c899ab96349a5df0fba74e60d481e619823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542951Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833565}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ddf5ae4b8a5..0fdb2247e82e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d05c47c106b8dc23fd9955b2b9e2c27d53e4f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572655Reviewed-by:
-
Yu Su authored
Since in cl: https://chromium-review.googlesource.com/c/chromium/src/+/2508299 we allow 0-RTT for POST request if the request is idempotent, we update the DCHECK in net/quic/quic_chromium_client_stream.cc Change-Id: I02a8a4c6a1da7eb945b65a8453c92957f10cd945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565453Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#833563}
-
Anupam Snigdha authored
This patch fixes a bug where the text input state updates are not being sent to IME when control bounds change due to the change in active element's position. Bug: 1151301 Change-Id: I7d1bf8a26bd43e49ffb480e1900ed257ecd6bba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570081 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833562}
-
Tibor Goldschwendt authored
Bug: 1110075 Change-Id: I735506c3e0efff1f92582498400bea0a914cf215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566374 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833561}
-
Matthew Mourgos authored
ClipboardHistory::Observer::OnClipboardHistoryItemRemoved was only called when removing an item from the list after the maximum number of items was reached. This change also calls the removed function when an item is manually removed with the 'x' button in the context menu. Bug: 1154811 Change-Id: I274beba20d1671e3e7aabdcf7c0b17d97c29d547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569854 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833560}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/91cf42a0759a..b2c18f2f62b9 2020-12-03 vitalybuka@chromium.org Support CMake generated build files 2020-12-03 ehmaldonado@google.com [owners] Fix SuggestOwners when there is only one owner. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I209f6c6c9a69df9304102445343a5403a0fb7cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573618Reviewed-by:
-
Thomas Guilbert authored
This CL removes the last remaining use of base::Bind in chrome/browser/media. It also removes the directory from the list of un-converted directories. Bug: 751838 Change-Id: Iddce00b9a5b63a31b9b8891e2742b735aff88d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568851 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833558}
-
Bao-Duy Tran authored
Some InputMethodManagerImpl tests are failing in specific environments due to usage of CrOS prod configs. Thanks to preparatory refactorings, we can now detach tests from legacy input_methods.txt configs for hermetic-ness, and adjust the data to un-fail two more tests. There remains one failure though, to be addressed in follow-ups. This also effectively reduces usage of legacy input_methods.txt [1][2] (remnant from before the migration to extension-based input methods circa 2011) and facilitates its complete deprecation. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea [2] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97 Bug: 970790, 1134526 Change-Id: If1ff356711bef55521f4391ec0956bd4b619cf75 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg;luci.chromium.try:linux_chromium_chromeos_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554277 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#833557}
-
Thomas Guilbert authored
This CL converts remaining instances of base::Bind and base::Callback to their appropriate {Once|Reapeating} equivalents. It also removes an unused callback in SCTReportingServiceFactory. Bug: 1152283 Change-Id: I27a6c3a152823080d4e5327978e260b6cc3fb654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573134Reviewed-by:Charlie Reis <creis@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#833556}
-
Nicholas Hollingum authored
This monitor will be sent requests to shutdown borealis with or without a delay, and it will act on those requests at the appropriate times. Bug: b/172006764 Change-Id: I81fb0cb73cfb1c868a6ebc8000cfa044a1569a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569323 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#833555}
-
Piotr Bialecki authored
Add depth buffer resolution limit along with a histogram to measure the resolution of depth buffer that was obtained from ARCore. Bug: 1154323 Change-Id: I7109c76732e76dd825f0a45e2dd32570b89e79d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568752Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#833554}
-
Nicholas Hollingum authored
Anonymous apps are generated when borealis identifies a window with an app_id it does not recognize. In this CL we add the logic to remove those anonymous apps. When all the windows close associated with that anonymous app, we say the app is "finished", allowing observers to clean it up. Bug: b/172979315 Change-Id: I5c1c0cfd2ed15fcd35474c53011cbce6c0733d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562624 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833553}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19a302fca592..0d2de6f05c54 2020-12-03 syoussefi@chromium.org Vulkan: Fix precision issue in blit math If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1154759 Tbr: ianelliott@google.com Change-Id: Ic3a87fa0b240cfdeefdb5d995ec43bf01848006c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572651Reviewed-by:
-
Yan, Shaobo authored
This CL replace SkImage::MakeFromYUVATexturesCopyToExternal with Sksurface. This will combine all of the uploading path to the same logic and remove duplicated codes. This CL also change the incorrect condition to try direct uploading path on Windows. BUG=1108154 Change-Id: Iaa44d23e984b192f4c3b38aa52c7d22dea879748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559649Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#833551}
-
Andrew Xu authored
This CL adds the ink drop ripple to the delete button. In order to achieve this, we create a new class called `DeleteButtonContainer` to paint the delete button background. Otherwise, because the ink drop ripple's layer is beneath the host view, the delete button's background will be placed above the ink drop ripple's layer. Due to the view hierarchy's change, this CL also modifies the api function provided by ContentsView to install the delete button. Bug: 1152815 Change-Id: I083850f41d15cb9c2c1974d84c217fcc93f83fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568152 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#833550}
-
adoneria authored
Added on chromium.updater buildergroup. This is to help updater team in easier monitoring of updater failures on chrome official builds for win and mac. Bug: 1155288 Change-Id: Ie65278f8f16f452cad0b72d525fc32e2b41a8240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572752Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#833549}
-
Renjie Tang authored
Split the content of QuicChromiumClientSession::OnProbeSucceeded() to two different methods for port migration and connection migration. These two methods will later be connected with IETF QUIC's path validators. Bug: 1151419, 1155306 Change-Id: Ie3eed049837fa87fd6fe0bff634a106c702a394d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572780 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
Gavin Williams authored
New tests cover more of the failure scenarios related to scanning. Bug: 1059779 Change-Id: I246a26c7dda8e460c5239318b2017b4db97d03e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569977 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833547}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..8ddf5ae4b8a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I19f86bf48a37e3d2652dd419e3545d92608b29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573131Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1025712c59ca7ac25c191cef3af65ef43d55f2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573283Reviewed-by:
-
Andre Vincent authored
Bug: 1080876 Change-Id: I278a8d4477f6811440e78e86b7bcf2fa7e10ad3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569433Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5537c0394234..d1cf5db4152d 2020-12-02 dberris@chromium.org sheriff-config: Improve validation coverage 2020-12-02 dberris@chromium.org sheriff-config: Fix crashloop If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1154561 Tbr: wenbinzhang@google.com Change-Id: I92ee5eaadc72ec277f9d34af7573b5d5ea797756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569457Reviewed-by:
-
Reilly Grant authored
These tests don't have any automation dependencies (since they are manual) so can be exported first. Bug: 884928 Change-Id: I6a3b9240d7ce8d61bfea43e5445d1334725bbd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572745 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833542}
-
Taylor Bergquist authored
This reverts commit 5e258bde. Reason for revert: Speculative fix for test failures in https://crbug.com/1155028 Original change's description: > Roll Media App from 9Aak3tK4o... to 6AHX-97XE... > > Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012020600_RC00.html > > https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/6AHX-97XEsRATZXtxtSFgMgB4HPdjrF2NmTP1UctxQQC > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll > Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: b/138543581,b/147599135,b/168067375,b/173978830,b/174442723,b/174536897 > Tbr: media-app@grotations.appspotmail.com > Change-Id: Ib6c2542e28b60d8c1a04a3d21d378e4a10cac32e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569796 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#832834} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,media-app@grotations.appspotmail.com # Not skipping CQ checks because original CL landed > 1 day ago. TBR: sebsg@chromium.org Bug: b/138543581 Bug: b/147599135 Bug: b/168067375 Bug: b/173978830 Bug: b/174442723 Bug: b/174536897 Change-Id: Ib1c2c8377cc932aa8223bc72282ebbf29cd77dac Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572164 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#833541}
-
Evan Stade authored
Use it to sever a Chrome dependency from InstallableManager. ChromeWebappsClient is added to the //chrome/browser target in a new //chrome/browser/webapps directory, as there's no directory currently shared by Android and desktop for web apps. That is, //chrome/android/webapps and //chrome/browser/web_applications are platform-specific. Unfortunately the new method is called in many unit tests, so to avoid crashing we either have to instantiate a ChromeWebappsClient in each unit test (or unit test base class, i.e. at least BrowserWithTestWindowTest, ChromeRenderViewHostTestHarness, and ExtensionServiceTestBase), or we gracefully handle a missing client. I opted for the latter, although this decision may be revisited if many other WebappsClient callsites wind up needing to null check. Bug: 1147276 Change-Id: I40eaa3e999dbe987aa4ecc2bbfaafb57cbcdc0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566743 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#833540}
-
Gary Tong authored
Change-Id: I0870a254683811a4e862518829b6cc49bd6d3d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570560 Auto-Submit: Gary Tong <gatong@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
David Van Cleve authored
Whoops. TBR=csharrison@chromium.org Change-Id: I9badb39d8d22041951fa8381271769a7d1cca5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573381Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833538}
-
Michael Ludwig authored
Bug: 1143929 Change-Id: I9259792778e80283e14f628cdce456c48d710af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571637 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#833537}
-
