- 25 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1b485322085d..afdbf8e6f881 2020-06-24 chemag@fb.com H264: Fix stap-a-to-annex-b loop over-read 2020-06-24 fippo@sip-communicator.org red: modify the encoder to send RFC 2198 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If593d70319c0e3d27da5153ac323740cabfec136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782245}
-
Xing Liu authored
Only show download later dialog when on metered network. Also refactor some code to use new network API. Bug: 1078454 Change-Id: I7217592b3dc79c3b2afb2e1c4a492d6e4a965d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261106 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782244}
-
tby authored
These metrics are useful for a while longer, for the suggested files experiment. This CL makes 2020/12/06 the date when all zero-state file metrics expire. Bug: 1097818 Change-Id: Iffd44003b4379009d92d1a6f3406288c2611f873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264090Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#782243}
-
Omid Tourzan authored
Using negative outline-offset to push outline into box border and add padding to put some distance between link text and its focus outline. Also remove the underline of "Learn more" link in the low space warning message to match the files-ng spec. Note: no need for this in the drive welcome message since it is inside a <cr-button> which removes the text underline style. Add 20px margin-inline-end on download warning element to space it away from the dismiss button. The 48px value in the design causes the text break into two lines at the default files app window size. Use 20px for now to avoid this line breaking. Bug: 1082539 Change-Id: I64794428dc48ecafc8a6d84e50725e5f735d9bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264088 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782242}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ice2d60d28546fa755feac36dd8278e3e14256200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264810 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782241}
-
Kenichi Ishibashi authored
crrev.com/c/2253259 added helper functions to store/delete registrations. We can use these helpers in some other tests to remove duplications. Bug: N/A Change-Id: Ie6c245e8b484c9473d62f74bae1f6451208363d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264091Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782240}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/36bfd8956dd0..e0658a4adf12 2020-06-25 jbudorick@chromium.org Restore --output-device-blacklist option to provision_devices temporarily. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098775 Tbr: oysteine@google.com Change-Id: I00a195d36cc758c51d088c769f4cbd32057a801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265491Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/10e4a44ce651..2a6cc4f8fb40 2020-06-25 jiawei.shao@intel.com Optimize B2T and T2B copies with multiple array layers on Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I87259a28fa80c1e4bb20f2ae4371a58e6688c6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265554 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
David Maunder authored
We have been calling the server too aggressively and need to reduce the calls. We achieve this by only allowing one call to the server every 5 seconds. Bug: 1093531 Change-Id: I4d0d263248b7489b1b688921382c4bb214810b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241348 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782237}
-
Reilly Grant authored
This change updates the Mojo interface provided to the renderer and implements the getInfo() method on the SerialPort object so that sites can determine the USB vendor and product IDs of a device. These properties are USB-specific and won't be present for other types of devices. These properties provide symmetry with the usbVendorId and usbProductId filter parameters a site can pass to navigator.serial.requestPort() and allow the site to automatically detect the model of a device in order to determine the protocol it supports. Bug: 1074383 Change-Id: I84e0028890c1ecb9598262594a55adbec7443b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236915 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#782236}
-
Yoshifumi Inoue authored
This patch changes "caret-ltr-right.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: Ie030551e9656436a4c2ac02cc14127b98d294e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262693 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782235}
-
Rachel Wong authored
This change adds a policy that sets Suggested Content to default disabled for enterprise users. Bug: 1079169 Change-Id: I994ff0efd9c5ff7605f0508fdf1c3556b45ecccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255736 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782234}
-
Stephen Roe authored
If the runner logs directory is not specified, if there is an emulator ssh connection error output the serial log contents using python script logging. Bug: 1067356 Change-Id: I437b60dc3dda699d8f1215c1f1baaac72f451f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261637 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782233}
-
Peng Huang authored
The vulkan queue submission has been removed from GrContext::updateBackendTexture(), so the queue submission in the WrappedSkImage::Update() method is not necessary anymore. Bug: 1087063 Change-Id: Ic77cc4194867778ac4f4694c005644e32763299e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265375 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#782232}
-
Hiroki Nakagawa authored
This CL delays recording loading breakdown metrics for navigation until the current page navigates away. The motivation of this change is to make the timing to record them consistent with the timing to record other PageLoad metrics. The loading breakdown metrics were newly added in M85 (the current milestone), so this change doesn't mess up the metrics already recorded. Bug: 1068843 Change-Id: I3a1f9671465d3c131a1864bb18001277d045b069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253828Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/EzR30mgq8gBio73c57P_BOSZHQ1vp_pejDwHKnzEKO4C Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006230800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I0c6d5b5265c0cd792ec977adc21622742251ccb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263633Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#782230}
-
Alexey Baskakov authored
WebAppFileHandlerManager::GetAllFileHandlers must return nullptr if web app is uninstalled. Semantically, app_id is a weak pointer. The WebApp object behind it can be destroyed. Bug: 1088434 Change-Id: Ic74545efbe4f9e1250e039bf88fd95dd46bcf342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264179 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#782229}
-
Ted Meyer authored
Bug: 1099034 Change-Id: Icabb126bfac5e69aa4d030cf68c63ef826ccfd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264945Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#782228}
-
Ben Joyce authored
Code coverages looks for files with a suffix __jacoco_sources.json. Need to have files match name this as right now, they have the suffix java_process_device_sources.json. Coverage has been broken because the new files are not named this after https://chromium-review.googlesource.com/c/chromium/src/+/2252690 landed. Bug: 1097815,1095770 Change-Id: Ie5571677ab1ef2ad7a6d4fc519b6068d0081f89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264469 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782227}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593032304-90202fa1b4038f00c77b47bcef25599006092a46.profdata to chrome-win64-master-1593043069-e9ed35a2ba4491e832399d01d535b62071a030c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I722cb480291462bb13a7ddaa449d75801cd53d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265713Reviewed-by:
-
Sara Kato authored
Update comments to follow convetions mentioned in https://developers.google.com/style/inclusive-documentation. Also perform some refactoring of other comments to ensure consistency/ readability. Bug: 842296 Test: N/A Change-Id: I389463cc5ccd8f21983ee83383df07521c58aa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265695 Commit-Queue: Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782225}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f08ecebda15a..0633c38c109f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150,chromium:1090082,chromium:1094506,chromium:1098971,chromium:834134 Tbr: melzhang@google.com Change-Id: I90d44bbe5d225ff3d7ab43829c777261b20a514c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782224}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I91925dd3fb2f6c0ac1186e653322d3a3fa1c8d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265755Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782223}
-
nancylingwang@google.com authored
BUG=1083331 Change-Id: Ib24ea57a1c472a28231f3e391c50d8406a8ae488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259313Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782222}
-
Rachel Wong authored
Previously, if Suggested Content was disabled, old results would still appear in the cache. This change ensures that results cache is always cleared. Change-Id: If9e09c95e65ff9b731195da5832803ee7505d956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264182Reviewed-by:
-
Tanya Gupta authored
Change-Id: Ie55e5d1b1bdb972db055ecb6e7c28b23badc22b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265432Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#782220}
-
Mohamed Heikal authored
This reverts commit 8a3e6a28. Reason for revert: Revert before next branch cut, was only required for a cherry-pick to M84 Original change's description: > Rollback protobuf lite runtime to 3.0.1 > > As a temporary fix for android webview regression b/157318961 this cl > rolls back the protobuf lite runtime to 3.0.1 using the codegen plugin. > > Binary-Size: This is temporary and there is not really much we could do. > Bug: 1093059, b/157318961 > Change-Id: I2bbaf6d3b434221b667901423c4616e26a7550c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238872 > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777495} TBR=yfriedman@chromium.org,agrieve@chromium.org,mheikal@chromium.org,harringtond@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093059, b/157318961 Change-Id: Ieda4530327ff3de513601ae3fe0ad5e9c99eeed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264466Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782219}
-
Caroline Rising authored
This also hides the pin button from the extensions menu as well as the pin option for an extension's context menu. Bug: 943702 Change-Id: Ib489b5dd55d2e94ffcee511bb625662bdbe1c259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261354 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#782218}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/054aeeed3b4c..18d412cba8ce 2020-06-25 jdarpinian@chromium.org Fix readBuffer validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I93088a6aeea57037a5e84809bd7b2b08fde553ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265560Reviewed-by:
-
Darwin Huang authored
Add logging for read and write with the platform clipboard. This logs all reads and writes, as well as their formats, that go through Chrome and hit the clipboard, from all endpoints (context menu, shortcut, web APIs, etc). This may be useful for determining usage of various formats and their change over time. An enumeration is used to understand which format is used for each read or write. Function calls for NOTIMPLEMENTED() reads or writes are not logged. The following clipboards are also omitted, as these don't really reflect use on "real" platforms: - TestClipboard[1], which is used for automated web / WPT tests, and the MockClipboardHost. - HeadlessClipboard[2], which is used for Selenium, Puppeteer, and other automated, non-UI platforms[3]. [1]: https://cs.chromium.org/chromium/src/ui/base/clipboard/test/test_clipboard.h [2]: https://cs.chromium.org/chromium/src/headless/lib/browser/headless_clipboard.h [3]: https://developers.google.com/web/updates/2017/04/headless-chrome Bug: 1079036 Change-Id: Ia90c447018221a839842497896cdc1b8f8d13e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255741 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#782216}
-
Timothy Loh authored
The change in https://crrev.com/c/2249239 was accidentally removed in https://crrev.com/c/2249245 due to a bad rebase. This CL relands it. Bug: 1094946, 1094944 Change-Id: I8ff7523933203c225b5befe70f20be664ab26a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264181 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#782215}
-
Alexandre Courbot authored
The V4L2 video decoder "slice" name is a relic from the time this decoder could only handle stateless decoders. Now that it can handle both types, rename it a something more generic and accurate. BUG=b:149663704 TEST=VDAtest --use_vd runs on Hana-kernelnext. Change-Id: If516bb0fbf5c245a131feaefbf550affcc4f6fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262753 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782214}
-
jameshollyer authored
The change makes the RenderWidgetMouseLockDispatcher::SendLockMouseRequest function bind the RenderWidgetMouseLockDispatcher::OnLockMouseACK to be called when the request is fulfilled. Previously it bound the Parent classes OnLockMouseACK function which stopped the WebWidget from being notified. Bug: 1098093 Change-Id: I367d84ad69997b8de81c629d1ddc7efd5ca47b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258954 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782213}
-
Henrique Nakashima authored
WebContentsStateBridge#createHistoricalTab() can be accomplished by calling other methods: - WebContentsStateBridge#restoreContentsFromByteBuffer() - WebContentsStateBridge#createHistoricalTabFromContents() - WebContents#destroy() Replace it with these calls. Bug: 1090048 Change-Id: I048f2aca26af8be92dfe450c124435264fb8c750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265133Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Eric Willigers authored
ChromeLauncherControllerWebAppTest tests ChromeLauncherController with a web app. This reverts commit d975d2ed and relands https://chromium-review.googlesource.com/c/chromium/src/+/2247992 The MSAN AssistiveWindowControllerTest unit test failure https://bugs.chromium.org/p/chromium/issues/detail?id=1096592 has been fixed by an unrelated CL: https://chromium-review.googlesource.com/c/chromium/src/+/2251862 Bug: 1087686 Change-Id: Ia7c432562933e06f696e1dbf5704f9727881d7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264178 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Varun Khaneja authored
The feature continues to be disabled by default for mobile platforms. Bug: 1044212 Change-Id: Ia4e1056a9c54786071d236a0df007060b8faf287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264797 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#782210}
-
Xing Liu authored
Adds the "ask when to download" setting in download setting page. Bug: 1078454 Change-Id: I8974413fc720694ca1cb39cd3ba740d47c480e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265174 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Previously, a query for "Google" would only show results related to the Google Assistant. This CL downgrades the default ranking for several of these search tags so that other Google-related content is surfaced. Fixed: 1096809 Change-Id: I75c2ade1a5997742fa18840a2d81e5ca112ccf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265438 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782208}
-
Alexandre Courbot authored
The new VD-based video decoder was initially built to support stateless (slice-based) decoders, but it is now able to handle both stateless and stateful ones now. Rename its source files to a shorter and more accurate name. BUG=b:149663704 TEST=VDAtest --use_vd runs on Hana-kernelnext. Change-Id: Ief2250ee88d7c64a5b98b3dd57cef61e861a9eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262752 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Scott Violet authored
This makes text-to-speech stop if the hosting WebContents is hidden, which differs from Clank (Clank stops when all activities are hidden). I think stopping when hidden is good for the current use case, but will need to be revisted at some point. BUG=1025626 TEST=wpt tests should cover this Change-Id: I631da77676f7822583e379cf2e51d5534d8199cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264621 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#782206}
-
