GitLab

This reverts commit 8444271f.

Reason for revert: Causing build failures, see https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14156?

Original change's description:
> Adds Desugar's jdk_libs_configuration to the build
> 
> This contains information required for new Java 8 desugaring features.
> 
> Bug: 1056751
> Change-Id: I87e15cd74f6a4a714fae748ed61172c000eda67c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354518
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Justin DeWitt <dewittj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798651}

TBR=yfriedman@chromium.org,dewittj@chromium.org,wnwen@chromium.org,agrieve@chromium.org,echristo@google.com

Change-Id: I21ea1a52845d3134339aa426e5699c452ac0e538
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1056751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358956Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798661}

Add a DumpWithoutCrashing to the sender side of
URLLoaderFactory.CreateLoaderAndStart.

Bug: 1028189
Change-Id: I05fcf83ebe3248b4b67c60d0ecb5c176173ad976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358478
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798660}

Bug: 927473
Change-Id: Icf7010f41392f761117915dac92f4f390b41f2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335289
Commit-Queue: Jonathan Mengedoht <mengedoht@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798659}

This adds use counters in both UKM and UMA for 3p cookie reads and
writes. The third party metrics observer records the use counters
with the other third party storage access types.

These two metrics will be used to understand how third party
cookie usage is on sites compared to other third party storage
mechanisms and give a more complete picture of how third party
storage is used across sites.

Bug=1059915

Change-Id: I2c1b645c7db7dcc6a1e44f6eab1d33110c2c5506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342578
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798658}

The issue below correlates to element_under_pointer_.at returning a
nullptr. All calls to element_under_pointer_.at but one are prefaced
with an if(element_under_pointer_.Contains(...)) check.
That one call is prefaced with a DCHECK. Most likely culprit is that
there is a real-world case in which the DCHECK doesn't hold and is
not covered by our tests.
Making the DCHECK a CHECK should confirm that. We'd still get the
same number of crashes overall, but with a different stacktrace.

Bug: 1114579
Change-Id: Ie28c971ed2114cf4a780f9eb5366c60d7669315c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359081Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798657}

Mostly, converts typedef -> using per style guide. Also uses
CallbackList::CallbackType more (and more systematically), and some
other misc. cleanup like using stl_util.h, explicitly declaring types
more, etc.

Bug: none
Change-Id: I63241972f5bede0c1cdb85ade8a0ba1155979cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354621
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798656}

Suspected root cause: https://crrev.com/c/1560083

Bug: 1116951
Change-Id: Ifd285549d2a36bad84bcc6073f65b7f659eb06c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359571
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798655}

Forwarding to base:: implementation:
- JobHandle::IsCompleted()
- JobDelegate::GetTaskId()
- worker_count passed as argument to GetMaxConcurrency().

Bug: 1114823
Change-Id: I9348a6171c19a39081205a33fbb5e19179a4601a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354163Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798654}

This CL adds the TWA quality enforcement for the launching URL failing
the digital assert link verification.

Bug: 1109609
Change-Id: I459015c0a70d4c00a5c3ec4f6f4506ff914c0552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339228Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798653}

Bug: 1092642
Change-Id: I1c96d5bfb0d886580c5498d7c8d1c4149ff148f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351285
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798652}

This contains information required for new Java 8 desugaring features.

Bug: 1056751
Change-Id: I87e15cd74f6a4a714fae748ed61172c000eda67c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354518Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798651}

Pedal button labels was updated when I added accessibility string for
them. Updating accessibility strings to match new button labels.

Bug: 1104264
Change-Id: I2381d0184dcee4a79d2e99c2a8dda8b6c2555ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359079Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/heads/master@{#798650}

Integrates PairedKeyVerificationRunner in NearbyServiceImpl to verify
remote device before receiving introduction and starting the transfer
flow.

Bug: 1085068
Change-Id: I73d42d9f85f3254007cdf3fdf46c6f5e05a48630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352799Reviewed-by: Alex Chau <alexchau@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798649}

Bug: 1113120
Change-Id: I7ab59d5a262dedbc36d90e8d4f3265b269c852de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346337
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798648}

Remove BUILD dependencies for merge_xml action and list all xmls that
need to be merged in merge_xml.py instead because listing them in the
sources is too verbose as we split up smaller xmls.

Bug: 1116096
Change-Id: I1ba1e09feece3442a673d4ba41868f36e1135298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359231
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798647}

"can only" was repeated twice.

Change-Id: I9acf582750dc2f01d700f2c9bacb26c95376df4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358584Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798646}

There is a recurring issue where bugs in browser process code introduce
deserialization errors on the main viz browser-to-GPU process message
pipe. The message pipe is closed and the GPU process crashes trying to
reinitialize the viz thread. Without a way to differentiate message pipe
closure due to a deserialization error vs the other side closing it, the
crash only happens when the browser tries to reinitialize the viz thread
after what it thinks is a GPU crash. There is a very little information
available in these crash reports, the message pipe is shared by multiple
interfaces and figuring out what IPC message the error occurred in is a
guessing game.

There is a global error handler that triggers for any mojo
deserialization errors which includes a string containing the interface
name and a message identifier. This CL adds a handler which stores the
error string. If the GPU process crashes due to reinitializing the viz
thread within 5 seconds after the handler fired, it populates a crash
key with that error message. While it's not guaranteed the last
deserialization error was what caused the viz thread to get
reinitialized, deserialization errors are infrequent enough it shouldn't
be an issue.

Bug: 1075495
Change-Id: I3a762fd5e9d50c0c1c301b3179f08ce892ff4912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356546
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#798645}

After current CL SharingMessage data type will stop on any persistent
auth error from the server. Previously, it would only stop on one
specific type of error (web signout).

Bug: 1097054
Change-Id: I917b20343b457e513004e5ad112bf6d42d0f42dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352743Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#798644}

This is a reland of d43884e1

Fix memory leak issue by cleaning selection_range member in
TextFragmentSelectorGenerator on DocumentDetached.
Reverted version is in patchset 1.

Original change's description:
> [SH-Blink] Create TextFragmentSelectorGenerator with page.
>
> Create TextFragmentSelectorGenerator with page and set selection
> information when context menu is shown.
> This is done so that Java code can just call the GenerateSelector
> function without any arguments and generation can happen for the latest
> selected text.
>
> Follow-up CL
> https://chromium-review.googlesource.com/c/chromium/src/+/2341662
> will connect to browser-side component.
>
> Bug: 1102382
> Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797256}

Bug: 1102382
Change-Id: If05b8e643627f4851dced45ce02cd78b7fa87fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354304Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798643}

chrome/services/sharing/*
- Introduced StopAllEndpoints to clean up all connections to remote
  endpoints

chrome/browser/nearby_sharing/nearby_connections_manager*
- Browser side usage of StopAllEndpoints. NearbyConnectionsManager
  uses StopAllEndpoints to clean up when shutdown is requested, or
  when the nearby process is stopped.

Bug: 1076008
Change-Id: Ie5cc7dedf2accad91774217be87d9e5218116594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346673
Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798642}

This CL adds a render test for the sign-in in progress screen in the
web sign-in bottom sheet.

Bug: 1090356
Change-Id: Ice77509c68b54c1090351ed7962850f98bdbdb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356025Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798641}

Change-Id: I26f79c147be2dcde083ac4f5be88267ccd2e236a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359135Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798640}

This CL is to fix the regressions caused by r785154. r785154 has been
causing two regressions. One is the context menu is opened at the wrong place
once right click is used inside emulation window. The other one is
a crash happens when performing a right click on 'Color selector'
overlay in emulation view.

The first regression caused by r785154 missed clearing
|host_context_menu_location_| unlike the original behavior. So, it
made RenderFrameImpl::ShowContextMenu() calculate the position of
the context menu with |host_context_menu_location| instead of the
current window position unlike the original behavior.

And, the second regresion was caused by RenderWidgetHostImpl::ShowContextMenuAtPoint
calls ShowContextMenu() through the Mojo message without checking if
|blink_frame_widget_| is bound.

This CL fixes those regressions.

Bug: 1093960, 1113088, 1115440
Change-Id: I94c3c385caeacda5561d30e6fd7ced6e86d69201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354128Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#798639}

https://skia.googlesource.com/skia.git/+log/c4245f475be7..866d2894ebd1

2020-08-17 djsollen@google.com Add android:exported values to all SkQP activities.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: stani@google.com
Test: Test: successful install on device with AOSP build
Change-Id: If67de613d99804be7f30f622b145844b07759b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798638}

Bug: 1087263
Change-Id: I2125c7072fcc9295749ff04f514e1b13d8754143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355905Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798637}

This is a re-land with sanity-checks of the kill() outcome removed, so
we can address the effects of process leaks separately from introducing
leak-checking.

Under Windows and Fuchsia the TestLauncher runs test batch processes in
their own jobs, allowing any leaked sub-processes leaked by tests to be
cleaned up.

Under POSIX platforms each batch is run in its own process group, but
the group was only being kill()ed if the test batch failed or crashed.

TestLauncher now proactively kill()s each test batch's process group.

Note that this will still miss processes launched into new process
groups by tests.

Bug: 1094369
Change-Id: I0880f08bd120fc5dd057a54efc3db63173feeca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359136
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798636}

With this CL, the edit fragment retrieves the compromised credential
from the start argument and fills them into the form. It also ensures
that temporary destruction of the fragment keeps the password and the
credential data.

Screenshot in the bug.

Bug: 1114720, 1092444
Change-Id: I8a0fe9a47f56b0af38465babd29c93afd8f669b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352901
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798635}

This CL removes ChromeGuard.


Bug: 1063824
Change-Id: Iad1224482534ff7a0f04116852dbebcabf27adce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346806
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798634}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

R=atotic@chromium.org, svillar@chromium.org

Bug: 1010217
Change-Id: I12a768919d9b5d5e4e9884a527296b2f7ad44b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358711Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#798633}

Bug: 1018157
Change-Id: I223619ed17fccf52313810177e79761569ba8459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353169
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798632}

Using wpt-import in Chromium 4bddba41.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I88dfc7319d5256c7c2f373c23ad005e9786e1e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358582Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798631}

This CL adds a way for ClientDiscardableSharedMemoryManager to discard
unlocked discardable memory locally. To achieve this, it keeps track
of all locked and unlocked, unpurged instances. These are then purged
all at once when ReleaseFreeMemory() is called.

This is guarded by a new feature which is disabled by default, and as
such there is no behaviour change by default.

Bug: 1109209
Change-Id: I7755d714ff354e831557627fda401751384392b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321400
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798630}

This patch adds the capability to deliver notification synchronously
in the post-layout stage. It uses this for the 'auto' content visibility
case. During the notification, if this is the first time we have a
notification, then it is done synchronously. Furthermore, if the
notification causes a locked-ness change, then we request that the
layout stage is re-run (to ensure that visible things are immediately
visible.

R=szager@chromium.org, chrishtr@chromium.org

Change-Id: I59c94590a5dd0ec2398a06f3f03212a80b581fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348415Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798629}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bff6472b..0c2650ad

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I624177f3c764aa2b2075ba4a698b9b5a9cd33f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358583Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798628}

Previously when passing nil to secondaryAttributedString  while
initiating a PopoverLabelViewController, the popover will show a large
blank area under the primary message. That's because a blank secondary
TextView has occupied the space. Fixed the issue by only create
secondary TextView when secondaryAttributedString has a value.

Bug: 1115925
Change-Id: Ic01ae94037aaae14b76194aca439b3677682b921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354519
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798627}

* Inline temps
* Combine conditions
* Use min/max more
* VideoPlaybackRoughnessReporter::kDesiredWindowDuration isn't needed

Bug: none
Change-Id: Ifbe23075f035df50e6bec4299802b6832c15d96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359000
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798626}

When setting a new DiscoverFeedVC calling reloadData would sometimes
not actually reload the Feed. Taking a look at a similar method
I realized that there's a bug and workaround for that, which I added to
our DiscoverFeedVC setter

Here's where the workaround is also being used:
https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm;l=504

Bug: 1085419
Change-Id: I9cf39edfe9da9006dc0b26bf1b27bb0f8c41d255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355439Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798625}

Remove "if defined(OS_CHROMEOS)" when setting default token_value in
SetRefreshTokenForAccount in identity_test_utils.

UserPolicySigninServiceTest was calling IssueOAuthToken with
"refresh_token_for_" + gaia_id value because they expect the refresh
token to have this value by default. Fix this test by calling
SetRefreshTokenForAccount with custom token value and using the same
token to issue OAuth token.

Bug: 1115075
Change-Id: I92ca73b25b87131b9fb02dbae8bbea8a5707adb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353333Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798624}

This is a reland of d7f6a170. The only
change since the reland was to disable some tests on android as they test
code paths that won't be hit on android.

Original change's description:
> Portals: Make breakpoints inside portalactivate event handlers work
>
> Currently, we reset the DevTools session before portal activation and
> create a new session with the activated portal's WebContents. We dispatch
> the portalactivate event and run any event handlers in the interim while
> there are no agents active, and as a result, existing breakpoints do not
> work.
>
> This CL waits for DevTools to point at the portal WebContents before
> actually swapping the WebContents, thus making sure that the
> portalactivate is dispatched after the main target has been reattached.
>
> Bug: 1025761
> Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797727}

Bug: 1025761
Change-Id: I16edcfe85f83fee5aee31624cbdc2c8a0a150a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355552
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798623}

This patch adds a browser test for ignoring non-TWA payment apps when
running inside of a TWA that provides app store payment capability to
Chrome. The test is for Chrome OS only, which is using the
cross-platform Android payment app factory. When this factory is ported
to Android, then the same test will work on Android as well.

Bug: 1061503
Change-Id: I8f366c0feca7604000e8efc5e47d57047ab68a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347400
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798622}