- 11 Oct, 2019 40 commits
-
-
dpapad authored
This is in preparation of migrating this UI to Polymer3/JS Modules, in which global namespaces like sync.confirmation will not exist. Bug: 1012533 Change-Id: I7fb3f6f3767a760d09c827acec133ef3f2c020f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853804 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705013}
-
Koji Ishii authored
The assumption is |NGLineBreaker::CreateBreakToken| always has a valid style. This patch adds DCHECK for the assumption. TBR=mstensho@chromium.org Bug: 1013040 Change-Id: Idbe5594136c8b1b9c4556dacf81631af49a56a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855066Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705012}
-
Koji Ishii authored
This test was unstable when I tried to rebaseline before, but wangxianzhu told me that Mac10.10 bots were unstable, and its instability was fixed. Re-trying the rebaseline. TBR=wangxianzhu@chromium.org NOTRY=true Bug: 1011453 Change-Id: Ic7f54ab756538e23cf17df3774863d62be99484e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855246Reviewed-by:
-
Nick Burris authored
Update the feature detectability API to window.location.fragmentDirective per https://github.com/WICG/ScrollToTextFragment/issues/19 Also updated web platform tests and confirmed tests pass. Bug: 1000308 Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705010}
-
Colin Blundell authored
As part of the effort to replace base::Bind by base::Bind{Once, Repeating}, this CL converts the one usage of base::Bind() in //components/web_resource to instead be a usage of base::BindRepeating(). The rational for using base::BindRepeating() is that the callback is being passed in to a PrefChangeRegistrar, which can invoke it multiple times in response to pref changes. This CL also takes the opportunity to update the PrefChangeRegistrar API in question to take in a base::RepeatingClosure rather than a base::Closure. TBR=jochen@chromium.org Bug: 1007753 Change-Id: I7550f64eedb9d0da719f9ff8617e2c4d9d415eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847216 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705009}
-
Daichi Hirono authored
Previously ArcAccessibilityHelperBridges has used GetCaptionStyleFromPrefs. But it started adding "important!" token to override existing style, which Android side does not recognize. The CL stop using GetCaptionStyleFromPrefs and loads caption style directly from prefs. BUG=b:141660231 TEST=GetCaptionStyleFromPrefsTests.* Change-Id: Iee017eb3c5afd28205067df842f112cc553406a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837437Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#705008}
-
Alexey Baskakov authored
Previously we did in-place immediate updates for existing apps. This was not consistent with the commit ideology since effects were becoming visible immediately. It didn't match the creation and deletion of apps: they were deferred until commit. With this CL we implement basic copy-on-write for WebApp object updates. We commit the created copy into the original for real, during the commit call. In next CLs: Fix UpdateSync algorithm to avoid excessive change_processor Put and Delete calls. TBR=alancutter@chromium.org Bug: 860583 Change-Id: I26eb53b668f74ce0c606a60af9016aa8a4cca1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851792 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705007}
-
Keishi Hattori authored
Replace ScopedPersistent in GarbageCollected classes with TraceWrapperV8Reference. Use of ScopedPersistent is discourage in favour of TraceWrapperV8Reference which is GC aware. Bug: 1013149 Change-Id: Idb131f7ff6af3bf405afe3ec3b2ae29ea67b42b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852349Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705006}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6950a87f9054..a5f5e7778ad7 git log 6950a87f9054..a5f5e7778ad7 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 jmadill@chromium.org D3D11: Fix warning that showed up in VS2019. Created with: gclient setdep -r src/third_party/angle@a5f5e7778ad7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I7107839b8467a1ced9b64573edf87ec2eda2ceb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705005}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 535458f6. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib6a485ce3061beaf17c4dda316808db6a85db9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853953Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705004}
-
Yoshifumi Inoue authored
Make LayoutTreeAsText to utilize NGInlineCursor instead of NGInlineFragmentTraversal::SelfFragmentsOf() This patch makes |LayoutTreeAsText| to utilize |NGInlineCursor| instead of |NGInlineFragmentTraversal::SelfFragmentsOf()| as preparation for migrating |NGFragmentItem|. Bug: 982194 Change-Id: I78a568464330228940e18ebd7cc836630627aea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852324 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=xiyuan@chromium.org Change-Id: I48c2e94c9ea998cf8992415fb2cba9d6206fdb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855438Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705002}
-
Lei Zhang authored
Instead of trying to handle a NOTREACHED() condition, just crash if the impossible happens. Change-Id: Ifbfdabe7e044c22c61b2e143d516d250319b6fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854245Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705001}
-
Hayato Ito authored
The test is flaky on platforms other than mac. TBR=rdevlin.cronin@chromium.org Bug: 851252 Change-Id: I72f099a12c5c99c52eedd6bde6c335f8f169b61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855064Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#705000}
-
Peter Kotwicz authored
This CL removes the UMA tracking which occurs in AppBannerUiDelegateAndroid destructor. As of http://crrev.com/c/1609744 AppBannerUiDelegateAndroid is only used for showing a dialog and is no longer used for infobars. - It is guaranteed that either AppBannerUiDelegateAndroid::OnUiCancelled() or AppBannerUiDelegateAndroid::AddToHomescreen() will be called, thus the UMA recording which occurs in the !has_user_interaction_ case can be removed. - TrackDismissEvent(DISMISS_EVENT_DISMISSED) is moved to OnUiCancelled() and AddToHomescreen(). This is in preparation for http://crrev.com/c/1833068 which changes when AppBannerUiDelegateAndroid's destructor is called. This CL also brings up to date the documentation for the AppBanners.UserResponse and WebApk.Install.InstallEvent UMA metrics BUG=994759 Change-Id: I44ee30b17a5a750aa7722ae8a3d4d2a0b52c05c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846562 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#704999}
-
Chris Cunningham authored
CHECK is very aggressive - saving bad data is generally not a show stopper (except for data that causes FLT_EXCEPTIONS on win). The idea is to let this sit in pre-beta channels for a bit and find out if there are any remaining ways we can cause corrutpion. TODO(me): revert this before beta promotion. Bug: 982009 Change-Id: If2faf12e56a54bd7244f08aa940be2ace9781ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855199 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#704998}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/93a34f0..5005010 5005010 Update IANA timezone db to 2019c 181ac4d Add "# COMPONENT" to icu OWNERS file 72f4754 Fix v8 formatRange/formatRange issues Bug: 473288,1004574, v8:9812 Change-Id: Ia73971d9399a0b699bd8940e9b4e3472cec891ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854570Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704997}
-
Chris Cunningham authored
debug::Alias did the trick. We were dividing by zero whenever a record with significant duration was saved to an empty bucket. Pretty awful bug. UMA shows this is causing 2% of DB reads to be discarded (assuming this is the sole remaining source of corruption). Bug: 982009 Change-Id: Ie13643a79652163bfaf343259af44141f2a53fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854796 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts AudioFocusManagerDebug{Ptr, Request} in content and services to the new Mojo type. Bug: 955171 Change-Id: I9b219438be413d57b0c97e635d39b48d8a2352b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849734 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704995}
-
Jay Harris authored
Previously, it was available on all pages, regardless of whether they were considered secure. Policy for new web apis is to only expose them in secure contexts. Bug: 1013493 Change-Id: Id2c810309d4b21554b2ab11300d959a0bcf31102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855149 Commit-Queue: Jay Harris <harrisjay@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#704994}
-
Mikolaj Walczak authored
Send a wayland event to Android when user requests a density change (CTRL +/CTRL -/CTRL 0) on ARC++ application. BUG=b:142100473 TEST=`adb shell logcat -s libwayland-client:*' Change-Id: I550557eeb017fb24eef83cc09a7b0d809462d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846629 Commit-Queue: Mikolaj Walczak <walczakm@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#704993}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within Safe Browsing, SSL, and Policy related browser tests. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Ie1d4e9241c53e0e8fe4ec504508f3d51dc9c1d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850733 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704992}
-
Sergey Ulanov authored
https://chromium.googlesource.com/angle/angle.git/+log/8ba50490174a..6950a87f9054 git log 8ba50490174a..6950a87f9054 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 sergeyu@google.com [Fuchsia] Exclude libvk_swiftshader.so on Fuchsia 2019-10-11 timvp@google.com Vulkan: Prevent Creating ES 3.0 Context if Min. Caps. Not Met 2019-10-11 jie.a.chen@intel.com Fix the missing global memory barriers 2019-10-11 m.maiya@samsung.com Vulkan: Enable GL_OES_EGL_image_external_essl3 Created with: gclient setdep -r src/third_party/angle@6950a87f9054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I535753ef5e55648b3a6b359f6312e591b76ddf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855121Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=dullweber@chromium.org Bug: 1007760 Change-Id: I067c7bb1680cb0c7cc72d9252d3075cf73aa5503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849537Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704990}
-
Wenbin Zhang authored
In order to save CQ capacity, system_health_smoke_tests.py checks the story versions to make sure that we only run the latest version. The version check happens when loadng all the stories. When it fails, the try job shows all shards as failed, instead of reporting the correct info. Hers's an example from the bug: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/369559 Since this is more a configuration issue, we now change it to be reported at an earlier stage, i.e., in PRESUBMIT. Bug: 1006771 Change-Id: I53882078a4784b460b2add78725ea18e8bfffddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850353 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704989}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1ff0c181bb37..ee8e9c15222c git log 1ff0c181bb37..ee8e9c15222c --date=short --no-merges --format='%ad %ae %s' 2019-10-11 cepheus@frii.com Fix #1924: Promote SPV_EXT_physical_storage_buffer to KHR when required. Created with: gclient setdep -r src/third_party/glslang/src@ee8e9c15222c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: Idad3ac27a5d2b2722cb0be533850a510c27b45a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855122Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts NetworkServiceClient from network_service.mojom to new Mojo types using PendingRemote, PendingReceiver, Remote, and Receiver. Bug: 955171 Change-Id: If04d706c02e97a4ddd647a61647865dc35dc4563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847469Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704987}
-
Christopher Cameron authored
This was the result of an infinite loop wherein - RWHVMac::OnFirstResponderChanged(true) would eventually call - (bunch of views::Views stuff) - RWHVMac::Focus() - Making the RWHVCocoa first responder, calling - RWHVMac::OnFirstResponderChanged(true) Early-out of redundant calls to RWHVMac::Focus, to break this loop. Bug: 998123 Change-Id: Iacf9abb6b03c07d11bd1168a7d9d7459a69fc554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848893Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704986}
-
Hayato Ito authored
This reverts commit 8f8c19f0. Reason for revert: flakiness again See https://bugs.chromium.org/p/chromium/issues/detail?id=1000251#c25 Original change's description: > Revert "[Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux" > > This reverts commit 2e452bbf. > > Reason for revert: https://crbug.com/1000251 is fixed. > > Original change's description: > > [Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux > > > > TBR=weidongg@chromium.org > > > > Bug: 1000251 > > Change-Id: I8e3372766ab9e560c9f47f7c2f8292ebc8af644c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782637 > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#692666} > > TBR=jdoerrie@chromium.org,weidongg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1000251 > Change-Id: Id9af5a221f5ca04873ce30737c2a9be58afd9fb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844854 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703303} TBR=kylechar@chromium.org,jdoerrie@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000251 Change-Id: I5f798d35aee20756268151c510c27a7a5bcf5515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855245Reviewed-by:
-
Yoshifumi Inoue authored
This patch implements |NGFragmentItem| version of selection painting by using |NGInlineCursor| to share logic with |NGPaintFragment| version. Bug: 982194 Change-Id: I44bd0e1b93db611fb03459179dda0bf5d350167d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832843 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Jeremie Boulic authored
When creating new folders from the directory tree, the new entry was sometimes added in the wrong spot due to the way labels were compared. The folders were then immediately reordered, causing the new folder to lose its renaming state with the corresponding input box. Issue fixed using the util.compareName function. Test to be added. Bug: 1004717 Change-Id: I1005e1061b099b195ea87d4b50b0a121f17d593b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855145 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704983}
-
David Staessens authored
CL crrev.com/c/1831728 introduced extra command line options to the video_decode_accelerator_tests. Unfortunately this change caused the video_decode_accelerator_perf_tests to ignore the '--output_folder' parameter. This is causing all tast.video.DecodeAccel(VD)Perf* tests to fail. TEST=./video_decode_accelerator_perf_tests --output_folder=test_folder BUG=b:142515248 Change-Id: I8ec751a89e0809de320965215d2dea31333e0bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855242Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#704982}
-
Nick Harper authored
Change-Id: I8e6a7aa26662bbd65443c05808c499f956be8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854527 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704981}
-
Dmitry Gozman authored
These two mean the same: client navigation should be aborted, most likely because a new one has started, or frame has been detached, or due to window.stop() call. This also adds missing RFO::DidFailProvisionalLoad call to AbortClientNavigation. Previously, we notified about the navigation start, but if it was aborted we did not notify RFOs. This corresponds to the step 7.h from the doc linked to the bug. Bug: 855189 Change-Id: I9a643870fd2f70645156bc6e5cc46da9c60a6c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802521Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704980}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I02f2654aff00e45e41997f8a2e15349116f1d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854920Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts TrialComparisonCertVerifierConfigClient and TrialComparisonCertVerifierReportClient from trial_comparison_cert_verifier.mojom using PendingReceiver, PendingRemote, Remote, RemoteSet, Receiver, and ReceiverSet. Bug: 955171 Change-Id: Ib2c97b143d2ee0a631531ee24e66007b91e80b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847411 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#704978}
-
Sammie Quon authored
Keeps this behind a flag, support for old wallpaper blur still exists. Copies the wallpaper layer to a layer which is blurred and kept alive for the duration of overview. Test: manual Bug: 1012829 Change-Id: I74046bb522d0751304cadd5aa5dd361f70b2831c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842698Reviewed-by:
-
Fergus Dall authored
Bug: 1011858 Change-Id: I9a151ceeb42326ca500d2f0a5a16d5aa9d6c16b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847705 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704976}
-
Ahmed Fakhry authored
- Remove Attempt Enter/Leave TabletMode() which was scattered and used all over the place. - Make a clear distinction between a device physical tablet state (which is affected by device events such as lid angle changes, tablet EC switches, ... etc.) and a UI tablet state (which is whether the UI is currently in tablet or clamshell modes). - Gather all the inconsistent and scattered logic that affects the device and UI states into consolidated, and clear functions that get invoked whenever the state needs to be updated. This CL is a prerequisite work for the auto-rotation work coming up soon. BUG=925087 TEST=No behavior change, all tests must pass. Change-Id: If4c2777f434a09f3c70b32bb60367cfb118102b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851286 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Noel Gordon authored
Our tree.css file is derived from cr.ui.Tree tree.css file, and should follow it rule-for-rule (mostly). The directory-tree section-start CSS rule is specific to FilesApp: move it to file_manager.css. Bug: 992819 Change-Id: I2fbfaaf539219da0f448fbeb1b6192b59b66c18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851627Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704974}
-
