- 17 Apr, 2020 40 commits
-
-
Oleh Lamzin authored
Add note in comment that if primary_enabled_usb_ethernet_device_path_ is empty, then IsUsbEnabledDevice(nullptr) returns false. BUG=none TEST=none Change-Id: Icf8737b2ffe8f18ee9ada7cb8055783514d88b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152806Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#760111}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie99cbbf38868e9b404a44a57368fd7f8dab3d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154597Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#760110}
-
Oksana Zhuravlova authored
This change adds a remote call to RemoteObjectHost's ReleaseObject method when the corresponding RemoteObject renderer instance is destroyed. Also removes the entry from RemoteObjectGatewayImpl's map. Bug: 794320 Change-Id: Ib9769ffac5a0cdc8c654164211c163c2ab889c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090922Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#760109}
-
Wan-Teh Chang authored
Change '+' to '_' in that comment. It should read required_previous_frame_index_. Change-Id: I98e3a180be2d4fc3eaba6b01f9f80ec363da088b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153696Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#760108}
-
Elly Fong-Jones authored
Currently, flags expire at every milestone, but this expiration process relies on manual updates at the branch point to several different files. This change automates that entire process. Specifically: * The existing hand-added "UnexpireFlagsM$M" features are replaced with automatically synthesized ones * The existing hand-added "temporary-unexpire-flags-m$M" flags are replaced with automatically synthesized ones * The hand-updated ExpiryEnabledForMstone function is replaced with an automatically synthesized one This is done by: 1) Generating a file //chrome/browser/expired_flags_gen.h, which declares the UnexpireFlagsM$M features and the ExpiryEnabledForMstone function 2) Generating a file //chrome/browser/expired_flags_gen.cc, which defines those features and that function 3) Generating a file //chrome/browser/expired_flags_gen.inc, which is a source fragment defining the temporary-unexpire-flags-m$M flags and binding them to the UnexpireFlagsM$M features 4) Checking those features when deciding whether flag expiry is enabled for flags expiring in a given milestone Points (1) through (3) are done by a new Python script, //tools/flags/generate_unexpire_flags.py, which is invoked during build. Point (4) is done via changes to the existing flags::IsFlagExpired() function. This change also: * Adds test coverage for the proper presence of unexpiration flags corresponding to the current and previous milestone * Adds a bit to the flag "platform" bitmask, kFlagInfrastructure, which causes the generated flags to be exempt from checks for flag metadata or histogram entries * Adds some uses of base::span internal to the flags test APIs * Updates one other flags test API to use base::span instead of passing a (pointer, length) pair After this change, no manual engineering work is needed to expire flags at a new milestone; the change to //chrome/VERSION drives the entire process. Bug: 1068258 Change-Id: Id205f42f043a806ab5be7aa60f203e2bd110f545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142327 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760107}
-
Ted Choc authored
BUG=1037491 Change-Id: Idb59c5fbdc104d2ec6caf552bc0cdcc859339b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153329 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Ted Choc authored
Sigh...lambda formatting makes me so, so very sad. BUG=1071247 Change-Id: Ia9b46ba20d10146a385c9acebc7391acfa23dadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153962Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760105}
-
Sharon Yang authored
Implement media load blocking in WebEngine, using logic in components/media_control. WebEngineIntegrationTest Test: Add BlockMediaPlaybackUnblocked and BlockMediaPlaybackBlocked to Bug: 1057860 Change-Id: I055d170fc942b2f88598e95605a9886fea413026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131210Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#760104}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/da6cda839dac..b613e3ab6b71 git log da6cda839dac..b613e3ab6b71 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 hbos@webrtc.org [Adaptation] Resource::IsAdaptationUpAllowed() for IsBitrateConstrained. 2020-04-17 hbos@webrtc.org [Adaptation] Introduce VideoStreamInputState and its Provider. Created with: gclient setdep -r src/third_party/webrtc@b613e3ab6b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd194b312aadcb78fe84479d94e89b4df2d12c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154564Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760103}
-
Scott Violet authored
At the time OnNavigationStarted() is called it's not safe to call Navigate(). This patch delays the navigate until it is safe (when NavigationThrottleImpl::WillStartRequest() is called). This is a reland because of a use-after-free. In particular, when NavigationThrottle calls out to DoNavigate, navigationThrottle may be deleted. The code was not set up to handle that. BUG=1070569 TEST=NavigationBrowserTest.NavigateFromRendererInitiatedNavigation Change-Id: I769ef0e0143d333e2fddbd997be2dc9de7aba3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154592Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#760102}
-
Anders Hartvoll Ruud authored
This defect actually has no effect in practice, since applying animations is the very last thing that happens while the StyleCascade instance exists in the StyleResolver, but of course that's just luck. Change-Id: I0de314b84889e2a314e1341192cd2f193df4e3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151514Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760101}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8aebb60a8d9d..888c0fe76833 git log 8aebb60a8d9d..888c0fe76833 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 engeg@google.com ReadHttpResponse: Handle 429s with retries and adjust retry count Created with: gclient setdep -r src/third_party/depot_tools@888c0fe76833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071590 Tbr: agable@chromium.org Change-Id: Ia024c1e891c9bcf8d06ad45d18cec2da4da2191f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154807Reviewed-by:
-
Akihiro Ota authored
Before this fix, assistive technologies (I tested with ChromeVox) were unable to navigate into the IME candidates. For ChromeVox in particular, using the arrow keys to navigate the candidates produced no speech output. With this fix, ChromeVox can navigate into the IME candidates and speaks each candidate to the user. Bug: 1034146 Change-Id: I77b584fc2a2648bc5f9fca479b2363d476628ac4 Relnotes: Make Chrome IME accessible to assistive technology. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151672Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#760099}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 to 84-4099.3-1586167754-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If54f8ba805f9403b2fe1777cd9321dc9a5e35488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154888Reviewed-by:
-
Abigail Klein authored
When the caption controller feature is initialized, it should create the UI of the live caption feature. Before this feature, the UI was only created when the kLiveCaptionEnabled pref changed. Note that SODA should only be registered when the pref changes. Bug: 1055150 Change-Id: I5d78520854b1a5ad0d5388724aea236f527a7804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151893 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#760097}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: Id41cbb7a1ced299610f60a4a0be691fdebf8b044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148026 Auto-Submit: Matt Menke <mmenke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#760096}
-
Philip Rogers authored
This patch makes will-change: backdrop-filter a compositing reason. The approach is similar to will-change: transform and will-change: filter (https://crrev.com/758501). LayoutBoxModelObject::StyleDidChange is used to invalidate when the will-change property changes. Bug: 960953 Change-Id: I40c147bbb7257e799c45a9c77199ed4efaf2098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154588Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760095}
-
Kush Sinha authored
This reverts commit e81b8956. Reason for revert: http://b/123630392#comment55 Original change's description: > Send platform_version to Gaia for Dent auth flow > > Send missing parameter |platform_version| to Gaia during Chrome OS > add account flow. > > Bug: 1064677 > Change-Id: I6e4745eb62fdc34c3ed303d138639e6d26bdb81e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121264 > Commit-Queue: Andrei Salavei <solovey@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755366} TBR=xiyuan@chromium.org,sinhak@chromium.org,solovey@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1064677 Change-Id: I69eeda6d00241e4c7ccfbaa7c96b6defee73f316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153054Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#760094}
-
Koji Ishii authored
This patch computes and stores |NGTextType| in |NGInlineItem|. This is part of preparations to eliminate |NGPhysicalTextFragment| for |NGFragmentItem|. Currently, we create |NGPhysicalTextFragment| even when |NGFragmentItem| is enabled, and create |NGFragmentItem| from the intermediate |NGPhysicalTextFragment|. This construction of intermediate |NGPhysicalTextFragment| consumes ~1% of total time. In order to create |NGFragmentItem| directly, We need a place to store this value until we create |NGFragmentItem|. |NGInlineItem| is the best place because this value does not change unless |CollectInlines| runs again. The size of |NGInlineItem| does not increase yet; r759978 crrev.com/c/2153459 added |static_assert|, and r759994 crrev.com/c/2154425 released two unused bits. This patch has no behavior changes. Bug: 982194 Change-Id: I3028542d8975af37d5dbcc63111ad0cb00b31688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154427Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760093}
-
John Z Wu authored
This API was planned to be used in ios/web_view, but plans have changed and it is no longer necessary. There is no change in behavior. Change-Id: Ie7de41895cbd4ed61a36a5e03b580975ba3ba58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145675Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#760092}
-
Yann Dago authored
upgrade." Reason for reland: Added trace event. Reason for revert: reverting to avoid perf analysis surprises -- to be relanded with a trace event. Original change's description: > Take user data snapshots on canary builds for each minor upgrade. > > Bug: 958893 > Change-Id: I987a99d3db2b659babe46d2f15cfac6627bc573c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134396 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757835} Bug: 958893 Change-Id: Ia72ab78c6fa56bee69051265d883f7ca6d03b79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144836Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#760091}
-
ckitagawa authored
This CL simply augments FileWStream to support capping the file size. This work is a precursor to allowing a limit on the total capture size. Bug: 1071446 Change-Id: I38590bd52e50221f1007d92d673aca74f127158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152768Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#760090}
-
Theresa Wellington authored
Previously a DEPS rule was limiting import of internal app menu classes in chrome/android/java. This CL uses GN visibility instead, which can be controlled from within the component itself. BUG=966644 Change-Id: I4be0c36f81271259a4f71388db7d0671bd8ba699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934521 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760089}
-
Marc Treib authored
Reason: The underlying state that's being watched (i.e. password_manager_util::IsOptedInForAccountStorage) gets the relevant account-related state from SyncService, not from IdentityManager. So this is more consistent, and ensures that there are no order-of-observers problems. (SyncService itself observes the IdentityManager, so before this CL, the outcome could depend on whether SyncService or PasswordAccountStorageOptInWatcher get notified first.) Bug: 1024332 Change-Id: I916c6035961056d46a2061a3eeb9362467ac8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151871 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#760088}
-
Sahel Sharify authored
This cl disables MultipleRulesetsIndexingTest.StaticRuleCountExceeded on debug builds since it times out frequently. Example build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17957 TBR: karandeepb@chromium.org Change-Id: I05a9b3e69f66694ac9627ab16383d480912433e1 Bug: 1071403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154600 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760087}
-
Devlin Cronin authored
Use WidgetActivationWaiter instead of a custom WindowDeactivatedWaiter in tabs/tab_hover_card_bubble_view_browsertest.cc. This is less code and reuses a common utility. Bonus: It fixes a small typo. :) Bug: None Change-Id: I09c2202ebe2b79dc7c0397d7cb59b2253e353377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151673Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760086}
-
sczs authored
Change-Id: I695b93df9fc6a723f76065891935e979ba48796d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151970Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#760085}
-
Sharon Yang authored
Add SetBlockMediaLoading() to ApplicationController to enable media loading to be blocked, and passes the call to fuchsia.web.Frame. Bug: 1057860 Change-Id: Ib3c53e35d3fd1ffe2e43d01991ab7d85e2f025e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083565 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Use new method for skipping screen. Add tests for UMA stats. Bug: 1064561 Change-Id: I2dd5ec7255fc748c33935c201d29384fbbc3ada2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151445 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760083}
-
nancy authored
For extensions, AppServiceProxy.Launch can't launch it, because they are not apps, and not saved in AppService app cache. So we have to restore the code change in CL:2049994 to use Extensions and LaunchAppWithParams to launch extensions. b:154201472 Change-Id: I8318a5144788e5b8f036a3369e2acf67c4fb1629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154347 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Part 1 of 2: This CL adds a custom layout to the ClearDataDialog and fleshes out the part when deleting storage for a single origin. The new custom layout includes a new warning for when deleting app data, and changes the title and Clear button text slightly. Bug: 1068710 Change-Id: Ia7f302fb138540b7ebd11aa1ee87bdd8447b2042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153147 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#760081}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bf127479c6d..a19abd58cb38 git log 1bf127479c6d..a19abd58cb38 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 egdaniel@google.com Fix spirv rtheight set. Created with: gclient setdep -r src/third_party/skia@a19abd58cb38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I9119adbe6131c94339cd62abdc44cb3c8dae6d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154563Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b8fda4b..c572fb7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7145f55cc41de8a2391c2a3cb77eebbc62b2c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153272Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760079}
-
David Van Cleve authored
This CL adds a test covering trust token issuance against an issuer whose configured batch size (number of tokens to request) is greater than the parameterized maximum batch size. It verifies that the number of tokens requested gets clamped to the maximum. R=csharrison Fixed: 1065388 Change-Id: I212d5e6a0b9dae6c8c812ed2513b2a4a4ff8d145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150304 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#760078}
-
Charlie Hu authored
Previously it is assumed when a frame owner element needs to update required policy, |GetDocument().GetFrame()| should not return NULL. It turns out this assumption is not always true. This CL let HTMLFrameOwnerElement::UpdateRequiredPolicy handle NULL frame explicitly, instead of assuming its not NULL. Bug: 1068100 Change-Id: I15e6ac7cffeff36761da945b67eca3f862719942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149527 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#760077}
-
Patrick Monette authored
This change is meant to make the order of the parameters of the factory functions and the constructor consistent. Change-Id: Icce46b60c7a5da5579fb172ea901eec92ffa566e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147888 Commit-Queue: Patrick Monette <pmonette@chromium.org> Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#760076}
-
Stephan Hartmann authored
Change-Id: Ifbc379adc5bb7242c21e7da0bcfc28f49e4dd06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153111Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02153f0ed2c9..35ebb85fa793 git log 02153f0ed2c9..35ebb85fa793 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 szuend@chromium.org [issues] Adapt SameSite cookie issues to backend changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@35ebb85fa793 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06c2d0c0e0ed567421e04cd78e66eec5c2152781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154561Reviewed-by:
-
Christian Dullweber authored
Add render test to ensure PageInfo is displayed correctly in various states. Bug: 1040091 Change-Id: Ic6334f662ec966e573bfbda5043f38815b83fe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061754Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760073}
-
Clark DuVall authored
Factored out chrome-specific logic into a delegate, and the protocol handler logic was completely moved to the delegate. The interesting changes are in tab_specific_content_settings*, most of the other changes are adding the content_settings:: namespace. Bug: 1070825 Change-Id: I912e385b10dbb98aa7ab9da1ee138264dab3ec96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151841 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760072}
-
