GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=173666

BUG=369609
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/278623003

git-svn-id: svn://svn.chromium.org/blink/trunk@173697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We've fixed all the know bugs. Hopefully this time it will stick. If you find
that this CL caused a regression, please mark the bug as blocking
http://crbug.com/365701

BUG=365701

Review URL: https://codereview.chromium.org/267343005

git-svn-id: svn://svn.chromium.org/blink/trunk@173696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173666

BUG=369609
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/272063002

git-svn-id: svn://svn.chromium.org/blink/trunk@173695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173666

BUG=369609
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/276803002

git-svn-id: svn://svn.chromium.org/blink/trunk@173694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test was added in http://src.chromium.org/viewvc/blink?revision=173653&view=revision.
Adam tells me it's fine to rebaseline.

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/274963002

git-svn-id: svn://svn.chromium.org/blink/trunk@173693 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173666

BUG=369609
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/275663002

git-svn-id: svn://svn.chromium.org/blink/trunk@173692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In particular, allow a layer L to squash if their clipping
ancestor differs from the squashing owner, but the clipping
ancestor for L is a descendant of a layer that does squash
into the squashing owner.

BUG=368410

Review URL: https://codereview.chromium.org/264013002

git-svn-id: svn://svn.chromium.org/blink/trunk@173690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also moved the testing for invalid values from
AudioContext::createBuffer to AudioBuffer::create, which knows what
the valid ranges are instead of having the tests in both
AudioBuffer::create and AudioContext::createBuffer.

Test case added for createBuffer(0,...).

BUG=362657

Review URL: https://codereview.chromium.org/235653002

git-svn-id: svn://svn.chromium.org/blink/trunk@173689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173661

BUG=371111,361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/273923002

git-svn-id: svn://svn.chromium.org/blink/trunk@173688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173653

BUG=370667
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/271993002

git-svn-id: svn://svn.chromium.org/blink/trunk@173687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The frame / iframe src attribute value was not correctly updated upon
serializing because HTMLFrameElementBase::hasLegalLinkAttribute() was returning
true if the attribute name was 'href' instead of 'src'. The attribute was thus
not detected as a link attribute and its value was not correctly updated with
the path to the serialized frame.

R=tkent@chromium.org, adamk@chromium.org
BUG=370772
TEST=WebPageNewSerializeTest.SubFrameSerialization

Review URL: https://codereview.chromium.org/275433011

git-svn-id: svn://svn.chromium.org/blink/trunk@173686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Web Animations: Fix error in clock update logic and re-enable timeline-time test"

This reverts r173583 and r173609. r173583 causes 
ImageResourceTest.MultipartImage to fail on Android debug, e.g.,
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/152167/steps/webkit_unit_tests/logs/stdio

TBR=dstockwell@chromium.org

Review URL: https://codereview.chromium.org/272543005

git-svn-id: svn://svn.chromium.org/blink/trunk@173685 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173660

BUG=368078
TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/277593006

git-svn-id: svn://svn.chromium.org/blink/trunk@173683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173614

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/270783005

git-svn-id: svn://svn.chromium.org/blink/trunk@173682 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173641

BUG=361729
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/272723010

git-svn-id: svn://svn.chromium.org/blink/trunk@173681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r173248 added it but there is a performance concern.
This change repalces it with a modest alternative that does same as what didRemoveAllPendingStylesheet() has been doing.

This change also removed 500ms sleep from a test that was added at r173248.

TEST=none
R=ojan@chromium.org,esprehn@chromium.org
BUG=367386

Review URL: https://codereview.chromium.org/279463002

git-svn-id: svn://svn.chromium.org/blink/trunk@173680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173633

BUG=361729
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/272793003

git-svn-id: svn://svn.chromium.org/blink/trunk@173679 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173616

BUG=361729
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/275643002

git-svn-id: svn://svn.chromium.org/blink/trunk@173678 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds document lifecycle assertions in for RenderObject::createObject,
RnederObject::addChild and RenderObject::removeChild.

In all cases we assert that we are currently in the InRecalcStyle state.

BUG=368052

Review URL: https://codereview.chromium.org/267053002

git-svn-id: svn://svn.chromium.org/blink/trunk@173677 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173616

BUG=361729
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/267303007

git-svn-id: svn://svn.chromium.org/blink/trunk@173674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729

Review URL: https://codereview.chromium.org/275603002

git-svn-id: svn://svn.chromium.org/blink/trunk@173673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

refreshPageScaleFactor only gets called if the page scale constraints are dirty.
This happens when the page changes width but not when the height changes. This
cuased a bug where changing the window height only wouldn't resize the main
frame/outer viewport.

BUG=370218

Review URL: https://codereview.chromium.org/271593005

git-svn-id: svn://svn.chromium.org/blink/trunk@173672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173616

BUG=361729
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/271873006

git-svn-id: svn://svn.chromium.org/blink/trunk@173671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/270283006

git-svn-id: svn://svn.chromium.org/blink/trunk@173670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=370490
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/278643002

git-svn-id: svn://svn.chromium.org/blink/trunk@173668 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is intended to make the MSE implementation more spec compliant.
More such CLs to follow after this initial round is checked in.

BUG=
TEST=new test pass

Review URL: https://codereview.chromium.org/267333006

git-svn-id: svn://svn.chromium.org/blink/trunk@173667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously all of these tests were converted to not output repaint rects
and just output pixels.  This ended up being a loss of information that
was useful to detecting missing repaints, and so they should be turned
back on where it makes sense.

BUG=369609

Review URL: https://codereview.chromium.org/262963003

git-svn-id: svn://svn.chromium.org/blink/trunk@173666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In particular, don't do it  when attributes changed if there
is no style resolver or the style change type is subtree or
greater. In both of these cases, it will either have no
additional effect or the code is incorrect.

It could be incorrect if the element was not yet attached.
It could be not needed because if there is no style resolver,
re-making it will recalc the whole document's style. Also,
style invalidation cannot trigger a style that is greater than
subtree.

Also clear style invalidation bits unconditionally in Node::detach.

BUG=366788

Review URL: https://codereview.chromium.org/273783003

git-svn-id: svn://svn.chromium.org/blink/trunk@173665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebFrameClient gets a dispatchManifestChange method that will
be called by the FrameLoaderClient when the manifest
information might have changed. The embedder is not aware of
the manifest URL.

BUG=366145

Review URL: https://codereview.chromium.org/249633002

git-svn-id: svn://svn.chromium.org/blink/trunk@173664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729,371111

Review URL: https://codereview.chromium.org/271553004

git-svn-id: svn://svn.chromium.org/blink/trunk@173661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't know the real destination scale of lazy decoded images
and should not be making filter choices based on the
transformation matrix here.

Instead use AwesomeResampling for all lazy decoded images and
leaves it up to skia to decided if a more efficient filter can
be used at rasterization time.

BUG=368078

Review URL: https://codereview.chromium.org/262263003

git-svn-id: svn://svn.chromium.org/blink/trunk@173660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

when removing certain kinds of layers.

BUG=370410

Review URL: https://codereview.chromium.org/270903002

git-svn-id: svn://svn.chromium.org/blink/trunk@173659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Originally the test expects full repaint of the viewport on page scale
changes. However, the repaint is unnecessary because we handle page
scale in the compositor. My later change will optimize this.

Convert it to a reftest to ensure the visual result is correct.

BUG=258219

Review URL: https://codereview.chromium.org/267333008

git-svn-id: svn://svn.chromium.org/blink/trunk@173658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- generalize selection in timeline, so we can select multiple
    types of objects (currently, just records and frames);
- make frame bars in the top of classic Timeline view selectable
(mutually exclusive with selected records on the left);
- move contents of frame details popover into details view;

BUG=

Review URL: https://codereview.chromium.org/270693003

git-svn-id: svn://svn.chromium.org/blink/trunk@173656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The change https://codereview.chromium.org/270553005/ doesn't update
inspector.html after moving TracingModel.js. This breaks devtools_frontend_resources
target

BUG=361045
TBR=yurys@chromium.org

Review URL: https://codereview.chromium.org/267363011

git-svn-id: svn://svn.chromium.org/blink/trunk@173655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/270553005

git-svn-id: svn://svn.chromium.org/blink/trunk@173654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderLayer::boundingBoxForCompositing knew how to exclude RenderLayers that
had their own composited layer mapping, but it didn't know how to exclude
RenderLayers that paint into grouped backings.

R=vollick@chromium.org
BUG=370667

Review URL: https://codereview.chromium.org/271863003

git-svn-id: svn://svn.chromium.org/blink/trunk@173653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn DOMTokenList, DOMStringList, DOMStringMap and their derived objects
into garbage collected objects.

R=haraken@chromium.org,ager@chromium.org,erik.corry@gmail.com
BUG=340522

Review URL: https://codereview.chromium.org/258143002

git-svn-id: svn://svn.chromium.org/blink/trunk@173652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up change adding trace events in some places that were missed in r172970.

BUG=361045

Review URL: https://codereview.chromium.org/271883002

git-svn-id: svn://svn.chromium.org/blink/trunk@173649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to avoid issues where a GC is hanging forever waiting for a thread to reach a safepoint. This should not happen, but in the case it does we would rather abandon the GC and attempt it again later.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/260723003

git-svn-id: svn://svn.chromium.org/blink/trunk@173646 bbb929c8-8fbe-4397-9dbb-9b2b20218538