- 05 Nov, 2018 40 commits
-
-
Danan S authored
Wrote unit test for DemoModeDetector, accounting for existing behavior, and also the new behavior introduced in this CL. R=michaelpg@chromium.org TEST=tested manually on dev chromebook, and with demo_mode_detector_unittest.cc Bug: 877655 Change-Id: Ibfd78ec1cf2d87c3acad71a8244e519f70601cec Reviewed-on: https://chromium-review.googlesource.com/c/1298417 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605408}
-
sczs authored
There are some crashes on shutdown and they seem to be related to History not stopping its Coordinator before some services/observers are dealloc. This CL stops the History Coordinator before shutting the rest of the App. Bug: 896309 Change-Id: I7500706266157c4a841fefa21c8299c1d8627d17 Reviewed-on: https://chromium-review.googlesource.com/c/1313674Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605407}
-
Caleb Rouleau authored
TBR=nednguyen@google.com NOTRY=true Bug: 901967 Change-Id: I1e7011fa715130a2c61766bd24bf8e1123cdd70a Reviewed-on: https://chromium-review.googlesource.com/c/1318429Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605406}
-
Scott Graham authored
Bug: 883496 Change-Id: Ia5a0e88ca4a1d41c6be4f81a4dc4cc46b74930a7 Reviewed-on: https://chromium-review.googlesource.com/c/1311082 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605405}
-
Andrew Grieve authored
Explicit registration is needed only when using the custom linker. Remoting doesn't use the custom linker, so has no need to jump through the extra hoops involved with explicit registration. Change motivated by JNI refactorings, which are made simpler by having fewer targets use manual JNI registration. Bug: 898261 Change-Id: I0b03afdd421f8c806886cbf7a6650ec1ca5d7f9c Reviewed-on: https://chromium-review.googlesource.com/c/1317339Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#605404}
-
Vladislav Kaznacheev authored
Remove the code that was made redundant by the new Shelf design. The code is theoretically supposed to have no effect due to clipping, but clipping works differently with GPU rasterization enabled. Bug: 896439 Test: manual Change-Id: Ib1429b388d3433cf1683b0405e3b08775eb01e04 Reviewed-on: https://chromium-review.googlesource.com/c/1313734Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#605403}
-
Becky Zhou authored
+ Update control highlight to 38% v2 grey 800. This would affect all theme selectable background + Update control normal color (toggles, switches etc) to grey 700 Bug: 835050 Change-Id: Ifc75ddb92490ad6d8a54a3610a315eb68b8decac Reviewed-on: https://chromium-review.googlesource.com/c/1316247Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605402}
-
Caleb Rouleau authored
TBR=nednguyen@google.com NOTRY=true Bug: 901493 Change-Id: Idae82ae8f4b325dd4346115853b193429fbbda1d Reviewed-on: https://chromium-review.googlesource.com/c/1318398Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605401}
-
Matt Reynolds authored
BUG=890096 Change-Id: I08bc0e42416e0dfd7e1c9409746f058b9dc1e767 Reviewed-on: https://chromium-review.googlesource.com/c/1318080Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#605400}
-
Maks Orlovich authored
This is arguably way too weird to have at this level, but jingle_glue::FakesSSLClientSocket is already pulled in via services/network/p2p, and the alternative would require hundreds of lines of new code to implement rather than basically a single if statement. Bug: 875032 Change-Id: I6fa2007b907378e43f1a619112f812e3d0bbfd50 Reviewed-on: https://chromium-review.googlesource.com/c/1310638Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605399}
-
Shawn Gallea authored
Allows OS-specific implementations of WMHelper Change ChromeOS-specific files to use WMHelperChromeOS. This CL does not change functionality. Bug: 896710 Test: Built and ran on ChromeOS. Change-Id: I3e2970313e85b07fdab97bd6e8645d8d3b23b40d Reviewed-on: https://chromium-review.googlesource.com/c/1292602 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#605398}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62f18490..fcb0f91c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6408be7467394a522b9b9cc9213de89d705093eb Reviewed-on: https://chromium-review.googlesource.com/c/1318049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605397}
-
Jérôme Lebel authored
Removing calls to IsUIRefreshPhase1Enabled() for Sign in promo. Bug: 884724 Change-Id: I8417859a633484a1ff46ac440eacb02558ea661f Reviewed-on: https://chromium-review.googlesource.com/c/1317859 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605396}
-
yileili authored
Bug: b:118193766 Test: Manual Change-Id: I6da9d8458a59701ae7c9ed642d16094e2f36782b Reviewed-on: https://chromium-review.googlesource.com/c/1304489Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#605395}
-
Andres Calderon Jaramillo authored
This CL disables virtual/threaded/fast/scroll-behavior/wheel-and-touch-scroll-use-count.html on Mac and Windows due to its flakiness. Bug: 766357 Change-Id: Ibcd8492031bc02c40ce9f72930960406ad1ced1c Reviewed-on: https://chromium-review.googlesource.com/c/1312679Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#605394}
-
Tomas Popela authored
Change-Id: Ibe06fb644a8ffb3cb83701b9faa55b3ade79a20d Reviewed-on: https://chromium-review.googlesource.com/c/1316771Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605393}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0909331d958f..8b35379ae1f1 git log 0909331d958f..8b35379ae1f1 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 fmalita@google.com Revert "[skjson] Unescape strings" Created with: gclient setdep -r src/third_party/skia@8b35379ae1f1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Idd72266ee85ceb2ad0dd3b4d99acc11cc5553aa1 Reviewed-on: https://chromium-review.googlesource.com/c/1318150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dd5c8ce56be8..688679325c64 git log dd5c8ce56be8..688679325c64 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 lalitm@google.com trace_processor: update bounding indices even if cs is not consumed Created with: gclient setdep -r src/third_party/perfetto@688679325c64 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I927d5a80a5016cf414e704759dbe1174ae7c5eb6 Reviewed-on: https://chromium-review.googlesource.com/c/1318133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605391}
-
Ovidio Henriquez authored
This change adds odejesush@chromium.org to watch USB and Bluetooth changes. Bug: None Change-Id: I416ed361521452df424730b49d671c8d45f72481 Reviewed-on: https://chromium-review.googlesource.com/c/1316653Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#605390}
-
Thomas Guilbert authored
The RemotingAppLauncher instantiates RemotingApps at runtime. It uses the app manifest to find class names of RemotingApps, and loads them via reflection. The DefaultRemotingApp is a simple wrapper around the default media receiver application. Bug: 790766 Change-Id: I01f51ebe90de361b947d67fe904a2faddc35f5de Reviewed-on: https://chromium-review.googlesource.com/c/1306778Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#605389}
-
Clark DuVall authored
This prevents a deadlock on Android, see bug for more details. Bug: 901026 Change-Id: I768be1479205d5efd3dbede943573a4558957297 Reviewed-on: https://chromium-review.googlesource.com/c/1313112Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#605388}
-
Zhongyi Shi authored
Change-Id: I09308e2d2222f738dcfbdae968537ecb4754f5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1315690Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605387}
-
Rouslan Solomakhin authored
Bug: 901542 Change-Id: Id262dc5a842f624ab6452e5b6eed5947500bc0d5 Reviewed-on: https://chromium-review.googlesource.com/c/1318174Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605386}
-
Dmitry Titov authored
This reverts commit 5528336d. Reason for revert: Broke VR tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3533 Original change's description: > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > This reverts commit c564235f. > > No changes from the original, VR flakes are caused by issues with > loadUrl and have been deflaked (see 894796 for details) > > Original change's description: > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > This reverts commit dd9df78c. > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > > > Original change's description: > > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > > > This is a reland of 7bd91635 > > > > > > No changes from the original, revert reason is fixed with > > > https://chromium-review.googlesource.com/c/1283037 > > > > > > Original change's description: > > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > > ScriptResource. In the future, this will allow us to start streaming > > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > > preload. > > > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > > ScriptResource. This callback is either when the streaming completes, > > > > or when there is no streaming and the ClassicPendingScript has told > > > > the ScriptResource that it doesn't intend to start streaming. In the > > > > long run, we want all scripts to go through the streaming interface, > > > > and we want ScriptResource to control when streaming starts, so the > > > > "no more streaming" call will disappear -- however it is necessary to > > > > maintain the current behaviour, and be able to control it with a > > > > runtime flag. > > > > > > > > Bug: chromium:865098 > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > > > Bug: chromium:865098 > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#601143} > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:865098 > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602310} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:865098 > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 > Reviewed-on: https://chromium-review.googlesource.com/c/1317566 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605295} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org Change-Id: I0a42464953d0c3f07977b03e868a1fb252a2ab66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:865098 Reviewed-on: https://chromium-review.googlesource.com/c/1318084Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605385}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f6050fb228f..5f64f594fd65 Created with: gclient setdep -r src-internal@5f64f594fd65 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If563576fe06bf1329946268f4db11e17db959b7f Reviewed-on: https://chromium-review.googlesource.com/c/1318131Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605384}
-
Zhuoyu Qian authored
https://drafts.csswg.org/cssom/#serializing-css-values "To serialize a CSS component value depends on the component, as follows: keyword The keyword converted to ASCII lowercase." Bug: 901666 Change-Id: Iff579a363de13441c75bbebfc951095b071f6060 Reviewed-on: https://chromium-review.googlesource.com/c/1317300 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605383}
-
Nektarios Paisios authored
Selection tests are stored under blink/renderer/modules/accessibility/testing/data/selection There are three files per selection test: <testname>.html - the actual HTML to be tested. AXSelection::SetSelection will be used to set the selection. <test_name>_dom.html - The selection resulting from AXSelection::GetSelection on the selection that the first file has produced. <test_name>-ax.txt - The resulting accessibility tree. The test framework will use the embedded selection markers "^" and "|" in the HTML to: A) set the selection specified in the first file and compare it with the selection in the "dom" file. B) Dump the accessibility tree after applying the selection and compare it with the tree in the "ax" file. R=dmazzoni@chromium.org Change-Id: I7c3c9e3a1eb222aac0afb69d1c4ffa2247a9cd49 Reviewed-on: https://chromium-review.googlesource.com/c/1240633 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#605382}
-
Kristi Park authored
Inline expected Links instead of initializing at the start of the test. Change-Id: I7077b5f00ddbc712bed603ed55ff8bc7a002b484 Reviewed-on: https://chromium-review.googlesource.com/c/1316431 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605381}
-
Richard Knoll authored
This makes sure that notifications are shown to the user after a screen unlock or after exiting fullscreen mode. Bug: 899106 Change-Id: Iac5efa2f784e2681a41357bf7aa8f5da33830c16 Reviewed-on: https://chromium-review.googlesource.com/c/1315567 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#605380}
-
Richard Knoll authored
Bug: 901840 Change-Id: Ib6b385e0b8cea19ec69b317853f6eb3eb5171412 Reviewed-on: https://chromium-review.googlesource.com/c/1317895 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#605379}
-
Xianda Sun authored
This is a followup patch to [1] and paints LayoutReplaced hit test rects into the scrolling contents layer. In this way we don't need to repaint on every scroll change. [1] https://crrev.com/603335 Bug: 888269 Change-Id: Ic8196f59b8a2f7d08285c5234ed562a61386ee6b Reviewed-on: https://chromium-review.googlesource.com/c/1310754 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605378}
-
Tarun Bansal authored
Add few browser tests that create component info with experimental and/or default loading hints. Then, load a webpage to verify that the resources specified by experimental/default hints are blocked based on the finch experiment settings. Change-Id: Id2d20d6f696d8de88a8cf0ed65a319ed67e9a500 Bug: 900699 Reviewed-on: https://chromium-review.googlesource.com/c/1314135 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#605377}
-
Peng Huang authored
This reverts commit 4df3f6e1. Reason for revert: This CL causes crash in RasterCommandBufferStub. The raster decoder still uses GL context and GL APIs even with vulkan. Before removing the GL contect for vulkan, we need remove all unnecessary GL context usage and GL calls for raster decoder. #0 0x55d1ec37f6ef base::debug::StackTrace::StackTrace() #1 0x55d1ec37f261 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fe55e62d0c0 <unknown> #3 0x55d1ed30103e gpu::RasterCommandBufferStub::Initialize() #4 0x55d1ed25f35c gpu::GpuChannel::OnCreateCommandBuffer() #5 0x55d1ed25ed0a bool IPC::MessageT<GpuChannelMsg_CreateCommandBuffer_Meta, std::__1::tuple<GPUCreateCommandBufferConfig, int, base::UnsafeSharedMemoryRegion>, std::__1::tuple<gpu::ContextResult, gpu::Capabilities> >::Dispatch<gpu::GpuChannel, gpu::GpuChannel, void, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)>(IPC::Message const*, gpu::GpuChannel*, gpu::GpuChannel*, void*, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)) #6 0x55d1ed25fcc4 gpu::GpuChannel::HandleMessageHelper() #7 0x55d1ec3058f1 base::debug::TaskAnnotator::RunTask() #8 0x55d1ec3050af base::MessageLoop::RunTask() #9 0x55d1ec305432 base::MessageLoop::DoWork() #10 0x55d1ec30743f base::(anonymous namespace)::WorkSourceDispatch() #11 0x7fe55def6fc7 g_main_context_dispatch #12 0x7fe55def7200 <unknown> #13 0x7fe55def728c g_main_context_iteration #14 0x55d1ec3072f2 base::MessagePumpGlib::Run() #15 0x55d1ec31fba5 base::RunLoop::Run() #16 0x55d1eeaedd3c content::GpuMain() #17 0x55d1ebb80562 content::ContentMainRunnerImpl::Run() #18 0x55d1ed68984c service_manager::Main() #19 0x55d1eb1d6081 content::ContentMain() #20 0x55d1ea8e316b main #21 0x7fe559a992b1 __libc_start_main #22 0x55d1ea8e302a _start Original change's description: > Add VulkanContextProvider to RasterDecoderContextState. > > Add VulkanContextProvider to RasterDecoderContextState which is needed > to get VkDevice in shareable image. Refactor RasterDecoderContextState > class to have seperate constructors for Vulkan and GL. > > Bug: 891060 > Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce > Reviewed-on: https://chromium-review.googlesource.com/c/1312194 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605146} TBR=ericrk@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891060 Change-Id: I4ceebc7033b4bd74e643a5f89bbbd6791b3eb6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1318073Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605376}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6386fdec9f49..3d2886849216 git log 6386fdec9f49..3d2886849216 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 achuith@chromium.org cros_run_vm_test: cwd should not be of type 'path' 2018-11-04 yshaul@chromium.org chromeos_config: Remove hw_tests from GeneralTemplates 2018-11-02 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-02 dgarrett@google.com chromeos_config: Fix release branch trigger syntax. 2018-11-02 dgarrett@google.com chromeos_config: Use triggers for branched Chrome PFQs. 2018-11-01 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-01 jdufault@google.com chromeos_config: Mark tricky-chrome-pfq as experimental 2018-11-01 dgarrett@google.com gen_luci_scheduler: Correctly handle triggers for branched builds. 2018-11-01 dhanyaganesh@chromium.org cbuildbot: Schedule VMTest after autotest frees up 2018-11-01 dgarrett@google.com chromeos_config: Create factorybranch configs for existing branches. 2018-11-01 dgarrett@google.com chromeos_config: Create placeholder prototype-factorybranch build. 2018-11-01 chrome-bot@chromium.org Update config settings by config-updater. 2018-10-31 dgarrett@google.com commands: PushImages, log --buildroot. 2018-10-31 achuith@chromium.org cros_run_vm_test: type 'path' for arg parsing. Created with: gclient setdep -r src/third_party/chromite@3d2886849216 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc73752b3e2ddac0131d88f1f9b64b92c0a49278 Reviewed-on: https://chromium-review.googlesource.com/c/1318132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605375}
-
Sky Malice authored
Bug: 901414 Change-Id: I48deea892c422385fc6a1bb7efabf824b8efc4ea Reviewed-on: https://chromium-review.googlesource.com/c/1316102Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#605374}
-
Ioana Pandele authored
Deleting characters from a generated password until only 3 or fewer characters are left, results in the password not counting as generated anymore. Until now, the leftover characters were masked immediately after the password length was shorter than 4 chars. This CL changes the behavior to keep the password unmasked until the user completely deletes it or it loses focus. Bug: 874822,899798 Change-Id: I19a4116374388d51a5d5bafcba6d45076dde2800 Reviewed-on: https://chromium-review.googlesource.com/c/1305555Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#605373}
-
Rune Lillesveen authored
We called AttachLayoutTree on a new Document which just got its LayoutView created. It will not do anything useful as the document does not yet have any child nodes. Change-Id: I1af44b96b86dcb0a597c662b4c47fe9ab3d972aa Reviewed-on: https://chromium-review.googlesource.com/c/1317889Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#605372}
-
Liquan(Max) Gu authored
The initial implementation has a bug that the frame index is assigned to the record when a record is created. This is incorrect. This should happen when the image is loaded instead, as frame index is used to indicate which frame a loaded image belongs to in order for the swap time to be assigned to the right records. This CL is to correct this bug. Bug: 869924 Change-Id: I4a371183d66ed33b7ac87cb9a570e7221a2a7c4f Reviewed-on: https://chromium-review.googlesource.com/c/1316663 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#605371}
-
Mario Sanchez Prada authored
Let's use "test@test.com" to make it more explicit that we're passing an email address to MakePrimaryAccountAvailable(), and avoid using an accessor method when we can simply reference an object directly. Bug: 890825 Change-Id: Id84246d3c07e7494c7b9188000a18277fce92621 Reviewed-on: https://chromium-review.googlesource.com/c/1317862Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#605370}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26341990a1c3..aed3070ad40c git log 26341990a1c3..aed3070ad40c --date=short --no-merges --format='%ad %ae %s' 2018-11-05 sprang@webrtc.org Replace GetScalingSettings() with GetEnocderInfo() in TestEncoder 2018-11-05 nisse@webrtc.org Refactor RtpSender to use absl::string_view for payload name. Created with: gclient setdep -r src/third_party/webrtc@aed3070ad40c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib13ad32cc17b44f6ae134b33187bd0497b165511 Reviewed-on: https://chromium-review.googlesource.com/c/1318130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605369}
-