- 22 Sep, 2020 40 commits
-
-
jchen10 authored
Unsuppress the DirectComposition info_collection_test and trace_test for HD630(0x5912). Bug: 1079393 Change-Id: I6cdd7c146c69b7154dde27b10e9b18b5f989950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413291 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809210}
-
Shakti Sahu authored
This CL sets up the video player HTML/JS files to be served locally through chrome-untrusted:// scheme. It currently uses a WebUIDataSource and will be moved to an untrusted WebUIController factory once it is ready. Bug: 1129715 Change-Id: I1d514c5f316a462547ef6e1dff78cfecbf143fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414787 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809209}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d56d50c3..ff52c73e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e0878ed99514033b2ea9fc43afdf83c91290571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421874Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809208}
-
Reilly Grant authored
This reverts commit fdbcb258. Reason for revert: The new flag didn't resolve the issue. Original change's description: > serial: Add option to switch enumeration methods > > A potential solution for issue 1119497 is to switch from enumerating > devices implementing GUID_DEVINTERFACE_COMPORT to using the "bus > enumerator" identified by GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. > > I'm putting this behind a flag so that developers can try it out in > canary-channel. If it works I can enable it by default and keep the flag > around for a couple releases in case it causes other problems. > > Bug: 1119497 > Change-Id: Icad9008799ed331c3da15e5a70e0184144c47a58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417460 > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808368} TBR=reillyg@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119497 Change-Id: I3e39d5de932e94b980e7fb5f6de71a2cfa45b0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423053Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809207}
-
Yunke Zhou authored
display:table should be removed since we are now using style from oobe-dialog. Bug: 1021608 Change-Id: I779291ef6ddd94fd83c0ed0922f53d29c4c403f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421649Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#809206}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b436e07b1e0..5ec560fb8c75 2020-09-21 jmadill@chromium.org Add restricted trace golden image script test. 2020-09-21 jmadill@chromium.org Trace/Replay: Reset replay after taking a screenshot. 2020-09-21 ianelliott@google.com Vulkan: Further refine invalidate for depth/stencil 2020-09-21 syoussefi@chromium.org Vulkan: Disallow loadOp=LOAD for MSRTT depth/stencil textures 2020-09-21 lehoangq@gmail.com Metal: Implement PBO. 2020-09-21 ianelliott@google.com Vulkan: Fix copy-paste error in hasCopyImageView 2020-09-21 lexa.knyazev@gmail.com Metal: Implement ASTC LDR support 2020-09-21 jmadill@chromium.org Vulkan: Optimize Attribute Change Perf (5/5) 2020-09-21 jmadill@chromium.org Fix early fragment tests optimization condition. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: DrawCallPerfBenchmark.Run/vulkan_attrib_changeTest: Test: tested with trigger.py Change-Id: Ia2ea153bd1ac41531cf7262318c035c033ca0688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809205}
-
My Nguyen authored
New language settings divide into Languages and Input page. IME settings and Virtual Keyboard settings are both Input-related, so they should open Input page in the updated version. Bug: 1113439 Change-Id: I0f21cbba0600d034a9f55f526638fd2ed4e63b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422923 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809204}
-
My Nguyen authored
Removable condition is different for Language Settings V2 as we are decoupling device language and input methods from language preference. Current view: http://screen/4ax5XVRUryvctHW Bug: 1113439 Change-Id: I0d31f7eda4a3fbe6bf10abd5654b0b0282f603b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417673 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809203}
-
Mike Wittman authored
Moves creation of Unwinders from the profiled thread to the profiler thread on Android, Windows, and Mac. This initialization is expensive on Android -- 50+ ms -- so it's important to not block the profiled thread on performing it. Mac does some work in its unwinder construction so might see a small benefit as well. This is accomplished by passing a factory function for creating the unwinders into StackSamplingProfiler rather than the unwinders themselves. The naming of the classes that create the individual unwinders in ThreadProfiler is updated to call them 'creators', to minimize confusion over multiple levels of factories. Also updates class-level documentation on how to use the profiler. Bug: 1129082 Change-Id: I791538c72dce5c0d04c4f30e2f287fef96da1db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414773 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#809202}
-
Darwin Huang authored
Ensure the RenderFrameHost is still active before use. Previously, RawClipboardHostImpl incorrectly assumed that the RenderFrameHost was guaranteed to outlive the RawClipboardHostImpl, and didn't check that the renderer was always still active. Bug: 1101509 Change-Id: I3e503634be50b1ca60e4c00131546c2337e4176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411673Reviewed-by:
-
Nazerke authored
This CL adds a coordinator for the tabstip and adds it to BVC. Bug: 1130395,1128249. Change-Id: Ica2770c78e8ebac7656a98857897c20bde5717d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418410 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809200}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600711078-3749581e3468596138c3e122333d23faab2aaf5f.profdata to chrome-mac-master-1600732621-efcb2b5a6f18794514e083516aa5205975064ad2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id6fde7c7c61f03d1a0eb2fa10b051941855d6c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422322Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c00c7f418c4..092f3bde17d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274,chromium:1099917,chromium:1128981 Tbr: meredithl@google.com Change-Id: I9001df966cf9edf8fb3fe64d025002225357ea90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809198}
-
Wei Lee authored
We have legacy migration logic since M69 to migrate photos/videos from CCA internal storage to "MyFiles/Downloads" folder. Since we are going to change the default camera folder from "MyFiles/Downloads" to "MyFiles/Camera" and show a dialog/notification to indicate user, it is preferable to remove such migration logic to avoid increasing complexity and too many notifications when launching app. Bug: 1127587 Test: None Change-Id: I6a576cfda3f3ea4d1b97f441710ad45687cf1b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407733 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#809197}
-
Peter Kotwicz authored
This CL: - Adds --android-deps-dir parameter to fetch_all.py This avoids having to place the androidx build.gradle in //third_party/androidx/third_party/android_deps/build.gradle - Adds 'internalTargetVisibility' parameter to build.gradle. This will be used to enable //third_party/android_deps to depend on //third_party/androidx targets - Removes 'depsPath' parameter in build.gradle and changes fetch_all.py to ignore --android-deps-dir parameter in computation of where in build directory DEPS is copied ot. - Adds //third_party/android_deps to the 'ANDROID_DEPS' environment variable when running jetification. This fixes jetification for internal chrome BUG=1064277 Change-Id: I2165846c032071315581278036bcee4ccea97262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422518 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809196}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc2909804286..02ffb6f47a21 2020-09-22 agrieve@chromium.org CheckDirMetadataFormat: LocalPath() -> AbsoluteLocalPath() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127507 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9cdfcf2cea411021f705f35f91d1e7fc0fa22a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423184Reviewed-by:
-
Olivier Yiptong authored
This change adds the requirement for sticky user activation for the enumeration API to return a result. This will require sites to wait for a user activation on session-restore or whatever causes the page to load without user activation before accessing the API. Also, the enumeration API now consumes the transient activation. Bug: 1043306 Change-Id: I77e18795eaa22cc801145243b276c6fd29308d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414920 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809194}
-
Akihiro Ota authored
This patch changes how lessons are organized. Previously, they were categorized by user type (new user, experienced user, developer). UXR discovered that this method of organization could make it more difficult for users to find the content they are looking for. The new strategy is to organize lessons based on content, which makes finding information easier. This patch also adds the OOBE lessons to the main menu; this will allow users to revisit the content whenever they would like to. To keep the visual styling consistent, titles were added to each of these lessons. However, this created an issue in how initial focus is placed when interactive lessons are shown; we don't actually want to focus the title for these lessons, rather the text content that instructs users which keystrokes to press. To solve this issue, this change also adds logic in tutorial_lesson.js for where to place focus when a lesson is shown. Lastly, this change fixes an issue where UserActionMonitor wasn't properly destroyed, thus continuing to block ChromeVox execution even after an interactive lesson was exited. Bug: 1124070 Change-Id: If13952d8a7b6e954fc7292e01444a59fe6a624ef AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412223 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809193}
-
Shakti Sahu authored
This CL adds TutorialManager class to the video tutorials. Also cleaned up a few methods on the storage layer. Bug: 1130260 Change-Id: Ida331aefc538daddccd30175cd5652152cf4ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420779 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809192}
-
Josh Nohle authored
The ListPublicCertificates RPC has an optional field in the request where the client can list the IDs on all locally stored public certificates. Certificates with these IDs will not be returned in the response. However, this RPC is made in Chromium via an HTTP GET request, and One Platform documentation notes request-URL size limits [1]. There are ways to circumvent these size restrictions, but until the Nearby Share server makes the appropriate changes to the API, we will not send the ID list. [1]https://g3doc.corp.google.com/google/g3doc/oneplatform/http.md#long-request-url Bug: b/168701170 Change-Id: Ieec8ad883c152769006c9c8dd94a0341ff46dd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423323 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809191}
-
Austin Tankiang authored
Bug: 1115025, 1128870 Change-Id: Ic3deb289f3730db92b717817f594cc7d9c969868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419058Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#809190}
-
Filip Gorski authored
Bug: 1117078 Change-Id: I8c747c93a7217202e564036c277dc43b8146380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422500 Auto-Submit: Filip Gorski <fgorski@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#809189}
-
Eugene Zemtsov authored
1. VideoEncodeAcceleratorAdapter calls H264AnnexBToAvcBitstreamConverter to convert H264 bitstreams 2. webcodecs::VideoEncoder and media::VideoEncoder have callbacks to report decoder config Bug: 1122955 Change-Id: I897974a04b60cdb2a5c1ce98a9812b6ca9648d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415221Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#809188}
-
Marijn Kruisselbrink authored
Creation and deletion of namespace should never be re-ordered. Creation doesn't depend on having the database open (which often allows delaying opening the database until after chrome startup has completed), however deletion does sometimes require the database. Previously part of the delete operation could be reordered to happen after later create operations, resulting in situations where state could get out of sync. This CL fixes all that by completely pausing processing incoming mojo calls while the database is being opened. This will ensure that no new namespaces get created while we're waiting for the database to be opened while in the process of deleting a namespace. Bug: 1128318 Change-Id: Iea28b92172da88d3719853a42dbb323da2522eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419124 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809187}
-
Curtis McMullan authored
The Chromium flag for the resizable vk is no longer needed. This CL removes all code relating to the flag. BUG=b:164919876 Change-Id: Ie4de22d122ebe4c64f5d87bbfdb694ee79471275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413679Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809186}
-
Andrew Xu authored
This CL handles the clipboard data with the restricted access from the multipaste menu. It implements the following things: (1) Disable the menu item whose clipboard history data should not be accessed through the multipaste menu. (2) The disabled menu item should have different UI appearance. Bug: 1106847 Change-Id: I4c58cc898a3f529a928787d6ef378eaa49f5871a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409736Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809185}
-
Xianzhu Wang authored
We should not add ContentsVisualOverflowRect() to VisualOverflowRect() if a LayoutBox should clip overflow. This should include contain:paint. This also makes the bounds of the composited layer just contain the visible part, not all descendants. Change-Id: Ibca5839ba4db59f3478131e0d00245070d99dc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422150 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809184}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d41c2a6b8aeb..edd7f9e94d43 2020-09-21 tommi@webrtc.org Check if logging for a severity is enabled at the call site. 2020-09-21 glahiru@webrtc.org Rename CancerStickCastle to RoboCaller. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8eaf8d373cea70b2af417a406f3086270accfeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422827Reviewed-by:
-
Mustafa Emre Acer authored
Bug: 1130092 Change-Id: I50224da935beb436f2828ef8047435882a044452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419389Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809182}
-
Regan Hsu authored
This CL removes the NewOsSettingsSearch flag from the cc and enums files and defaults the JS/HTML codepaths it affects to true. Bug: 1080777 Change-Id: I0198f8a3141c3653072c8124a311dbf9beea5dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422266Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch changes the content-visibility check in the inspector code to make sure that we consider ancestor frames as locked as well. R=chrishtr@chromium.org Bug: 1128790 Change-Id: Ie8a4dfebb694bbe50e8c5179ccd9e8cdcc57c35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422244Reviewed-by:
-
rbpotter authored
Bug: 1048812 Change-Id: I1b93c04ca890423f2361d5f3c8211e8a926fed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416839Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Nicholas Verne authored
Fixed: 1094742 Change-Id: I86e65b45d34da352049f7c43d82d0e7a4ec1f615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422020 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#809178}
-
Frédéric Wang authored
This is a follow-up of [1] which didn't handle the case of pseudo elements with a math display value. A reftest is added to verify the expected behavior with pseudo elements, but will fail until the parsing of math display values is adjusted to match what the CSSWG agreed. However, this test checks the fix for an assertion failure (http://crbug.com/1130127). Bug: 6606, 1127222, 1130127 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2404789 Change-Id: I4f7c13db003f776045a934eae9be5839b3c0343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418658Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#809177}
-
David Maunder authored
In EditUrlSuggestionProcessor and EditUrlSuggestionUnitTest there is an assumption that the URL can be acquired off an uninitialized Tab. This is currently not allowed using the UserData pattern. I recommend if the Tab is not initialized we pull the url off the web contents and not store on the UserData object CriticalPersistedTabData. Bug: 1117396 Change-Id: I0223d481b7a25722f4e6bf85e78cad45060fcbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410346 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#809176}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/3f5086309f48..e8573af9803f $ git log 3f5086309..e8573af98 --date=short --no-merges --format='%ad %ae %s' 2020-09-13 chanheepark Add a safeguard in case matching an element take longer than the interaction timeout time. 2020-09-10 tirodkar Multi-window support for visibility check 2020-09-10 tirodkar Add optional verbose logging for AppStateTracker info. 2020-09-10 mobile-devx-github-bot Disable auto capitalization for text fields and text views to reduce flakiness. 2020-09-09 chanheepark Disable auto capitalization for text fields and text views to reduce flakiness. 2020-09-08 chanheepark Fix test failure when tested locally on iPhone 11. 2020-09-06 chanheepark Do not log element information before performing action. 2020-09-03 chanheepark UI element's respondsToSelector needs to be called on the main thread. 2020-09-01 chanheepark Modify the executeJavascript action so that it works on main thread. 2020-08-31 albertbow Rename EDOBlacklistedType to EDOBlockedType per go/respectful-code. 2020-08-28 tirodkar s/URLBlacklistRege/KeyBlockedURLRegex 2020-08-28 chanheepark Rename 'explicitRunLoopDrain' to 'explicitDrainInMainRunLoop' to be more clear. 2020-08-26 tirodkar Fix Xcode project with new assertions / keyboard work. 2020-08-25 chanheepark Deleted unused methods. 2020-08-24 tirodkar Update breaking Assertion Define Macro strings. 2020-08-24 albertbow Resolve process-ownership mismatch of isKindOfClass in EG tests. 2020-08-19 tirodkar Fix issue with typing in a UITextField of the emailAddress keyboardType. 2020-08-18 tirodkar GREYAssertions logging fix 2020-08-17 chanheepark Warn user when the application uses grey_tap() to enable UISwitch. 2020-08-14 chanheepark Adds some comment for readability. 2020-08-12 mobile-devx-github-bot Add the new EarlGrey assertions macros for Objective-C. 2020-08-12 tirodkar Add support for internal runloop push / pop methods. 2020-08-11 chanheepark Print element description on GREYLogVerbose before performing action or assertion. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1126944 Change-Id: Icb5737162412efc5fb0675c30f75d6e843cddc25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416745Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#809175}
-
Sergey Ulanov authored
Some codecs require extra_data to be passed from the demuxer to decoder. FuchsiaAudioDecoder wasn't passing that information to AudioConsumer, so it wasn't passed to the decoder. Bug: 1130881 Change-Id: I095c5cdd8fa99a7316af976d9a5cb748ec9027eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423304 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809174}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I42e3f16d4237ce6fd4cfbb7df8c78c5ef08f40a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422582Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809173}
-
Andrew Grieve authored
Useful for downloading .sizediff from trybots and inspecting locally. Includes minor refactoring of file_format.py Bug: None Change-Id: I7cf9f8a5829e0eaab6210b632713508ce279ba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422318 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809172}
-
Maggie Cai authored
There are couple of cases where when selecting "Stay In Chrome" and "Remember my choice" actually stores an entry with empty app_id. However this happens randomly and cannot be reproduced easily. Add the DumpWithoutCrashing to get a trace to help debugging. The main purpose is to identify where the empty string get generated, because logically it doesn't seem to be possible. In addition to this, some early return are also added to avoid storing the entries. BUG=853604 Change-Id: I320f29418b606288e056d38088f266c817f812e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418279Reviewed-by:
-
