- 10 Aug, 2018 40 commits
-
-
Kevin McNee authored
A tabindex of -1 on the GuestViewContainer element allows it to be focusable but not reachable via sequential keyboard navigation. There does not appear to be any further need for the GuestViewContainer element itself to be focusable given that we override the focus method. Previously, we had a focus event listener on the GuestViewContainer element in order to propagate the focus to the internal element which would explain why this was needed. See https://crrev.com/6476573b7d9099b04002736d90a078550c8651eb https://crrev.com/53ba951bb6ed4df0998240520fed9d00a7ffff67 Bug: 231664, 803274 Change-Id: If6ffb6f7282db86a1a7ab9e856785e6f51d79a80 Reviewed-on: https://chromium-review.googlesource.com/1170988Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582294}
-
yoshiki iguchi authored
This CL adds the setting to select the following mode of the lock screen notification to the Chrome OS setting. - Hide: don't show notifications on the lock screen (default, same as the current behavior) - Show: show notifications on the lock screen - Hide Sensitive: show notifications, but hide sensitive contents (with a flag to disable this, since this may not launch at the same time) PRD: go/notification-on-lock-screen Bug: b/111391270 Change-Id: Ieba42369923472ecef02eac85df9e9009df3ad84 Reviewed-on: https://chromium-review.googlesource.com/1165723 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#582293}
-
Alexander Alekseev authored
Bug: 828996,868093 Change-Id: Ic1dd75cc142bd22b2b9edc31bd5b90abe150e081 Reviewed-on: https://chromium-review.googlesource.com/1170430Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582292}
-
Dan Sanders authored
This is the main body of code required to support MojoVideoDecoder for hardware decode of WebRTC streams. It tries to be as similar as possible to RTCVideoDecoder so that a transition can be managed slowly. The implementation actually supports any media::VideoDecoder, in particular FFmpegVideoDecoder works well for testing. Bug: 857111 Change-Id: I0a4dc37a0a133b4c112a55a215aba8058cca598b Reviewed-on: https://chromium-review.googlesource.com/1117837 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582291}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/04c084dd3cf4..077cd858b2d4 git log 04c084dd3cf4..077cd858b2d4 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 theoking@google.com Vulkan: Introduce Command Buffer Perf Test Created with: gclient setdep -r src/third_party/angle@077cd858b2d4 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie4d97da1f754b092c895391c9215b052d2005e30 Reviewed-on: https://chromium-review.googlesource.com/1171164Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582290}
-
Lukasz Anforowicz authored
Sometimes the commit IPC really is for |navigation_request_| even when the URL checks at the top of RFHI::TakeNavigationHandleForCommit indicate a mismatched URL. Examples of when this can happen are XFO checks (see https://crbug.com/870815) and CSP/frame-ancestors checks (see https://crbug.com/759184). Before this CL, in the cases above |navigation_request_| would be leaked. This CL fixes the leak. Bug: 872803 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.perf:obbs_fyi Change-Id: Ia09f355e69f182479386b3deeea1f7f0c8996813 Reviewed-on: https://chromium-review.googlesource.com/1169865 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582289}
-
Emil A Eklund authored
Change how boolean flags are initialized and stored in NGConstraintSpace and NGConstraintSpaceBuilder. Use a single flag field storing a mask for each option instead of a separate boolean for every one. This simplifies passing the options from the builder to the ConstraintSpace constructor. Furthermore it simplifies addition of new options as they are guaranteed to be passed from the builder to the constructor correctly and that copy and compare operations take them into account without any extra changes. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibd2cfca11f67fa0f526a21cf56a6e461c6ad376f Reviewed-on: https://chromium-review.googlesource.com/1064892 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#582288}
-
Esmael El-Moslimany authored
Bug: 870202 Change-Id: Id1afc62ba99ce648068b773e900f1373413cb8d7 Reviewed-on: https://chromium-review.googlesource.com/1168144Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582287}
-
Mike Klein authored
Change-Id: I6418f338f95a564d85c246b3b65d3fec27480bb4 Reviewed-on: https://chromium-review.googlesource.com/1170589Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#582286}
-
Joe Mason authored
Fix ODR violation with ExecutionMode by declaring the streaming operator in the same header as the type, and add back the GetParamNameForTest calls that use that operator. Also add a streaming operator for ChromePromptValue so that all types declared in constants.h can be pretty-printed. R=proberge Bug: 872748 Change-Id: Idfe3f6044f97b003f17d83c6985d442f9b4103f6 Reviewed-on: https://chromium-review.googlesource.com/1170852 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#582285}
-
Alexis Hetu authored
SwiftShader is now usable on Fuchsia. Requires sister cl to roll into chromium: https://swiftshader-review.googlesource.com/c/SwiftShader/+/20208 Bug: chromium:739182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8be1f554da7633a46ecb888975911d9897f07c78 Reviewed-on: https://chromium-review.googlesource.com/1170040Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582284}
-
spqchan authored
This CL implements downloading the billing blacklist and then triggering the billing interstitial UI. The page info bubble is updated to support the billing interstitial. The billing page info and the interstitial UI is placed behind a new safebrowsing feature flag, "BillingInterstitial". Bug: 867518 Change-Id: Id87463b272a9dcc4a3e3d95faaa48a942a2cb664 Reviewed-on: https://chromium-review.googlesource.com/1163286Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582283}
-
Matthew Cary authored
Removes gold-style section orderfile, as that is now not possible to generate with ThinLTO in lld. Bug: 869997 Change-Id: I9d6970cf9c251cefdc69fbef6c87118fde844374 Reviewed-on: https://chromium-review.googlesource.com/1162221 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582282}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/615ae9b6f35a..5a4110982f31 git log 615ae9b6f35a..5a4110982f31 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 dtu@chromium.org [dashboard] Stop sending 'None' as the comparison_magnitude. Created with: gclient setdep -r src/third_party/catapult@5a4110982f31 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:873022 TBR=sullivan@chromium.org Change-Id: I2d7a717b179bc4d5b613689b9fca13b6a3f62c07 Reviewed-on: https://chromium-review.googlesource.com/1171162Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582281}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4174b5ab6ac9..e1a7e8589a8c git log 4174b5ab6ac9..e1a7e8589a8c --date=short --no-merges --format='%ad %ae %s' 2018-08-10 tsepez@chromium.org Remove const_cast<> from CFX_LZWDecompressor::Decode() caller. Created with: gclient setdep -r src/third_party/pdfium@e1a7e8589a8c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I09961c58c5a521d64ae17af1a762ef100096a1a9 Reviewed-on: https://chromium-review.googlesource.com/1171043Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582280}
-
Ivan Sandrk authored
If the policy is set, remove restrictions that were put into place for public sessions. Bug: 865947 Change-Id: Ifdecf36916d9999ee2f90145dc69b7f46e18d0e1 Reviewed-on: https://chromium-review.googlesource.com/1160651 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582279}
-
Martin Kreichgauer authored
This adds a ScopedTouchIdTestEnvironment class to allow convenient faking functionality of the Touch ID authenticator that requires hardware support or user interaction. TouchIdContext is modified to: - allow injection of fakes through TouchIdContext::Create, in order to disable fingerprint prompts; - allow overriding the value returned by TouchIdContext::TouchIdAvailable, which determines hardware support and configuration status for Touch ID. The Keychain wrapper class is modified to allow injection of a fake into the singleton returned by Keychain::GetInstance. (FakeKeychain implementation will be done in a follow-up CL). Change-Id: I1b801b5bbe9b787965a5958206e6772a9a5eb09a Reviewed-on: https://chromium-review.googlesource.com/1162946 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582278}
-
Tibor Goldschwendt authored
Make bundle modules depend on the secondary ABI libraries. This should fix a build race condition where we fail if we build the Monochrome bundle module before the APK. Bug: 872998 Change-Id: I756b779ac390e806666f398e00936df29f93cdaf Reviewed-on: https://chromium-review.googlesource.com/1171217 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582277}
-
Alexey Kozyatinskiy authored
R=luoe@chromium.org TBR=lushnikov@chromium.org Bug: v8:7486 Change-Id: I332f979fb91d97c80f08f7dadd47d8929439c3fc Reviewed-on: https://chromium-review.googlesource.com/1169777Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582276}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ed63968a391..4eac21fee047 git log 6ed63968a391..4eac21fee047 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader d7622ffdd25e..dd662d210afc (1 commits) 2018-08-10 bungeman@google.com Subpixel in Viewer from -1 to 1. 2018-08-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9b6a3f926032..04c084dd3cf4 (1 commits) 2018-08-10 herb@google.com Rename GrTextUtils::Target to GrTextTarget Created with: gclient setdep -r src/third_party/skia@4eac21fee047 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ifd7584067a7fd1dff4d00a87ecf636c88e7257cd Reviewed-on: https://chromium-review.googlesource.com/1171122Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582275}
-
Esmael El-Moslimany authored
Bug: 870270 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I17c9c1494d2622dbf61398065c0b556a1183075f Reviewed-on: https://chromium-review.googlesource.com/1171203Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582274}
-
Esmael El-Moslimany authored
Bug: 872197 Change-Id: Ie98bf0737a9755312fda763053c9c15316b566be Reviewed-on: https://chromium-review.googlesource.com/1168283Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582273}
-
Christian Biesinger authored
Also, makes CalculateBorderScrollbarPadding equivalent to ComputeBorder + ComputePadding + GetScrollbarSizes. This also makes the padding set on the fragment more correct. R=eae@chromium.org Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8db38ca5955d30fa789a636e5c6deb2ec1fd1829 Reviewed-on: https://chromium-review.googlesource.com/1169321 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#582272}
-
Jennifer Apacible authored
This change updates the close button style. The color of the 'x' is now white. There is no background unless the user hovers over the icon. In this case, there is a grey circular background. As part of this change, CloseIconButton is created to account for the hover behavior. Bug: 872098 Change-Id: I90a53c5e42d6377db4ee45b47633689315865c18 Reviewed-on: https://chromium-review.googlesource.com/1168732 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#582271}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idacc45e249291bd9d42ff7bf9a8abffe8636f6cf Reviewed-on: https://chromium-review.googlesource.com/1117692 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582270}
-
Tibor Goldschwendt authored
This is a reland of f86a758d with fix for x86 bots that have VR disabled. Original change's description: > [vr] Make VR Java android_library and separate VR JNI registration > > This CL does two things: > > - In order to move VR Java code into its own module move the code into a > separate android_library target. > > - As a result of the separate library target we may miss making the VR > JNI registrations (in case VR moves out of chrome_public_apk). Thus, > separate the JNI registration generation for VR and register VR JNI > calls in VR code. > > Bug: 862694 > Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 > Reviewed-on: https://chromium-review.googlesource.com/1158715 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581576} TBR=agrieve@chromium.org,mthiesse@chromium.org Bug: 862694 Change-Id: If069e04fe7897f95ce7634b5fd6199eece3a6f73 Reviewed-on: https://chromium-review.googlesource.com/1167770 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582269}
-
Kevin Bailey authored
Currently the code falls through to "if (command) then open in background." This change breaks out the variation if shift is also pressed. Bug: 870789 Change-Id: Ie96d355c7c75bec276ed5322aac03f0d3f472a9b Reviewed-on: https://chromium-review.googlesource.com/1170860Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582268}
-
Weidong Guo authored
Bug: 872804 Change-Id: I2cac9c78c0d7c1fdde72741509f275b7273b7b12 Reviewed-on: https://chromium-review.googlesource.com/1169778 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582267}
-
Lei Zhang authored
Change-Id: I3c63bb11a46b234f1bc8fddaf28f61c25924e837 Reviewed-on: https://chromium-review.googlesource.com/1170565Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582266}
-
Eugene But authored
New Download Manager was shipped to 100% users in M68 and enabled by default. Bug: 791806 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccbc05ba0aeb90449518cea1ddb4422fff8eab3c Reviewed-on: https://chromium-review.googlesource.com/1170128 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582265}
-
Tessa Nijssen authored
EphemeralRange crashes when it receives a null position. If a textfield is empty, the start and/or end of the word around the caret may be null. This causes the renderer to crash. Add a check that the start and end positions are not null before passing them in to EphemeralRange. Bug: 872443 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7156bb99b53134d076359f9ea320b5a5cdbe5bc0 Reviewed-on: https://chromium-review.googlesource.com/1169584 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582264}
-
Thomas Tangl authored
This CL rolls back the unified consent preferences when the installation is excluded from the experiment. This is needed in case the unified consent feature has to be disabled due to some reason and rolled out again later. During rollback, the following is done: - All unified consent prefs are cleared. - Sync-everything is turned back on if all datatypes are turned on and if the consent bump was supposed to be presented. Bug: 863937 Change-Id: Icb58fad008069c0b38a1ef952ed19e48f8cd3fe6 Reviewed-on: https://chromium-review.googlesource.com/1165226 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582263}
-
Kyle Horimoto authored
This CL updates the kSuiteEnabledPrefName and kAndroidMessagesFeatureEnabledPrefName preferences to true when they are registered. These values should be set to true so that once the setup flow completes, the toggles will be turned on. Without this change, users would complete the setup flow only to discover that MultiDevice features are disabled. Note that this change does not mean that these features will be available without completing setup; these preferences are not used until after setup has completed. Bug: 824568 Change-Id: Ib14434a320a6dc9b1091e8e246f6924835a03763 Reviewed-on: https://chromium-review.googlesource.com/1170176Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#582262}
-
Peter Kasting authored
This reverts commit 94a8710d. Reason for revert: Seems to have caused significant flakiness of many WebRtc tests: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRhODcxMGRjZmViMjFhNDUxNjBjOTY4NmVkZWVjN2RlN2UzMjVjNAw Original change's description: > Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy" > > This is a reland of 7dae0f63 > > The original CL caused flakiness because, in production code, > WebRtcEventLogManager is torn down during Chrome shutdown, after > all threads other the the UI thread have quit. For unit tests, this > was not the case, and so the tests hit some use-after-destruction. > This was fixed by making the tests stop the non-UI threads before > tearing down WebRtcEventLogManager. > > Original change's description: > > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > > 1. If the policy was disabled before, and becomes enabled, > > subsequent calls to StartRemoteLogging() will succeed (barring > > unrelated issues), even for peer connections created while the > > policy was disabled. > > 2. If the policy was enabled before, and becomes disabled: > > a. Peer connections associated with the profile reject > > calls to StartRemoteLogging(). > > b. Active logs (associated with the profile) are stopped, > > and those log files deleted. > > c. Pending log files (associated with the profile) are deleted. > > d. If a log file associated with the relevant profile is > > currently being uploaded, the upload will be cancelled, > > and the file deleted. > > > > Bug: 775415 > > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > > Reviewed-on: https://chromium-review.googlesource.com/1162168 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Elad Alon <eladalon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581167} > > TBR=guidou@chromium.org > > Bug: 775415 > Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff > Reviewed-on: https://chromium-review.googlesource.com/1168962 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582162} TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org Change-Id: I39bd5b6ac26325522f068e78846dde2443f067ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415 Reviewed-on: https://chromium-review.googlesource.com/1171263Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582261}
-
Christopher Thompson authored
This tweaks the policy templates and examples to be clearer about affects on the "Not Secure" UI and how wildcard hostname patterns work. Bug: 844885 Change-Id: I49eba85762272a0bfedb4163cecad1b8e6df513a Reviewed-on: https://chromium-review.googlesource.com/1166247Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582260}
-
Jacob Dufault authored
ShelfBackgroundAnimator determined color by looking at both ShelfBackgroundType and also the session state. ShelfBackgroundType was set from ShelfLayoutManager. Both ShelfLayoutManager and ShelfBackgroundAnimator observed session state changes and updated the shelf colors from that. This means that there were multiple color updates, and beyond that the rendered background type could diverge from what was requested by ShelfLayoutManager in the time between the two callbacks. Remove the ability for ShelfLayoutManager to observe session state changes, and encode the needed information in ShelfBackgroundType. This simplifies control flow and reduces complexity. Bug: 857221 Change-Id: I173e8cc47d7f6f22123814d341a94749472f7932 Reviewed-on: https://chromium-review.googlesource.com/1168028 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#582259}
-
Matthew Cary authored
Adds --pregenerated-profiles and --profile-save-dir to orderfile_generator_backend.py. These allow for precise comparisons between different versions of profile processing, that are not affected by variations in the symbols seen during device profiling. Bug: 869997 Change-Id: I9dd734a77ea4a738e22f20f095e76879e71f3c0c Reviewed-on: https://chromium-review.googlesource.com/1162179 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582258}
-
Jun Mukai authored
Previously the device id was extracted from the offline policy, but that means all of the offline-enrolled device shared the same device id (since the offline policy data is stored on the device). This isn't a big issue as long as the device stays offline, but we should use the generated ID to allow making the transition to the online demo mode after the offline enrollment is conducted. BUG=827369 TEST=manually walked through the offline enrollment Change-Id: I0d9713d78c08fabcd0fb49326e1acca9ee578b98 Reviewed-on: https://chromium-review.googlesource.com/1147336Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#582257}
-
Changwan Ryu authored
We are unnecessarily adding this permission for standalone WebView: com.google.android.c2dm.permission.RECEIVE This was added in rolling a new version of GMS core through BackgroundTaskScheduler. WebView is only using TaskIds in BTS, just to avoid collision with Chrome (which is using the same UID). Therefore, this CL splits TaskIds from the rest of BTS and have WebView depend on it. Bug: 872977 Change-Id: I424659366b2af661d83ad19590c4a76bca37a2ad Reviewed-on: https://chromium-review.googlesource.com/1170426Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582256}
-
Thomas Guilbert authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/de23348fef6f..5659adb8fc6f $ git log de23348fe..5659adb8f --date=short --no-merges --format='%ad %ae %s' 2018-07-24 tguilbert Uncommit script changes 2018-07-24 tguilbert GN Configuration 2018-07-24 tguilbert M70 Chromium patches GN Configuration 2018-07-04 cus avformat/mxfdec: drop invalid index table segments when sorting them 2018-07-16 minasamy_ avfilter: Add colorconstancy filter 2018-07-23 liberato Start robosushi auto-merge. 2018-07-15 michael avcodec/cdgraphics: Clear first frame only once 2018-07-15 michael avcodec/tscc: Do not duplicate images 2018-07-15 michael avcodec/tscc: Move reading the side data palette before other checks 2018-07-22 onemda avcodec/bink: set color range (...) Created with: roll-dep src/third_party/ffmpeg BUG=864711 Change-Id: Ib256516b28b0b2095b52b3ac58c71f5fea8f2f60 Reviewed-on: https://chromium-review.googlesource.com/1159479Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#582255}
-