GitLab

This reverts commit 6379817e.

Reason for revert: Heap use after free that caused original revert has been fixed (see crbug/998642).

Original change's description:
> Revert "Turn tab hover cards on by default on TOT."
> 
> This reverts commit 6381a942.
> 
> Reason for revert: Causing heap use after free on ASAN bots.
> https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=TabStripTest.TabCloseButtonVisibilityWhenNotStacked
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55741
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905195500078197360/+/steps/unit_tests/0/logs/Deterministic_failure:_TabStripTest.TabCloseButtonVisibilityWhenNotStacked__x2f_0__status_CRASH_/0
> 
> Original change's description:
> > Turn tab hover cards on by default on TOT.
> > 
> > Stable approval has been given for 76 in crbug/962604.
> > 
> > Bug: 910739
> > Change-Id: If66c3c8954794126ff194c3d681c3cc71ec20759
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747977
> > Commit-Queue: Caroline Rising <corising@chromium.org>
> > Reviewed-by: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#686596}
> 
> TBR=pbos@chromium.org,corising@chromium.org
> 
> Change-Id: I361c919fb44bbe44aa7e028845693b44429f51d6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 910739
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753844
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686743}

TBR=alancutter@chromium.org,pbos@chromium.org,corising@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 910739
Change-Id: I7888f967ddfd2d7a3e3aa15256e3b4ba808967cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778983Reviewed-by: Caroline Rising <corising@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692114}

After the GPU watchdog starts in the GPU initialization, the watchdog
thread is stopped before sandbox initialization and then restarted after
the sandbox. This CL fixes the bug that causes the watchdog restart failure.

Because of this bug, the GPU watchdog did not run on Linux. This CL will
enable the GPU watchdog on Linux again.


Bug: 992572
Change-Id: I9dc1da1ef23bda772f2d47d9f4a733b624dce517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772516Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692113}

Intent to Experiment[Draft][Google Only]: https://docs.google.com/document/d/1wlvSc31ddpHoRChAbiuAz1o7gM1bF_3W1IaIjSf1Nb4/edit?usp=sharing

Bug: 955750
Change-Id: Ied1b84ccec1c8ba3f720f99a3f8aca173aa94af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681114Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692112}

With this feature, votes for the |CREDIT_CARD_VERIFICATION_CODE|-type
are generated for fields which either have the CVC value, which was used
to unlock the server-cards, or are heuristically detected to be most
likely the CVC field of a credit-card form.

Bug: 
Change-Id: If3b54afb801dec4aec5856a5f97a68cee56870fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762215
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692111}

Bug: 999007
Change-Id: I762a61350619d0f0796769b94a69013efe1c8419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777111
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692110}

https://chromium.googlesource.com/catapult.git/+log/e69fbd1b2db5..f5980f492582

git log e69fbd1b2db5..f5980f492582 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 dberris@chromium.org Pinpoint: Make unicode parsing more permissive

Created with:
  gclient setdep -r src/third_party/catapult@f5980f492582

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:998941
Change-Id: I5098a09d0ca72c893b9f79fb585bb0232751ecd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778813Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692109}

This new NG layout engine implements a different approach for margin
calculation, giving the containing block the responsibility of its
children's margin computation.

However, in legacy layout this is children's responsibility; this is
the reason why the issue this patch tries to fix is only only
reproducible using layout-ng.

The grid code assumed this legacy behavior when computing the 'auto'
margins of the grid items. So, in order to fix the bug, this patch
just ignores any previously computed 'auto' margin when performing a
a relayout of a grid cntainer.

Bug: 994300
Change-Id: I44658876f7c2f2067202e45c6a552593bddfe6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763749
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692108}

This reverts commit 7f6a912d.

Reason for revert: We are relanding this to prove whether this patch was or was not the cause of the style and layout performance regression.

Original change's description:
> Revert "Only update AnimationClock when rendering lifecycle updates."
> 
> This is a speculative revert in order to either confirm or eliminate it
> as a source for a hard to track down persistent performance regression.
> 
> This reverts r679216 (commit 629180ff).
> 
> Tbr: bokan@chromium.org
> Bug: 993476, 785940
> Change-Id: I3585b8bc048509343af495cdb2247131e1b05527
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763754
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689490}

TBR=flackr@chromium.org,pdr@chromium.org,eae@chromium.org,haraken@chromium.org,majidvp@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 993476, 785940
Change-Id: Ia98857042e4b4dff78715199a74ddc8a24f082f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778802Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692107}

This is a reland of e7e516c5

Original change's description:
> Pass Feed library's proguard config through its build target's proguard_config parameter
> 
> R=skym@chromium.org
> CC=agrieve@chromium.org
> 
> Change-Id: I565a3cd2e8af0c90e5727ac9c61eec631d6ec264
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773890
> Reviewed-by: Sky Malice <skym@chromium.org>
> Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691299}

Change-Id: Ica7bd6e1d0e5065ece26106b7fa49469e2a5f804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775369Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692106}

Test: manual
Bug: 988521

Change-Id: Iee9cc88044ecdef9b42645cadce9dd2037918dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771672
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692105}

The parameterization of one test changed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1771134

This CL updates the filter file accordingly.

TBR: sophiechang@chromium.org
Bug: 991488
Change-Id: I0ffa2d7b519a11f5d14bfb8b8a64b51655029841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778762Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692104}

https://skia.googlesource.com/skia.git/+log/6d50818641b7..2aa85df8e782

git log 6d50818641b7..2aa85df8e782 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 brianosman@google.com Particle cleanup: split SkParticleBinding out of SkParticleEffect
2019-08-30 ethannicholas@google.com SkSL sample() now permits specification of coordinates
2019-08-30 penghuang@chromium.org Add SkSurfaceProp::operator!=.

Created with:
  gclient setdep -r src/third_party/skia@2aa85df8e782

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Iaddca798271ca7d4b128aa171c0b0c47a6f177d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778568Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692103}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ef4e2562a78..cc61f5424733


Created with:
  gclient setdep -r src-internal@cc61f5424733

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I514d653dc52512b088975a74a8c5ad3c94aec09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778567Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692102}

With the deprecation of Jelly Bean the
generate_v14_compatible_resources.py script has now been removed
(https://crrev.com/c/1651934), so these styles no longer need to be
placed in a version-specific resource directory.

The WebNotification text color is extracted here to color resources to
resolve a presubmit error.

Bug: 923477
Change-Id: Ifc7a14275138c11a0010974b373b900e2b7cab69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776861Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692101}

ExpandablePreferenceGroup wasn't picking up the default theme because
the default style was being explicitly set to the system preferenceStyle
rather than the Support Library style.

This is a code simplification only. It has no effect on the UI. Verified
on KitKat, Lollipop and Pie.

Bug: 985727
Change-Id: I7d56be2c0b8c4ef4aed3c30caede4999a47bd604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776727Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692100}

Caused by https://crrev.com/c/1764794

R=mahmadi@chromium.org

Bug: 999420
Change-Id: I95b7e8734eab479d0e2ade5edede562fe269609a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776612
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692099}

Setting the DefaultSearchProviderEnabled policy to false means
TemplateURLService::GetDefaultSearchProvider returns null. This CL adds 2 null
checks for this case.

Firstly, when the user selects a keyword match e.g. 'yahoo.com world', a
shortcut is created for the input 'world'. If the user then begins typing
'world', the shortcut provider determines whether the shortcut suggestion
requires a keyword based on whether it's search engine (yahoo) differs from the
default search engine (e.g. google). This CL short circuits this check and adds
the keyword if there is no default search engine.

Secondly, to determine the deletion URL of a search result, the omnibox queries
the default search engine. This CL skips setting the deletion URL when there is
no default search engine.

Bug: 871898
Change-Id: I5b008121c0ce6afd019463070507718ebf86b8dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778642
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692098}

Bug: 986317
Change-Id: I719332e7ed175bca03f15eb311fec598670d5d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778486
Auto-Submit: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692097}

BUG=990870
TEST=copy power.js locally to chromeOS device exhibiting failure and
no longer see 'undefined'

Change-Id: I1d79164bdae6e4bf239a7da5581e9f37c813e6f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777103
Auto-Submit: Todd Broch <tbroch@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692096}

Previously in this small refactor CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1769025,
we introduced a bug that StopSequence moves a tracker to the list of
|removal_tracker_|, and that NotifyFramePresented will never apply to
that list.

This CL fixes the bug and added unit testing.

Bug: None
Change-Id: I37a39994b26c5627e5fc1add9d9688cbf69184a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774313
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692095}

According to the reference[1], std::isfinite(NaN) is false. Therefore,
std::isnan() check is unnecessary.

[1] https://en.cppreference.com/w/cpp/numeric/math/isfinite

Bug: 984849, 985067
Change-Id: Ia03fa3cf337101b589938cb83252ddded7ec054f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715465Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#692094}

The <webauthn.h> API methods return HRESULT values to indicate success or
various types of failures. These values can be translated to one of the WebIDL
DOMException error names referred to by the WebAuthn spec using the
WebAuthNGetErrorName() method. Because the Windows API integration in
//device/fido is implemented as a FidoAuthenticator and FidoAuthenticators
return their operation results as CtapDeviceResponseCodes, we synthesize the
WebAuthNGetErrorName() return value back into a CtapDeviceResponseCode. However,
the MakeCredential and GetAssertion FidoRequestHandler types don't distinguish
the synthesized CtapDeviceResponseCodes returned by the Windows authenticator
from "real" CTAP response codes. This resulted in a bug where the
MakeCredentialRequestHandler dropped the Windows response on the floor for
certain response codes (e.g. NTE_INVALID_PARAMETER -> "NotSupportedError" ->
CtapDeviceResponseCode::kCtap2ErrUnsupportedAlgorithm; see crbug.com/977047).

To fix this, this change adds a separate path to MakeCredentialRequestHandler
and GetAssertionRequestHandler that immediately hands any Windows errors back to
AuthenticatorImpl. Also add new values for FidoReturnCode to indicate whether a
Windows request should result in a "NotAllowedError" or "InvalidStateError",
which AFAICT are the only DOMException types that are permissible to be returned
fora WebAuthn call. (Windows returns additional errors, too. We hence map those
back to "NotAllowedError".)

Also remove the FidoAuthenticator* parameter from
AuthenticatorRequestClientDelegate::DoesBlockRequestOnFailure() because this
change makes it obsolete.

Bug: 977047
Change-Id: I9ae6fe4bfc4b71441ab6d744c1818a1fb617e879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764792Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692093}

https://swiftshader.googlesource.com/SwiftShader.git/+log/793b6c3d0b6b..69ffc317eb39

git log 793b6c3d0b6b..69ffc317eb39 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 capn@google.com Initialize the blend state using memset
2019-08-29 sugoi@google.com Add VK_IMAGE_USAGE_SAMPLED_BIT to SurfaceKHR
2019-08-29 sugoi@google.com Support for independentBlend feature

Created with:
  gclient setdep -r src/third_party/swiftshader@69ffc317eb39

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140286664,chromium:b/140193782
Change-Id: Idabb325ceb200af6d4a8564a2690a675f4a5f980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692092}

After:
https://chromium-review.googlesource.com/c/chromium/src/+/1759900
a new navigation "into" a document and "away" from it is added. It
expects the process used for this document to exit, which doesn't happen
if the document is stored into the BackForwardCache.

It can easily be fixed by disallowing the document to enter the
BackForwardCache.

TBR=alexmos@chromium.org

Bug: 990354
Change-Id: I0e5f1f052d0486c2d3db8fa8664e26146a0ab411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778543Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692091}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/66a74a65..14ad3f97

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9d8d0337ae5ffe4c352f1080acb5ed9b4633b8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778007Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692090}

'pointerdown' event

This worked in most other situations because the cr-icon-button ripple
is either created when the button gains focus through a click or
keyboard. When the ripple is present, it is listening for the 'down'
event synthetic Polymer event similar to 'pointerdown'.

This issue arose in settings due to the use of cr.ui.focusWithoutInk
which will focus on the button with 'noink' set. |ensureRipple| can
take an event which can be used to determine if a ripple should also
be shown.

Bug: 999070
Change-Id: I355a6a835627e628b88e3eb3b6737354034fc67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775200Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692089}

Adds a function, CallOnGraphAndReplyWithResult, to the performance
manager api. This function allows you to post a callback that will be
run on the PM sequence, and be provided a pointer to the Graph. The
return value of that callback is passed back as an argument to the reply
callback.

Bug: 980965
Change-Id: Icf1abc0d738bd1edd8ff2f50d5dba824fa861853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773961
Commit-Queue: Ryan Powell <ryanpow@google.com>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692088}

This CL adds DevUiModuleProvider classes (Java and C++) as backend to
install and load the DevUI DFM. The C++ API must be called from the UI
thread. It consists of query helpers:
* DevUiModuleProvider::GetInstance().ModuleInstalled(),
* DevUiModuleProvider::GetInstance().ModuleLoaded(),
and asynchronous (i.e., takes callbacks) actions:
* DevUiModuleProvider::GetInstance().InstallModule(),
* DevUiModuleProvider::GetInstance().LoadModule().

The Java backend handles DFM installation, and implements standard
on-demand DFM installation flow. For simplicity, no Java UI elements
(e.g., using Toast or InfoBar) as used. Instead, an interstitial page
that calls the C++ API will be used.

Some sources of complexity, also encountered by VrModuleProvider (upon
which the code is based) are:
* Interaction between C++ and Java DevUiModuleProvider via JNI calls
  and interaction between the singletons.
* Queue management for InstallModule() and LoadModule(), to handle the
  corner case of multiple concurrent install / load requests.

Bug: 927131
Change-Id: I4a6f3e4209857542a63e49ff79871a50bc5da4ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769170
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692087}

The 'thank you' page looks a bit out of style. So we skip showing
it and directly close the window.

BUG=979530

Change-Id: Ic55c83fd15a8359d2d975dbf7bb098b4fa9a820a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776932Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692086}

Currently, CrActionMenu's a11y tree looks like:

Menu
  Group (wrapper div)
    Menu item 1
    Menu item
    ...

On macOS, this causes VoiceOver to interpret the wrapper as the sole
item in the menu, and to read the wrapper's generated a11y name, which
is the concatenation of the menu items.

This change removes the wrapper from the a11y hierarchy. Removing the
tabindex is necessary since an explicitly set tabindex overrides
`role=none`.

Bug: 947222
Change-Id: Ice8124b1b19ce04773f8fe7e0fda54755fdcfd3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776223Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692085}

Bug: chromium:992975
Change-Id: Iaaf7557c43eb5655ffb9df22ec1f0d8f1ca546da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777071
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692084}

This reverts commit 84437412.

Reason for revert: Suspected cause of browser test failures on Linux CFI. Confirmed via local bisect on TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedIframe/0 which consistently times out after this CL.

Original change's description:
> Break apart RenderWidgetHost::GetVisualProperties()
> 
> RenderWidgetHost::GetVisualProperties() was doing 3 separate things
>   (1) Actually calculating the VisualProperties
>   (2) Checking against the last stored VisualProperties to determine
>       if the stored copy needs updating.
>   (3) Determining if an ack should be expected if an update is eventually
>       sent with the result of this function.
> 
> This CL breaks it out into 3 new functions:
> 
> GetVisualProperties() - Generates the VisualProperties. This should be
> const but too much of the call chain underneath it did not annotate
> their getters with const that annotating would be too annoying.
> 
> DidVisualPropertiesSizeChange() - Helper function that extracts a common
> query used by DoesVisualPropertiesNeedAck() and
> StoredVisualPropertiesNeedsUpdate().
> 
> DoesVisualPropertiesNeedAck() - Returns true if sending the given
> VisualProperties update to the renderer will generate an ack.
> 
> StoredVisualPropertiesNeedsUpdate() - Returns true if the stored copy
> of the VisualProperties is different enouhg from the incoming one that
> it needs an update.
> 
> Bug: 998273
> Change-Id: Ie8fee3ddedc1ea8b492765cb5b35e7bda99234de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773878
> Commit-Queue: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691879}

TBR=ajwong@chromium.org,ccameron@chromium.org,erikchen@chromium.org

Change-Id: Ia0af4e2dd74bb16841464c2d2c23ed177edf0744
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 998273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778812Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692083}

This CL also fixes a minor bug the Cellular UI to show a disabled
'Connect' button if Cellular is not connectable (since it is never
configurable).

Bug: 853953
Change-Id: I218f34268b27a4a8fde10956a055d9235d329d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769549
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692082}

https://chromium.googlesource.com/angle/angle.git/+log/120b61d34ba8..56ba54cc03f3

git log 120b61d34ba8..56ba54cc03f3 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 timvp@google.com Support separate read and draw surfaces in eglMakeCurrent

Created with:
  gclient setdep -r src/third_party/angle@56ba54cc03f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: None
Change-Id: I2822bd641778b0633975d048bda9b8fc0c88cad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692081}

* No longer dismiss the IPH entrance when user enters the IPH dialog
  and sees the animation. Instead, only dismiss it when user explicitly
  closes the IPH entrance, or has performed drag-and-drop behavior (this
  is not reflected in this CL).
* Make the IPH animation repeat and restart from beginning every time
  the dialog is reopen.

Bug: 997707
Change-Id: If419316c9dc406927649260575b128c650ef2120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777108Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692080}

The BackgroundTaskScheduler is used to schedule one-off or periodic
tasks for Chromium, by delegating the actual scheduling to the
corresponding system API. GcmNetworkManager is used in L and lower
Android versions, while JobScheduler is used in the other newer versions
of Android.

Since a new data type is added in order to support scheduling of
tasks at exact times, a new API will be used to schedule this type
of tasks: AlarmManager. The reason for using this API is that it offers
more guarantees regarding the scheduling of the tasks: even if the
device is in idle mode (added in the newer versions of Android), the
task will still be scheduled at the wanted time, with a maximum delay
of 9 minutes.

This CL adds a new BackgroundTaskSchedulerDelegate implementation,
responsible for the delegation of tasks to AlarmManager. The necessary
updates in the existing classes and new tests are added with this
change.

Bug: 970160
Change-Id: I87d090c64854dab209a444a7cae65c2dcb6c2430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755989
Commit-Queue: Ioana Stefan <ioanastefan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692079}

This patch converts the grid tab switcher and groups from the
existing MVC RecyclerView infra to the SimpleRecyclerViewAdapter.
The most notable change is the removal of the view holders for
lookup by ID.

Bug: 982075
Change-Id: I0b6afe496343e430a72a80c2f940979834207f9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687926
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692078}

https://skia.googlesource.com/skia.git/+log/b30ba90aec5b..6d50818641b7

git log b30ba90aec5b..6d50818641b7 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 rmistry@google.com Match CanvasStateHelpers.cpp change in Android repo

Created with:
  gclient setdep -r src/third_party/skia@6d50818641b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Idbd333068c08ac02f32243e161217b476d8a3b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778581Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692077}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c470eee0063..6ef4e2562a78


Created with:
  gclient setdep -r src-internal@6ef4e2562a78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: Id0d0a111a544512e7e8b90e1461f56927b0fe1bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692076}

Previously wheel scrolling was being treated similar to touchpad.
This lead to behavior where it was very hard to escape snap points
since at the end of every wheel tick which scrolls a small amount
Blink would snap back. The only escape was to wheel continuously
to get closer to the next snap point.

This is not ideal. It is much more natural for wheel ticks which
are discrete to be treated as "direction scroll" for snapping
purpose. So single wheel tick would take user to the next snap points.

See [1] for a before/after video.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=963609#c5


Bug: 963609
Change-Id: I72d1f23ab25e3d1ce29afa47d2d591497e8f1c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758498
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692075}