GitLab

When a new permission is needed to show the chooser (e.g. camera
permission), the chooser was not showing up. This is because the
permission request was routed through the Activity instead of the
Fragment. This fix is similar to what was done to send the Intent
through the Fragment in http://crrev.com/c/1880072.

Bug: 1018955
Change-Id: Ie0226d388b8a9148afeeda2ccec8907f1b547dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891748Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711565}

This CL converts old Mojo types of ContentDecryptionModule
interface to new Mojo types. Major changes are as below,

  - Convert mojom::ContentDecryptionModulePtr to
    mojo::Remote<mojom::ContentDecryptionModule>
  - Convert mojo::Binding to mojo::Receiver

Bug: 955171
Change-Id: I19068217af7a0a315dd8c46405ab0839c2fb22f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890406
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711564}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c87ed60623e4..540178c7543f

git log c87ed60623e4..540178c7543f --date=short --no-merges --format='%ad %ae %s'
2019-10-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@540178c7543f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I4ef9ad788ca0503bc2736897d885998c2888f81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711563}

The size of Identity Disc was decided once based on visibility of bottom
toolbar. Toolbar can be shown/hidden based on experiment combination
(enabled duet, disabled tab grid layout) and device orientation.

This CL adds support for adjusting IDentityDisc size. Images are
retrieved on demand. Images for both sizes are cached since the user is
likely to rotate the device multiple times.

R=twellington@chromium.org

Bug: 971711
Change-Id: I456168b7e1fe9956691a344e162dc9c4455e521a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877189Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711562}

Fixed: 1020340
Change-Id: I5152492b0683537fc1dbabfc2bca332f3923e5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894237
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711561}

BUG=841098

Change-Id: I09726ccc545f09da0913e78f0b4e842306cbdd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894137
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711560}

For further refactoring: removing createHelperIframe() and
unifying requestViaForm() with other navigables.

This can enable referrer-policy tests for <form>,
while it is not spec'ed yet though:
https://github.com/whatwg/html/issues/4320.

Bug: 906850
Change-Id: I96c43ec8c8b39f794f8bf8291f2af798f1a30c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562120
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711559}

No functional change, but simplifies the code, and is a necessary precursor for
fixing bug 1015717.

Bug: 1015717
Change-Id: I0f5212ce85841540a2ca85b8c73d8a1149576240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884814
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711558}

Specifically, if the child height is odd and the line height is even, this
shifts the child down by 1 px compared to the current behavior.

This behavior seems reasonable and KeyboardShortcutItemView expects it.  Without
this change, a later CL to position KeyboardShortcutItemView children based on
line heights instead of first child centers can change behavior unexpectedly.


Bug: 1015717
Change-Id: I66b92baae5a8ca0dd83db454fbf0349925bdb169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892291
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711557}

This also adds api to activate accelerator, which is used
to change the launcher state.

Bug: 1001728
Test: covered by unittests
Change-Id: I9e545a4ab5a646a5260f59b821e3229e87ad5466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869991
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711556}

https://skia.googlesource.com/skia.git/+log/5b6ccbb6b599..283ec65f632a

git log 5b6ccbb6b599..283ec65f632a --date=short --no-merges --format='%ad %ae %s'
2019-10-31 emircan@google.com Handle all failures for vkWaitForFences
2019-10-31 herb@google.com Fast SkPackedGlyphID CTOR
2019-10-31 michaelludwig@google.com Use point to line distance instead of area for colinear check

Created with:
  gclient setdep -r src/third_party/skia@283ec65f632a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:1019469,chromium:881505,chromium:1018218
Change-Id: Id385c03a072621a0c3cda8a0c879070398db54f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894060Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711555}

This CL adds UMA states to track the smoothness of the desk
activation, and desk removal animations.

BUG=1016994
TEST=No behavior changes, all tests should pass.

Change-Id: Ia0630d5c9a9265c41bfb05d5aa0eb182e438e036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891766
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711554}

When LayoutNG was enabled, nested containers (e.g., "inline-block") no
longer produced the correct values for kNext- and kPreviousOnLineId.

The problem was tracked to |AXLayoutObject::NextOnLine| (and
|ShouldUseLayoutNG|), which wasn't taking the LayoutNG path for nodes
where the |IsInLayoutNGInlineFormattingContext| flag is set.

Bug: 1012542
Change-Id: Ifdb9f0a2559a605469ecbcfcc767435c0dcbfb33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848594
Commit-Queue: Ian Prest <iapres@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711553}

TBR=ambake@microsoft.com

Bug: 1020379
Change-Id: I6a395b7e88418e13a3b720e7d336025b403cd7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893473Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711552}

Bug: 997885
Change-Id: Idcde0d4479bc571ad2dd39d84941d240e1797419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888127
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711551}

R=altimin@chromium.org, arthursonzogni@chromium.org

Change-Id: Ib562302291ca94810a66d85737e90618af35ff52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892476
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711550}

This CL converts old Mojo types of WilcoDtcSupportdServiceFactory interface
to new Mojo types. Major changes are as below,

  - Convert WilcoDtcSupportdServiceFactoryPtr* to
    mojo::Remote<wilco_dtc_supportd::mojom::WilcoDtcSupportdServiceFactory>*
    in CreateWilcoDtcSupportdServiceFactoryMojoInvitation

Bug: 955171
Change-Id: Ie9015cb651f2c375823ee66e9d23931b77bd56e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890520Reviewed-by: Polina Bondarenko <pbond@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711549}

TBR=tedchoc@chromium.org

Bug: 1020381
Change-Id: I0550cc1722e677222d774ffeaca8f2a082cdb517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894046Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711548}

This reverts commit a2c0ced3.

Reason for revert: Tentative revert to help with system OOM issues.

Original change's description:
> [Fuchsia] Reenable protected mode in WebEngine
> 
> Bug: 982922, fuchsia:24570
> Change-Id: If9fb495249488c43f97e4451a14f0193911d600f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697683}

TBR=sergeyu@chromium.org,emircan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 982922, fuchsia:24570
Change-Id: I94ae35ec8d84d96af757068ab552d3942318048b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894103Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711547}

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
All uses of base::ProtectedMemory have already been removed, now delete
the remaining code and build changes.

Bug: 1018834, 1007916
Change-Id: I2df8d6d30d3ccfa7e8fb679d047e9df02539ff49
Fixes: 1018834, 1007916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891114
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711546}

Somehow this code got committed without git cl format being run.

Change-Id: I85ded7a8e9a5ec6e9d31ad8af38669bc12b3a49a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894535
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711545}

This CL handles the following issues on interstitial pages.
1 - The links for privacy, support etc will be open with the preview tab.
2 - The link "Back to safety" will go to the previous page. If there
    is no previous page i.e. previous page is NPT, the preview tab
    will be closed.

The change works for overlay panel-based preview tab only.

Bug: 1014689
Change-Id: I8d16f344ee6d523fb22382a0a208a25dbe7229fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890517
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711544}

&foo.front() is undefined if foo is empty. Both std::string and
std::vector provide data methods these days.

Bug: 923166
Change-Id: I7b9136dd29eecd1a2a4b21199fe171d042f9ab8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894047
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711543}

This change enables the construction of StoreUpdateDatas that contain
PredictionModels and HostModelFeatures so they can be persisted in the
HintCacheStore. This includes new StoreEntryTypes for PredictionModels and
HostModelFeatures.

PredictionModel StoreEntries do not require metadata entries as all the
metadata is contained with in the StoreEntries themselves. There will be
relatively few of these entries and will only be loaded based on the
OptimizationTarget.


Bug: 1001194
Change-Id: I5c7db3552022148aa0d527a00fd3b69c902f2ad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888816
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711542}

BUG=5027

Change-Id: Ieb23ffe8279fbdab9fdf7357916312ec534793af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885630
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Yohei Yukawa <yukawa@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711541}

Removed all code and documentation references to the old detached
bookmark bar state. Deprecated metrics collection for the detached
bookmark bar feature.


Bug: 871419
Change-Id: Ia7e0e0fa6055c08491cd940a1d9fe4fe149f768e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863736
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711540}

Convert the implementation and all users of the
chrome_cleaner::mojom::CleanerEngineRequests interface.

Bug: 955171
Change-Id: Ic89e56e567b1d357fb994f5636cd62adbfb4c8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855922
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711539}

Bug: 1019252
Change-Id: I92e73ae5f587fc50a05676f7c3eb5502d0caaf64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887891Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711538}

- This CL added a interface for controllers and use factory
to create the instance based on the feature flag.
- Registered this client into system.
- Added UpdateNotificaitonScheduleCoordinator in Java side.
- In Java side, moved all notifications related code under
omaha/notifications.


Bug: 1013685
Change-Id: I791d590e9c3b5d03a842e818e902ee630f588031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888115Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711537}

This splits the libxml_utils helper classes into xml_reader and
xml_writer targets. The xml_writer can be safely used from any target.
The xml_reader has strictly limited visibility to locations that are
audited by the Security Team. Direct access to the libxml target is now
also limited.

Bug: 699306
Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711536}

This CL cleans up old Mojo types for mojom::Receiver using
Receiver.

Bug: 955171
Change-Id: I5ad59189f2759a6df51d768dedf78d1dd95d18c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890382Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711535}

- add a README.chromium for the Speech Rule Engine
- move all files out of ...chromevox/[injected|background] to chromevoxclassic (which is the only user).
- add a gni file for liblouis library generation (for classic)

TBR=dmazzoni@chromium.org

Change-Id: I7e0c38a360438845edc39f0b34aeda502c0a4aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892553
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711534}

Ran 100 times locally w/o flaking.  This does add @RetryOnFailure
to be consistent with the test above, which does this only a single
time.

BUG=516018

Change-Id: I233166bb2ca9004a02dd81a9a3b32cc5a72545f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893977Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711533}

Bug: 1006268, 860467
Change-Id: I98ee82f2a672ba09f9e06f27f8a7164f729c4719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816511
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711532}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0434c1ced7a..fa2b7d8d16c4


Created with:
  gclient setdep -r src-internal@fa2b7d8d16c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1019931,chromium:1018879,chromium:1018879
Change-Id: I9bb27ed76585fb82533f66dd2fae0fe4f30da5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894056Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711531}

This fixes a crash when building with _LIBCPP_DEBUG=0. This function
returned true for nullopt < nullopt when it should return false.

Bug: 923166
Change-Id: I904566ad19ca4ac6e1405db15851ffa79b3a4836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894099
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711530}

This CL cleans up old Mojo types for network::mojom::NetworkContext using
ReceiverSet.

Bug: 955171
Change-Id: I6b368a65a42d9441c56aaea4e2c5692e2b361c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890522Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711529}

This prevents a browser crash when a page attempts to use the Web
Speech API.

Bug: 1019511
Change-Id: Ie369adc51dc4fa8228bd9df5a1b102dffd44daa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888105Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711528}

Change-Id: I06d29a268b5c1b0526dc04c2980b116a987d54c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890403Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711527}

Convert the implementation and all users of the
chrome_cleaner::mojom::EngineRequests interface.

Bug: 955171
Change-Id: I32b6bc3f8d1e1f7c55f688c8dca5df85b9097472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855980
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711526}