- 24 Oct, 2018 40 commits
-
-
Tetsui Ohkubo authored
In order to look visually consistent with UnifiedSystemTray, notification popup ordering should be inverted on Chrome OS. To implement that, this CL adds MOVE_UP_FOR_INVERSE animation state to MessagePopupCollection. TEST=MessagePopupCollectionTest BUG=876769 Change-Id: I0dcb5c20c8bc3e76f44b32c989b7c935d0e2f676 Reviewed-on: https://chromium-review.googlesource.com/c/1290450 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602259}
-
Antonio Gomes authored
BUG=890771 Change-Id: I9fbb028db7c7e4c259885aa804ef475bb79deb47 Reviewed-on: https://chromium-review.googlesource.com/c/1296872Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#602258}
-
Satoshi Niwa authored
Design doc : go/arc-file-picker BUG=b:64281746 TEST=out/Default/unit_tests --gtest_filter="ArcSelectFilesHandlerTest.*" Change-Id: I38fdcf214ddc08a986086f6d96943bfe69d53e30 Reviewed-on: https://chromium-review.googlesource.com/c/1272341 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602257}
-
Joel Hockey authored
Only persist shares from right-click > Share with Linux. Do not persist shares that are done for the purpose of opening a file with a linux app. Share with Linux is only supported for directories (not files), but open with linux app will share only the selected files, and not the containing directories. Also needed to fix chrome.fileManagerPrivate.executeTask jsdoc to correctly declare that callback receives !chrome.fileManagerPrivate.TaskResult. I'm not sure why closure compiled previously without this fix. Bug: 878324 Change-Id: Idfe0728cd817ba406b0dd1a1eb80c561944f1ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1290581Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602256}
-
Alex Danilo authored
File manager added support for using MIME types for icon display in https://codereview.chromium.org/1158923004 and used a mixture of string literals and Regexp constructors. The RegExp constructors need escaping of the strings so they lex correctly. This change corrects those strings. BUG=chromium:675506 TEST=Manually checked, automated lexer in bug report was personal project by the reporter. Signed-off-by:
Alex Danilo <adanilo@chromium.org> Change-Id: I2241b87231d75d0d1b2d2c7b8bdfe13a6d3a0770 Reviewed-on: https://chromium-review.googlesource.com/c/1296934Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602255}
-
Xinghua Cao authored
Driver may create a compatibility profile context when collect graphics information on Linux platform, but command buffer service gets a core profile context when supports GLX_ARB_create_context, so make them identically. Try to collect graphics information based on core profile context after disabling platform extensions. BUG=867675 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibf0abc1942532d6518fb7c65ebb857dc4d509171 Reviewed-on: https://chromium-review.googlesource.com/c/1247531Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Cr-Commit-Position: refs/heads/master@{#602254}
-
Satoshi Niwa authored
and fill StartArcMiniContainerRequest with the flag value in arc_session_impl Refrence CL: http://crrev.com/c/617748 TEST=Manually confirmed that the flag value is passed to arc-setup BUG=b:117814025 Change-Id: If2eb9a71fcd565af45aba7de77cc40f80acb7f37 Reviewed-on: https://chromium-review.googlesource.com/c/1295974 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
-
Alex Danilo authored
The 'New folder' menu item should create a folder with the same case for the folder name. This implements that, and updates the test. BUG=chromium:894971 TEST=Ran all the FilesApp tests Signed-off-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63963f35905f..10ebffa1d5f3 Created with: gclient setdep -r src-internal@10ebffa1d5f3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie991c685b619fb2264658ca4a099546a8d75212a Reviewed-on: https://chromium-review.googlesource.com/c/1296985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602251}
-
Xianzhu Wang authored
For fixing SlimmingPaintV2 scrolling background painting and invalidation, we need a single place to get the accurate value of the background paint location. Bug: 732611 Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f Reviewed-on: https://chromium-review.googlesource.com/c/1297586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602250}
-
Esmael El-Moslimany authored
This is a follow-up CL to creating an alternative radio group called cr-radio-group and replacing all usages of paper-radio-group with cr-radio-group. Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6637190f8eb63409c16ff70f6a7bc65872442780 Reviewed-on: https://chromium-review.googlesource.com/c/1277526 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602249}
-
Karan Bhatia authored
- Allow manifest version 2 to be used as "max_manifest_version". - Allow manifest version 3 to be used as "min_manifest_version". BUG=896897 Change-Id: I72009c94bb715b7de3606b013d8e4eb5c94f44af Reviewed-on: https://chromium-review.googlesource.com/c/1292903 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602248}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73f3917e89ca..41ed3e083ed5 git log 73f3917e89ca..41ed3e083ed5 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b1cb8571..5e500373 (601125:602066) Created with: gclient setdep -r src/third_party/webrtc@41ed3e083ed5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70217a4e62655c53e4d61d7b105fd03bd010c931 Reviewed-on: https://chromium-review.googlesource.com/c/1296866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f57470be7f99..63963f35905f Created with: gclient setdep -r src-internal@63963f35905f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idd571ce51d826dc6a1f93fe7ef8c34de0829a88b Reviewed-on: https://chromium-review.googlesource.com/c/1297121Reviewed-by:
-
Jun Mukai authored
This CL changes the order of HideImpl and giving up the focus within DesktopWindowTreeHostMus. As is written in the comment, this is because some code like WindowActivityWatcher assumes the window is already invisible when the window gives up the focus. BUG=896080 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I48a45bbea87c2e66d9827d2f7776b038edfca512 Reviewed-on: https://chromium-review.googlesource.com/c/1297401Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602245}
-
Xianzhu Wang authored
- Replace LayoutObject::SetBackgroundChangedSinceLastPaintInvaldiation() with LayoutObject::SetBackgroundNeedsFullPaintInvalidation(). - Previously we used SetShouldDoFullPaintInvalidation( PaintInvalidationReason::kBackground) in some cases, but it may miss invalidation of background painted on the scrolling contents layer. Now use the new method in all cases that the background needs full paint invalidation. - Move all view background paint invalidation into BoxPaintInvalidator. This simplifies the call sites which now just call SetShouldCheckForPaintInvalidation(), and make it possible to do just incremental invalidation instead of full invalidation when the browser control hides and background at the bottom appears on Android. - Other cleanups - New tests This is a preparation for SPv2 scrolling background invalidation. Bug: 732611 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d51d0788e614021c177de478e8cf70e5507aa7f Reviewed-on: https://chromium-review.googlesource.com/c/1289994 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602244}
-
James Cook authored
It seems to pass now. Bug: 831826 Change-Id: Idacf939fcc05a76fa14824ffa3f5f2cc4f68f984 Reviewed-on: https://chromium-review.googlesource.com/c/1297403Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602243}
-
Hiroshi Ichikawa authored
Bug: 786891 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7b51609b0b4382d28e34ec63ac5d81d60eb84b2d Reviewed-on: https://chromium-review.googlesource.com/c/1293057Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#602242}
-
Daniel Cheng authored
- Use std::unique_ptr to pass ownership of WebSetSinkIdCallbacks. - Use base::OnceCallback in //content since the callback can only be invoked once. - Remove //media wrapper for std::unique_ptr<WebSetSinkIdCallbacks>. - Remove the default case from the //content to Blink callback mapping and handle the previously missed enumerator value OUTPUT_DEVICE_STATUS_ERROR_TIMED_OUT. Change-Id: I2695ba1f8b0e715a85e1dbfb4814410bd18188a3 Reviewed-on: https://chromium-review.googlesource.com/c/1297304 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602241}
-
Yi Gu authored
This test started to crash on linux-xenial-rel. Suspecting the patch crrev.com/c/1286425. TBR the owner and merge the bug to the LayoutNG meta bug. TBR=mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Ib5c8c74f80ce9e2b4c0215504a39bfd1695eb823 Reviewed-on: https://chromium-review.googlesource.com/c/1297734Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602240}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I0dcfcf2bf08021590984dedd56efe43c36e94625 Reviewed-on: https://chromium-review.googlesource.com/c/1297483Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#602239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc77baee. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 57cc1d42 "Added 304 CSP test and removed "content-*" prefix from headers to ignore on 304" 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26611 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I940b69a43f4cd022459673c471ff50cde4e836d3 Reviewed-on: https://chromium-review.googlesource.com/c/1297729 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602238}
-
Scott Violet authored
Which is used in some tests. BUG=889101 TEST=covered by tests Change-Id: I2757361aed21909b8020fe0f9e7c600fe88f950c Reviewed-on: https://chromium-review.googlesource.com/c/1297408 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602237}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6a85907fbdd..685b5de1133a git log c6a85907fbdd..685b5de1133a --date=short --no-merges --format='%ad %ae %s' 2018-10-23 eakuefner@chromium.org [Dashboard] Rewrite/remove add_histograms_queue TODOs Created with: gclient setdep -r src/third_party/catapult@685b5de1133a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iea2b3ad4e7fb9a37f09ac6fc10f8052d23c24cbc Reviewed-on: https://chromium-review.googlesource.com/c/1297669Reviewed-by:
-
Antonio Gomes authored
In a follow up step UserCloudPolicyTokenForwarder will be migrated away from using ProfileOAuth2TokenService, in favor of PrimaryAccountAccessTokenFetcher. BUG=893504 Change-Id: I3b1f96a46e5ef61a8f6b796af37f344deef3023f Reviewed-on: https://chromium-review.googlesource.com/c/1296873Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#602235}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f52fb7021299..d86805176f39 git log f52fb7021299..d86805176f39 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 tsepez@chromium.org Be more particular about FX objects constructed from JS 2018-10-23 thestig@chromium.org Pull in current Chromium IMMEDIATE_CRASH() implementation. 2018-10-23 tsepez@chromium.org Test color.convert() and equal() from JS (and fix comparison logic). 2018-10-23 tsepez@chromium.org Split field.in into field_properties.in and field_methods.in 2018-10-23 tsepez@chromium.org Remove CJS_Field::ValueIsOccur() 2018-10-23 tsepez@chromium.org Remove CJS_Report class. Created with: gclient setdep -r src/third_party/pdfium@d86805176f39 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6f03fddbacc45e87954ccec3da4701ac284eb4a Reviewed-on: https://chromium-review.googlesource.com/c/1297120Reviewed-by:
-
Tetsui Ohkubo authored
This is the first part of three CLs removing old MessageListView code. The split is suggested in the review. https://crrev.com/c/1292667 (1) Removing the old implementation (2) Removing the flag (3) Renaming the implementation TEST=trybot pass BUG=870801 Change-Id: Id5c31fa38a6df4bae3b991b2a88950d01b4b1979 Reviewed-on: https://chromium-review.googlesource.com/c/1295613 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7ab9988ec40f715979cf94ec2d8fd94e87723d4f Reviewed-on: https://chromium-review.googlesource.com/c/1277868 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602232}
-
Alan Cutter authored
TBR=creis@chromium.org Bug: 898370 Change-Id: Ic868afff813491718b30d2cd36b12307c09cdd9d Reviewed-on: https://chromium-review.googlesource.com/c/1296937Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602231}
-
Aiden Benner authored
Even though String is an object (and so being casted to jobject across the jni boundary would make sense), the JNI spec gives special treatment for java string types and they're casted to jstrings instead of jobjects. This change makes sure Strings stay as Strings in the native method declaration. Previously all non-primitive types would be casted to objects. Also fixed a bug where void was being cast to object (this happened because void is non-primitive). Also adds better array support. Arrays with a primitive component type will stay as primitive arrays but arrays with a non-primitive component type will be casted to an object array. Change-Id: If795bcddf7a38f051d0c6fb515e1dd320dd3f30d Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1297083 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#602230}
-
Ken Rockot authored
Introduces generation of smaller JS mojom bindings. This implementation is incomplete, lacking support for unions, associated interfaces, and versioning. It's still sufficient for many existing WebUI use cases. The new bindings also present more ergonomic/webby interfaces for things. See bug and documents linked therein for details. The old concatenated mojo_bindings.js sits at around 155 kB, and the new mojo_bindings_lite.js is around 47 kB uncompiled. With compilation enabled it's 21 kB, a net reduction of ~86%. On platforms where the build supports Closure compilation, the common bindings library is always compiled. Bug: 894376 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I47dafbca77dccd6a45a829d21c33679440da0a2f Reviewed-on: https://chromium-review.googlesource.com/c/1278470Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#602229}
-
Yi Gu authored
This test is consistently slow on Mac 10.13. TBR=sahel@chromium.org NOTRY=true Bug: 898378 Change-Id: I09c144a06023918f6b4965409cecdb7743c095dc Reviewed-on: https://chromium-review.googlesource.com/c/1297733Reviewed-by:
-
Ehsan Chiniforooshan authored
This should be submitted after https://chromium-review.googlesource.com/c/catapult/+/1286371 Bug: 890757 Change-Id: I1185895b778024fd8c2f64a6597899cb717c6610 Reviewed-on: https://chromium-review.googlesource.com/c/1287029Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#602227}
-
Adrienne Walker authored
In looking at some sampling profiles, it turned out that these commands (set/reset url and the query commands) were all causing unnecessary RestoreState in RasterDecoder. As these don't touch gl state, whitelist them so that they don't cause extra work. Bug: 894200 Change-Id: I54837830d7df3b5333b3a3e8e42d9232ef8e8b41 Reviewed-on: https://chromium-review.googlesource.com/c/1297592 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602226}
-
Renee Wright authored
This allows up to discriminate between container setup errors and container startup errors in the UMA Bug: 898043 Change-Id: I71921b6980c3f1f85c27ecee178db64a93bed232 Reviewed-on: https://chromium-review.googlesource.com/c/1295630Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#602225}
-
Karan Bhatia authored
This CL adds a csp_validator::ParseCSP method to parse a CSP string. Existing code doing the parsing is changed to use this new method. This CL should have no behavior change. Also add unit tests exercising the new method. BUG=896041 Change-Id: Ic97e31ab23b6d21c0b3ad4b771a2fd7c37bec6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1292825 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 897050 Change-Id: I0d3a758917d44ea9841e78696b1be829b20b3596 Reviewed-on: https://chromium-review.googlesource.com/c/1297636Reviewed-by:
-
HyeockJinKim authored
Bug: 866923 Change-Id: I7e68f4b199ae41280e3745d47849fe3557d24661 Reviewed-on: https://chromium-review.googlesource.com/c/1257723 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602222}
-
Alan Cutter authored
This reverts commit 3b3248da. Reason for revert: Test crashing on all bots. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931832645289538640/+/steps/blink_platform_unittests/0/logs/BitmapImageTest.DecoderAndCacheMipLevels/0 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&tests=BitmapImageTest.DecoderAndCacheMipLevels https://bugs.chromium.org/p/chromium/issues/attachment?aid=364338&signed_aid=j6fGrtk-5lTyU5qtiDtjbg==&inline=1 Original change's description: > Move image resources for bitmap_image_test to /testing/data > > This pacth means blink/renderer/platform/graphics/bitmap_image_test.cc > loads images from blink/renderer/platform/testing/data. > This will more cleanly separate the unit test and layout test data. > > Bug: 898155 > Change-Id: I34f582f127df6fff8634aaff66893fb27abffaaa > Reviewed-on: https://chromium-review.googlesource.com/c/1296870 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> > Cr-Commit-Position: refs/heads/master@{#602168} TBR=pdr@chromium.org,jdragon.bae@gmail.com Change-Id: I2996bdfa2fdf7bcba544b8925bc33da5b634a8df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898155 Reviewed-on: https://chromium-review.googlesource.com/c/1296938Reviewed-by:
-
Yi Gu authored
This test started to fail after crrev.com/c/1296870 which was landed 4 hours ago. Disable the test and assign the bug to the owner. TBR=jdragon.bae@gmail.com NOTRY=true Bug: 898372 Change-Id: I7b3d8ba10535caed7226b295d74537ac7e5dfeda Reviewed-on: https://chromium-review.googlesource.com/c/1297715Reviewed-by:
-
