GitLab

replace std::find() with base::containsValue()
at components/bookmarks and components/exo
and components/infobars

Bug: 561800
Change-Id: I9b2cb633e6872e37663a249fba77548a074d9e02
Reviewed-on: https://chromium-review.googlesource.com/1124719Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573562}

Allow elements that use cr-dialog to override the appearance of the
close button when it is focused.

Bug: 859857
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id13b83ad9653149e0a81b2b23fe6af62ee349669
Reviewed-on: https://chromium-review.googlesource.com/1125289Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573561}

Bug: 841735
Change-Id: I0adf1eec46833b8f69cd186ef4eccef42c879cb0
Reviewed-on: https://chromium-review.googlesource.com/1093095
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573560}

Add the following UMA metrics:
- Search.HistoryReport.DeltaFile.LastSeqNo
- Search.HistoryReport.DeltaFile.LevelDBEntries
- Search.HistoryReport.UsageReportsBuffer.LevelDBEntries

These are health checking signals to see if Icing-related levelDBs
could grow too big.

Bug: 857345
Change-Id: Icfc67b3442864a1c31b15427de40b406ea674ff7
Reviewed-on: https://chromium-review.googlesource.com/1117937Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573559}

This CL introduces SharedBuffer::Iterator for reading data from a SharedBuffer.
Now we can read all the data from a SharedBuffer |buffer| by

 for (const auto& span: *buffer)
   ProcessData(span.data(), span.size());

Also, we can read a data range starting from a specific point |pos| by

 for (auto it = buffer->GetIteratorAt(pos); it != buffer->cend(); ++it)
   ProcessData(it->data(), it->size());

This CL also removes existing GetSomeData and ForEachSegment from SharedBuffer.

Bug: None
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9a5891204d3323cb87ee7b6ee0f8ec2011d88e4b
Reviewed-on: https://chromium-review.googlesource.com/1127760
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573558}

...to the extent possible. This involves lowering 64-bit Linux' limit from 8
GiB to 4, to match Windows.

Note that in the process of writing a previous version of this CL, we learned
that macOS apparently does not enforce RLIMIT_DATA, so we continue to not have a
limit on that platform. (The same goes for RLIMIT_AS, which we previously knew
about.)

Bug: 853873,459158
Change-Id: I5a2a76b4c98a0862c16ce121572c4b2b0f910b44
Reviewed-on: https://chromium-review.googlesource.com/1130235Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573557}

This corresponds with the consistency change from session to permanent.

BUG=859048

Change-Id: Ib6f9c977c24d75c74a5b64703610c9020f835bd3
Reviewed-on: https://chromium-review.googlesource.com/1125215
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573556}

Prior to this patch DesktopNativeWidgetAura::Close() would call
content_window_->Hide() and then hide the WindowTreeHost. The call to hide for
the WindowTreeHost is what triggers animations in ash. The hide/close animation
works by cloning the layers. Because the content window was hidden before the
close animation starts, the animations would happen on a hidden layer (all
black).

This patch moves the calls to content_window->Hide() to the
DesktopWindowTreeHost implementations, and changes DesktopWindowTreeHostMus to
hide the WindowTreeHost first. This ensures animations in ash operate on the
content.

I tend to think hiding the content is entirely unnecessary, but I am not about
to try to tackle that here.

BUG=855658
TEST=covered by test


Change-Id: Ie07775beecc2a6627ac2d7c6e0c57ad563bbb8d1
Reviewed-on: https://chromium-review.googlesource.com/1130502Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573555}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/03053f998fa6..dd9855c6d184


git log 03053f998fa6..dd9855c6d184 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 dgarrett@chromium.org Revert "chrome_committer: Implement git cl auth workaround."


Created with:
  gclient setdep -r src/third_party/chromite@dd9855c6d184

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:860584
TBR=chrome-os-gardeners@chromium.org

Change-Id: I42ff0f859829555fa0a9de854c464ecb3f64308c
Reviewed-on: https://chromium-review.googlesource.com/1130182Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573554}

We can express the sequencing operation by leveraging the
sequenced order that observers are notified and remove the need
for a stateful inner class.

Bug: None
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I48988d4f82e0ad0b77c085123173b67c5acc6930
Reviewed-on: https://chromium-review.googlesource.com/1129376Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573553}

The title bars should not visible while animating overview mode. This cl
hides the title bar if needed and waits until the next paint before
animating the windows. This will hide the title bar as expected while
keeping the benefits of DeferPaint.

Test: manual
Bug: 843851
Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024
Reviewed-on: https://chromium-review.googlesource.com/1112774Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573552}

BUG=762641
TBR=oshima@google.com

Change-Id: Ib25cae8dee9ae82cb2567d99abd2603f3a594125
Reviewed-on: https://chromium-review.googlesource.com/1128759
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573551}

Since the width is given in pixels which is correct
only on the display with the same DSF, the width needs to
be multiplied by phanton window scale / source scale.

BUG=861967
TEST=Manual. See bug for repro step.

Change-Id: Ib073bb705d8998cf07f41f9d646f0c23828b48de
Reviewed-on: https://chromium-review.googlesource.com/1130595Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573550}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9b520351974..1e61e482fbbb


Created with:
  gclient setdep -r src-internal@1e61e482fbbb

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6534d37e6c439320fa041f365372f430727328c0
Reviewed-on: https://chromium-review.googlesource.com/1130183Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573549}

The text representation can be easily copied to the symbolization service.

BUG=803276

Change-Id: Ice8157f0ba7544be4b300d5a97df36d41cc02db6
Reviewed-on: https://chromium-review.googlesource.com/1130498Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573548}

On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.

Instead, we should keep the slice info when resume with an error.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug: 837128
Change-Id: I59ddb7ff57551beb862884febe2de3f3ee9e1359
Reviewed-on: https://chromium-review.googlesource.com/1130349Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573547}

Methods, like .complete(), show(), etc. always return a new object. They
should probably be marked as [NewObject].

This is no behavior change. So, no requires a "intent to implement".

Releated spec change:
  https://github.com/w3c/payment-request/pull/746

Bug: none
Change-Id: Ib4646a77ab7426310c42011d69c410ef104a91a4
Reviewed-on: https://chromium-review.googlesource.com/1128825Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573546}

This CL refactors RulesMonitorService. In particular, inner classes
FileSequenceState and FileSequenceBridge are introduced to handle the file
sequence operations. Also, while loading a ruleset on the file sequence, instead
of hopping directly to the IO thread, we return the result to the UI thread,
which then decides what to do. And unloading a ruleset now proceeds directly to
the IO thread instead of hopping to the file sequence first. This refactoring is
in preparation for a subsequent CL which will handle indexed ruleset corruption.

This CL does not introduce any behavior change.

BUG=852058

Change-Id: Idad96dcacc4563c1936890daf3c7bd548b9d4319
Reviewed-on: https://chromium-review.googlesource.com/1119635
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573545}

I don't know what ui/latency does, but the test is small and builds
and runs fine, so just run it.

Also remove now-empty and currently-unused non_mac_chromium_gtests.

Bug: 843511
Change-Id: I71abcab45133bb235f268f34e4df6097758867d4
Reviewed-on: https://chromium-review.googlesource.com/1129680
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573544}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ie3dea1da3f7a42b0454a79ea1ca77a153629ddc9
Reviewed-on: https://chromium-review.googlesource.com/1126174Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573543}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92745a5b0e2e..c3975e55e146


git log 92745a5b0e2e..c3975e55e146 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 sergiyb@chromium.org Allow using pipes to specify properties for buildbucket.py


Created with:
  gclient setdep -r src/third_party/depot_tools@c3975e55e146

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I47a9711bedb0ce4912dc418e09a8f69cd1566b26
Reviewed-on: https://chromium-review.googlesource.com/1130184Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573542}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ida5724a5c8587a72c2474189f8888e6c23b12f24
Reviewed-on: https://chromium-review.googlesource.com/1126206
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573541}

* Add back boostForPendingView logic accidentally removed in r554797
* Send updates when frame depth changes, which was missing in r546622.
  Note this fix is limited to OS_ANDROID to maintain the desktop
  workaround for crbug.com/560446
* Also improve testCrossDomainNavigationDoNotLoseImportance to also
  log the calling stack on failure.

Bug: 861826
Change-Id: I0757647a81228a9bfc5fda02d775f62fb6bee723
Reviewed-on: https://chromium-review.googlesource.com/1128573Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573540}

PrepareWriteValue is a procedure to reliably write to GATT
characteristics in a GATT service. A client can PrepareWrite to
various characteristics in a reliable write session and Execute or Abort
those writes later.

For now, BlueZ handles prepare writes by caching them and then sends out
regular write requests to the application in the case of commit, or
silently drops them in the case of abort.

We keep the caching in BlueZ but implement a new function named
PrepareWriteValue() such that applications can tell prepare write
requests from regular write requests. Since BlueZ only sends out the
write requests when the remote device commits, applications not
interested in achieving reliable writes can safely regard all prepare
write requests as regular ones.

A relevant patch is crrev.com/c/1094214

Bug: b:78650442
CQ-DEPEND: CL:1094214
Test: Pass Android CtsVerifier test on GATT server reliable write
Change-Id: If2464cf3a17e7c91dc11dc8f4c37734a2987543e
Reviewed-on: https://chromium-review.googlesource.com/1094316
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573539}

BUG=859649
TEST=Covered by unit test

Change-Id: I9c662852659aec26034d0992f530398b5121ad2c
Reviewed-on: https://chromium-review.googlesource.com/1124878Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573538}

The API used to retrieve the list of layouts does not reflect the
order of the layouts in the control panel.  I don't see another
Win32 API which would give us that ordering so I am now grabbing
the current layout and swapping it with the first element to ensure
it is evaluated first.

BUG=832811

Change-Id: Icef22303e38be4b2680ad8636ba408fcb81239a2
Reviewed-on: https://chromium-review.googlesource.com/1130455Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573537}

We need to use the pref in components, so move the pref to ui/base so it
can be accessed.

TBR=jam@chromium.org

Bug: 729596
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iffc7c5c2f459340c14a74787defeab00c6c5589c
Reviewed-on: https://chromium-review.googlesource.com/1125143
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573536}

The FileSystemProvider API tests load up platform apps that rely on an
external extension's web accessible script to be injected. This script
would normally be blocked by the platform app's CSP. Update the tests to
use an explicit CSP allowing the extension's resource.

Bug: 861815
Change-Id: Ifd2ce1ce01cb6578663b10ac11940cd9a066769f
Reviewed-on: https://chromium-review.googlesource.com/1129473
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573535}

CreateSimpleURLLoaderWithVariationHeaders.

Tons of people call AppendVariationHeaders() with variations::SignedIn::kNo with
the following comment:
  // Note: It's OK to pass SignedIn::kNo if it's unknown, as it does not affect
  // transmission of experiments coming from the variations server.
This CL simply make a version without the sign-in parameter of
AppendVariationHeaders and CreateSimpleULRLoaderWithVariationHeader and remove
those many comments in the code.

BUG=857127

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id0af5394ce31b117e109033f44a43720d4407197
Reviewed-on: https://chromium-review.googlesource.com/1121669
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573534}

BodyStreamBuffer has a ReadableStream instance, but because it's
implemented in V8Extra we cannot holds it as a member (i.e., as a
ScriptValue). Instead, we attach the value to the JS wrapper of the
C++ object. This required us to maintain chains of wrappers,
FetchEvent -> Request -> BodyStreamBuffer for example, manually.

This CL replaces that mechanism with wrapper tracing.

Bug: None
Change-Id: I889ef0d0442d62ad50826a4b487ec234f041a982
Reviewed-on: https://chromium-review.googlesource.com/1124270Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573533}

This change solves two problems related to font colors:
* Changes passed down from UX have requested the use of the subtext/hint
  color for all text in footer rows.
* A bug causes text colors to change (permanently) to incorrect values
  when hover styles are applied. This was observed on Linux under GTK+
  theme only. We don't need to modify text colors during RefreshStyle
  anyway, so the simplest fix is to define these at initialization and
  not touch them again.

Change-Id: I80d2de91bb7067b3dc8fea6f369c83658e15c22a
Bug: 861883, 859887
Reviewed-on: https://chromium-review.googlesource.com/1130015
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573532}

The code stopped working when paper-icon-button-light was updated to its
latest version, which changed the structure of the DOM.

Bug: 860854
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0c7189752a5ae47eab0024e3e81775a5f93ee7b6
Reviewed-on: https://chromium-review.googlesource.com/1128463Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573531}

This CL connects |enable_canvas_2d_image_chromium| on CrOs, enabling
use of GpuMemoryBuffers for blitting the Skia produced textures onto.

GMBs on CrOs are GL_TEXTURE_EXTERNAL_OES, which can't be used to
CopyTextureCHROMIUM() onto, so CanvasResourceGpuMemoryBuffer gets
a new member (a 2D texture ID), connected to the same GMB, to be
used for that purpose.

Also as pointed during the review, there's no need to hold on to a
Image2DChromium as long as it's bound to a texture (to which we
hold on to), so removing the current |image_id_|.

Bug: 839970
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I375451cca8f4e29e8fd40a4e6aaadc1a49bcd398
Reviewed-on: https://chromium-review.googlesource.com/1056168
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573530}

Outlines should always be rectangular, and the outline paint code forces
the outer/inner radii to zero.

But the shared paint code in BoxBorderPainter::DrawDoubleBorder does not
enforce zero-radii when computing the intermediate double edges.

Update DrawDoubleBorder() to avoid rounded intermediate edges when the
exterior edges are not rounded.

Bug: 861816
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I81cfccfbb3f14568a0aeacb065fc447f583f28c8
Reviewed-on: https://chromium-review.googlesource.com/1129334Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573529}

Bug: 805612
Change-Id: I86af86a62fe2e46691db6bfb2b24da404c93ec1d
Reviewed-on: https://chromium-review.googlesource.com/1130059
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573528}

Proposing to add myself as the owner since I have been maintaining and reviewing
these files and looking forward to cleanups and adding more profiles support
soon.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I73e637c376e91df209f759fb55d5f6ba8d86a219
Reviewed-on: https://chromium-review.googlesource.com/1130230Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573527}

This both helps organize the members of UkmRecorderImpl a bit, and
also simplifies the code for Purge(), so that it doesn't need to know
about all of the different fields. This should help make it harder to
accidently add a new field and not delete it during a Purge().

Change-Id: I49558468cfb491c34ef76d2c2801aae72ddc8364
Reviewed-on: https://chromium-review.googlesource.com/1054142
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573526}

https://chromium.googlesource.com/angle/angle.git/+log/d7890bca9b35..c56adf60d141


git log d7890bca9b35..c56adf60d141 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 tobine@google.com Roll Vulkan repos fwd as of 7/3
2018-07-09 jmadill@chromium.org Vulkan: Add driver uniforms set.
2018-07-09 jmadill@chromium.org Vulkan: Roll SPIRV-Tools and SPIRV-Headers.
2018-07-09 jmadill@chromium.org Vulkan: Make DynamicDescriptorPool single pool.
2018-07-09 geofflang@chromium.org Vulkan: Support EGL_ANGLE_surface_orientation for vertical surface flipping.
2018-07-09 jmadill@chromium.org Return an Error from ContextImpl::syncState.


Created with:
  gclient setdep -r src/third_party/angle@c56adf60d141

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I0a67fff7f7d0db7042c340605d9ae848407a64e6
Reviewed-on: https://chromium-review.googlesource.com/1130180Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573525}

This CL replaces base::Timer with its subclasses.
As base::Timer changes its behavior subject to its construction time
flags, that makes hard to see the actual timer behavior, especially
it's unclear when a timer is injected from other components.
Also, that OnceCallback support of base::Timer is hard to implement on
the dynamically determined invocation pattern.

Bug: 850247
Change-Id: I2a7a85a39ba25da01cec2b151d2911f7dba8029a
Reviewed-on: https://chromium-review.googlesource.com/1128691Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573524}

Bug: 860699
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3845e42fb4bde966077406d8553a9b74c9a46c22
Reviewed-on: https://chromium-review.googlesource.com/1128177Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573523}