- 16 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6fbe4e685f0..938b4532b48f git log a6fbe4e685f0..938b4532b48f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 reed@google.com Revert "transition matrix44 to opt-in only" Created with: gclient setdep -r src/third_party/skia@938b4532b48f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Id49df72286dc274f9cbeffe6cc4fbc9439775f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759627}
-
Rainhard Findling authored
* Deprecate the |ENABLED| SB state in safety check and use |ENABLED_STANDARD| and |ENABLED_ENHANCED| states instead. * This CL updates the JS side of safety check. The C++ side is updated in crrev.com/c/2141983. Bug: 1015841 Change-Id: I24388fec9060eebe43dbfb7f537dd88080560fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148735Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759626}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 82c12e80. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" 9c8b766c "[css-grid] Migrate grid-auto-fit-rows.html test to WPT" 9373f79e "[css-grid] Migrate grid-baseline.html to WPT" b792b260 "[css-grid] Migrate grid-baseline-margins-1.html to WPT" 44402a06 "[css-grid] Migrate grid-baseline-margins-2.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I97b5ef280eff559728efe1418eb5c95402f1925f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151968Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759625}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fill, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I2b2f2d02ecdb250a42b38ac4b5773c546ce9e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147487 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759624}
-
Andrey Zaytsev authored
This state is present on non-Google branded browsers, where it is not possible to check for updates directly. In this case Safety check simply prints out the current version. Bug: 1015841 Change-Id: I23e54330366fb722f36a7b6732970c0627a9a705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144038Reviewed-by:
-
Daniel Cheng authored
- roll.py has been updated to apply local patches *before* attempting to configure libxml. This allows issues at Makefile generation to also be locally patched if needed. - roll.py now uses input redirection for applying patches, so missing patch files are now a fatal error. Missing files would previously be ignored, since only the exit code of the final command in a sequence of piped commands is considered for success/failure. - libxml2-2.9.4-security-CVE-2017-7376-nanohttp-out-of-bounds-write.patch is no longer needed. This has been fixed an alternate way upstream, though it is somewhat unclear why parsing a port number larger than 65535 is desirable. - revert-non-recursive-xml-parsing.patch: recursive to non-recursive conversion of XML parser is causing test failures. - add-missing-ifdef-in-xml-reader.patch: add a preprocessor check around error handling for a feature that is disabled in Chrome. Change-Id: Iee172f9142146224b70cc35d3b97ced6786c1b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142719Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759622}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51591a540007..d67b97dfbac8 git log 51591a540007..d67b97dfbac8 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 taylori@google.com perfetto-ui: Fix time slider Created with: gclient setdep -r src/third_party/perfetto@d67b97dfbac8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153765614 Tbr: perfetto-bugs@google.com Change-Id: Ic1372c1ab13aa3730b36e5eddc5a719e5e50f7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152428Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: Ib7d476bc45aa3d2364c6d723d6b085f25632651f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144021 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Oleh Lamzin authored
Remove logic that checks whether MAC address source property on USB Ethernet adapter must be updated. This logic is complicated and doesn't work very well. For example, 0. policy value for MAC address source is "designated_dock_mac" 1. device is not link up and has MAC address source property equals to "designated_dock_mac" 2. we send request to change MAC address source to "usb_adapter_mac" 3. device is link up, but MAC address source property hadn't been updated, so we update path to primary USB Ethernet adapter 4. device MAC address source property was updated to "usb_adapter_mac", but we see that primary USB Ethernet adapter didn't change and policy value is still the same. Here we have to verify that primary Ethernet adapter still has correct property. After applying this CL, each time there will be property value verification. Side effect of this CL is that we may send the same request to shill few times. In practice, it's only 2 requests. BUG=b:152425041 TEST=manual end-to-end TEST=existing unit tests Change-Id: I773aeff67d0aae9a2bb5e7172e3677dbd8a18141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150598 Commit-Queue: Oleh Lamzin <lamzin@google.com> Auto-Submit: Oleh Lamzin <lamzin@google.com> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759619}
-
Anders Hartvoll Ruud authored
This is the "Keyframe Animation Inconsistency" described in the initial StyleCascade design doc [1] (see Appendix). This was fixed at some point during the StyleCascade work, probably when interpolations started using the same StyleCascade instance as the main declarations. The test only asserts equality between the standard and custom property cases, while ignoring absolute values, as browser disagree wildly on what that value should be at the moment [2]. [1] https://docs.google.com/document/d/1HrmPmcQBTUMouqQQG3Kww43I5aFW9-Q9tr-DEKZk09I [2] https://github.com/w3c/csswg-drafts/issues/3751 Change-Id: I1447aea439fe60cce1d280b0310a0983e71155b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150432Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759618}
-
Andrey Zaytsev authored
Bug: 1015841, 1068587 Change-Id: I84a2b48fb179a5d8959864cf4429a18130ca2d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141983Reviewed-by:
-
Michael van Ouwerkerk authored
This is particularly important for persistent notifications in their current form, because having multiples on screen is not helpful. Change-Id: I52a92095124c60de14ad8032dd5b53dbd724145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144076Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759616}
-
Harald Alvestrand authored
This change makes sure the SetLocalDescription completes before we call SetRemoteDescription. If we don't wait, we will sometimes see a change to have-remote-offer rather than the expected change to first have-local-offer, then stable (and then have-remote-offer, but the test doesn't wait for that). Bug: chromium:1071329 Change-Id: I7eaa06a71edff92e76448ac2ef1fdfecee795ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152446 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759615}
-
Hidehiko Abe authored
This is preparation to support LaCrOS Chrome. BUG=chromium:1043804 TEST=Ran tryjob. Change-Id: I6036f44cedab76560d6d1c0031aa030870707a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084774Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759614}
-
Victor Hugo Vianna Silva authored
No behavior is changed. The interface methods are altered to return an optional ModelError instead of the older SyncError. To achieve this, some helper methods in the implementations must be changed in that same way, which is a natural step in the final goal of eliminating the SyncError class. Change-Id: I7211eb1613aabb8bce9273765c943a3ec1fd958c Bug: 1057577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093482 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759613}
-
Harald Alvestrand authored
This avoids some MSAN error messages. Bug: chromium:787254 Change-Id: If01797d8bd1a57ea44a151ad3bdd74e3cb4aecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152365 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
The following histograms were removed after M80 because they are only relevant for the deprecated and deleted bookmarks sync directory implementation: - Sync.BookmarksModelSyncStateAtNewDuplication - Sync.BookmarksDuplicationsAtAssociation Code has been removed in http://crrev.com/c/1863808 Bug: 1053166 Change-Id: Iabdbe8ffd467c395756eeb43e080fb3e1a8f6bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148322 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759611}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/159f3561ccfa..5491b2a8263c git log 159f3561ccfa..5491b2a8263c --date=short --first-parent --format='%ad %ae %s' 2020-04-16 fancl@chromium.org Cleanup old versions when push-on-green Created with: gclient setdep -r src/third_party/catapult@5491b2a8263c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I253821c5f342406f9843dfa3f306949bb34e3d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152426Reviewed-by:
-
Victor Hugo Vianna Silva authored
The caller of this method now only uses the error field of the returned SyncMergeResult, and lives under the Unified Sync and Storage directory, so this CL changes the return type to base::Optional<syncer::ModelError> instead. The implementations of the interface are refactored to remove the logic that previously filled the remaining fields of the merge result. Bug: 1057577 Change-Id: I9f2f5d32e3f3379d0cd9cd50714be248483ff9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087914Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4099.3-1586165807-benchmark-84.0.4111.0-r1 to 84-4103.6-1586774345-benchmark-84.0.4114.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I93e36fb29be364c6252ec5745fa72fe60c953030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152433Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I23abdf2174ab06c59f6ad20586f93edb3b039abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146905 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 84-4091.0-1586169474-benchmark-84.0.4111.0-r1 to 84-4099.3-1586770550-benchmark-84.0.4114.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3407c607bc982b90ce6a82551a343622d4ff24cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152434Reviewed-by:
-
Ayu Ishii authored
This chance adds some minor cleanup and a few additional test cases. Change-Id: I938afe6d596bdbe4c6a520ab76622dfc3f6f3f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137486 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759605}
-
Nazerke authored
Coordinator. This CL modernizes the ToolbarContainerCoordinator to use |browser| in the initializer. Also this change updates ChromeCoordinator by removing the deprecated initializers and updates all subclasses. Bug: 1029346, 1048396, 1068614 Change-Id: Ibdfe654ce92b6a7722cbc74b72c6c6b42c00ea2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139668 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759604}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I6507b9fd4176e4ed08d2fc47637963259b133c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145743Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759603}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 84-4099.3-1586167754-benchmark-84.0.4111.0-r1 to 84-4103.6-1586771664-benchmark-84.0.4114.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id74cb2b2bfd0400cd5e85f9f1afd9dd468a8e1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152431Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49ad8eaae192..5f3889a6dff8 git log 49ad8eaae192..5f3889a6dff8 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src c018fc6ae667..61b7de3c39f0 (2 commits) Created with: gclient setdep -r src/third_party/angle@5f3889a6dff8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I8d967d832d41f9c0053f15b47ad9e761c6afcbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151530Reviewed-by:
-
Wez authored
Migrate the FuchsiaSystemLogging test from the deprecated DumpLogs() API to DumpLogsSafe(). Bug: 1070664 Change-Id: Ib78ac00881359229e82aff7bba077f781c88a4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149416 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759600}
-
Miyoung Shin authored
CL migrates clip-path-reference-restore.html to external/wpt/css/css-masking/clip-path/, adding links to the relevant specs and a test assertion describing its purpose. BUG=1063749 Change-Id: I2edd1a97f7c99dd70710c88a1d9f67c6feeff852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143176 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#759599}
-
Victor Hugo Vianna Silva authored
The value for the access point is now set in the PasswordAutofillManager and plumbed up to the ShowDiceAddAccountTab call. With this change, this value can now also be verified in a unit test for that class. Bug: None Change-Id: I2efa2b4a39d4f565609650583f5a2e1666042d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148750Reviewed-by:
-
Victor Hugo Vianna Silva authored
Before this CL, every caller of the PasswordManagerClient's reauth API used to set the opt-in pref upon success. Now this is taken care by the AccountStorageAuthHelper. Bug: 1070944 Change-Id: I354e10516ac759aa52ee07a8d8a130c7087bbc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149655Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Miyoung Shin authored
CL migrates clip-path-transform-mutated.html to external/wpt/css/css-masking/clip-path/, adding links to the relevant specs and a test assertion describing its purpose, renaming it to clip-path-transform-mutated-002.html. BUG=1063749 Change-Id: I1639669d37fdd01893a7bbaaadab07a8e4abc692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145389 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline-must-respect-grid-order.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-004.html. BUG=1063749, 767015 Change-Id: Ie0427d83993ec9b5e67b33652bc25b1bca32e1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147759 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759595}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fit, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I8230eb65c8c143c2dc5b51fd6178a525f6523564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148913 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Michael Lippautz authored
Existing work found a new home in V8 as cppgc. Bug: chromium:1056170 Change-Id: Ic7f159a6432792787d552f0fc53eca8b3fffef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151588Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759593}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ChromeAppModule class. While ChromeAppModule generates |ChromeAppModule_ProvideLastUsedProfileFactory| class to deliver regular profile with dependency injection, with this change it will generate |ChromeAppModule_ProvideLastUsedRegularProfileFactory| for the same purpose to reduce the naming confusion. Bug: 1041781 Change-Id: I27e1e9e8e19a5b0cf5326539a624261ef3fe0901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149323Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759592}
-
Gauthier Ambard authored
This CL adds a test to make sure we don't display the NTP if the loaded page is an interstitial page. Fixed: 1067250 Change-Id: If0b28650148acee4f1379028826ca1cc603834f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151451 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759591}
-
Mugdha Lakhani authored
PageInfoController no longer depends on InstantAppsHandler and VrModuleProvider, and instead gets this info from ChromePageInfoControllerDelegate. Bug: 1052375 Change-Id: I7050f105b10d6e78873f185e5516c2df318c8936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144016 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759590}
-
Alex Rudenko authored
The inspect mode does not work if there is a highlighted frame. With this change, the inspect tool gets reset from the frame highlighting to the default tool once the mouse moves. The new behavior affects NodeHighlightTool only. Fixed: chromium:999440 Change-Id: I6bfe1f5587fea18b1aa23c389812231ac52b3b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150430Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759589}
-
Rainhard Findling authored
* For non-Google-based browsers, |VersionUpdater| returns a "updates disabled" state. Until now, safety check displayed this as a generic error. * This CL adds a "unknown" updates status, which displays the current version of the browser in the safety check update status. * This CL updates the JS side. The C++ side is updated in crrev.com/c/2144038. Bug: 1015841 Change-Id: Ied9d8cc1b07ba6f12494b2e253a8f7f90e4f3375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148778Reviewed-by:
-
