- 15 May, 2018 40 commits
- 
- 
Andrey Kosyakov authoredBug: 838777 Change-Id: I8a1a049ade70cadfebabc8115471732f15432ac1 Reviewed-on: https://chromium-review.googlesource.com/1058372Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#558736} 
- 
Qiyu Hu authoredTwo relevant patches are ag/4013275 and crosreview.com/1043496. Bug: b:78593133 Test: Pass test CtsVerifier test on MTU exchange Change-Id: I527dee3d105d3b3db744f550c2c7003789d65c57 CQ-DEPEND: CL:1050621 Reviewed-on: https://chromium-review.googlesource.com/1058328Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#558735} 
- 
Jennifer Apacible authoredCq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f84ea07d53d29dc967645d12b3c27654e19fc8c Reviewed-on: https://chromium-review.googlesource.com/1058388Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Adam Parker <amp@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#558734} 
- 
Owen Min authoredChange the order to match the enum.xml. Bug: 843141 Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8 Reviewed-on: https://chromium-review.googlesource.com/1059579 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558733} 
- 
James Cook authoredThere are flaky failures in ash::tray::MultiProfileMediaTrayView likely due to a race between media capture code's idea of the number of users vs. ash::SessionController's idea of the number of users. Disable the test while that gets sorted out. TBR=xiyuan@chromium.org Tbr: xiyuan@chromium.org Bug: 842442 Test: browser_tests Change-Id: I8f80484190830aafb45ce4683be12206708d3ecc Reviewed-on: https://chromium-review.googlesource.com/1059704Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#558732} 
- 
James Cook authoredCreate one touch hud views::Widget per display and open/close new widgets as displays are added and removed. Bug: 840380 Test: run chrome --show-taps-app and add/remove displays Change-Id: I21c87b35ec520bd1501f0cbf02c073d030c7ff64 Reviewed-on: https://chromium-review.googlesource.com/1058591 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#558731} 
- 
Qiang Xu authoredBug: b/78193960 Test: covered by added tests Change-Id: I69d5651a76af3f49a39669f9ef10c2dae3718e7d Reviewed-on: https://chromium-review.googlesource.com/1058594Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#558730} 
- 
Eugene But authoredDownload Manager UI does not support multiple downloads per Tab. When the second download is requested DM can either prompt the user to replace the download or just silently drop the request. Before this CL download request would be silently dropped if the user typed the url into omnibox. This CL changes the login to prompt the user. It is still the desired behavior to silently drop the request if the download was initiated by the web page to prevent page from spamming the user. Bug: 837602 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I262d3ef98c52995229567823e79df355761bff65 Reviewed-on: https://chromium-review.googlesource.com/1033332 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#558729} 
- 
Rayan Kanso authoredRemove custom Serialization and Deserialization logic used in background fetch. Bug: 826257 Change-Id: If9e13dd6bbffa0a521209f7cabbe5ed0f3d08991 Reviewed-on: https://chromium-review.googlesource.com/1059658 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#558728} 
- 
Brian Salomon authoredThis reverts commit 835ae72c. Reason for revert: Fix for MSAN issue landed here: https://skia.googlesource.com/skia/+/3d945e840c1955b5756fdeb696599c2818ed95fc Original change's description: > Revert "Use Skia's new simplified read/write pixels code paths" > > This reverts commit 6d0559c0. > > Reason for revert: Breaks ImageBitmapTest.AvoidGPUReadback on MSAN, e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F9783%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Flogs%2FImageBitmapTest.AvoidGPUReadback%2F0 > > Original change's description: > > Use Skia's new simplified read/write pixels code paths > > > > Bug: 826819 > > Change-Id: Ia6eaca75fe43f9d9ec94f8fe644a44e8e7436675 > > Reviewed-on: https://chromium-review.googlesource.com/1054520 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557943} > > TBR=bsalomon@chromium.org,robertphillips@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 826819 > Change-Id: Ia4dca1186fbb79569672fbf5cdabd9657c702762 > Reviewed-on: https://chromium-review.googlesource.com/1056847 > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558215} TBR=bsalomon@chromium.org,timloh@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826819 Change-Id: Idd8043535288d6f224531f90d381f85ca548c01d Reviewed-on: https://chromium-review.googlesource.com/1059793Reviewed-by: Brian Salomon <bsalomon@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#558727} 
- 
spqchan authoredThis CL refactors RenderViewContextMenuMac by moving the logic to show a Cocoa menu into a RenderViewContextMenuMacCocoa class. To show the context menu using Views, this CL adds a RenderViewContextMenuMacViews. Bug: 837230 Change-Id: Id07f9e758278638c6fc47003de1055d9357ed1fa Reviewed-on: https://chromium-review.googlesource.com/1056468Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558726} 
- 
Mark Pilgrim authoredBug: 773295 Change-Id: I6be6adefab29b5d4e67013f45ba5ffe4e058dbdc Reviewed-on: https://chromium-review.googlesource.com/1030062Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#558725} 
- 
Steve Kobes authoredBug: 823365 Change-Id: I7fbf12296ec51b3685833f26371fe5f9467a6591 Reviewed-on: https://chromium-review.googlesource.com/1058128Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558724} 
- 
Gary Kacmarcik authoredSee spec: https://wicg.github.io/keyboard-map/ Bug: 832811 Change-Id: I74bf2ecd3581bd4e68a1c17390b24101a79721ab Reviewed-on: https://chromium-review.googlesource.com/1053398Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#558723} 
- 
https://webrtc.googlesource.com/src.git/+log/5702736f7e46..59216ec4a415 $ git log 5702736f7..59216ec4a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6549be88db6a4034fee7a2ae8ac98357efd7813b Reviewed-on: https://chromium-review.googlesource.com/1059575 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558722} 
- 
Ricky Liang authoredWe should discard the incoming capture GpuMemoryBuffer and return when VideoCaptureDeviceClient::OnIncomingCapturedGfxBuffer fails to reserve the I420 output buffer. Otherwise we'll end up crashing. BUG=b:79729317 R=emircan Change-Id: I616d97ca618ad9cc40abdf9d1a8f06ce568cfbb0 Reviewed-on: https://chromium-review.googlesource.com/1059495Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558721} 
- 
Robert Sesek authoredWhen the browser detects that a renderer is hung (via not ack'ing input events), it displays a hung-page dialog. On Windows, if the user chooses to kill the page, the browser will generate a minidump for the hung process for post-mortem analysis. This CL implements the same on Mac. Bug: 842806 Change-Id: I2d50fc7395fc6c4fe080a5cc05bfcee8f4f36e79 Reviewed-on: https://chromium-review.googlesource.com/1058009 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558720} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/6bbd386a0e4b..81f60ecd9cc0 $ git log 6bbd386a0..81f60ecd9 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 reed Allow slides/gms to extend the UI Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ie5bab037e74f8928abc8fc0ec0f04254d231b3d6 Reviewed-on: https://chromium-review.googlesource.com/1059577Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558719} 
- 
Rayan Kanso authoredBug: N/A Change-Id: I8874134483806c01323042ad7593125e1e2c7b35 Reviewed-on: https://chromium-review.googlesource.com/1059782Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558718} 
- 
Allen Bauer authoredGetOpacity() didn't handle the active tab case where the close button should be always visible. Bug: 822061 Bug: 842218 Change-Id: Id91e5ab402fb1e9e249f8cb60d1a26a3c9a3c46e Reviewed-on: https://chromium-review.googlesource.com/1055648 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#558717} 
- 
Hans Wennborg authoredIt's already excluded manually from almost all Android bots. For some reason this also enables it on some chromium.clang and chromium.memory bots. If it turns out to fail there, we can add exclusions. Bug: 842698, 840756, 843134 Change-Id: I6c119b5272163a41676f1a0f8b7a2081631c9564 Reviewed-on: https://chromium-review.googlesource.com/1059780Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558716} 
- 
A Olsen authoredRight now we use only single-line textboxes. It is difficult for admins to make a large JSON dict fit into a single line textbox, so this change displays a multiline textbox instead in the following situations: - Only in Chrome OS policies - not for Windows. (We could also turn this on for windows once we have checked for side effects.) - Whenever an policy of type 'dict' or 'external' is expected. - Whenever a policy of type 'string' that is actually JSON is expected. As of this change, we will also still show a single-line textbox along with the multiline, so that admins can still see the old single-line value, since the two types of textboxes aren't completely compatible. Eventually, we can stop showing the single-line textboxes. See the attached bug for more information. Also: Show more example values in help-text - - for dicts and external, not just for list + string. Bug: 829328 Change-Id: Ic095d0e54dd324437dcfe89ef60c34a31f8ae16b Reviewed-on: https://chromium-review.googlesource.com/1007082 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#558715} 
- 
Erik Staab authoredR=tandrii@chromium.org Bug: 731967 Change-Id: Ie0d2a57cfb398032a9278324791dba6167b74aa0 Reviewed-on: https://chromium-review.googlesource.com/1058531Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558714} 
- 
Michael Lippautz authoredInstead of emitting write barriers for single writes in HashTable, conservatively emit a barrier for the backing store during rehashing. This moves us in the tradeoff space: - Removes 40KiB of binary bloat - Avoids emitting barriers when re-inserting single elements which improves throughput for the case where incremental marking is off - Emits a single conservative barrier at the end of RehashTo. This potentially means that we (re-)scan more objects when incremental marking is on Bug: chromium:839514, chromium:757440 Change-Id: Ib5495c9e2210836424d7b26f2138d852f8dafec7 Reviewed-on: https://chromium-review.googlesource.com/1055400 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558713} 
- 
Ben Wagner authoredThis updates SkFontConfigInterface::SetGlobal calls to use the smart pointer version. This removes the awkward trailing ->unref and will allow Skia to remove the old non-smart version of this method. Change-Id: Icf67a1976820f5f0f07243ab1539e90e18db2ef4 Reviewed-on: https://chromium-review.googlesource.com/1058019Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558712} 
- 
Miguel Casas authoredSimplify logic around |enable_canvas_2d_image_chromium| in runtime_features.cc. Bug: 839970 Change-Id: I7371c6ce22e7a2c73013b75c8545e5fc91b983c7 Reviewed-on: https://chromium-review.googlesource.com/1057388Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#558711} 
- 
Joel Einbinder authoredThis makes VSCode a lot faster in the DevTools codebase by only autocompleting over the files depended on by this file. Change-Id: I94421969291a135a46673c02722e77f0d6709426 Reviewed-on: https://chromium-review.googlesource.com/1058680 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558710} 
- 
Hans Wennborg authoredIt's already excluded manually from almost all Android bots in test_suite_exceptions.pyl, and fails if we try to run it on [1]. It seems this test simply does not reliably work on Android, and so excluding it by default makes more sense. For some reason, this move also enables it on some chromium.clang bots. I'm not sure whether disabling it for those bots was intentional, but we'll find out. [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Bug: 840756, 842698, 843124 Change-Id: I4c40bbfe66943ad77e6f970f4ca3fa1a218166d3 Reviewed-on: https://chromium-review.googlesource.com/1059514 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558709} 
- 
Florent Castelli authoredThis is part of the onion soup efforts. Bug: 787254 Change-Id: If099833448584243d4b03586f100faf1939c4887 Reviewed-on: https://chromium-review.googlesource.com/1057309 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558708} 
- 
Alex Sakhartchouk authoredBUG=none TEST=flash device run through flings. Change-Id: Icb6363c8418df76d868cdf1cefa4268e0eebc980 Reviewed-on: https://chromium-review.googlesource.com/1059696Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#558707} 
- 
John Chen authoredReplace "no alert open" error with "no such alert", as specified in W3C spec. Bug: chromedriver:2420 Change-Id: Ide525e18bde7d6163e8a171e7574e9157846f16b Reviewed-on: https://chromium-review.googlesource.com/1054156Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558706} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium ac8e3260. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17650 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hta@chromium.org: external/wpt/webrtc mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=markdittmer No-Export: true Change-Id: I129f9043c5a90700469da2da4a57342b66931a64 Reviewed-on: https://chromium-review.googlesource.com/1059713 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558705} 
- 
Dmitry Gozman authoredThis class has generic purpose and is used in many places. At the same time, it has no relation to the rest of platform/text. This also reverses dependency between TextStream and geomtry primitives. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id3fd58afc94e25a2fad10ae2c49dc6494d80684b Reviewed-on: https://chromium-review.googlesource.com/1058267Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558704} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/075ca3000abf..35cefb8d8a2f $ git log 075ca3000..35cefb8d8 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 csharrison Introduce a BrowserOption for seeding a default profile Created with: roll-dep src/third_party/catapult BUG=chromium:823982 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ibe75061d90cddd4ed6e48831254b094521feaa76 Reviewed-on: https://chromium-review.googlesource.com/1059695 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558703} 
- 
John Chen authoredThe default color profile on Mac causes some adjusts to displayed colors, so that screenshots have different colors from expected. This caused some screenshot tests to fail. Fix by forcing srgb color profile. Bug: chromedriver:1857 Change-Id: I65aa784836e527fe8d1fa5ee3f45e50f19cdc9d3 Reviewed-on: https://chromium-review.googlesource.com/1058985Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558702} 
- 
rbpotter authored- Regenerate only for destination change, not id and capabilities - Try to reduce unnecessary updates of settings availability, by splitting updates that are based on document info from those based on destination. - Do not regenerate if media size vendor ID or name changes, since this is irrelevant to the preview generation, or when changing to custom margins. - Also fix the destinations dialog size, so that it does not change height as destinations load or when a search query is entered. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6d8f7052dca89a7894160d9e4eaf32e1184c5072 Reviewed-on: https://chromium-review.googlesource.com/1054140 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558701} 
- 
Max Moroz authoredBug: 833912 Change-Id: Ie6bff55a2f3af2c670367315efd21d063e0c317d Reviewed-on: https://chromium-review.googlesource.com/1054425 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by: Abhishek Arya <inferno@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558700} 
- 
Eugene But authoredBug: 842781 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I001fbaf3d100e173252aacde7b3cc4f28e28fa31 Reviewed-on: https://chromium-review.googlesource.com/1058378Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558699} 
- 
Emily Stark authoredBug: 839969 Change-Id: I5c0de5f31d997be815a2c956e279f06dc1047d84 Reviewed-on: https://chromium-review.googlesource.com/1058113Reviewed-by: Edward Jung <edwardjung@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558698} 
- 
Miguel Casas authoredThis CL introduces InSequence and s/const/constexpr/ in the GMB-related Canvas2DLayerBridgeTest cases. This is a minor preparation for crrev.com/c/1056168 where having the expectations in a sequence makes things clearer. Bug: 839970 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8b43341af1e7bbae50cf9a117e20867bf2628e73 Reviewed-on: https://chromium-review.googlesource.com/1058018Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#558697} 
 
-