- 13 Jan, 2020 40 commits
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 1041419 Change-Id: Ifda2bd08230bb9c9403bc8d82f8f97d564b00939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997921 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#730954}
-
Dominique Fauteux-Chapleau authored
Update the Deep Scanning DLP supported file types to mirror those currently supported internally. Change-Id: I93036341678cf4138eba429f0abd327fc800b618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991996Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#730953}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=dbeam@chromium.org Bug: 1041419 Change-Id: I56203e5f4245372031c8d5120d552a5b33caa9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997764 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730952}
-
dalyk authored
This is a reland of 834f2092 Now not squashing ERR_NOT_IMPLEMENTED to avoid disrupting existing InProcessBrowserTests. Original change's description: > Squash top level error code returned from host resolver. > > If the host resolution process fails, the top level error code should > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > found in ResolveErrorInfo. > > Bug: 1016325 > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728725} Bug: 1016325 Change-Id: If2d029ea94f1a85f95d641cf02e4283973316a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992191Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#730951}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1041419 Change-Id: I18ccdffc4fc953b70ed6389c0e3f24809f2301ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998649 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#730950}
-
Ian Kilpatrick authored
This patch requires the infra changed in: https://chromium-review.googlesource.com/c/chromium/src/+/1988376 Implements the logic required to select the correct baseline from a child and propagate it to its parent. This should fix the remaining baseline issues with FlexNG. Bug: 1038467 Change-Id: I166dcdc5b71f264734924f700e21c99a52786d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994064 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#730949}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mfoltz@chromium.org Bug: 1041419 Change-Id: Ic27e22f6c510f6892da29aa78af3e506c56b092d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997925 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#730948}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jhawkins@chromium.org Bug: 1041419 Change-Id: I8a59a74e2c57daef2143f6328f31798734224409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997990 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#730947}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1041419 Change-Id: Ib84c89b68833fa71528a3f2977d0dac6893acb0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998703 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#730946}
-
Adam Ettenberger authored
https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings The <area> tag should only be exposed as a Link with the Value Control Pattern if it has an |href| attribute. Adjusting the intrinsic role of AXImageMapLink to be Role::kStaticText if it doesn't have a link. Bug: 1040717 Change-Id: Icfa1c5e6d97f9bb8514df88b07b3768b36fc0d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994525Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#730945}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=yuweih@chromium.org Bug: 1041419 Change-Id: I0294a2309b33a72deba3f518f6efad470dc10ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998786 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#730944}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/15c442e941fb..e5cb8f2eff7e git log 15c442e941fb..e5cb8f2eff7e --date=short --first-parent --format='%ad %ae %s' 2020-01-13 rharrison@chromium.org Rolling 3 dependencies Created with: gclient setdep -r src/third_party/dawn@e5cb8f2eff7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iacece499b60f27d966c7118f4c6320adca792358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730943}
-
Steven Bennetts authored
Bug: none Change-Id: Iecd47b49f9f89aa43f36eb3f43388bb8eb3bec59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999060 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#730942}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1041419 Change-Id: I8505619899bde8bfea8cf098c00ea4aad0e0f990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998271 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This config contains the information necessary to configure an InfobarPasswordModalConsumer. Bug: 1030357 Change-Id: Ie5d68e53540bbf9f92617c792db2c14653a518c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996128 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730940}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 1041419 Change-Id: If30a489cd751d1764d1caede26136a2ee1dd8626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998292 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#730939}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1041419 Change-Id: Icfc1dab6a6aa67f8347ad83de8aa7b94296e4205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998667 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Re-enables BrowserMinidumpTest on ChromeOS except for on betty devices, where the issue that caused the tests to be disabled actually occurs. TBR=crouleau@chromium.org Bug: 1038043 Change-Id: I871f98842bc42c925e7cf0c05676d546316b7af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997653Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#730937}
-
Matt Simmons authored
This is a reland of 9d870f42 Original change's description: > Add a field trial config for ChromeStart. > > Bug: 1004441 > Change-Id: I9a5f182b9997fc0b6b61cf2b721d53fbc9c06ebe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946939 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Matt Simmons <mattsimmons@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721012} Bug: 1004441 Change-Id: I0e5a47214bfb0af87f03c84cc42024a0a1a0c79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997998Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#730936}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1041419 Change-Id: I57b749d5873cf687718a10adc072f02a9fe94853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998653 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 1041419 Change-Id: I3d2f1d21348882a527c1afd01fafec0fe4f60cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998862 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#730934}
-
yjliu authored
Bug:1035639 The purpose of this changelist is to help improve the performance on the ui when there is background blur. The related bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1035639 The general idea is to avoid recomputation of a background blur if the damaged regions under the blur surface don't intersect the surface, as any damage coming from above the surface doesn't contribution to the re-calculation of backdrop blur. A flag can_use_cached_backdrop_filtered_result_ is added to RenderSurfaceImpl to indicate if backdrop filter cache from last update can be used. The major changes here in this changelist are in DamageTracker and they are quite contained. It will be combined with another couple of changelists on GL side to fulfill the end goal. Description of the approach: This changelist is based on the presumption that any render surface has to have at least one layer contributing to it. In other words, in the 'tree' where all layers and surfaces pointing to their respective render targets, leaves can only be layers and vice versa, non-leaves can only be surfaces and vice versa. Even though the changes here are to serve to performance improvement of backdrop blur filters, they are written in a generic way so you can use the functions for other purposes where you see fit. To achieve the goal requires the damage tracker to be able to tell if any damage coming from below intersects a rect on the surface in question. This is done through the walk over all layers and surfaces to accumulate damage in DamageTracker::UpdateDamageTracking() [1]. As we know, when anytime we visit a surface in [1], all its ancestor render targets on the chain to the root have already accumulated all the damage from layers and surfaces below this surface. Whether this surface has accumulated damage on top itself is not relevant. So at this point, we only have to walk up the ancestor render target chain to root to see if any damage rect intersects the rect in question (backdrop filter surface rect). However this is not sufficient, as some layers and render surfaces that were in the previous update can be removed and no longer exist in the current update. If any of these layers and surfaces were below the surface in question, they need to be considered as well. This requires us to know the order of layers and surfaces when they are drawn to the same render target. I call these layers and surfaces siblings and added a prev_sibling_ and next_sibling_ pointers in RectMapData so each layer and surface in rect_history_for_layers_ and rect_history_for_surfaces_ points to both its immediate older and younger siblings. These pointers are to help track the draw order of siblings. When you go through the siblings through the prev_sibling_ pointer one by one, you get all surfaces and layers drawn before the current surface. This is how I did the damage intersection check. (There are more details. Please see code.) When a new layer or surface is added, the prev_sibling_ and next_sibling_ pointers have to be hooked up. This is done when each layer is iterated in [1]. Since we know the layers are visited once and only once in each update, I hook up the sibling pointers for the new layer when it is visited and walk up its ancestor render target chain to hook up the sibling pointers of each target until root or a target that already had the pointers hooked up. This ensures all layers and surfaces are hooked up. Possible further improvement: Backdrop filters sometimes have bounds (or clipping?), so maybe we could use the bounds or clipped region to do the intersection check with damage below the surface and the backdrop filter cache thus could take less space. Change-Id: I27e593ffce0046aa60c3eeca76961ce10e9511ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988155 Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#730933}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1041419 Change-Id: I9b6e47cc5b373c6e2b186a2185bfec96cbf841e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998627 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 1041419 Change-Id: I4a60f516570499f06808f65541f6209aca04b3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998274 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1041419 Change-Id: Ifa634f5939f17473ee3a01f4c4af538c3fa4cfea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994437 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 1041419 Change-Id: If9a6b90958cd60f7d6ac1886553e730cfa87be38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998344 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Avery Musbach authored
If you start dragging a minimized window from overview and drag to another display, the shadow bounds are too big, because the window is visually represented by a WindowPreviewView whose bounds extend outside the visually occupied area. Test: ash_unittests DragWindowResizerTest.DragWindowControllerWithCustomShadowBounds Bug: 961170 Change-Id: Ic0efbb1aa790f72a64d9559e5076ae37a3ff7a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995706Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#730928}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=seantopping@chromium.org Bug: 1041419 Change-Id: I2fb896607f48bb4ead0f20c016b1d268013caa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997715 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#730927}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=oysteine@chromium.org Bug: 1041419 Change-Id: Ic9e82356b306e7eb0ec62d5c124f602af0219c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998248 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#730926}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jsbell@chromium.org Bug: 1041419 Change-Id: I0d5089e4c5ce6d07cbeade73cae75ff7777e5099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998641 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#730925}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=estevenson@chromium.org Bug: 1041419 Change-Id: I1632310782bceaa6249095fc3e72d9a54ebece4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998959 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730924}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=battre@chromium.org Bug: 1041419 Change-Id: I2fd85c6d04ae7d06cc3175998bf50aaa71509c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998599 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#730923}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gab@chromium.org Bug: 1041419 Change-Id: Ib2a842e460df79dddc4a87dd4647563d12c8c487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998099 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#730922}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=tedchoc@chromium.org Bug: 1041419 Change-Id: I19e2fa142676ae22349656f9429447629aa69f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998257 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#730921}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1041419 Change-Id: Id1b9ec569f5ea61bfe99ee97f2e77570f1b1a5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998033 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#730920}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1041419 Change-Id: I682da943be78f7552e3599552f8dcb10ab73f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998501 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=aee@chromium.org Bug: 1041419 Change-Id: Ic610d63e280fc34e3fa870ee28f065862e51f26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998386 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#730918}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 1041419 Change-Id: Iceb59bcb8bcdaf87c0df9b2a70f4b0f02503ac94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998261 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#730917}
-
Wez authored
This argument has not been required since we migrated to publishing packages to VMs & devices via 'pm'. Bug: 895627 Change-Id: I972a2a40e7e655c8b4e0915f1868bfc31e549265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994919 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#730916}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 1041419 Change-Id: I6fc00babc06e91bff038f861de8851637d510d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997962 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#730915}
-
