- 26 Mar, 2020 40 commits
-
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I03a5fff56c973663e307cd01fb75bbac1aff162e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117731Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#753550}
-
Rohit Agarwal authored
The method testAllowPermissionDoNotLeakFromIncognitoToIncognito failed when CustomTabIncognitoManager#hasIsolatedProfile returns true. This happened because the test was missing a method call to request permission. This CL adds the method invocation and updates comments. Bug: 1035770 Change-Id: I4ca71b082a6140d79c2e4835d3e803099fb26232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120415Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753549}
-
Anastasiia Nikolaienko authored
Add component and strings for parent info screen. Move edu-login-button position CSS to shared CSS file. Update template to allow scrollable content. Screenshot: http://screen/ty41uTYuCQO Bug: 1043108 Change-Id: Iea78f81e8469a41ca17357e891355676bf57d8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010963Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#753548}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8c6c0e0f3a6..ee2ec6de995b git log d8c6c0e0f3a6..ee2ec6de995b --date=short --first-parent --format='%ad %ae %s' 2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 107e4e989e94..6719f54ac7ce (6 commits) 2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 772d2084..16171704 (389 commits) Created with: gclient setdep -r src/third_party/skia@ee2ec6de995b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I837d2815d36b92c241a094e0b286a16c3ca93f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121761Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753547}
-
David Jean authored
Use AppGround to open "learn how" link. Bug: 1045455 Change-Id: Ic9c8bb4c12a51804f2d95510d401777fa576da87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115543 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#753546}
-
Trent Apted authored
To fix [..:INFO:test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite< BrowserNonClientFrameViewAshTestNoWebUiTabStrip> UninstantiatedParamaterizedTestSuite< ImmersiveModeBrowserViewTestNoWebUiTabStrip> These test suite aliases were added in r748410. Bug: 1059514 Change-Id: I6a60a2d862a08e0e8f3cad8083de7966cdf19823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121520 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753545}
-
Eric Willigers authored
We make the kWebAppFileHandlers key available on stable rather than trunk. The ExtensionFromWebApp unit tests now use a test fixture that sets up a testing environment (by inheriting from ExtensionServiceTestBase). This is a speculative fix for a bug (crbug.com/1062239) that seems to have been introduced by a change to ConvertWebAppToExtension (crrev.com/c/2087327). The test WebAppFileHandlersAreCorrectlyConverted is re-enabled. This CL replaces https://chromium-review.googlesource.com/c/chromium/src/+/2108208 Bug: 1062239 Change-Id: I107a0731ab5b17faa51660384c10cab400e3cb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120676 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753544}
-
Matthias Körber authored
Currently, either the country field in an address form is used to determine the address requirements for autofill profile creation, or the the app_locale is used as a fallback option. This change adds the country code supplied from Chrome Variations as a primary fallback before the app_locale is used to deduce the country of a user. Also the country code is used to as a source for the default country for address creation. Change-Id: Ia7d28c66a31775b26d7d33153670b1db6eade74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107981 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#753543}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5a3755f19aa..0e15e8064fd0 git log d5a3755f19aa..0e15e8064fd0 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 sigurds@chromium.org [coverage] Disable save button if there is nothing to save Created with: gclient setdep -r src/third_party/devtools-frontend/src@0e15e8064fd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id0f793f72de9b90406ad02a88f794a1da189dba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121760Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5fc94e77c5636e33c8cce31006c21534ccdd7011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121759Reviewed-by:
-
Peter Kasting authored
It sets itself as the root window's client on construction and nulls that out on destruction. DesktopScreenPositionClient already did this, this just hoists that to the base class. This makes it harder to introduce bugs like "constructed the client but forgot to set it on the window" or the more likely (and insidious) "failed to null the client on shutdown, leaking state into another test and triggering test flakiness". Bug: none Change-Id: Ib8ddb193d78d7d7e5b0cf48683a7ef9653d31f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117335Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753540}
-
Trent Apted authored
MediaAppIntegrationTest.MediaAppLaunchWithFile and MediaAppIntegrationWithFilesAppTest.FileOpenCanTraverseDirectory have been flaking at low rates, but got flakier in r753464. Haven't been able to reproduce locally. https://crrev.com/c/2108400 adds some robustness, but without a local repro I haven't been able to verify this. Disabling to investigate further. TBR=zafzal@google.com Bug: 1064863 Change-Id: I1b27f9b9b89f3ad72d45b2548c2115b8361620f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121119Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753539}
-
chrome://media-appTrent Apted authored
This adds a new IDR resource id, to decouple the shown-icon from any icon asset that gets brought in via DEPS. Bug: b/150637102 Change-Id: I55b98e9fe7cf0d3fde4a87661d9dfbd39dc12ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120661 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#753538}
-
Marc Treib authored
...into ComputePendingCredentialsState and BuildPendingCredentials. This will allow us to call ComputePendingCredentialsState twice in MultiStorePasswordSaveManager - separately for the account matches and the profile matches. Bug: 1012203 Change-Id: Ie017474b84e4dc8b0b82bb4bb35a483dfb1a9175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116039 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/056caa9eda32..22ff3cfaf62e Created with: gclient setdep -r src-internal@22ff3cfaf62e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052460,chromium:1058597 Tbr: jbudorick@google.com Change-Id: Ic3dc696055b5c39692f82a319eda7353847f9d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121536Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753536}
-
chrome://media-app-guestTrent Apted authored
chrome://media-app-guest runs unprivileged code that doesn't require any of the implicit powers that chrome:// schemes get. Switch it over to the new chrome-untrusted:// scheme that was built to cater for this use case. The approach here follows the approach used for the help app in r744077. But since the test harness for media-app-guest no longer has a webui it can piggyback off, the tests need to be migrated into a framework which allows the tests to be injected into the unprivileged frame within the context of the test harness that exists for the privileged webui. Bug: 996088 Change-Id: I41c9866375f86a032eff752ce9a3b9c1c00ed212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108400Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753535}
-
David Tseng authored
Fixed by Suppress -Wpredefined-identifier-outside-function in SpeechMonitor TBR=dtseng@chromium.org Change-Id: I5e583e9b9c7c35778ca081ec7b3bd7e82da81af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121474Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753534}
-
Istiaque Ahmed authored
This CL makes the test load an actual extension from test dir instead of just creating a test extension object that is not loaded in extension system. The test flakily fails because the first call to network::BlockingDnsLookup doesn't resolve dns lookup. This CL is based on the wild intuition that as we use the extension's url in NetworkIsolationKey and the extension is not present in extension system, the test fails. Therefore, loading the extension would remove the failure cause. Two thousand runs with this fix survives in bots, where the test wouldn't without this CL. Bug: 1064832 Change-Id: Id75af472f9457b1205f1caef34b4e6686bbcaeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121344 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2d325c1d67a..d8c6c0e0f3a6 git log c2d325c1d67a..d8c6c0e0f3a6 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 540bdf92531d..77090261dabc (10 commits) Created with: gclient setdep -r src/third_party/skia@d8c6c0e0f3a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5ce93795ea54ef374ae007458d221f72cff8f08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121471Reviewed-by:
-
Noel Gordon authored
DirectoryTree displays focus rings when the keyboard or pointer device (mouse/pointer/touch) is used for interaction in files-ng. Change that: only show focus rings for keyboard interaction, using the global focus-outline-visible class provided by the cr.ui.focus_outline visibility manager. Bug: 1062902, 992819 Change-Id: Idb94a7be5582cfa4ae7429f04d53b95c8c855596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114512Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753531}
-
Rakina Zata Amni authored
This function might be called after the frame is removed now. Bug: 1064683 Change-Id: I3092d2f77eeb0652c072277b9724fe4191e2e580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120777Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#753530}
-
Hwanseung Lee authored
Use enum class instead of enum for views::LayoutFadeType. enum class is more type safety. Bug: 940736 Change-Id: I9c026d131835d77d212e4084bc84cb703a0638a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120837 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Store PDF version of the document as an enum field in DocumentMetadata. Bug: 93619 Change-Id: Ied76c6fd4cdaf379e822046af0fff4ab4ff8af12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118682Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753528}
-
Hayato Ito authored
This reverts commit 105f5197. Reason for revert: build failure https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/4471 Failure Step compile failed. Error logs are shown below: [86291/95274] SOLINK ./libvk_tests__library.cr.so FAILED: libvk_tests__library.cr.so libvk_tests__library.cr.so.TOC lib.unstripped/libvk_tests__library.cr.so /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long) ld.lld: error: undefined symbol: gfx::GpuMemoryBufferHandle::GpuMemoryBufferHandle(base::android::ScopedHardwareBufferHandle) >>> referenced by vulkan_android_unittests.cc:133 (../../gpu/vulkan/android/vulkan_android_unittests.cc:133) >>> obj/gpu/vulkan/android/vk_tests__library/vulkan_android_unittests.o:(gpu::VulkanImplementationAndroidTest_CreateVkImageFromAHB_Test::TestBody()) Original change's description: > Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android" > > This is a reland of 838eb034 > > Original change's description: > > VulkanImage: support create from GpuMemoryBufferHandle on Android > > > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > > > Bug: None > > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753394} > > TBR=rjkroege@chromium.org,vasilyt@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng > Bug: None > Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753501} TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org Change-Id: Ifbb45c4dbb1017d26d68c1216f3b5bdaece36991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120995Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#753527}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8351d2182b54..a8bbccaabeff git log 8351d2182b54..a8bbccaabeff --date=short --first-parent --format='%ad %ae %s' 2020-03-26 phoglund@google.com Remove histogram proto JSON converter code. Created with: gclient setdep -r src/third_party/catapult@a8bbccaabeff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: skyostil@google.com Change-Id: Id827eea4c6b4c36a48769007e06059f0afb5a4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121376Reviewed-by:
-
Glen Robertson authored
This allows us to remove the cases where a TestABMD and ABMD coexisted and the workaround for that ie. all observers previously had to implement OnAppBannerManagerChangedForTesting. This is in prep for adding a new observer. Change-Id: I0fb1e87a1e7072a2ef28d6b5bb57c2a296659794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111253Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#753525}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I11a272729c422a3eb48d07ea21493f7998fc226e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119465Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#753524}
-
chrome://media-appTrent Apted authored
Linters are cool. PRESUBMIT.py is the one that was in ui/file_manager, but with the path adjusted so it can find `web_dev_style`. .eslintrc.js is the one from ui/webui but with 'parserOptions': { 'ecmaVersion': 2018, 'sourceType': 'module', }, added. This is needed to support `await` and spread syntax, and matches our closure typechecking flags. Note we also inherit the .eslintrc.js configuration in src/.eslintrc.js. Fixes were mostly achieved by ./third_party/node/linux/node-linux-x64/bin/node \ third_party/node/node_modules/eslint/bin/eslint.js \ chromeos/components/media_app_ui/{test,resources/{js,mock}} --fix The remaining bits were: - document.getElementById is a restricted keyword. Recommendation is to use resources/js/util.js, but I'm not sure we need/want that dependency. Found a workaround (querySelector), but we might add that dependency in a follow-up. (Where we use getElementById is placeholder/ experimental code currently). - linter didn't like declaring a "namespace" like media_app. Changed to declare pageHandler directly. - linter also couldn't automatically fix the `==` -> `===`. Bug: b/152284689 Change-Id: Ib12765ade3cc5f3a9f46448ad8741eb3b8434737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119336Reviewed-by: -
sczs authored
Change-Id: I0782ba0e2879110475831d7e1d56b8cb91ddb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118581 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#753522}
-
Alex Danilo authored
Bug: 1064478 Change-Id: Ief97408a822f6ff1ed2be2e1366d1d261ffc7062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121117Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753521}
-
Jonah Chin authored
This change sets up a code path to render a simple canvas with OOP rasterization. It covers the most basic Canvas2D cases (ie. draw operations with stroke()). This CL also introduces diverging code paths based on the CanvasOopRasterization flag. OOP-R canvas functionality will remain divergent behind this feature flag as we work towards parity with the current code path, at which point the current code path will be removed. In this change, the flag is often used to bypass uses of GrContext, SkSurface and SkImage (all of which are unavailable with OOP-R). References to these objects will be replaced in future changes as we flesh out the OOP code path. This is being done as part of the OOPR-Canvas2D project. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1023277 Change-Id: Iffd279418f7b104a84513f14495983fc63e623c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076555 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#753520}
-
Patrick Monette authored
This is a reland of b7526e4f, but by with an additional fix. When a PerProfileWorkerTaskTracker instance is deleted because StopUpdating() was called, then the removal notifications must not be sent to the task manager (as part of the TaskProvider's API contract). This is handled in WorkerTaskProvider by dropping the notification when IsUpdating() is false. Original change's description: > [Task Manager] Properly clear worker tasks on profile shutdown. > > Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is > notified when there are outstanding tasks that are about to be > deleted. > > Bug: 1060506 > Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 > Auto-Submit: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751915} Bug: 1060506 Change-Id: I3c1a7f8f94a580d021b7e3658af885110bfa8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118770 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#753519}
-
Trent Apted authored
This reverts commit 59211f2c. Reason for revert: Persistent failures on linux-chromeos-chrome waterfall bot starting https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4305 errors like ../../chrome/browser/chromeos/accessibility/speech_monitor.h:64:54: error: predefined identifier is only valid inside function [-Werror,-Wpredefined-identifier-outside-function] const base::Location& location = FROM_HERE); Original change's description: > Include line numbers in SpeechMonitor async api > > Unfortunately, to resolve base::Location for each api call, we cannot support chaining. > > However, shortening the variable name for > |speech_monitor_| > to > |sm_| > and not having to indent, we actually save some indent space. > > Also, this change now includes all pending utterances (for understanding the state when the test is waiting). > > Sample output: > [158567:158567:0325/082550.588956:ERROR:speech_monitor.cc(276)] Still waiting for expectation(s). > Unsatisfied expectations... > ExpectSpeech("Fail!Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:931 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:933 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:934 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:936 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:938 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:941 > ExpectSpeech("Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:942 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:943 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:944 > > pending speech utterances... > Volume 100 percent > Rate 19 percent > > Satisfied expectations... > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:926 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:928 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:930 > > Change-Id: If1bdbfb517014e681cb233800eab3f62f608188f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120741 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753353} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: Ib3acf61914b3dd81ce2d777961d16de060ae9192 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121598 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Trent Apted authored
This reverts commit a3c46feb. Reason for revert: Landed on top of https://chromium-review.googlesource.com/c/chromium/src/+/2120741 which needs to be reverted Original change's description: > Re-enable some SpokenFeedbackTests > > General strategy: > - perform all actions (sm_.Call) > - gather pending utterances > - mix in Expect* calls between all Call actions (incrementally from the top) > - keep the tests mostly simple (limit UI interactions) to prevent flakes > - do use the async SpeechMonitor api which should be less flakey > - deleted one test who's behavior is still in flux (empty panel menu behavior) > > Some tests were still failing but due to external factors. Comments left. > > Change-Id: I7689880dbeeac3b31fe22a8029fae5078d975f0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119382 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753470} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: I01288031b7aab5694da31522da5393bf25ff2018 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121636Reviewed-by:
-
Jeff Yoon authored
This is a reland of f039e78b Original change's description: > [ios] ios-simulator-cronet tryjob src side Chromium config > > ios-simulator-cronet under chromium.fyi has already been migrated. > Missed migrating the trybot with it. > > Bug: 1055164,912681 > Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753391} Bug: 1055164, 912681 Change-Id: If39fc51bcf87744f46345630881bdd6074a88638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121136Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753516}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b69c4e14c5e2..6719f54ac7ce git log b69c4e14c5e2..6719f54ac7ce --date=short --first-parent --format='%ad %ae %s' 2020-03-26 courtneygo@google.com Update Vulkan header and related repos Created with: gclient setdep -r src/third_party/angle@6719f54ac7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I52959a4e93b1deb319188c24ed42a5589bf7c9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121464Reviewed-by:
-
Jeff Yoon authored
- chromium recipe and xcode build version set in goma.star - additional_compile_targets in waterfalls.pyl - mb arguments in mb_config.pyl - clobber flag is set recipe side. Generated files: - chromium.goma.json - chromium.ci.json - cr-buildbucket.cfg Bug: 1055164, 912681 Change-Id: Ie7b99ec62aace430bd0a563fc341cf1104a32963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113431Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753514}
-
tby authored
This removes the remaining references to the old 'cat' model, which we are no longer using. Bug: 1028447 Change-Id: I2d08e65e24fd979f485180338a03107902e57e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121597 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#753513}
-
Kenichi Ishibashi authored
All methods/fields that should remain //content have moved to ServiceWorkerRegistry so these comments are no longer needed. Bug: 1039200 Change-Id: I6282c4d43c4cc59bd7d9782ad20ddea416d8fbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120660 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#753512}
-
Hayato Ito authored
Bug: 1064395 TBR: dominickn@chromium.org Change-Id: If8bcce47c110603e49155f5476104a2d7f30e104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120835Reviewed-by:
-
