- 22 Jun, 2020 40 commits
-
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. CL also moves WebMediaPlayerMS away from using WebMediaStream directly, in favor of MediaStreamDescriptor. BUG=704136 R=guidou@chromium.org Change-Id: Ica4bbbf47b5754e2bdd92369e56b7143ebff4727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254584 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#780829}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Ic0d59407e28200355332852d290f18441d6f678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253980 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780828}
-
Nigel Tao authored
JSONReader is the API. JSONParser is *an* implementation, and we would like to experiment (in future commits) with different implementations (crbug.com/1069271). Doing so is easier if they don't also have to match exact error code values for invalid JSON input. In practice, API callers don't care about the error code value (if less than 1000). Also swap the order of the JSON_SYNTAX_ERROR and JSON_INVALID_ESCAPE enum values so that JSON_SYNTAX_ERROR takes the enum value 1, the same as the new kErrorCodeInvalidFormat enum value. Also update a switch statement in components/policy/core/common/config_dir_policy_loader.cc to also catch JSON_TOO_LARGE, JSON_UNREPRESENTABLE_NUMBER and any future enums added. Bug: 1069271 Bug: 1070409 Change-Id: I786c5d7ffc77e4d7927614a133bf1e7aae7eda5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251561Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#780827}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592823242-c0a158a98eb51cc1e695f636e9edb128f03ff58d.profdata to chrome-win64-master-1592830246-afb27d0ab9d498e780360849bc14fecea8fdad6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia6a9e4ba57643a7cc77bd61671f6014e87dbb5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780826}
-
Ben Pastene authored
The two sets of pools should be identical now. So this moves all tests back to the old pools so we can delete the temporary *.template ones. Bug: 812428 Change-Id: I65109f627cad33d00cd0a26c6bd8368321d62e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250927Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#780825}
-
Corentin Wallez authored
It has been failing since the broader suppression has been removed. TBR=ynovikov@chromium.org Bug: chromium:1097752 Change-Id: I0e40fd5e3207987a56f0d1b4c990856aab4e8dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256227Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780824}
-
Corentin Wallez authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d385bf096f5d..f9ae06512ef7 $ git log d385bf096..f9ae06512 --date=short --no-merges --format='%ad %ae %s' 2020-06-22 dsinclair Roll deps and update tests. 2020-06-22 post MSL: Remove the old VertexAttr API. 2020-06-19 cwallez Fix placement of SPIRV_CROSS_DEPRECATED. 2020-06-19 post Fix duplicated initialization for loop variables with initializers. 2020-06-18 post MSL: Add test case for constructing struct with non-value-type array. 2020-06-18 post MSL: Deal with loading non-value-type arrays. 2020-06-18 post MSL: Add tests for array copies in and out of buffers. 2020-06-18 post MSL: Improve handling of array types in buffer objects. 2020-06-18 post Clean up some deprecation warnings when building with Makefile. 2020-06-18 post Remove unused member in MSLShaderInput. 2020-06-13 cdavis MSL: Fix up input variables' vector lengths in all stages. 2020-06-16 post HLSL: Fix texProj in legacy HLSL. 2020-06-12 git GLSL: Require GL_ARB_draw_instanced for gl_InstanceID in GLSL < 1.40 2020-06-08 post GLSL: Handle the rest of GL_ARB_sparse_texture_clamp. 2020-06-08 post GLSL: Support uint code for sparse residency query. 2020-06-05 post Refactor texture fetch function generation. 2020-06-06 AlexanderMeissner Fix missing switch cases in Y'CbCr conversion 2020-06-04 post GLSL: Implement sparse feedback. 2020-06-04 post MSL: Remove obsolete MSLVertexAttr members. 2020-06-04 post HLSL: Add native support for 16-bit types. TBR=dsinclair@google.com Created with: roll-dep src/third_party/spirv-cross/spirv-cross Bug: None Change-Id: I67856dbc40a6b4d78704c3def6ba0497282c89b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257420Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780823}
-
James Cook authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn to use conditionals to include source files only on the platformn where they are used. Bug: 1018739 Test: compiles Change-Id: I59d91073a908f8312119302fff403d32b5f4d2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253214Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#780822}
-
Oleh Lamzin authored
Add battery info to probe interface. Request real cros healthd service interface. Mojo interfaces design doc (sorry, Google only): https://docs.google.com/document/d/1IolbGR2cZJYU0Lz4n6X8Qyxw7w6--4BH6G4NL3ltlSw/edit Bug: b:158658869 Test: existing browser test verifies that Telemetry Extension does not crash Change-Id: I6e50cd7d589a739fb768360d5870d2378fed1d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237985 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780821}
-
Hans Wennborg authored
It was missing some includes, see https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/10954 TBR=thakis Bug: 1031540 Change-Id: I259b7c577acac45ba50aef940ec2e20939dab555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257693Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780820}
-
Hans Wennborg authored
I'll push this upstream afterwards. TBR=mark Bug: 1031540 Change-Id: Ic160c18b46d099d552ba7362e10987e0bae89c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255613Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780819}
-
Ben Mason authored
Bug: 1093993 Change-Id: I12aaaf7e26c401b3f2b8e77690d5a06ad615def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257558Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#780818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea3fc18261ac..4599eb7bc4fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com,apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:477479 Tbr: anthonyvd@google.com,apotapchuk@google.com Change-Id: I35bba06348afe9d9233ab6495a2b4504d8245348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257438Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780817}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Idc9091bb275200a667827c520e289d084c6d30d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254758 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#780816}
-
Ioana Pandele authored
This reverts commit fea89df3. Reason for revert: This solution causes the sheet to require two clicks to close. Original change's description: > [ReEPwdSave] Add support for Keyboard Accessory v1 > > Clicking the toggle changes the tab icon by replacing all tabs. This > requires the tab to be re-marked as selected after its replacement. > > Bug: 1044930 > Change-Id: Ife8ef25cf6a7b081fba4dcabd9d81c9fa7dd0f94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250111 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780798} TBR=fhorschig@chromium.org,ioanap@chromium.org Change-Id: Ib68f58b1c4fcf774da5d4c1a903b4f4663cb0195 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256217Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#780815}
-
Liquan (Max) Gu authored
Before: When a merchant request a payment that involves a app store billing method but the merchant is not in a TWA, the browser reject the request with a generic error message. After: When that happens, the browser reject the request with a specific and actionable error message: ``` NotSupportedError: The payment method "https://play.google.com/billing" is not supported. Payment method https://play.google.com/billing is only supported in Trusted Web Activity. ``` Bug: 1095808 Change-Id: I40ae0896ac39f78ac63eae717faad733c73e8851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253129 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780814}
-
David Tseng authored
This change: - properly passes through AXActionData.request_id -> AXEvent.action_request_id - this id is used with the AutomationNode.hitTestWithReply(x, y, callback) action/function. When called, the action populates the action request id, which eventually makes its way to AutomationManagerAura. There, AutomationManagerAura::PostEvent dropped all fields of the action except for event to fire and the node id. - we resolve both paths were this was being dropped. Hit tests that land on a view, and hit tests that are directly on a window. R=dmazzoni@chromium.org, hirokisato@chromium.org Test: call hitTestWithReply on ARC++; verify receive a hit test result on the exo surface window in the reply callback. Change-Id: I177b255f4b3a1d0f3baf81d2c4ede23d370a8ed7 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254344Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780813}
-
anthonyvd authored
This reverts commit ae61a59a. Reason for revert: Appears to be breaking compile, see https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20(Nexus%205X)/31916? Original change's description: > [Autofill Assistant] Added ForEach interaction. > > Note: this is an alternative solution for http://crrev/c/2235698 > > This interaction executes a number of callbacks for the input loop value. This is intended to be used to inflate UI elements for client-only values, i.e., for values that the backend can't specify. > > Internally, ForEach loops are implemented by introducing the concept of callback contexts, which will change value and view lookup accordingly. > > In particular, callback contexts are used to automatically replace placeholders of the form ${i} in value and view identifiers (where 'i' is the loop identifier). This allows creating and referencing values and views with templated names, such as "created_view_${i}" and "value[${i}]". > > Bug: b/145043394 > Change-Id: I53089252fe1cc14b2b1fb74cfc56d7314bc4b37c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241975 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Marian Fechete <marianfe@google.com> > Cr-Commit-Position: refs/heads/master@{#780785} TBR=arbesser@google.com,marianfe@google.com,sandromaggi@google.com Change-Id: I88363b22e93fa021c1d23b25d78c0433a1b58242 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/145043394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256444Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#780812}
-
ckitagawa authored
Trying to pinpoint the cause of a flake. Make error messages better. Bug: 2252578 Change-Id: Ic5bee4c8b3b126275cbc915af199d380ce7d9adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255646Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#780811}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Id0f04386d2024d6646d7bc05761954eeedd1e338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254779 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780810}
-
Denis Kuznetsov authored
Bug: 1067260 Change-Id: Ie46d8552e912f11224cd5ffbe50a64facc9da4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252807 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780809}
-
Alex Ilin authored
When reauth fails because the GAIA page cannot be loaded, we need to indicate to the user what went wrong. We decided to simply show a regular Chrome error page in that case. An error page may or may not contain a button to reload the current page, depending on the error. This CL modifies ReauthTabHelper to not complete Reauth in case of an error. This means that an error page will be displayed in the web contents hosting GAIA reauth, either in a dialog or in a tab. Bug: 1045515 Change-Id: I8955d824b4c954ba0472288a081af386fb9cd62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255472 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780808}
-
Dave Tapuska authored
When the WebFakeWidgetScheduler terminates we toss out any pending tasks otherwise this could lead to a leakage on the LSAN bot. BUG=1073560 Change-Id: I653a1649b29bf36eb6a0e2626ef939265bada49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257498 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780807}
-
Xida Chen authored
These histograms were added to figure out whether there is any difference of performance by comparing the blocking handlers and the non-blocking handlers. These UMAs don't have much value at this moment. So this CL marks them obsolete. Bug: 1088748, 1072663, 1059793, 1055386, 1053244, 1053243, 1053242, 1037588, 1037071, 1034573 Change-Id: I94c9223955ba4483029978c00d323355abe6d527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252616Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780806}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: If7e09c6168c289fc12e602b1ba7738d82b791875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254283 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#780805}
-
Sam Maier authored
This also fixes a mistake I made in a previous CL where I was not keeping any methods annotated by @DoNotInline. Bug: 1094569 Change-Id: Ic6d6c5771764a8faf9d387e677423c0cd43a2091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249723Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#780804}
-
Clemens Backes authored
The test output will change with the next v8 roll, hence skip the tests now and rebaseline after the v8 change rolled in. R=thibaudm@chromium.org, haraken@chromium.org Bug: 1097717 No-Try: true Change-Id: I00bbfa9ada558b87e3e581fe13c2d957963a8a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256183 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#780803}
-
Dave Tapuska authored
Add some additional types so that we can move more input handling into blink from content/renderer. These structures are used by the webview's synchronous compositor. BUG=1073560 Change-Id: I6af4798934fe618229c87e3794489562072e1cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249343 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a061b4a78240..956ec8a8bcdd 2020-06-22 johnstiles@google.com Update GrCCClipProcessor to support an input FP. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I3c0c65c693241c6b43e7cf6aa68b833f9e36f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780801}
-
Gauthier Ambard authored
The share menu requires JavaScript execution to capture the page's canonical URL, but script execution is halted when JavaScript dialogs are running. This CL adds ToolbarMediator as an OverlayPresenterObserver and disables the button when a overlays are displayed in OverlayModality::kWebContentArea. Fixed: 987247 Change-Id: Ia09b9eb5e9e734e4d25252aee236acf46a6d81c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256230 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#780800}
-
arthursonzogni authored
We have tests with: - (opener <-> openee) with COOP on the openee. This patches adds: - (opener <-> openee) with COOP on the opener. Along the way, reduce the size of the previous set of tests, make them independent of the other reports. Bug: 1090273 Change-Id: I2af9e6f520cec745a875e4b048d02b7c6e6573b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255470 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780799}
-
Ioana Pandele authored
Clicking the toggle changes the tab icon by replacing all tabs. This requires the tab to be re-marked as selected after its replacement. Bug: 1044930 Change-Id: Ife8ef25cf6a7b081fba4dcabd9d81c9fa7dd0f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250111Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#780798}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a57798d. With Chromium commits locally applied on WPT: bca089ad "[LayoutNG] Truncate block-end child margins at fragmentainer boundaries." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I666cb819bacb2a83792d6dcefa264feff0d7304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255508Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780797}
-
Sylvain Defresne authored
Remove compatibility aliases allowing to load sessions saved with Chrome version pre M-59 (should have been after M-68 was released which happened long ago). Bug: 661633 Change-Id: I617dc4a394f61e0a4a89cd2da40ff73b2650d903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255611 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780796}
-
Hans Wennborg authored
This is a reland of a6e9e966 Original change's description: > Remove/replace unnecessary includes of logging.h (base/) > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > macros, use the appropriate header for that instead. > Or if logging.h is not needed at all, remove it. > > This is both a nice cleanup (logging.h is a big header, > and including it unnecessarily has compile-time costs), > and part of the final step towards making logging.h no > longer include check.h and the others. > > TBR=thakis > > Bug: 1031540 > Change-Id: Ib87efde411a3617fcebad6dae08313c20d63d0bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254284 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780580} TBR=thakis Bug: 1031540 Change-Id: I0ba8608458cf14c3e4bbc86eaef4c7ad136a9263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256179Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780795}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1dccfa608557..dbb8f3185736 2020-06-22 tvanderlippe@chromium.org Reland "Add rollup_entrypoint to rollup entrypoints in front_end" 2020-06-22 alexrudenko@chromium.org Add additional assertions to styles pane tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1061037,chromium:1096473,chromium:946975 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c76e044980cb5e2096b9428539362ccbb2759a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780794}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I7a96c78d4a93b99956a920d61636ed91cf0e82ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219462 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#780793}
-
Robert Ma authored
to be consistent with the shebang in `run_web_tests.py` Also `chmod +x` because checkperms complained. Note that vpython(.bat) is provided by depot_tools and should be available in PATH after following the Windows build instructions: https://chromium.googlesource.com/chromium/src.git/+/master/docs/windows_build_instructions.md#install Bug: 1095643 Change-Id: I0afaae268022e0a2a368ecae6cd7020c453f5812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249086 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#780792}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f594ffdc357a..a4434747558d 2020-06-20 sebras@gmail.com [cff] Fix handling of `style_name == NULL' (#58630). 2020-06-20 apodtele@gmail.com Simplify unused macro. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I0300ca5bab677272e312581e26f3c05f71c88967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#780791}
-
Fredrik Söderqvist authored
We will not create LayoutObjects for <stop> elements, so when animating stop-color on one of these elements we should access ComputedStyle via Node::GetComputedStyle(). Fixed: 1097762 Change-Id: I9e5996b733cae97f813ab392f62f37a8aaa0e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255366Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#780790}
-