- 28 Oct, 2019 40 commits
-
-
Nico Weber authored
Changes some new uses, and does fairly harmless modifications to keep GOOGLE_CHROME_BRANDING out of .h files. Bug: 961769 Change-Id: Ia273654e515c1ba07cbd91b51937422d792a9f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882110Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709895}
-
Yuki Shiino authored
Use of "${ x | trim }" of Mako template unconditionally removes whitespaces including newlines. It makes it hard to insert empty lines in generated code. This patch revisits the newline problem again, and improves it. Bug: 839389 Change-Id: If838b4766fe8938e7f7c2bfb2ff8802d56ac9441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883830Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709894}
-
Jeremy Roman authored
Inspired by https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Y8kOXPOqA9A/discussion Tbr: dcheng@chromium.org No-Presubmit: true Change-Id: Ib83a4c72028fe7a36f7cb68b0399bb1a84dec902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844059 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709893}
-
Javier Ernesto Flores Robles authored
Bug: 1017690 Change-Id: I68b0643a099456c41c1abd483c1ae66edc957398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878411 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709892}
-
henrika authored
Trivial change which only cleans up WebRTC logs containing the string "request_id=n". We used to mix "request_id=n" and "request_id = n" but now all white-spaces are removed to make the logs more consistent and easier to parse. Bug: 1017219 Change-Id: I0aed5cccb7c77d14a63b8a972ae92ce748ba88cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878368Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#709891}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id2c18902346490fa5b66a711c2bd7ee7a71281c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709890}
-
Matt Falkenhagen authored
So it's not split between two files. Change-Id: Ib39b2e1147a6424884f7f26cdcd505681a51fc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880989 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#709889}
-
Francois Doray authored
LockObserver browser tests were disabled on Android Kit Kat because of flaky failures of the navigation performed in SetUpOnMainThread(). Since it is not important to perform the navigation from SetUpOnMainThread(), this CL moves it to the test body. The failure seems related to this comment: https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.cc?l=650-664&rcl=786a9194459684dc7a6fded9cabfc0c9b9b37174 This CL also removes the ContentMockCertVerifier in LockManager browser tests, and instead specifies the switches::kIgnoreCertificateErrors command-line flag, which is simpler. Bug: 1011765, 1014015 Change-Id: Ia1e140605a6734a95012f5c6019c6cef4918f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854901 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#709888}
-
Richard Knoll authored
This is a temporary workaround as the XPC used to show alert style notifications does not work on 10.15+. Showing those as banners is not ideal as they auto dismiss into the notifications center but it is better than not showing them at all. Bug: 1007418 Change-Id: Ib50ed9f2125b7bdf5885b5ffd63e81137e50e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883648Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709887}
-
Andreas Haas authored
We want to use V8::BackingStore as the backing store implementation for WTF::ArrayBuffer to clarify memory ownership. However, libwtf, where WTF::ArrayBuffer is at the moment, does not load libv8. Therefore this CL moves the implementation of WTF::ArrayBuffer to DOMArrayBuffer, which is the only real user of WTF::ArrayBuffer anyways. Note that in the long run we want to remove WTF::ArrayBuffer completely. This CL is one step to enable that removal.d This CL did the following changes: * Move the implementation of WTF::ArrayBuffer and co from /platform/wtf/typed_arrays/* to /core/typed_arrays/array_buffer/*. * Adjust includes where necessary. * Adjust the include guards. * Introduce a new DEPS file. * Adjust BUILD.gn files. * Add exception to third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py. * Change the namespace of all moved classes from WTF:: to blink:: R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Iaee4937d3acce7ea578fbf2e278b6fa91f3b4627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875731Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This dialog's button labels can change as its model is updated, so always reset them in UpdateUIForCurrentSheet() before calling DialogModelChanged(). Bug: 1011446 Change-Id: I3125ffe6e9b13c5f365c473de0b5eb226a7ebfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878629 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709885}
-
Jinsong Fan authored
In GetSelectionStart|Endpoint, the rect local to the layoutObject at the selection start or end might be empty. The CL add checks for that. Bug: 1018679 Change-Id: I203ca1c6683e984699691f5d99a4f3bc3353f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880362Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#709884}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c189ace20a43..3eae7e4e3cdf git log c189ace20a43..3eae7e4e3cdf --date=short --no-merges --format='%ad %ae %s' 2019-10-28 sprang@webrtc.org Add exponential backoff of retransmissions for a given packet 2019-10-28 perkj@webrtc.org Ignore low probe results when using NetworkStateEstimator under field trial 2019-10-28 jonaso@webrtc.org ICE : add field trial for initial select dampening Created with: gclient setdep -r src/third_party/webrtc@3eae7e4e3cdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I10fc5def882475142265c4c84623c43a46041989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883130Reviewed-by:
-
Yutaka Hirano authored
This is (3) in https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/. Bug: 1018050 Change-Id: Ib265bd86153842b4f90c836fb0b06d200e94a787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880361 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/04863c42bedd..f6281a5530c0 git log 04863c42bedd..f6281a5530c0 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 enga@chromium.org perf_tests: Add missing trace event "id" Created with: gclient setdep -r src/third_party/dawn@f6281a5530c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I14e626ecbacb15ff32818334cf4b11bc6a30497a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883129Reviewed-by:
-
Gabriel Charette authored
Only start monitoring after BrowserMainLoop::PreMainMessageLoopRun() invokes base::DisallowUnresponsiveTasks(). R=erikchen@chromium.org, rkaplow@chromium.org Bug: 1018359 Change-Id: I597c4b6a45797c66c0fa1b30fc3efdc9108aa81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881709 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/512f209de9b5..2b0233b972a6 git log 512f209de9b5..2b0233b972a6 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 khokhlov@google.com Fix Windows build 2019-10-28 lalitm@google.com traceconv: bump shas to a58d04db 2019-10-28 primiano@google.com Fix strnicmp for MSVC 2019-10-28 treehugger-gerrit@google.com Merge "Fuchsia importer: Don't rely on non-guaranteed alignment" 2019-10-28 primiano@google.com Merge "tools(ci): support running with podman" 2019-10-27 primiano@google.com Trace Processor: add --httpd 2019-10-27 primiano@google.com String utils: add StringView.find(StringView) and ToLower Created with: gclient setdep -r src/third_party/perfetto@2b0233b972a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:142489755,chromium:143074239 Change-Id: I2b61d46405894109d70f47351ed6c42b0cb43fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883131Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4fd34ae..99564c9b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I15fee9f5387f3aa40eb75787fae24bb90ca25a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882937Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709878}
-
Greg Thompson authored
These tests must allow tasks on the cache thread and the main loop to run to allow for proper cleanup. Without this, files in the profile dir may be held open beyond the lifetime of the test function, inhibiting ScopedTempDir's ability to clean them up during TestBrowserContext destruction. BUG=546640,1016662 Change-Id: I1f9b50cb91a7fd287a103a4528ffe393720aeec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882319 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709877}
-
Robbie Gibson authored
This conversion has a very large app_interface. This is mostly due to the heavy use of mocking and swizzling these tests use to interface with the iOS camera status. This also moves the CameraState enum into a separate file and gn target so it can be included in test-side processes. Bug: 987646 Change-Id: I5755ee1861de3ba74b9594e2c528d234b85feca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879249 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#709876}
-
Rune Lillesveen authored
Bug: 966283, 1018438 Change-Id: I076a4daa612f6453b631d953baa26ac4f093d322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883072 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#709875}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=jam@chromium.org Bug: 891670 Change-Id: I224d419e31a6fb41156fed62bf856674fc69e6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878372Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#709874}
-
Arthur Hemery authored
NavigationClient is on by default, removing unnecessary branching. Bug: 784904 Change-Id: I9024044ec53edd8776dda2427e59b754cd0f91ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821179Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709873}
-
Sergio Villar Senin authored
In crrev.com/c/1866520 the WebContextMenuData::MediaType was extracted to a different file and renamed as ContextMenuDataMediaType. That alone required so many changes (as the enum became an enum class) that an alias was added for the old name in order to keep the changes under control and ease the review. In this follow up patch the alias (using) is removed and the code starts to use the new enum class name. Bug: 1014517 Change-Id: I563fb0d6cc1a13a796988d6a66e995835b92c335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872004Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Olivier Robin authored
Bug: 1017213 Change-Id: I28221c29e3e69b50a97d47f0f8981e0a516d65b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878075 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#709871}
-
Juan Antonio Navarro Perez authored
Bug: 1001038 Change-Id: I08747c6a733ac42bd564f985e3f9ad52478ce210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879207Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709870}
-
Kazuhiro Inaba authored
RestartArcSession() can reuse the upgrade_params_ data that was previousely set. Moving the content is not appropriate. BUG=b:143439620 BUG=b:142144019 BUG=b:143092860 TEST=ArcSessionRunnerTest.Restart TEST=`adb reboot` successfully restarts the ARC container. Change-Id: Ie7a9254e03de29efde94a4a8918e80a1b871471c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883427Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#709869}
-
Yuki Shiino authored
It turned out that some of SymbolDefinitionNodes need to be followed by UnlikelyExitNode just like the following example, so this patch makes SymbolDefinitionNode inherits from SymbolScopeNode so that a definition can consist from multiple CodeNodes. Example: const auto& return_value = F(exception_state); if (exception_state.HadException()) { return; } A symbol definition of |return_value| needs to be followed by UnlikelyExitNode to return early if an exception is thrown. Note that SymbolNode is just moved and should have no code change. SymbolDefinitionNode is updated accordingly. Bug: 839389 Change-Id: I65e2f730084ad5018c2521ea0826c058910d153b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882253 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Mark Cogan authored
This is the third CL of several breaking crrev.com/c/1860025 into smaller chunks. This just plumbs a Browser into the signin promo classes. Change-Id: Ie059a52ea81e801a1d5d1cfe59940b3faffed6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863026Reviewed-by:
-
Arthur Hemery authored
We are now always using the NavigationClient to commit a successful navigation or an error page. We update all the "commit calling" stack to reflect that. One important exception to note is committed interstitials, that commit without a NavigationRequest. This prevent us from fully removing the old FrameNavigationControl::CommitNavigation path. Bug: 784904 Change-Id: Ife819ed0d2274630939323ad21863c354229a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819242Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Olya Kalitova authored
Propagates CrostiniAnsiblePlaybook policy value to CrostiniManager so playbook applied to the default Crostini container during its startup is the one specified by policy. Test: unit_tests --gtest_filter="Crostini*" Bug: 973793 Change-Id: I680faa6e3d570eab502d797633a39a12b8a3d6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879298 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709865}
-
Yves Gerey authored
* single_user_demo_mono_16kHz.pcm was never used, apparently. * speechmusic_mono_16kHz.pcm was only referenced by one test, which was removed here: https://codereview.chromium.org/194813002 TEST=content_unittests Bug: chromium:331030 Change-Id: I4b77c264729db411d38f5d0568496cb76a2ce4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882308Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#709864}
-
Yuki Shiino authored
It turned out that duplicated SymbolDefinitionNodes emit unnecessary newlines and it makes the code ugly. This patch removes duplicates. Bug: 839389 Change-Id: I1a319f18457eb77a847f0131ae65d2e187205687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882248Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/076f869ce5ac..225301d6dc53 git log 076f869ce5ac..225301d6dc53 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f44f7c066a67..1737a30e3e34 (1 commits) Created with: gclient setdep -r src/third_party/angle@225301d6dc53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I4c7ce95eea1c980a56a4744a922a2bf0fc711e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883589Reviewed-by:
-
Adam Rice authored
Previously the Transform() and Flush() methods of TransformStreamTransformer returned void. This meant that there was no way for them to wait for asynchronous work to finish. Change the function signatures to return ScriptPromise. Transform() or Flush() won't be called again until the returned promise is settled. Returning v8::Local<v8::Promise> would have been slightly more efficient, but ScriptPromise was used for consistency with UnderlyingSinkBase and UnderlyingSourceBase. Add tests that Transform() and Flush() promises are actually waited for. BUG=962837 Change-Id: I2e79c6a79a457fd021eee17eca4f1502c3aa521f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865735Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709861}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSpanElement> and DynamicTo<HTMLSpanElement> as new downcast helper 2. Use IsA<HTMLSpanElement>(element) in place of IsHTMLSelectElement(element) Bug: 891908 Change-Id: If2150ecebb45b7dd6dd78682ffac47eb60372c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878269Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
Change-Id: I567141992ec4a9269068c03a1798f2561dba24f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879946 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709859}
-
Yuki Shiino authored
Renames CodeGenerationContext.property to |property_| in order to avoid conflict with the built-in property function. Also adds more utility properties. Bug: 839389 Change-Id: I166374af1d3dc451b1e783d873f61f5b6aa48c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882188Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1f6fbe1. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iabab2e29d81fac05ed33609c1de3208a5213c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882935Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709857}
-
Marina Sakai authored
Function inlining of the GetSymbol function using SymbolKey instance as a key is not negligible because that might bloat out code size especially with the Android compiler. This CL prevents function inlining of the GetSymbol function by defining it in v8_private_property.cc. Bug: 715418 Change-Id: I73aa068ee71802ed4b0ebf001d846520ae13be08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880900Reviewed-by:
-
