GitLab

This change adds a new expectation file for Blink layout tests to be run
by PlzNavigate's FYI bot. It's contents are based on local runs.

This change will be followed by another one to enable the layout tests in
the FYI bot: http://crrev.com/1598463002

BUG=576261

Review URL: https://codereview.chromium.org/1586203005

Cr-Commit-Position: refs/heads/master@{#370677}

BUG=475633

Review URL: https://codereview.chromium.org/1604653002

Cr-Commit-Position: refs/heads/master@{#370676}

BUG=579672

Review URL: https://codereview.chromium.org/1616863002

Cr-Commit-Position: refs/heads/master@{#370675}

BUG=578849

Review URL: https://codereview.chromium.org/1603783002

Cr-Commit-Position: refs/heads/master@{#370674}

Review URL: https://codereview.chromium.org/1610273002

Cr-Commit-Position: refs/heads/master@{#370673}

Remove use of of obaque void** and use instead size_t*
parameter. Logic inside is untouched.

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1594973004

Cr-Commit-Position: refs/heads/master@{#370672}

The images in Drive were not world-accessible, host them on Google Cloud
Storage instead.

TBR=primiano@chromium.org

Review URL: https://codereview.chromium.org/1617703002

Cr-Commit-Position: refs/heads/master@{#370671}

BUG=387516
R=sergiyb@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/1613843002 .

Cr-Commit-Position: refs/heads/master@{#370670}

This CL renames and hides original |copyTextTo()| functions as private
|copyCodeUnitsTo()|.

New |copyTextTo()| functions are introduced to |TextIterator| and
|SimplifiedBackwardsTextIterator| to allow copying a range of characters
to a buffer without worrying about breaking code points. The new functions
are implemented as wrappers of |copyCodeUnitsTo()|.

This is part of a bigger CL [1].

[1] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=webkit_unit_tests --gtest_filter=*TextIteratorTest.CopyWholeCodePoints

Review URL: https://codereview.chromium.org/1607213002

Cr-Commit-Position: refs/heads/master@{#370669}

See https://codereview.chromium.org/1597553003 and https://goto.google.com/lgaln
for more context.

BUG=none
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/1611163002 .

Cr-Commit-Position: refs/heads/master@{#370668}

The spec is: https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssignedNodes-sequence-Node--AssignedNodesOptions-options

BUG=531990

Review URL: https://codereview.chromium.org/1590533006

Cr-Commit-Position: refs/heads/master@{#370667}

When adding use counters for link headers, preload was left out. This CL
fixes that historical mistake.

BUG=471199

Review URL: https://codereview.chromium.org/1602203005

Cr-Commit-Position: refs/heads/master@{#370666}

BUG=479898

Review URL: https://codereview.chromium.org/1602283002

Cr-Commit-Position: refs/heads/master@{#370665}

BUG=579148

Review URL: https://codereview.chromium.org/1603893002

Cr-Commit-Position: refs/heads/master@{#370664}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/48645f99..ed58de7a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1616733003

Cr-Commit-Position: refs/heads/master@{#370663}

BUG=363159

Review URL: https://codereview.chromium.org/1614793002

Cr-Commit-Position: refs/heads/master@{#370662}

Extend DisplaySourceConnectionDelegate::Connection interface to support
control message exchange with the connected sink.

Also connection error notification method is added.

BUG=242107

Review URL: https://codereview.chromium.org/1603013002

Cr-Commit-Position: refs/heads/master@{#370661}

The term "shadow distributed" has been used to refer
to matching of "::content" pseudo element against
<content> or <shadow> elements.

Shadow DOM V1 introduces the new <slot> element and
::slotted pseudo element, rename all occurrences
of "shadow distributed" to "content pseudo", or
"slotted pseudo" etc. so it should make more sense.

This CL should land after
https://codereview.chromium.org/1575363006

BUG=531990

Review URL: https://codereview.chromium.org/1616743002

Cr-Commit-Position: refs/heads/master@{#370660}

There are already such utils in //chrome/browser/sync and the //ios version as
well. This CL starts by pulling out some trivial parts into a common file in
//components. More will follow as ProfileSyncService unittests will get
componentised.

BUG=544972

Review URL: https://codereview.chromium.org/1607473003

Cr-Commit-Position: refs/heads/master@{#370659}

BUG=

Review URL: https://codereview.chromium.org/1619443002

Cr-Commit-Position: refs/heads/master@{#370658}

Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (patchset #2 id:20001 of https://codereview.chromium.org/1605233002/ )

Reason for revert:
caused a regression, crbug.com/579895

Original issue's description:
> Implement PopupMenu::updateFromElement() for ExternalPopupMenu.
>
> It closes a shown popup, and re-show a popup with the latest content.
> This CL affects only OSX and Android.
>
> Implementation:
> A major part of show() was moved to showInternal(), and updateFromElement() calls
> showInternal() later.  showInternal() returns false if it failed to show a popup.
>
> BUG=176241
> TEST=manual; See crbug.com/176241.
>
> Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
> Cr-Commit-Position: refs/heads/master@{#370329}

TBR=keishi@chromium.org
NOTRY=true
BUG=176241,579895

Review URL: https://codereview.chromium.org/1613813002

Cr-Commit-Position: refs/heads/master@{#370657}

There are other places which "shadow distributed" is used
(e.g. css/RuleSet.h), and those are renamed to "content pseudo" etc. in
https://codereview.chromium.org/1616743002/

For these tests in editing, renaming it to "ShadowV0" should
make more sense because it is tested against V0 distributed
node (i.e. <content>).

This is a name-only change and no functionality/test difference.

BUG=531990

Review URL: https://codereview.chromium.org/1610993003

Cr-Commit-Position: refs/heads/master@{#370656}

Revert of Remove unused arguments of blink::PopupMenu::show(). (patchset #1 id:1 of https://codereview.chromium.org/1610553003/ )

Reason for revert:
to revert a depending CL

Original issue's description:
> Remove unused arguments of blink::PopupMenu::show().
>
> This CL has no behavior changes.
>
> Committed: https://crrev.com/fe9b3fb0d905a64db165cabe933d6dc2fe872dc4
> Cr-Commit-Position: refs/heads/master@{#370634}

TBR=keishi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1613783003

Cr-Commit-Position: refs/heads/master@{#370655}

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1616713003

Cr-Commit-Position: refs/heads/master@{#370654}

This matches the content version of shutdown, and was missing due to a
merge mistake during the time when iOS shared the content main loop
code, with significant diffing.

BUG=412727

Review URL: https://codereview.chromium.org/1615493002

Cr-Commit-Position: refs/heads/master@{#370653}

Spec is the link below.
http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath
This feature is guarded by ShadowDOMV1 RuntimeEnabled flag.

BUG=531990

Review URL: https://codereview.chromium.org/1577163003

Cr-Commit-Position: refs/heads/master@{#370652}

These tests are frequently timed out on Linux Tests (dbg)

BUG=579666
TBR=dbeam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1617623002

Cr-Commit-Position: refs/heads/master@{#370651}

This CL is split off of
https://codereview.chromium.org/1523843004/

and implements mathcing part of ::slotted() pseudo element.
This CL depends on parsing part:
https://codereview.chromium.org/1565263003/

Implements ::slotted() pseudo element, whose spec is discussed at
https://github.com/w3c/webcomponents/issues/331

BUG=531990
TEST=new layout tests

Review URL: https://codereview.chromium.org/1575363006

Cr-Commit-Position: refs/heads/master@{#370650}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c568bf1a..48645f99

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1613743002

Cr-Commit-Position: refs/heads/master@{#370649}

This CL makes sure that when an event happens on an element which is assigned to a slot, the event path goes to the slot after the element and goes up the v1 tree.
Described here in spec.
http://w3c.github.io/webcomponents/spec/shadow/#event-paths

BUG=531990

Review URL: https://codereview.chromium.org/1606153002

Cr-Commit-Position: refs/heads/master@{#370648}

Add check to LayoutObject::document to return the document of the parent
if m_node is NULL, thereby assuring that it cannot be NULL. Further adds
an ASSERT to verify that either m_node or parent() is avalible.

BUG=402056
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1618543002

Cr-Commit-Position: refs/heads/master@{#370647}

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html

Review URL: https://codereview.chromium.org/1603873004

Cr-Commit-Position: refs/heads/master@{#370646}

SampledEffect cannot be made non-Finalized due to the
Vector<RefPtr<Interpolation>> member requiring destruction.
This change removes the TODO to make SampledEffect non-Finalized.

Review URL: https://codereview.chromium.org/1612913002

Cr-Commit-Position: refs/heads/master@{#370645}

BUG=579816

Review URL: https://codereview.chromium.org/1602093004

Cr-Commit-Position: refs/heads/master@{#370644}

These coordinates are currently the same but will differ when use-zoom-for-dsf is enabled. (See bug for discussion and design doc)

BUG=485650

Review URL: https://codereview.chromium.org/1602203007

Cr-Commit-Position: refs/heads/master@{#370643}

We aligned them at their top position.  It was incorrect in some cases.
- We reset line-height of inner-editor element in some cases, but never reset
  line-height of placeholder.
- Even if their font settings are identical, box heights can be different if the
  specified font doesn't cover all of characters and another font is used.

This problem happened frequently after crrev.com/369975 because we don't limit the
inner-editor height since it.

BUG=178032,569869,579381

Review URL: https://codereview.chromium.org/1616553004

Cr-Commit-Position: refs/heads/master@{#370642}

Revert of Implement webview.captureVisibleRegion() (patchset #9 id:160001 of https://codereview.chromium.org/1582053002/ )

Reason for revert:
The test WebViewAPITest.TestCaptureVisibleRegion is failing on several windows bots:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/45040
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/42690
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/64394

Original issue's description:
> Implement webview.captureVisibleRegion()
>
> This CL implements  webview.captureVisibleRegion(), an extension/apps
> API to allow WebView users to capture screenshots of the contents
> displayed in a WebView. The surfaces contents capture has been plumbed
> via RenderWidgetHostViewChildFrame so this implementation should not
> require changes when WebView switches to using OOPIF.
>
> As part of the implementation, there are two notable refactors:
>
> 1) CaptureWebContentsFunction has been refactored into
> WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction
> dependence so that this code can be used by both tabs.captureVisibleTab
> and webview.captureVisibleRegion, and
>
> 2) common code from DelegatedFrameHost has ben moved to
> content/browser/compositor/surface_utils.* in order to avoid duplication
> as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now
> use the code.
>
> BUG=326755
>
> Committed: https://crrev.com/5b8cdcc82fc9da7bab15fd3dbf65df843dc73589
> Cr-Commit-Position: refs/heads/master@{#370565}

TBR=rockot@chromium.org,creis@chromium.org,kenrb@chromium.org,nick@chromium.org,fsamuel@chromium.org,wjmaclean@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=326755

Review URL: https://codereview.chromium.org/1614703003

Cr-Commit-Position: refs/heads/master@{#370641}

They were deleted in https://codereview.chromium.org/1618523002 because apparently some filesystems get
confused by only changing the case of characters in the filename, so I'm re-adding them in this CL.

Review URL: https://codereview.chromium.org/1612893002

Cr-Commit-Position: refs/heads/master@{#370640}

This patch replaces an include of StyleVariableData with a forward
declaration in StyleRareInheritedData. This significantly reduces the
number of files that need to recompile when touching files like
CSSVariableData and CSSParserToken from ~900 to ~50.

Review URL: https://codereview.chromium.org/1618563002

Cr-Commit-Position: refs/heads/master@{#370639}

TBR=yoav@yoav.ws
BUG=579854

Review URL: https://codereview.chromium.org/1618563003

Cr-Commit-Position: refs/heads/master@{#370638}