GitLab

Implements constants, trace member function, and member
variable definitions.

Bug: 839389
Change-Id: I53d3bbeace3bdd80f7bb4734d12e40dfc56bc252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512324
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824906}

Bug: 1136043
Change-Id: I2caa0b769cc08dd071d55336ca9202548f0dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521705
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824905}

https://chromium.googlesource.com/angle/angle.git/+log/0781b693fa2d..49d9785e4224

2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c2b2b5788575 to a61d07a72763 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ia25ed3e6ac64e844017f43e56e33e25e9c2d0dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521209Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824904}

In r824597 we have landed the new behavior of the NGLineBreaker class to
deal with trailing ideographic spaces, according to the last changes in
the CSS Text 3 specification.

These spaces are defined in the spec as 'other space separator' [1] and
as such, they should not be considered 'collapsible spaces' [2]. This
fact has some implications in the implementation of the Phase I [3] of
the White Space Processing algorithm.

Additionally, this CL implements also the required logic in the
BreakingContext class to deal with this kind of trailing spaces,
according to the value of the 'white-space' [4] CSS property. When its
allowed, these trailing spaces will be hang or even broken (in case of
break-space value), instead of selecting previous breaking opportunities
to avoid overflow, like it's described in the bug.

It's worth mentioning that even though this CL is about hanging trailing
spaces, we need to apply some changes in the TextBreakIterator. These
changes are needed to avoid ideographic spaces to be handled by ICU. The
problem is that ICU, following the UAX14 spec where ideographic spaces
are classified as BA, will return breaking opportunities 'after' the
trailing spaces character sequence. However, due to some performance
optimizations, we have decided to implement the BreakingContext logic
assuming that we always break before space (kBeforeEverySpace).

We have landed a patch in r807457 with an important refactoring to sync
TextBreakIterator behavior on the white-space handling with ICU, so that
we always break 'before space'. However, this change affects only to the
LayoutNG inline-layout logic, which was adapted accordingly to the new
behavior.

We have decided to avoid this approach for Legacy layout, since a big
refactoring like this could imply important regressions, difficult to
track and fix nowadays. The changes in the TextBreakIterator performed
by this CL try to handle ideographic spaces as if they were regular
white space character, avoiding ICU. The specific hanging behavior will
be implemented then by the BreakingContext class, assuming the old
'break before space' behavior.


[1] https://drafts.csswg.org/css-text-3/#other-space-separators
[2] https://drafts.csswg.org/css-text-3/#collapsible-white-space
[3] https://drafts.csswg.org/css-text-3/#white-space-phase-1
[4] https://drafts.csswg.org/css-text-3/#white-space-property

Bug: 972952
Change-Id: Ibc5a9d4c0b420320ef03f2a088685775b0034ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521614Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#824903}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d6242c0dc2d..639610df4433

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tinazwang@google.com,clamy@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: tinazwang@google.com,clamy@google.com
Change-Id: I7711e579b873b0576d3e6800863351d5eb1bcf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522648Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824902}

This is a reland of 6b7290b3

Compared to the original CL, the reland sticks more to the previous
behavior of AvatarMenu::GetImageForMenuButton(), it does not download
high res avatar. The only change in behavior is on Windows where it uses
2x built-in avatars instead of 1x avatars which is beneficial for the
large taskbar of Win10.

Original change's description:
> [Profiles] Use new colored default avatars for taskbar badges
>
> Recently, all logic around profile avatars has been integrated into
> ProfileAttributesEntry::GetAvatarIcon() incl. new features such as
> colored default avatars.
>
> This CL updates code that generates taskbar badges on Windows to
> delegate most of its logic to GetAvatarIcon(). Only the pieces needed
> for obtaining ImageLoadStatus remained in this code.
>
> The only behavioral change is for non-GAIA avatars: high-res /
> 2x windows old avatars are returned instead of low-res avatars. This
> means more downscaling is needed than before. This will be addressed
> by further CLs that will make GetAvatarIcon() respect preferred_size in
> more cases.
>
> Bug: 1122559
> Change-Id: I5eecc7c6647dc78f9ff92d74edb64214a48e8e63
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514153
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Auto-Submit: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824494}

Bug: 1122559
Change-Id: I5814c801165fde00bb20694561e5b94db0e12cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521735
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824901}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I01e0cb646b86a219deefb4751a4218672c5e8604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824900}

TBR=aboxhall@chromium.org

Bug: 1141280
Change-Id: I4682a0ed73e14bc8243bb57326334d0db752fa4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518625Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824899}

fx_logger_log_with_source() takes file and line as parameters
and lets the syslog library handle them.

Change-Id: I15b3b7948e8ad48781ac36afa6fa9df2145da5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521365
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824898}

Add the missing comment in
chromeos/components/telemetry_extension_ui/mojom/diagnostics_service.mojom.

This is to make the RunBatteryHealthRoutine() method documentation
consistent with
chromeos/services/cros_healthd/public/mojom/cros_healthd.mojom.

Bug: b:171327161
Change-Id: I49ee24348138b7505ede83d900c9f48d1d238fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523191Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#824897}

Bug: 1007807
Change-Id: I8c78ba00cd743dd62d8b96d853cf9a352239d911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520800Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824896}

Tests that tapping on "Close All" shows a confirmation dialog.
It also tests that tapping on "Close x Tab(s)" on the confirmation
dialog displays an empty grid and tapping on "Cancel" doesn't modify
the grid.

Bug: 1119319, 1124309
Change-Id: I65a8a70a867efe3643ebfde1c59f3fb186177c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450317
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824895}

This reverts commit b430ce77.

Reason for revert: This change causes linker errors in absl.dll on my Windows 10 workstation.

This was tested by checking out the CL before this one and confirming that the build completes successfully, then checking out this CL and confirming that it errors.

Please see the full error at the bottom of this description.

Original change's description:
> Generate absl .def file at build time.
>
> Instead of generating absl .def files at roll time, this CL switches
> the build config to generate the required .def file on the fly while
> building.
>
> The advantages are:
>
> 1. No need to re-generate .def files when something external to absl
> changes and affects .def files (e.g. when a new compiler optimization
> it enabled).
> 2. No need to hard-code supported build flavors in the .def generator
> script, resulting in multiple .def files checked-in.
>
> On the other hand, this makes the build slightly slower than it
> is today because reading all absl object files to generate the
> .def file can take a few seconds.
>
> Bug: 1046390
> Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824844}

---
Full error:
PS C:\src\chromium\src> autoninja -C out/bug absl.dll
"C:\src\depot_tools\ninja.exe" -C out/bug absl.dll -j 1000 
ninja: Entering directory `out/bug'
[1/1] Regenerating ninja files
[3/3] LINK(DLL) absl.dll absl.dll.lib absl.dll.pdb
FAILED: absl.dll absl.dll.lib absl.dll.pdb
ninja -t msvc -e environment.x64 -- ..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /nologo -libpath:..\..\third_party\llvm-build\Release+Asserts\lib\clang\12.0.0\lib\windows -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\lib\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\um\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\ucrt\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\atlmfc\lib\x64 /IMPLIB:./absl.dll.lib /DLL /OUT:./absl.dll /PDB:./absl.dll.pdb @./absl.dll.rsp
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, 
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct 
std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><1, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *>::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *><0, struct absl::synchronization_internal::ThreadData *, struct absl::synchronization_internal::ThreadData *>(struct std::__1::__tuple_indices<0>, struct std::__1::__tuple_types<struct absl::synchronization_internal::ThreadData *>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>><0, 
1, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, 
class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>(struct std::__1::__tuple_indices<0, 1>, struct std::__1::__tuple_types<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>> &&, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><0, 1, 2, class absl::string_view, 
class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int, char const (&)[2], char const (&)[2], int>(struct std::__1::__tuple_indices<0, 1, 2>, struct std::__1::__tuple_types<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, char const (&)[2], char const (&)[2], int &&)        
lld-link: error: <root>: undefined symbol: public: __cdecl absl::AlphaNum::AlphaNum<16>(struct absl::strings_internal::AlphaNumBuffer<16> const &)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::thread::thread<void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&, void>(void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__bind<void 
(__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *><void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *, void>(void (__cdecl &)(struct 
absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, 1>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0>::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, 
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::tuple<class 
absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::tuple<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><char const (&)[2], char const (&)[2], int, 0, 0>(char const (&)[2], char const (&)[2], int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_leaf<0, class absl::string_view, 0>::__tuple_leaf<0, class absl::string_view, 0><char const (&)[2], void>(char const (&)[2])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[5], char const (&)[4], 0>(char const (&)[5], char const (&)[4])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[6], char const (&)[7], 0>(char const (&)[6], char const (&)[7])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, 0>(char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int const>::optional<int const><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int volatile>::optional<int volatile><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int>::optional<int><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int const, 1>::optional_data_dtor_base<int const, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int volatile, 1>::optional_data_dtor_base<int volatile, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int, 1>::optional_data_dtor_base<int, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see 
all errors)
ninja: build stopped: subcommand failed.
---

TBR=brucedawson@chromium.org,mbonadei@chromium.org

Change-Id: Iaf681079a2c786a7e694538b9fddc68d96dd1a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523240Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#824894}

Dependency/include graph:

- frame_utils.h is included by frame_header.cc;
- frame_header.h is included by default_frame_header.h
- browser_non_client_frame_view_ash.cc includes default_frame_header.h.

So, in order to free browser_non_client_frame_view_ash.cc|h from
including //ash/ headers the items above will migrate step by step
to //chromeos/ui.

BUG=1113900
R=jamescook@chromium.org, sky@chromium.org

Change-Id: I573a053321b82825d80554c1a3c44079bf6d2a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521364
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824893}

This reverts commit 1ad663a1.
The name should be modified.
Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [iOS] Adds EnableCloseAllTabsConfirmation config
>
> This CL adds the EnableCloseAllTabsConfirmation feature to the
> fieldtrial testing config.
>
> Bug: 1119319
> Change-Id: I197528caa2d090e2ddd6fde43b18223da49e226f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513597
> Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824884}

TBR=isherman@chromium.org,sweilun@chromium.org,ewannpv@chromium.org

Change-Id: Ia7ae4c6e83613b1b8f8aab8fad9279d80f727d9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1119319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523177Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824892}

This reverts commit be3eeb5b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 824814 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlM2VlYjViMzk5NTY5YTZiMWQ4OGY5ZTk1M2M3NmIxNDQxMWJiYTEM

Sample Failed Build: https://ci.chromium.org/b/8864373521456164320

Sample Failed Step: capture_unittests

Original change's description:
> [macOS] PixelBufferPool: Test retaining IOSurface, not CVPixelBuffer.
> 
> Pixel buffers originating from a CVPixelBufferPool are recycled when
> no longer in use, previously only tested by releasing the last pixel
> buffer reference and not touching the IOSurface.
> 
> This CL tests what happens when we are retaining not references to the
> pixel buffer, but references to a pixel buffer's IOSurface or
> incrementing its use count.
> 
> Outcome:
> - Retaining references (base::ScopedCFTypeRef<IOSurfaceRef>) to an
>   IOSurface does NOT prevent recycling.
> - Retaining use count (IOSurfaceIncrementUseCount) to an IOSurface DOES
>   prevent recycling.
> 
> This behavior is now documented in pixel_buffer_pool_mac.h.
> 
> Bug: chromium:1132299
> Change-Id: Ibdcd3752a4467bc495eba4b543ecd73da1b2f41f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520829
> Commit-Queue: Markus Handell <handellm@google.com>
> Reviewed-by: Markus Handell <handellm@google.com>
> Cr-Commit-Position: refs/heads/master@{#824814}


Change-Id: I9ffde1dcd267cf97ed5918ba86e913189625f3e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1132299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523054
Cr-Commit-Position: refs/heads/master@{#824891}

The implementations of these functions were removed, but not their
declarations.

Bug: None
Change-Id: I73d726dfce004de3df74790d17b4bf594ec96e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521736
Commit-Queue: Victor Vianna <victorvianna@google.com>
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824890}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86a7c52a9341..db4f0a699e04

2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files for performance_monitor/
2020-11-06 alexrudenko@chromium.org Remove _impl suffix from overlay filenames
2020-11-06 tvanderlippe@chromium.org Typecheck lighthouse/LighthousePanel.js with TypeScript
2020-11-06 tvanderlippe@chromium.org Typecheck performance_monitor/PerformanceMonitor.js with TypeScript
2020-11-06 jacktfranklin@chromium.org Clear karma-coverage before a coverage test run.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibf34e8182f7ec64ff727fc21438f65f7abf7abd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824889}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011060600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/dwzJL11UWg2QnfhcT7oCo00QTq5SX_Mm6Q5iInfP6sQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/159851982,b/170161460,b/171836521,b/172520108,b/172615641
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ic6ebde9cff23a543c66586bb79842c30e87d29c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523224Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824888}

Following up r824533 <crrev.com/c/2515399> which traverses
fragments for |PositionForPoint|, this patch fixes
|SelectionController| to traverse fragments without going
through |LayoutObject|.

It looks like the code in |SelectionController| has slight
difference from |HitTestResult::GetPosition()| but it does not
look intentional.

The fix is needed to support block fragmentation in
<crrev.com/c/2514048>.

Bug: 829028
Change-Id: I35060e5e2030e3282c60cb11b590105c11f69ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522799Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824887}

This patch fixes |NodeAtPoint()| so that:
* The |LayoutObject| function does not support block
  fragmented objects.
* Make sure we traverse fragment tree, without going through
  |LayoutObject|, whenever it may have fragmented children.

The current code calls |LayoutBlock::HitTestChildren()| when
|!ChildrenInline()|. It is fixed to traverse fragment tree to
achieve the second point above.

The same philosophy as |Paint| in r824316 <crrev.com/c/2515429>.

Bug: 1061423
Change-Id: Ie153bfab663e9d7353378355b0734e725ed0516d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517215Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824886}

This reverts commit a2c9272d.

Reason for revert: suspect this cl causes build failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21195

Original change's description:
> [Multipaste] Speak a11y announcement when delete button is focused
>
> This CL does two things:
> (1) Ignore the MenuItemView instance in accessibility events handling.
> Then we can customize accessibility behaviors of the multipaste menu
> in ClipboardHistoryItemView class.
>
> (2) When the delete button gets the pseudo focus, the accessibility
> side is notified.
>
> Bug: 1145773
> Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Commit-Queue: Andrew Xu <andrewxu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824561}

TBR=newcomer@chromium.org,andrewxu@chromium.org

Change-Id: I999c30afd42fa4c703f506a536fd736bcbfb48df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1146255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523237Reviewed-by: Tina Wang <tinazwang@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824885}

This CL adds the EnableCloseAllTabsConfirmation feature to the
fieldtrial testing config.

Bug: 1119319
Change-Id: I197528caa2d090e2ddd6fde43b18223da49e226f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513597
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824884}

With this change, the click action can optionally check whether an
element is on top and either report its finding, but click anyways or
not click.

This is implemented as three web actions:

- WaitUntilElementIsStable
- CheckOnTop (optional)
- ClickOrTap

Three actions are needed as CheckOnTop must be executed after the
element has stopped moving but before actually clicking or tapping.

The logic for checking whether the element is on top is the same as the
one used by the on_top filter; the two share the same JavaScript
snippet.

Bug: b/171463353
Change-Id: I8ed71f3b6c07a9254d16d314220b008669f4d600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517578
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#824883}

Bug: 1138210
Change-Id: I95d57fb3fe0802298fad44d4415aaac7e87871bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510250Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824882}

Test:
1. run weblayer shell
2. press home button to hide app
3. kill the renderer process `adb shell ps` and `adb shell kill`
4. switch back to weblayer shell

Automated tests to be added in a follow up.

Bug: 1146058
Change-Id: I6164f8ca377416437ff09beee6afa37fa4f36f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521338
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824881}

Also fix lint errors; no functional change

Bug: 1010217
Change-Id: I3e4af6d594f34b9717d2a96a8f14f3bd6c90e318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516881Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824880}

TBR=stkhapugin@chromium.org

Bug: 1128463
Change-Id: I939bbb3883f1ece20bc357d53e5c603e2589f0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521702Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824879}

This CL is fixing a corner case where RenderText::Elide(...) may
produce a text with more codepoints than the original one. This is
an issue since the breaklists are not resized and the overflow
will lead the render_text code to perfoarm an out-of-bound memory
access by deferencing breaks_.end() while rendering the text. This
is causing chrome to crash.

See crbug/1142020 for details.

The bug was happening when:
  1) The text to elide was a single codepoint
  2) The width of the glyph of the codepoint is larger than the width
     of the ellipsis glyph
  3) Eliding is set to ELIDING_TAIL
  4) The display_rect width will trigger eliding
     (smaller than codepoint width, but larger than ellipsis width)
  5) The render text is set to RTL

A possible solution is to adjust the breaklist but this required
larger refactoring and cannot be a minimal patch to be merge on
other channels.

Bug: 1142020
Change-Id: I9854651175562ec5f0d0bf7083a8da99fede0e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522892
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824878}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I32cd7e377903e753d6d1a8584977f94bf2cb2c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523233Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824877}

https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I029985ee36fd35eb814d648bc46d94411edf4dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523234Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824876}

The warning message shown when a test case is missing was garbled. Fix
the message so it correctly states that an expected test is not present.

Change-Id: I3202572b57dd47b6925aad7f4d28d586c5a4a677
BUG: 791125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522154Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#824875}

There are a series of messages that are sent to the RenderThreadObserver
of the webview. This maps ClearCache onto one of those messages.
Other targeted messages will be converted in followup CLs.

BUG=993189

Change-Id: I93d84f08bfcc74211ac175463754bf6b9d3d7ce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515043
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824874}

As above.

Change-Id: Ibd1f4a342454960d211776568a73fa3bf8a8f8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522406
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824873}

visibility is blocking the autoroller. Explicitly roll it so it is
visibile.

errorprone: error_prone_annotations target is used by doubldown and the
Change-Id: I33386182ef80ae9975378188d021503ea4e9e0f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522603
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824872}

I have been able to reproduce the linked issue flakily. Disabling
animations seems to fix it. The previous workaround might no longer be
necessary, but will stay in for a bit until we're sure that the issue
is indeed resolved.

Bug: 1146084
Change-Id: I6d199f19f0dbcb9ef4b10f3492566f34f96104e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521818
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Luca Hunkeler <hluca@google.com>
Auto-Submit: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Luca Hunkeler <hluca@google.com>
Cr-Commit-Position: refs/heads/master@{#824871}

Roll Chrome Win32 PGO profile from chrome-win32-master-1604629242-25a4011689f36cdb7c5ac3ab0a40a3994e18267e.profdata to chrome-win32-master-1604642156-7d0afa322bb4bb6abbaa9b475fb0ac5b24eae09a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If44cb43893698aacbbb9bf71144ce48f00553bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523092Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824870}

This reverts commit 702076d2.

Reason for revert: Instacrash crbug.com/1146408

Original change's description:
> [ios] Add Location Permissions Field Trial Experiment
>
> This change adds setup for a client-driven experiment that buckets
> users on First Run into 3 groups, two experiment and one control.
>
> Bug: 1138603
> Change-Id: I7c100d173ea2d64e718950047d0c2f04ff4c3fbf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506749
> Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824647}

TBR=rohitrao@chromium.org,isherman@chromium.org,boliu@chromium.org,asvitkine@chromium.org,twellington@chromium.org,thegreenfrog@chromium.org

Change-Id: I792cd345c47ceec5b8b817f9efe69da172050f2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1138603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522977Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824869}

Bug: 1143929
Change-Id: I9c9ff50b0cca7197180e9c6e61f2196053df2cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508555
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824868}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/24c7b2d7..d38e0064

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I03e1931586b16e8d0c50d617c72bc40b92f6ce63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523231Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824867}